Re: xhci patch 20150623

2015-07-15 Thread takahiro hayashi
Hello, I fixed a bug that xhci_close_pipe caused mutex lock error as close method is called with sc_lock held. --- src/sys/dev/usb/xhci.c.orig 2015-06-27 01:08:34.0 +0900 +++ src/sys/dev/usb/xhci.c 2015-07-15 05:20:26.0 +0900 @@ -1583,7 +1583,7 @@ xhci_close_pipe(struct

Re: xhci patch 20150623

2015-06-24 Thread takahiro hayashi
On 2015/06/24 07:17, takahiro hayashi wrote: On 2015/06/23 17:01, takahiro hayashi wrote: Hi, On 2015/06/23 16:12, Nick Hudson wrote: On 06/23/15 07:43, takahiro hayashi wrote: [snip] + USB keyboard interaction is laggy and annoying. Any idea why keyboard is laggy? Currently I'm not

Re: xhci patch 20150623

2015-06-23 Thread Nick Hudson
On 06/23/15 07:43, takahiro hayashi wrote: Hello, Here is xhci patch for nick-nhusb branch. nh-xhci-check.diff + Add port range check in xhci_rhpsc(). + Add sanity check if xfer-ux_pipe != NULL in xhci_handle_event(). nh-xhci-prc.diff + Remove SET_FEATURE C_PORT_RESET(PRC) -- what

xhci patch 20150623

2015-06-23 Thread takahiro hayashi
Hello, Here is xhci patch for nick-nhusb branch. nh-xhci-check.diff + Add port range check in xhci_rhpsc(). + Add sanity check if xfer-ux_pipe != NULL in xhci_handle_event(). nh-xhci-prc.diff + Remove SET_FEATURE C_PORT_RESET(PRC) -- what would happen?

Re: xhci patch 20150623

2015-06-23 Thread takahiro hayashi
Hi, On 2015/06/23 16:12, Nick Hudson wrote: On 06/23/15 07:43, takahiro hayashi wrote: Hello, Here is xhci patch for nick-nhusb branch. nh-xhci-check.diff + Add port range check in xhci_rhpsc(). + Add sanity check if xfer-ux_pipe != NULL in xhci_handle_event(). nh-xhci-prc.diff

Re: xhci patch 20150623

2015-06-23 Thread takahiro hayashi
On 2015/06/23 17:01, takahiro hayashi wrote: Hi, On 2015/06/23 16:12, Nick Hudson wrote: On 06/23/15 07:43, takahiro hayashi wrote: [snip] + USB keyboard interaction is laggy and annoying. Any idea why keyboard is laggy? Currently I'm not sure. Something is wrong with interval value