Avoid UB in pslist.h (NULL + 0)

2020-03-21 Thread Kamil Rytarowski
I propose to change the fun(pointer + 0) logic with fun(pointer, 0). We still maintain the sanity checks and we can optimize the code to generate not worse code than before. We can pass the "0" argument only with DIAGNOSTIC or DEBUG kernel.

Re: Avoid UB in pslist.h (NULL + 0)

2020-03-21 Thread Joerg Sonnenberger
On Sun, Mar 22, 2020 at 12:50:16AM +, Taylor R Campbell wrote: > (b) Change how we invoke ubsan and the compiler by passing > -fno-delete-null-pointer-checks to clang. joerg objected to this > but I don't recall the details off the top of my head; joerg, can > you expand on your

Re: Avoid UB in pslist.h (NULL + 0)

2020-03-21 Thread Kamil Rytarowski
On 22.03.2020 01:50, Taylor R Campbell wrote: >> Date: Sun, 22 Mar 2020 00:03:57 +0100 >> From: Kamil Rytarowski >> >> I propose to change the fun(pointer + 0) logic with fun(pointer, 0). > > I don't think this is a good approach -- it requires modifying code > further and further away from the

Re: Avoid UB in pslist.h (NULL + 0)

2020-03-21 Thread Taylor R Campbell
> Date: Sun, 22 Mar 2020 00:03:57 +0100 > From: Kamil Rytarowski > > I propose to change the fun(pointer + 0) logic with fun(pointer, 0). I don't think this is a good approach -- it requires modifying code further and further away from the relevant part. But let's step back a moment. So far,