Re: Are modunload and ifconfig create racy?

2017-01-20 Thread Paul Goyette
(Replying _without_ looking at the code! I can look more deeply if you could re-send a pointer to the code...) Generally, the module's unload code should detach the devsw entry for the driver first, to prevent any new accesses. Then, the config_fini_component() call will fail if existing

Re: RFC: L2TPv3 interface

2017-01-20 Thread Joerg Sonnenberger
On Fri, Jan 20, 2017 at 09:26:52PM +0900, Kengo NAKAHARA wrote: > On 2017/01/20 0:38, Taylor R Campbell wrote: > >Date: Thu, 19 Jan 2017 17:58:17 +0900 > >From: Kengo NAKAHARA > > A few little comments: > > > >diff --git a/sys/net/if.c b/sys/net/if.c > >

Re: RFC: L2TPv3 interface

2017-01-20 Thread Kengo NAKAHARA
Hi riastradh@n.o, Thank you for your detailed review! At first, here is updated patches. http://netbsd.org/~knakahara/if-l2tp-2/01-accept-ifname-include-digit.patch http://netbsd.org/~knakahara/if-l2tp-2/02-if-l2tp.patch And then, each response is below. On 2017/01/20 0:38, Taylor R