Re: Some changes to autoconfiguration APIs

2021-05-10 Thread Jason Thorpe


> On May 10, 2021, at 7:58 PM, matthew green  wrote:
> 
> please, can we revert and re-do with a type-safe API.

I don't plan to revert, but I will consider a betterly-typed API that's not 
extremely cumbersome to use.  I am not a fan of Taylor's proposals.  Concrete 
proposals welcome.

-- thorpej



re: Some changes to autoconfiguration APIs

2021-05-10 Thread matthew green
> > It was REALLY obvious that there was a lot of blind copy-pasta
> > lurking around as I audited everything.
>
> I appreciate the work you did to audit this!  But we should make it
> easier, not harder, for the compiler to audit mistakes if we're going
> to make tree-wide changes; this appears to be strictly a regression on
> technical grounds, for a change in cosmetics.  The same audit outcome
> could have applied just as well to the type-safe(r) API we had.

having looked at this issue closely, and spent the last few
days pondering, i've come to agree quite strongly with
Taylor's POV here.

please, can we revert and re-do with a type-safe API.

thanks.


.mrg.