Re: [PATCH 0/2] Delete CIRCLEQ

2020-10-12 Thread Christos Zoulas
In article , Kamil Rytarowski wrote: >This removal is a part of a larger synchronization with other BSDs as >we lack various features in sys/queue.h (like LIST_PREV()). > >CIRCLEQ was already deleted from the documentation and disabled in the >kernel in NetBSD-7. If there are still any unaware

Re: [PATCH 0/2] Delete CIRCLEQ

2020-10-12 Thread Kamil Rytarowski
This removal is a part of a larger synchronization with other BSDs as we lack various features in sys/queue.h (like LIST_PREV()). CIRCLEQ was already deleted from the documentation and disabled in the kernel in NetBSD-7. If there are still any unaware users, they are certainly long broken.

Re: [PATCH 0/2] Delete CIRCLEQ

2020-10-12 Thread Mouse
>>> Remove the CIRCLEQ API completely from the system headers and >>> document this fact in the QUEUE(3) man-page. >> why? queue.h may be used by more than src. >> i don't see any benefit except forcing working code to be changed, >> possibly introducing bugs. >> please leave it alone. > It's

Re: [PATCH 0/2] Delete CIRCLEQ

2020-10-12 Thread Kamil Rytarowski
Everything relatively modern that uses sys/queue.h directly was already switched a long time ago to TAILQ. Christos Zoulas changed most users of CIRCLEQ in the src tree 6 years ago. The last leftover is handled in this patchset. I was able to find some 3rd projects using CIRCLEQ, but probably

Re: [PATCH 0/2] Delete CIRCLEQ

2020-10-11 Thread David Holland
On Mon, Oct 12, 2020 at 01:23:15PM +1100, matthew green wrote: > > Switch the last user (ypserv) from CIRCLEQ to TAILQ. > > This is inspired by analogous refactoring from OpenBSD: > >

re: [PATCH 0/2] Delete CIRCLEQ

2020-10-11 Thread matthew green
Kamil Rytarowski writes: > Switch the last user (ypserv) from CIRCLEQ to TAILQ. > This is inspired by analogous refactoring from OpenBSD: > https://github.com/openbsd/src/commit/d53c0cf4d32fdbd8b42debfba068f1b0efa423dc#diff-8d0a4fbb89658213ebf314ff188581d7 > > Remove the CIRCLEQ API completely