Re: Removing extsrc: (was Re: Proposal: Deprecate (or rename) extsrc/)
On 22-08-21 08:51, Luke Mewburn wrote: | On 22-01-07 12:47, Luke Mewburn wrote: | | I propose that we deprecate or remove the "extsrc/" tree, | | as the name name-complete conflicts with "external/". | | | | The "external/" tree was added in mid 2008. | | A lot of the in-tree third-party source is now in this tree, | | and developers need to traverse this tree a lot. | | | | The "extsrc/" tree was added in late 2009. | | Nothing in tree uses "extsrc/"; it's a placeholder for third-party | | vendors to hook into the build for their own extensions. | | There's no reason a vendor can't just integrate into the build | | with local changes - that's what Wasabi Systems did in the early 2000s. | | | | (Also, if I recall correctly, "extsrc/" without much consultation). | | | | If some people require the "extsrc/" functionality in tree, then I propose: | | 1) A good case to retain the functionality should be made by them. | | 2) A better name than "extsrc/" should be chosen, that's not | |going to cause completion rage. Maybe "3rdparty"? | | I only received support for removing extsrc. | There were no comments to retain as-is or to retain with a different directory name. | | As such, I propose to completely excise extsrc from the build. | This includes: | 1. Makefile: remove do-extsrc target. | 2. build.sh: remove options -y and -Y extsrcdir . | 3. distrib/sets: remove support for extsrc in various tools |including the options -L ext and -y, and the extsrc sets. | 4. bsd.own.mk, (etc.): remove support for extsrc/, EXTSRCSRCDIR, MKEXTSRC. | 5. BUILDING: remove docs for extsrc/, EXTSRCSRCDIR, MKEXTSRC, ... | 6. extsrc/: remove the directory. | | | I'll do this in the next few days. I've done it now.
Re: Removing extsrc: (was Re: Proposal: Deprecate (or rename) extsrc/)
lukem@ wrote: > | (Also, if I recall correctly, "extsrc/" without much consultation). There was a proposal on tech-toolchain: https://mail-index.netbsd.org/tech-toolchain/2009/11/29/msg000790.html but I could not imagine a typical usecase at that time. > I only received support for removing extsrc. > There were no comments to retain as-is or to retain with a different > directory name. I agree name-complete conflicts are always annoying and I'd also favor your proposal. Thanks, --- Izumi Tsutsui
Removing extsrc: (was Re: Proposal: Deprecate (or rename) extsrc/)
On 22-01-07 12:47, Luke Mewburn wrote: | I propose that we deprecate or remove the "extsrc/" tree, | as the name name-complete conflicts with "external/". | | The "external/" tree was added in mid 2008. | A lot of the in-tree third-party source is now in this tree, | and developers need to traverse this tree a lot. | | The "extsrc/" tree was added in late 2009. | Nothing in tree uses "extsrc/"; it's a placeholder for third-party | vendors to hook into the build for their own extensions. | There's no reason a vendor can't just integrate into the build | with local changes - that's what Wasabi Systems did in the early 2000s. | | (Also, if I recall correctly, "extsrc/" without much consultation). | | If some people require the "extsrc/" functionality in tree, then I propose: | 1) A good case to retain the functionality should be made by them. | 2) A better name than "extsrc/" should be chosen, that's not |going to cause completion rage. Maybe "3rdparty"? I only received support for removing extsrc. There were no comments to retain as-is or to retain with a different directory name. As such, I propose to completely excise extsrc from the build. This includes: 1. Makefile: remove do-extsrc target. 2. build.sh: remove options -y and -Y extsrcdir . 3. distrib/sets: remove support for extsrc in various tools including the options -L ext and -y, and the extsrc sets. 4. bsd.own.mk, (etc.): remove support for extsrc/, EXTSRCSRCDIR, MKEXTSRC. 5. BUILDING: remove docs for extsrc/, EXTSRCSRCDIR, MKEXTSRC, ... 6. extsrc/: remove the directory. I'll do this in the next few days. Luke. signature.asc Description: PGP signature
Re: Proposal: Deprecate (or rename) extsrc/
On Sat, Jan 08, 2022 at 12:28:52PM -0800, Paul Goyette wrote: > > Count me in as well - the name completion collision has always annoyed me. > > +2 :-) -- David A. Holland dholl...@netbsd.org
Re: Proposal: Deprecate (or rename) extsrc/
On Sat, 8 Jan 2022, Alistair Crooks wrote: Count me in as well - the name completion collision has always annoyed me. +2 :-) ++--+--+ | Paul Goyette | PGP Key fingerprint: | E-mail addresses:| | (Retired) | FA29 0E3B 35AF E8AE 6651 | p...@whooppee.com| | Software Developer | 0786 F758 55DE 53BA 7731 | pgoye...@netbsd.org | | & Network Engineer | | pgoyett...@gmail.com | ++--+--+
Re: Proposal: Deprecate (or rename) extsrc/
On Sat, 8 Jan 2022 at 00:29, matthew green wrote: > > I propose that we deprecate or remove the "extsrc/" tree, > > as the name name-complete conflicts with "external/". > > yes, please. > > Count me in as well - the name completion collision has always annoyed me. Thanks, Al
re: Proposal: Deprecate (or rename) extsrc/
> I propose that we deprecate or remove the "extsrc/" tree, > as the name name-complete conflicts with "external/". yes, please. .mrg.
Re: Proposal: Deprecate (or rename) extsrc/
On Fri, Jan 07, 2022 at 12:47:53 +1100, Luke Mewburn wrote: > The "extsrc/" tree was added in late 2009. > Nothing in tree uses "extsrc/"; it's a placeholder for third-party > vendors to hook into the build for their own extensions. > There's no reason a vendor can't just integrate into the build > with local changes - that's what Wasabi Systems did in the early 2000s. > > (Also, if I recall correctly, "extsrc/" without much consultation). > > If some people require the "extsrc/" functionality in tree, then I propose: > 1) A good case to retain the functionality should be made by them. > 2) A better name than "extsrc/" should be chosen, that's not >going to cause completion rage. Maybe "3rdparty"? Yeah, it's kinda there "for the furniture" only. The build.sh usage still claims the default is /usr/extsrc and the makefile do-extsrc target uses hardcoded "extsrc" instead of EXTSRCSRCDIR (sic). Also it's built separately, so one can't easily use it to add say a library that some other 3rd party tool already in src can use, etc. -uwe
