Re: fallthrough and breaks in drm and atheros codes

2019-02-18 Thread Christos Zoulas 
Yes, the order matters. I am not sure why it is different in my build...

christos

> On Feb 18, 2019, at 8:40 PM, Robert Elz  wrote:
> 
>Date:Mon, 18 Feb 2019 19:26:07 -0500
>From:Christos Zoulas 
>Message-ID:  
> 
> 
>  | there is -Wno-error=implicit-fallthrough
> 
> Does the order of the -W flags matter ...
> 
>  | [7:23pm] 2507#make zlib.o
>  | #   compile  GENERIC/zlib.o
>  | gcc -Wno-error=implicit-fallthrough [...] -Werror -Wall  [...]
> 
> kre

Re: fallthrough and breaks in drm and atheros codes

2019-02-18 Thread Robert Elz 
Date:Mon, 18 Feb 2019 19:26:07 -0500
From:Christos Zoulas 
Message-ID:  


  | there is -Wno-error=implicit-fallthrough

Does the order of the -W flags matter ...

  | [7:23pm] 2507#make zlib.o
  | #   compile  GENERIC/zlib.o
  | gcc -Wno-error=implicit-fallthrough [...] -Werror -Wall  [...]

kre

re: fallthrough and breaks in drm and atheros codes

2019-02-18 Thread matthew green 
> The only different is that my GENERIC has DEBUG and LOCKDEBUG... And as
> you can see from the command line, there is
> -Wno-error=implicit-fallthrough

hmmm..  is this being missed some how?

> cat conf/copts.mk
#   $NetBSD: copts.mk,v 1.3 2019/02/10 05:01:59 mrg Exp $

# MI per-file compiler options required.

.ifndef _SYS_CONF_COPTS_MK_
_SYS_CONF_COPTS_MK_=1

.if defined(HAVE_GCC) && ${HAVE_GCC} == 7 && ${ACTIVE_CC} == "gcc"
COPTS.zlib.c+=  -Wno-error=implicit-fallthrough
COPTS.pf.c+=-Wno-error=implicit-fallthrough
COPTS.radeon_cs.c+= -Wno-error=implicit-fallthrough
COPTS.via_dmablit.c+=   -Wno-error=implicit-fallthrough
.endif

.endif

it's a new file, but should be present for all kernel builds?


.mrg.

Re: fallthrough and breaks in drm and atheros codes

2019-02-18 Thread Christos Zoulas 



> On Feb 18, 2019, at 7:20 PM, matthew green  wrote:
> 
>> I am not sure if the following is correct, so I am posting it here instead
>> of committing...
> 
> see my post to source-changes-d -- most of these should
> be ignored for warings already, so i'm curious why you
> had to fix them.
> 
> wrt what is correct, i found several fixes needed by our
> copy of upstream code were already upstream, so it was
> easy to determine what was right for those ones.
> 
> i doubt anyone can really tell you about nouveau fixes
> except upstream.

The only different is that my GENERIC has DEBUG and LOCKDEBUG... And as you can 
see from the command line, there is -Wno-error=implicit-fallthrough

christos


[7:23pm] 2507#make zlib.o
#   compile  GENERIC/zlib.o
gcc -Wno-error=implicit-fallthrough -mcmodel=kernel -mno-red-zone -mno-mmx 
-mno-sse -mno-avx -msoft-float -mindirect-branch=thunk-inline 
-mindirect-branch-register -ffreestanding -fno-zero-initialized-in-bss 
-fno-delete-null-pointer-checks -g -O2 -fno-omit-frame-pointer 
-fstack-protector -Wstack-protector --param ssp-buffer-size=1 
-fno-strict-aliasing -fno-common -Wno-error=implicit-fallthrough -std=gnu99 
-Werror -Wall -Wno-main -Wno-format-zero-length -Wpointer-arith 
-Wmissing-prototypes -Wstrict-prototypes -Wold-style-definition -Wswitch 
-Wshadow -Wcast-qual -Wwrite-strings -Wno-unreachable-code -Wno-pointer-sign 
-Wno-attributes -Wextra -Wno-unused-parameter -Wold-style-definition 
-Wno-sign-compare -Damd64 -Dx86_64 -I. -I../../../../external/bsd/acpica/dist 
-I../../../../external/bsd/libnv/dist -I../../../../../common/lib/libx86emu 
-I../../../../../common/lib/libc/misc -I../../../../../common/include 
-I../../../../arch -I../../../.. -nostdinc -DCOMPAT_UTILS -DDIAGNOSTIC -DDEBUG 
-DCOMPAT_44 -D_KERNEL -D_KERNEL_OPT -std=gnu99 
-I../../../../lib/libkern/../../../common/lib/libc/quad 
-I../../../../lib/libkern/../../../common/lib/libc/string 
-I../../../../lib/libkern/../../../common/lib/libc/arch/x86_64/string 
-D_FORTIFY_SOURCE=2 -I../../../../external/isc/atheros_hal/dist 
-I../../../../external/isc/atheros_hal/ic 
-I../../../../external/bsd/common/include 
-I../../../../external/bsd/common/include 
-I../../../../external/bsd/drm2/include -I../../../../external/bsd/drm2/include 
-I../../../../external/bsd/drm2/include/drm 
-I../../../../external/bsd/common/include 
-I../../../../external/bsd/drm2/dist/include 
-I../../../../external/bsd/drm2/dist/include/drm 
-I../../../../external/bsd/drm2/dist/uapi -I../../../../external/bsd/drm2/dist 
-D__KERNEL__ -DCONFIG_BACKLIGHT_CLASS_DEVICE=0 
-DCONFIG_BACKLIGHT_CLASS_DEVICE_MODULE=0 -DCONFIG_DRM_FBDEV_EMULATION=1 
-DCONFIG_FB=0 -I../../../../../common/include 
-I../../../../external/bsd/libnv/dist -I../../../../external/bsd/drm2/i915drm 
-I../../../../external/bsd/drm2/dist/drm/i915 -DCONFIG_DRM_I915_FBDEV=1 
-DCONFIG_DRM_I915_PRELIMINARY_HW_SUPPORT=0 -DCONFIG_DRM_FBDEV_EMULATION=1 
-I../../../../external/bsd/drm2/include/radeon 
-I../../../../external/bsd/drm2/radeon 
-I../../../../external/bsd/drm2/dist/drm/amd/include 
-I../../../../external/bsd/drm2/dist/drm/radeon 
-I../../../../external/bsd/drm2/dist/drm/nouveau 
-I../../../../external/bsd/drm2/dist/drm/nouveau/include 
-I../../../../external/bsd/drm2/dist/drm/nouveau/include/nvkm 
-I../../../../external/bsd/drm2/dist/drm/nouveau/nvkm 
-I../../../../external/bsd/drm2/nouveau -DCONFIG_NOUVEAU_DEBUG=5 
-DCONFIG_NOUVEAU_DEBUG_DEFAULT=3 -I../../../../external/bsd/acpica/dist/include 
-c ../../../../net/zlib.c -o zlib.o
../../../../net/zlib.c: In function 'inflate':
../../../../net/zlib.c:3531:22: warning: this statement may fall through 
[-Wimplicit-fallthrough=]
   z->state->mode = FLAG;
   ~~~^~

re: fallthrough and breaks in drm and atheros codes

2019-02-18 Thread matthew green 
> I am not sure if the following is correct, so I am posting it here instead
> of committing...

see my post to source-changes-d -- most of these should
be ignored for warings already, so i'm curious why you
had to fix them.

wrt what is correct, i found several fixes needed by our
copy of upstream code were already upstream, so it was
easy to determine what was right for those ones.

i doubt anyone can really tell you about nouveau fixes
except upstream.


.mrg.