Re: sys/idtype.h unused enumeration values

Date:Tue, 19 May 2020 15:14:21 +0200 From:Kamil Rytarowski Message-ID: | I've abandoned the intention of changing these values (by adding | comments, renaming etc). Good, thank you. | Once I will have spare time I might look into | implementing the missing

Re: sys/idtype.h unused enumeration values

On 19.05.2020 15:06, Robert Elz wrote: > Date:Tue, 19 May 2020 14:12:31 +0200 > From:Kamil Rytarowski > Message-ID: <6874bb63-5146-797f-98b7-b9c497677...@gmx.com> > > | Rationale for pointless? > > There is no point. What more can I say? > > | My points were:

Re: sys/idtype.h unused enumeration values

Date:Tue, 19 May 2020 14:12:31 +0200 From:Kamil Rytarowski Message-ID: <6874bb63-5146-797f-98b7-b9c497677...@gmx.com> | Rationale for pointless? There is no point. What more can I say? | My points were: | | - Clobbering OS that claims the goals of clean

Re: sys/idtype.h unused enumeration values

On 19.05.2020 08:38, Robert Elz wrote: > Date:Mon, 18 May 2020 21:11:36 +0200 > From:Kamil Rytarowski > Message-ID: <05255347-1c55-2762-aaf6-fec3caf48...@gmx.com> > > | Next, I can add my value at the end of list (and before _P_MAXIDTYPE). > > Other than this,

Re: sys/idtype.h unused enumeration values

Date:Mon, 18 May 2020 21:11:36 +0200 From:Kamil Rytarowski Message-ID: <05255347-1c55-2762-aaf6-fec3caf48...@gmx.com> | Next, I can add my value at the end of list (and before _P_MAXIDTYPE). Other than this, everything that you propose is pointless. This one you

Re: sys/idtype.h unused enumeration values

The *used* enum values are already burned into existing programs. Reordering/removing from the list breaks ABI. They are best left alone. christos > On May 18, 2020, at 4:55 PM, Kamil Rytarowski wrote: > > Signed PGP part > On 18.05.2020 22:18, Christos Zoulas wrote: >> >> >>> On May 18,

Re: sys/idtype.h unused enumeration values

On 18.05.2020 22:18, Christos Zoulas wrote: > > >> On May 18, 2020, at 3:40 PM, Kamil Rytarowski wrote: >> >> If I delete P_TASKID ... P_P_CPUID ones, P_SETID will be reordered (but >> we can force the number anyway). If I delete P_CID there is an inelegant >> hole. Naturally P_SETID -> P_CID

Re: sys/idtype.h unused enumeration values

> Date: Mon, 18 May 2020 21:40:16 +0200 > From: Kamil Rytarowski > > If I delete P_TASKID ... P_P_CPUID ones, P_SETID will be reordered (but > we can force the number anyway). If I delete P_CID there is an inelegant > hole. Naturally P_SETID -> P_CID can fill the gap. > > This is in theory ABI

Re: sys/idtype.h unused enumeration values

> On May 18, 2020, at 3:40 PM, Kamil Rytarowski wrote: > > If I delete P_TASKID ... P_P_CPUID ones, P_SETID will be reordered (but > we can force the number anyway). If I delete P_CID there is an inelegant > hole. Naturally P_SETID -> P_CID can fill the gap. > > This is in theory ABI change,

Re: sys/idtype.h unused enumeration values

On 18.05.2020 21:31, Taylor R Campbell wrote: >> Date: Mon, 18 May 2020 21:11:36 +0200 >> From: Kamil Rytarowski >> >> On 18.05.2020 20:24, Robert Elz wrote: >>> Date:Mon, 18 May 2020 19:45:55 +0200 >>> From:Kamil Rytarowski >>> Message-ID: >>> >>> | I have got a

Re: sys/idtype.h unused enumeration values

> Date: Mon, 18 May 2020 21:11:36 +0200 > From: Kamil Rytarowski > > On 18.05.2020 20:24, Robert Elz wrote: > > Date:Mon, 18 May 2020 19:45:55 +0200 > > From:Kamil Rytarowski > > Message-ID: > > > > | I have got a local use-case for another P_type (premature to

Re: sys/idtype.h unused enumeration values

On 18.05.2020 20:24, Robert Elz wrote: > Date:Mon, 18 May 2020 19:45:55 +0200 > From:Kamil Rytarowski > Message-ID: > > | I have got a local use-case for another P_type (premature to discuss it > | in this thread) and I would rather recycle an unused value. > >

Re: sys/idtype.h unused enumeration values

Date:Mon, 18 May 2020 19:45:55 +0200 From:Kamil Rytarowski Message-ID: | I have got a local use-case for another P_type (premature to discuss it | in this thread) and I would rather recycle an unused value. Don't do that, it is just a number, use one that

Re: sys/idtype.h unused enumeration values

I copied these from FreeBSD who in turn copied them from solaris and changed P_ZONEID to P_JAILID. The FreeBSD comment is: http://bxr.su/FreeBSD/sys/sys/wait.h#100 I decided to keep all the names too. christos > On May 18, 2020, at 1:45 PM, Kamil

sys/idtype.h unused enumeration values

POSIX notes: "The type idtype_t shall be defined as an enumeration type whose possible values shall include at least the following: P_ALL P_PGID P_PID" https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/sys_wait.h.html For some reason we copied as-is solaris types into our public headers