Re: Conflicting fuse_opt.h

2022-04-01 Thread Reinoud Zandijk
On Mon, Mar 28, 2022 at 09:03:07AM -0400, Mouse wrote: > > If you want portable code, i'd refrain from using underspecified > > types like `long' and just plain `int' in an interface! > > Depending on what you're trying to do, int or long int may well be the > more portable choice. Using (for

Re: Conflicting fuse_opt.h

2022-03-28 Thread Mouse
> If you want portable code, i'd refrain from using underspecified > types like `long' and just plain `int' in an interface! Depending on what you're trying to do, int or long int may well be the more portable choice. Using (for example) int32_t renders the code nonportable to systems that don't

Re: Conflicting fuse_opt.h

2022-03-28 Thread Reinoud Zandijk
Hi, On Wed, Mar 23, 2022 at 02:28:39PM +, Emmanuel Dreyfus wrote: > I am almost certain I already raised that question, but I could not find > where, and the issue remains to be fixed. > > NetBSD's src/lib/librefuse/fuse_opt.h > struct fuse_opt { > cons

Conflicting fuse_opt.h

2022-03-23 Thread Emmanuel Dreyfus
Hello I am almost certain I already raised that question, but I could not find where, and the issue remains to be fixed. NetBSD's src/lib/librefuse/fuse_opt.h struct fuse_opt { const char *templ; int32_t offset; int32_t value; }; libfuse's

Re: fuse_opt.h

2021-06-04 Thread Emmanuel Dreyfus
On Fri, Jun 04, 2021 at 08:06:44AM +0200, Jaromír Dole?ek wrote: > It's very rare that any lib supporting, and indeed any app building, > using header one of compatible lib and linking against the other. Sure, but here it is very easy to mix by mistake: same header names, same definitions, just

Re: fuse_opt.h

2021-06-04 Thread Jaromír Doleček
Le ven. 4 juin 2021 à 02:17, Emmanuel Dreyfus a écrit : > > Jason Thorpe wrote: > > > Seems like it would be a bad idea NOT to fix it. I assume one of the > > goals of librefuse was to be ABI compatible? > > My concern is that if you build a FUSE filesystem, using FUSE headers > from

Re: fuse_opt.h

2021-06-03 Thread Emmanuel Dreyfus
Jason Thorpe wrote: > Seems like it would be a bad idea NOT to fix it. I assume one of the > goals of librefuse was to be ABI compatible? My concern is that if you build a FUSE filesystem, using FUSE headers from /usr/include and linking with libfuse will cause a crash on LP64. You must

Re: fuse_opt.h

2021-06-03 Thread Joerg Sonnenberger
On Thu, Jun 03, 2021 at 11:57:50AM -0700, Jason Thorpe wrote: > > > On Jun 3, 2021, at 7:19 AM, Emmanuel Dreyfus wrote: > > > > Is there any reason not to fix it? > > Seems like it would be a bad idea NOT to fix it. I assume one of the goals > of librefuse was to be ABI compatible? It

Re: fuse_opt.h

2021-06-03 Thread Jason Thorpe
> On Jun 3, 2021, at 7:19 AM, Emmanuel Dreyfus wrote: > > Is there any reason not to fix it? Seems like it would be a bad idea NOT to fix it. I assume one of the goals of librefuse was to be ABI compatible? -- thorpej