yacc: NULL-before-free check

2017-08-07 Thread Michael W. Bombardieri
Hi, In yacc(1) remove one null check before free(). This has previously been done for other files so this instance in get_line() was probably missed. Older example: http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/usr.bin/yacc/output.c?f=h#rev1.25 - Michael Index: reader.c

Re: Improve the accuracy of the TSC frequency calibration (Was: Calculate the frequency of the tsc timecounter)

2017-08-07 Thread Ted Unangst
Adam Steen wrote: > I initially thought the calibration would take place at line 470 of > amd64/identcpu.c > (https://cvsweb.openbsd.org/cgi-bin/cvsweb/src/sys/arch/amd64/amd64/identcpu.c?annotate=1.87) > > But I looked into using the acpihpet directly but it is never exposed > outside of

fix inconsistency in ifstated.8

2017-08-07 Thread Rob Pierce
All other network daemon man pages reference Configtest as one word. Ok? Index: ifstated.8 === RCS file: /cvs/src/usr.sbin/ifstated/ifstated.8,v retrieving revision 1.9 diff -u -p -r1.9 ifstated.8 --- ifstated.8 25 Sep 2015

Dynamic interfaces broken in 1.1028 of distrib/miniroot/install.sub

2017-08-07 Thread Pontus Lundkvist
Hi, This change introduced in version 1.1028 of distrib/miniroot/install.sub seems wrong or incomplete. (Pardon the lack of tabs): for _hn in $_trunks $_svlans $_vlans; do - ifstart $_hn + ifstart $_if done Either _hn should be changed to _if as well, or just leave the

Re: [diff] httpd: tls client cert & CRL checks

2017-08-07 Thread Jack Burton
On Tue, 08 Aug 2017 14:23:02 +1000 Joel Sing wrote: > On Saturday 29 July 2017 20:49:18 Jan Klemkow wrote: > > Hi Jack, > > > > On Fri, Jul 28, 2017 at 02:05:34AM +0930, Jack Burton wrote: > > > On Thu, 27 Jul 2017 13:10:14 +0200 > > > > > > > But, I found a bug in the part

Improve the accuracy of the TSC frequency calibration (Was: Calculate the frequency of the tsc timecounter)

2017-08-07 Thread Adam Steen
On Mon, Jul 31, 2017 at 3:58 PM, Mike Belopuhov wrote: > On Mon, Jul 31, 2017 at 09:48 +0800, Adam Steen wrote: >> Ted Unangst wrote: >> > we don't currently export this info, but we could add some sysctls. there's >> > some cpufeatures stuff there, but generally stuff isn't

rtadvd: reschedule timer when a new prefix is added

2017-08-07 Thread Jeremie Courreges-Anglas
ra_timer_update() just updates rai->timer.tm, we need to call evtimer_add(3) for the new timeout to be scheduled. I missed this one when converting rtadvd to libevent. ok? Index: config.c === RCS file:

Re: [diff] httpd: tls client cert & CRL checks

2017-08-07 Thread Joel Sing
On Saturday 29 July 2017 20:49:18 Jan Klemkow wrote: > Hi Jack, > > On Fri, Jul 28, 2017 at 02:05:34AM +0930, Jack Burton wrote: > > On Thu, 27 Jul 2017 13:10:14 +0200 > > > > > But, I found a bug in the part of the FastCGI variables. The > > > following condition is always false. > > > > > >

Re: uplcom(4): add adapter to manual

2017-08-07 Thread Jeremie Courreges-Anglas
On Mon, Aug 07 2017, Anton Lindqvist wrote: > Hi, > I recently got an Aten UC232A (Prolific chipset) adapter which is > supported by uplcom. > > Comments? OK? ok jca@ > Index: uplcom.4 > === > RCS file:

faq/ports/guide: Missing space

2017-08-07 Thread Klemens Nanni
Index: faq/ports/guide.html === RCS file: /cvs/www/faq/ports/guide.html,v retrieving revision 1.71 diff -u -p -r1.71 guide.html --- faq/ports/guide.html26 Jun 2017 17:18:58 - 1.71 +++ faq/ports/guide.html7 Aug

uplcom(4): add adapter to manual

2017-08-07 Thread Anton Lindqvist
Hi, I recently got an Aten UC232A (Prolific chipset) adapter which is supported by uplcom. Comments? OK? Index: uplcom.4 === RCS file: /cvs/src/share/man/man4/uplcom.4,v retrieving revision 1.26 diff -u -p -r1.26 uplcom.4 ---

Re: libc syslog dead variable

2017-08-07 Thread Jeremie Courreges-Anglas
On Tue, Aug 08 2017, Alexander Bluhm wrote: > Hi, > > Since sendsyslog(2) handles the LOG_CONS parameter, conp in syslog(3) > is a dead variable. > > ok to remove? ok jca@ > bluhm > > Index: lib/libc/gen/syslog_r.c >

Re: ifstated: consistent use of log.c

2017-08-07 Thread Rob Pierce
On Sun, Aug 06, 2017 at 06:47:38PM +0200, Jeremie Courreges-Anglas wrote: > On Thu, Aug 03 2017, Rob Pierce wrote: > > As a result ifstated.c no longer needs err.h. > > > > Index: ifstated.c > > === > > RCS file:

Re: ifstated: add handing of departed interfaces

2017-08-07 Thread Jeremie Courreges-Anglas
On Sun, Aug 06 2017, Rob Pierce wrote: > The following diff adds support for detecting the state change of a departed > interface. ifstated is not a very verbose daemon, so this diff quietly does > the right thing (i.e. there is no exttra warning about a departing interface). But

Re: ifstated: consistent use of log.c

2017-08-07 Thread Jeremie Courreges-Anglas
On Mon, Aug 07 2017, Rob Pierce wrote: > On Sun, Aug 06, 2017 at 06:47:38PM +0200, Jeremie Courreges-Anglas wrote: >> On Thu, Aug 03 2017, Rob Pierce wrote: >> > As a result ifstated.c no longer needs err.h. >> > >> > Index: ifstated.c >> >

ip local input queue length

2017-08-07 Thread Alexander Bluhm
Hi, When testing socket splicing throughput I saw unsteady results. Turns out that I hit the congestion limit of the local delivery input queue. By increasing this value from 256 to 2048 I get much better results, changes from jumping around 1.1 GBit/sec to 1.7 GBit/sec constant throughput. I

libc syslog dead variable

2017-08-07 Thread Alexander Bluhm
Hi, Since sendsyslog(2) handles the LOG_CONS parameter, conp in syslog(3) is a dead variable. ok to remove? bluhm Index: lib/libc/gen/syslog_r.c === RCS file: /data/mirror/openbsd/cvs/src/lib/libc/gen/syslog_r.c,v retrieving

Re: fix format warning

2017-08-07 Thread Alexander Bluhm
On Mon, Aug 07, 2017 at 11:53:13AM +0200, Mark Kettenis wrote: > Or as pirofti@ suggests, simply droppy the 'h' modifier altogether is > safe as well as u_char gets promoted to int in a varargs function. > And clang doesn't want about this one. > > Any preference? When I encountered this problem

Re: Enable kprintf format attribute in clang

2017-08-07 Thread Florian Obser
On Sun, Aug 06, 2017 at 10:01:53PM +0200, Mark Kettenis wrote: > This makes clang actually do something for kprintf. This is a minimal > diff that actually allows some FreeBSD-specific kprintf type > specifiers. But I'd prefer to do a proper overhaul of this code > upstream first and keep the

Re: fix format warning

2017-08-07 Thread Florian Obser
OK florian@ On Mon, Aug 07, 2017 at 11:53:13AM +0200, Mark Kettenis wrote: > > Date: Mon, 7 Aug 2017 11:32:55 +0200 (CEST) > > From: Mark Kettenis > > > > > Date: Mon, 7 Aug 2017 11:04:51 +0200 (CEST) > > > From: Markus Hennecke > >

Re: fix format warning

2017-08-07 Thread Mark Kettenis
> Date: Mon, 7 Aug 2017 11:32:55 +0200 (CEST) > From: Mark Kettenis > > > Date: Mon, 7 Aug 2017 11:04:51 +0200 (CEST) > > From: Markus Hennecke > > > > On Thu, 3 Aug 2017, Mark Kettenis wrote: > > > > > Currently clang ignores the

Re: run nd6_expire when needed

2017-08-07 Thread Florian Obser
On Mon, Aug 07, 2017 at 03:51:00PM +0200, Alexander Bluhm wrote: > On Mon, Aug 07, 2017 at 08:07:33AM +, Florian Obser wrote: > > index cafdd9fe36f..7796af6191c 100644 > > --- sys/netinet6/in6.c > > +++ sys/netinet6/in6.c > > @@ -686,6 +686,10 @@ in6_update_ifa(struct ifnet *ifp, struct

Re: run nd6_expire when needed

2017-08-07 Thread Florian Obser
On Sun, Aug 06, 2017 at 01:56:08PM -0400, Martin Pieuchot wrote: > On 06/08/17(Sun) 17:04, Florian Obser wrote: > > On Sun, Aug 06, 2017 at 10:29:09AM -0400, Martin Pieuchot wrote: > > > On 03/08/17(Thu) 09:13, Florian Obser wrote: > > > > > > > > as mpi pointed out in "nd6 address expiration &

Re: fix format warning

2017-08-07 Thread Mark Kettenis
> Date: Mon, 7 Aug 2017 11:04:51 +0200 (CEST) > From: Markus Hennecke > > On Thu, 3 Aug 2017, Mark Kettenis wrote: > > > Currently clang ignores the "kprintf" format attribute. I've got a > > fix for that, but with that fix it complains about the code fixed

Re: run nd6_expire when needed

2017-08-07 Thread Alexander Bluhm
On Mon, Aug 07, 2017 at 02:30:19PM +, Florian Obser wrote: > On Mon, Aug 07, 2017 at 03:51:00PM +0200, Alexander Bluhm wrote: > > On Mon, Aug 07, 2017 at 08:07:33AM +, Florian Obser wrote: > > > index cafdd9fe36f..7796af6191c 100644 > > > --- sys/netinet6/in6.c > > > +++ sys/netinet6/in6.c