Re: openssl's *strlcy

2014-04-19 Thread Marc Espie
On Fri, Apr 18, 2014 at 09:41:47PM -0400, Jacob L. Leifman wrote: I'm guessing that openssl was incorporated into OpenBSD base without prior sufficient audit by the OBSD devs because it was presumed to have better auditing / quality control upstream given its security critical nature and

Re: openssl's *strlcy

2014-04-19 Thread Theo de Raadt
I'm guessing that openssl was incorporated into OpenBSD base without prior sufficient audit by the OBSD devs because it was presumed to have better auditing / quality control upstream given its security critical nature and function. Everyone has to take shortcuts. After what you've seen

Re: openssl's *strlcy

2014-04-19 Thread Theo de Raadt
Seems it is ok to use strlcat/strlcpy that way in some cases: $ cat src/usr.sbin/smtpd/*.c | egrep -c ' strlc(at|py)\(' 249 Hi Claus @ Sendmail [come on, your employeer matters when you point at code like this, you know better] smtpd is a new project. The 2-3 developers working on it should

IPv6 DoS sysctl man page additions

2014-04-19 Thread Loganaden Velvindron
Hi All, I'm taking a short break from playing with pf statistics. There were 4 sysctls added from KAME, but the man pages weren't updated accordingly. (Adapted from the NetBSD man page changes) Feedback welcomed. Index: lib/libc/gen/sysctl.3

Re: IPv6 DoS sysctl man page additions

2014-04-19 Thread Loganaden Velvindron
On Sat, Apr 19, 2014 at 04:04:30AM -0700, Loganaden Velvindron wrote: Hi All, I'm taking a short break from playing with pf statistics. There were 4 sysctls added from KAME, but the man pages weren't updated accordingly. (Adapted from the NetBSD man page changes) Feedback welcomed.

openssl fallout, dealing with it

2014-04-19 Thread Marc Espie
Since the tree wants to move fast, here's a sketch of how we deal with ports breakage. - someone makes sure everyone is aware there's breakage. ports and src should communicate so we assert what got removed intentionally, what got removed by accident. - if the removal is not accidental, fix

Re: fix for ifa RB tree corruption

2014-04-19 Thread Martin Pieuchot
On 18/04/14(Fri) 18:12, Claudio Jeker wrote: Bad stuff happens when the ifa lookup tree gets corrupted. In my case local traffic was suddenly no longer local and was forwarded to lo0 ad infinitum. Which lookup exactly? This was caused by the usage of rdomains and destroing pseudo interfaces.

Re: openssl's *strlcpy

2014-04-19 Thread Theo de Raadt
On Sat, Apr 19, 2014, Theo de Raadt wrote: Hi Claus @ Sendmail [come on, your employeer matters when you point It does? That must be something american or english -- it doesn't matter for me: I'm not talking for my (ex-)employer but only as an individual. In my country of origin I've

Re: fix for ifa RB tree corruption

2014-04-19 Thread Claudio Jeker
On Sat, Apr 19, 2014 at 03:09:40PM +0200, Martin Pieuchot wrote: On 18/04/14(Fri) 18:12, Claudio Jeker wrote: Bad stuff happens when the ifa lookup tree gets corrupted. In my case local traffic was suddenly no longer local and was forwarded to lo0 ad infinitum. Which lookup exactly?

Re: fix for ifa RB tree corruption

2014-04-19 Thread Martin Pieuchot
On 19/04/14(Sat) 16:10, Claudio Jeker wrote: On Sat, Apr 19, 2014 at 03:09:40PM +0200, Martin Pieuchot wrote: On 18/04/14(Fri) 18:12, Claudio Jeker wrote: Bad stuff happens when the ifa lookup tree gets corrupted. In my case local traffic was suddenly no longer local and was forwarded

IPv6 mtudisctimeout sysctl man page fix

2014-04-19 Thread Loganaden Velvindron
Hi All, The code was added for MTU discovery timeout in IPv6, but the man page misses the description. Feedback welcomed. Index: sbin/sysctl/sysctl.8 === RCS file: /cvs/src/sbin/sysctl/sysctl.8,v retrieving revision 1.174 diff -u

Re: IPv6 mtudisctimeout sysctl man page fix

2014-04-19 Thread Loganaden Velvindron
On Sat, Apr 19, 2014 at 07:51:34AM -0700, Loganaden Velvindron wrote: Hi All, The code was added for MTU discovery timeout in IPv6, but the man page misses the description. Feedback welcomed. s/icmp6/ip6 from henning@ and sthen@, and change from Return the number of seconds to Number

Re: IPv6 mtudisctimeout sysctl man page fix

2014-04-19 Thread Loganaden Velvindron
On Sat, Apr 19, 2014 at 08:19:23AM -0700, Loganaden Velvindron wrote: On Sat, Apr 19, 2014 at 07:51:34AM -0700, Loganaden Velvindron wrote: Hi All, The code was added for MTU discovery timeout in IPv6, but the man page misses the description. Feedback welcomed. s/icmp6/ip6

Re: stop advertising disabling pmtud and window size increasing

2014-04-19 Thread Claudio Jeker
On Sat, Apr 19, 2014 at 06:21:40PM +0200, Henning Brauer wrote: very rarely if ever needed any more. we should not trick people into thinking they are impoving sth doing so, it's rather the opposite these days. Yes please. We should remove the buttons people should not touch unless they know

Re: help needed from someone with an sk(4)

2014-04-19 Thread Christian Weisgerber
On 2014-04-19, Henning Brauer lists-openbsdt...@bsws.de wrote: we're in the same boat here - it's ust that I don't care too much either way (both of us) doesn't really help in taking a decision :/ Well, in that case I suggest that we remove this hack from all drivers that have it. A network

Re: openssl's *strlcy

2014-04-19 Thread Gilles Chehade
On Fri, Apr 18, 2014 at 05:19:15PM -0700, Claus Assmann wrote: Seems it is ok to use strlcat/strlcpy that way in some cases: $ cat src/usr.sbin/smtpd/*.c | egrep -c ' strlc(at|py)\(' 249 We tend to be very strict with our checks in smtpd and we did not check in various places because the

Remove RX offload hack from gem(4), hme(4), hme(4/sparc)

2014-04-19 Thread Christian Weisgerber
This removes a RX offload hack similar to the one just deleted from sk(4). These chips can only add 16-bit words starting from some offset, and so the driver gives them the likely start of the TCP/UDP payload and then tries to compensate and... ugh. Affected drivers: * gem(4) * hme(4) * another

[patch] courier-imap-4.13 imapd patch replacing malloc, strcat and strcpy with asprintf

2014-04-19 Thread Peter Malone
Hi, I'm using OpenBSD 5.5. courier-imap-4.13 is in the ports tree and it's quite a mess. I started looking at it today with the hope of just replacing some of the malloc,strcat strcpy calls with asprintf, but it became clear before long that there's lots more issues with this code. Regardless,