Re: [Patch] httpd - don't leak fcgi file descriptors

On Mon, Jun 08, 2015 at 09:17:41PM +0200, Claudio Jeker wrote: On Mon, Jun 08, 2015 at 09:12:32PM +0200, Joerg Jung wrote: On Tue, Jun 02, 2015 at 05:47:47PM +0200, Claudio Jeker wrote: On Tue, Jun 02, 2015 at 01:50:35PM +0200, Joerg Jung wrote: Am 01.06.2015 um 01:25 schrieb Todd

Re: [Patch] httpd - don't leak fcgi file descriptors

On Tue, Jun 09, 2015 at 07:46:15AM +, Florian Obser wrote: On Mon, Jun 08, 2015 at 09:17:41PM +0200, Claudio Jeker wrote: On Mon, Jun 08, 2015 at 09:12:32PM +0200, Joerg Jung wrote: On Tue, Jun 02, 2015 at 05:47:47PM +0200, Claudio Jeker wrote: On Tue, Jun 02, 2015 at 01:50:35PM

Re: jail_bin_add: script to add binary and libs to chroot

On Mon, Jun 08, 2015 at 03:37:27PM +0200, Landry Breuil wrote: On Mon, Jun 08, 2015 at 02:59:28PM +0200, Marc Espie wrote: On Mon, Jun 08, 2015 at 01:46:17AM -0400, dan mclaughlin wrote: i figure this should be useful to some. any nits welcome. Unfortunately, this will become

pfctl -ss -R

Hi, Any idea why don't we support filtering the show states output by the associated rule number? Diff below works fine here, OK? Index: pfctl.c === RCS file: /home/cvs/src/sbin/pfctl/pfctl.c,v retrieving revision 1.329 diff -u -p

Re: pfctl -ss -R

Mike Belopuhov(m...@belopuhov.com) on 2015.06.09 16:23:04 +0200: Hi, Any idea why don't we support filtering the show states output by the associated rule number? indeed, why not? Diff below works fine here, OK? ok! Index: pfctl.c

SNMP: support new no-route pf counter

Hi, Please review SNMP bits for the new 'no-route' pf state insertion failure counter. Any improvements to the MIB description? Here's what I mean by no target addresses were available: for instance, with such ruleset: table empty persist pass in on vmx0 inet proto tcp to port 80 route-to

Re: pf: increment rule counters after successful state insertion

On Tue, Jun 09, 2015 at 18:11 +0200, Mike Belopuhov wrote: Hi, I was surprised to see 'State Creations' rule counter go up when I've just realised that I might have been a bit too vague in my description. no real state creation happens. Should read: when state creation/insertion fails.

don't error for duplicate identical type definitions

Our current base compiler will abort with an error if it finds a typedef being redefined, even if the new definition is no different from the one it knows about. Allowing this kind of type redefinition is a new C11 feature, which some third-party software has already started using. Moreover,

pf: increment rule counters after successful state insertion

Hi, I was surprised to see 'State Creations' rule counter go up when no real state creation happens. This is because we increment all counters too early, but then don't decrement 'states_tot' which is a total number of states created by the rule. Not entirely sure why was it done but I see no

Re: SNMP: support new no-route pf counter

On Tue, Jun 09, 2015 at 17:52 +0200, Mike Belopuhov wrote: Hi, Please review SNMP bits for the new 'no-route' pf state insertion failure counter. Any improvements to the MIB description? Here's what I mean by no target addresses were available: for instance, with such ruleset: table

[patch] libc/locale/setlocale.c: remove unused arg

Hi, I start reading libc/locale code in order to understanding it. Here a patch to remove an unused argument isspecial from static function load_locale_sub. The function is called once, with isspecial=0, and the argument isn't used in function's body. Any comments ? -- Sébastien Marie

clean the tree from superfluous case '?': /* FALLTHROUGH */

Hello tech@ delete case '?': /* FALLTHROUGH */ where it is already handled by default: usage();. Rarely also adjust getopt(3)'s optstring. Index: bin/pax/options.c === RCS file: /cvs/src/bin/pax/options.c,v retrieving revision

Re: [patch] libc/locale/setlocale.c: remove unused arg

On Tue, Jun 09, 2015 at 07:47:21PM +0200, Sébastien Marie wrote: Hi, I start reading libc/locale code in order to understanding it. Here a patch to remove an unused argument isspecial from static function load_locale_sub. The function is called once, with isspecial=0, and the argument

Re: clean the tree from superfluous case '?': /* FALLTHROUGH */

Hi, On Tue, Jun 09, 2015 at 07:46:20PM +0200, Benjamin Baier wrote: Hello tech@ delete case '?': /* FALLTHROUGH */ where it is already handled by default: usage();. Not quite sure it is correct to remove the '?' case from npppd.c, since there is no 'default' case. Also, if the idea is to

Re: RIP hzto(9) 4/4: manual pages

On 10 Jun 2015, at 07:43, Mike Belopuhov m...@belopuhov.com wrote: OK? yep. diff --git share/man/man9/Makefile share/man/man9/Makefile index d145186..c63132f 100644 --- share/man/man9/Makefile +++ share/man/man9/Makefile @@ -12,11 +12,11 @@ MAN= aml_evalnode.9 atomic_add_int.9

Re: RIP hzto(9) 3/4: the implementation

ok. On 10 Jun 2015, at 07:42, Mike Belopuhov m...@belopuhov.com wrote: OK? diff --git sys/kern/kern_clock.c sys/kern/kern_clock.c index 279804c..e35f2f4 100644 --- sys/kern/kern_clock.c +++ sys/kern/kern_clock.c @@ -200,63 +200,10 @@ hardclock(struct clockframe *frame) if

Re: RIP hzto(9) 2/4: NFS

ok. On 10 Jun 2015, at 07:41, Mike Belopuhov m...@belopuhov.com wrote: OK? diff --git sys/nfs/nfs_socket.c sys/nfs/nfs_socket.c index 9edd615..a4a279f 100644 --- sys/nfs/nfs_socket.c +++ sys/nfs/nfs_socket.c @@ -1003,13 +1003,13 @@ tryagain: error =

Re: RIP hzto(9) 1/4: IPsec

ok. On 10 Jun 2015, at 07:41, Mike Belopuhov m...@belopuhov.com wrote: OK? diff --git sys/net/if_bridge.c sys/net/if_bridge.c index 637dea8..ce8d0d7 100644 --- sys/net/if_bridge.c +++ sys/net/if_bridge.c @@ -2181,11 +2181,10 @@ int bridge_ipsec(struct bridge_softc *sc, struct ifnet

RIP hzto(9) 3/4: the implementation

OK? diff --git sys/kern/kern_clock.c sys/kern/kern_clock.c index 279804c..e35f2f4 100644 --- sys/kern/kern_clock.c +++ sys/kern/kern_clock.c @@ -200,63 +200,10 @@ hardclock(struct clockframe *frame) if (timeout_hardclock_update()) softintr_schedule(softclock_si); } /*

RIP hzto(9) 1/4: IPsec

OK? diff --git sys/net/if_bridge.c sys/net/if_bridge.c index 637dea8..ce8d0d7 100644 --- sys/net/if_bridge.c +++ sys/net/if_bridge.c @@ -2181,11 +2181,10 @@ int bridge_ipsec(struct bridge_softc *sc, struct ifnet *ifp, struct ether_header *eh, int hassnap, struct llc *llc, int dir, int

RIP hzto(9) 2/4: NFS

OK? diff --git sys/nfs/nfs_socket.c sys/nfs/nfs_socket.c index 9edd615..a4a279f 100644 --- sys/nfs/nfs_socket.c +++ sys/nfs/nfs_socket.c @@ -1003,13 +1003,13 @@ tryagain: error = fxdr_unsigned(int, *tl); if ((nmp-nm_flag NFSMNT_NFSV3)

Re: clean the tree from superfluous case '?': /* FALLTHROUGH */

On Tue, 9 Jun 2015 14:01:01 -0700 patrick keshishian sids...@boxsoft.com wrote: Hi, On Tue, Jun 09, 2015 at 07:46:20PM +0200, Benjamin Baier wrote: Hello tech@ delete case '?': /* FALLTHROUGH */ where it is already handled by default: usage();. Not quite sure it is correct to

RIP hzto(9) 4/4: manual pages

OK? diff --git share/man/man9/Makefile share/man/man9/Makefile index d145186..c63132f 100644 --- share/man/man9/Makefile +++ share/man/man9/Makefile @@ -12,11 +12,11 @@ MAN=aml_evalnode.9 atomic_add_int.9 atomic_cas_uint.9 \ copy.9 config_attach.9 crypto.9 delay.9 \

[patch] vi: fix file modified more recently than this copy ... error

Hi, Noticed a regression with vi and recent changes to timespec data types. To reproduce, run vi without a file name to edit. Try save buffer via :w and you'll be presented by following message: file modified more recently than this this copy; use ! to override Patch below fixes this. Hope