Re: Introduce if_rtrequest()

On Sat, Oct 24, 2015 at 06:22:10PM +0200, Martin Pieuchot wrote: > On 24/10/15(Sat) 18:01, Martin Pieuchot wrote: > > Revamping the network stack design continue here at u2k15... > > > > This times it's about the L2 resolution mechanism plugged into the > > routing table. While discussing with

Re: rt_missmsg takes interface index

On Sat, Oct 24, 2015 at 07:04:52PM +0200, Alexander Bluhm wrote: > Hi, > > Instead of doing the the if_get() dance for rt_missmsg(), change the > function to take an interface index. > > ok? Yes > bluhm > > Index: net/route.c >

Re: telnet: kill dead IP source route

On Sat, Oct 24, 2015 at 9:08 AM, Jérémie Courrèges-Anglas wrote: > until today I did not know that some of our code did check for IP SSRR > and LSRR IP options in incoming packets. > > That made me look for software that tried to use these options in > outgoing packets. That

documenting multiple standards

>From wcrtomb(3): The wcrtomb() function conforms to ISO/IEC 9899/AMD1:1995 (``ISO C90, Amendment 1''). The restrict qualifier is added at ISO/IEC 9899/1999 (``ISO C99''). This wording is confusing. Is it implying that we don't use a restrict qualifier? (We do.) If a standard

Re: documenting multiple standards

On Sun, Oct 25, 2015 at 12:58 AM, Anthony J. Bentley wrote: > From wcrtomb(3): > > The wcrtomb() function conforms to ISO/IEC 9899/AMD1:1995 (``ISO C90, > Amendment 1''). The restrict qualifier is added at ISO/IEC 9899/1999 > (``ISO C99''). > > This wording is

Re: documenting multiple standards

On Sun, Oct 25, 2015 at 01:58:21AM -0600, Anthony J. Bentley wrote: > >From wcrtomb(3): > > The wcrtomb() function conforms to ISO/IEC 9899/AMD1:1995 (``ISO C90, > Amendment 1''). The restrict qualifier is added at ISO/IEC 9899/1999 > (``ISO C99''). > > This wording is confusing.

Re: documenting multiple standards

>>From wcrtomb(3): > > The wcrtomb() function conforms to ISO/IEC 9899/AMD1:1995 (``ISO C90, > Amendment 1''). The restrict qualifier is added at ISO/IEC 9899/1999 > (``ISO C99''). > >This wording is confusing. Is it implying that we don't use a restrict >qualifier? (We do.) > >If a

Re: [patch] tcpdump - better BGP UPDATE AS_PATH size calculations

On Sat, Oct 24, 2015 at 12:37:44PM -0600, Kevin Reay wrote: > Adopt an updated version of the tcpdump.org ASN size calculation for > BGP UPDATE message AS_PATHs. This corrects some bad behaviour due to > incorrect ASN size calculations. > > I believe that the current way of calculating the ASN

Re: inteldrm(4) diff that needs testing

On Sat, Oct 24, 2015 at 2:48 PM, Mark Kettenis wrote: > The diff below makes inteldrm(4) attach directly to pci(4) instead of > vga(1). Because inteldrm(4) depends on intagp(4), this also make > intagp(4) a child of inteldrm(4). Ultimately I'd like to integrate >

ld.so crash second attempt

Hi, I try to give it one more attempt with a bit more description about the bug. After calling dlclose in _dl_notify_unload_shlib_ group reference counts are decreased by following the object's grpref-list. Unfortunately the references are removed from the list during the graph traversal.

Re: inteldrm(4) diff that needs testing

On Sat, Oct 24, 2015 at 11:48:01PM +0200, Mark Kettenis wrote: > The diff below makes inteldrm(4) attach directly to pci(4) instead of > vga(1). Because inteldrm(4) depends on intagp(4), this also make > intagp(4) a child of inteldrm(4). Ultimately I'd like to integrate > intagp(4) into

Re: utf8 hack for ls

Ted Unangst wrote: > Christian Weisgerber wrote: > > On 2015-10-23, "Ted Unangst" wrote: > > > > >> To what degree should tools like ls protect terminals from escape codes? > > > > > > I think this is beyond the scope of what ls should care about. du doesn't > > > have > >

Re: inteldrm(4) diff that needs testing

On Sat, Oct 24, 2015 at 11:48:01PM +0200, Mark Kettenis wrote: > The diff below makes inteldrm(4) attach directly to pci(4) instead of > vga(1). Because inteldrm(4) depends on intagp(4), this also make > intagp(4) a child of inteldrm(4). Ultimately I'd like to integrate > intagp(4) into

Re: pledge(2) in quiz(6)

Jan Stary wrote: > Any comments/OK? > > On Oct 22 13:49:28, h...@stare.cz wrote: > > games/quiz.c popen()s a PAGER to display the help message. > > Throw that away and let the use pipe into a PAGER if needed. > > Then we can just pledge "stdio rpath". yeah, works for me.

Re: The router doesn't know the size of the internet...

On Sat, 24 Oct 2015 18:15:48 +0200, Sebastian Benoit wrote: > > s/size/diameter/ to quote RFC 2461 correctly > > > > The value should be set to that current diameter of the Internet. > > who measures that and tells me what to set there? Every sys/netinet hacker should own a set of internet

ftpd banner

unifdef some foolishness. note that BSD is not currently defined when this file is built. Index: ftpcmd.y === RCS file: /cvs/src/libexec/ftpd/ftpcmd.y,v retrieving revision 1.60 diff -u -p -r1.60 ftpcmd.y --- ftpcmd.y18 Aug 2015

route6d: another pidfile() removal

Following the recent discussions, here's another pidfile(3) removal. route6d(8) doesn't document it. ok? Index: Makefile === RCS file: /cvs/src/usr.sbin/route6d/Makefile,v retrieving revision 1.7 diff -u -p -r1.7 Makefile ---

Re: route6d: another pidfile() removal

ok! J??r??mie Courr??ges-Anglas(j...@wxcvbn.org) on 2015.10.25 23:15:12 +0100: > > Following the recent discussions, here's another pidfile(3) removal. > route6d(8) doesn't document it. > > ok? > > Index: Makefile > === > RCS

Re: support for malloc allocation canaries

Daniel Micay wrote: > This patch adds an opt-in malloc configuration option placing canaries after > small allocations to detect heap overflows on free(...). It's intended to be > used alongside guard pages for large allocations. Since it's essentially > adding extra padding to all small

slist remove invalidate

Hi, This diff that makes SLIST_REMOVE invalidate pointer more paranoid. I am running it for a while now without problems. ok to put in in? bluhm Index: sys/queue.h === RCS file: /data/mirror/openbsd/cvs/src/sys/sys/queue.h,v

Re: support for malloc allocation canaries

On 25/10/15 06:20 PM, Ted Unangst wrote: > Daniel Micay wrote: >> This patch adds an opt-in malloc configuration option placing canaries after >> small allocations to detect heap overflows on free(...). It's intended to be >> used alongside guard pages for large allocations. Since it's essentially

PF_KEY socket data sensitivity

There are a few daemons in base that make a point of zeroing all data read from PF_KEY sockets. However, Benjamin Baier and I have looked into it a litle (RFC 2367 et al.) and it seems that this may only be metadata. To those with PF_KEY experience: is it worth zeroing?

Re: telnet: low-delay traffic class for IPv6 connections

On Sun, 25 Oct 2015 17:18:28 +0100, =?utf-8?Q?J=C3=A9r=C3=A9mie_Courr=C3=A8ges- Anglas?= wrote: > While here, there is no option to pass a different tos, and no other use > of the "tos" variable out of tn(), so move the "tos" variable in tn() > and assign it the right value from the start. OK

Re: sed: better error message

Jérémie Courrèges-Anglas wrote: > Tobias Stoeckmann writes: > > > $ sed s/a/b/ /nofile > > sed: 0: /nofile: /nofile > > > > That message doesn't tell me a lot, let's better write > > strerror(errno) if fopen returns NULL: > > > > $ ./sed s/a/b/ /nofile > > sed: 0: /nofile:

Re: sed: better error message

Jérémie Courrèges-Anglas wrote: > Michael McConville writes: > > It looks like it can be pretty easily replaced with calls to err(3), > > errx(3), warn(3), warnx(3), etc. > > Not sure about this, you'd have to repeat the same code over and over to > print the line number and

Re: sed: better error message

Michael McConville writes: > Jérémie Courrèges-Anglas wrote: >> Tobias Stoeckmann writes: >> >> > $ sed s/a/b/ /nofile >> > sed: 0: /nofile: /nofile >> > >> > That message doesn't tell me a lot, let's better write >> > strerror(errno) if fopen returns

Re: ftpd banner

"Ted Unangst" writes: > unifdef some foolishness. note that BSD is not currently defined when this > file is built. ok jca@ [...] -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE

Re: inteldrm(4) diff that needs testing

On Sun, Oct 25, 2015 at 09:38:14PM +0100, Mark Kettenis wrote: > > Date: Sun, 25 Oct 2015 15:51:54 +1100 > > From: Jonathan Gray > > > > On Sat, Oct 24, 2015 at 11:48:01PM +0200, Mark Kettenis wrote: > > > The diff below makes inteldrm(4) attach directly to pci(4) instead of > >

Kill rtable_mpath_conflict

Instead of having a separate function to check for MPATH conflicts simply pass the gateway to rtable_insert(). Some regress tests outputs will need an update as we're now doing one more rtalloc(9) call in RTM_ADD. This is a step towards MPATH by default. ok? Index: net/route.c

Re: Kill rtable_mpath_match

Martin Pieuchot(m...@openbsd.org) on 2015.10.25 16:14:27 +0100: > Diff below merges the guts of rtable_mpath_match() into rtable_lookup(). > As for the previous rtable_mpath_* diff this is a step towards MPATH by > default. > > This diff introduces a behavior change for RTM_GET. If multiple

Re: inteldrm(4) diff that needs testing

> Date: Sun, 25 Oct 2015 15:51:54 +1100 > From: Jonathan Gray > > On Sat, Oct 24, 2015 at 11:48:01PM +0200, Mark Kettenis wrote: > > The diff below makes inteldrm(4) attach directly to pci(4) instead of > > vga(1). Because inteldrm(4) depends on intagp(4), this also make > >

Re: inteldrm(4) diff that needs testing

On Sat, Oct 24, 2015 at 11:48:01PM +0200, Mark Kettenis wrote: > The diff below makes inteldrm(4) attach directly to pci(4) instead of > vga(1). Because inteldrm(4) depends on intagp(4), this also make > intagp(4) a child of inteldrm(4). Ultimately I'd like to integrate > intagp(4) into

Re: inteldrm(4) diff that needs testing

On Sat Oct 24 2015 23:48, Mark Kettenis wrote: > This diff needs to be tested on a wide range of hardware. So if you > have a machine with inteldrm(4), please give it a shot. I'm > particularly interested in testing on an x40. No problems on my Thinkpad T400 (also running X11). OpenBSD

telnet: low-delay traffic class for IPv6 connections

While here, there is no option to pass a different tos, and no other use of the "tos" variable out of tn(), so move the "tos" variable in tn() and assign it the right value from the start. ok? Index: commands.c === RCS file:

Re: Kill rtable_mpath_conflict

On Sun, Oct 25, 2015 at 03:22:51PM +0100, Martin Pieuchot wrote: > Instead of having a separate function to check for MPATH conflicts > simply pass the gateway to rtable_insert(). Some regress tests > outputs will need an update as we're now doing one more rtalloc(9) > call in RTM_ADD. > > This

Re: inteldrm(4) diff that needs testing

On Sun, Oct 25, 2015 at 08:20:50AM -0700, Philip Guenther wrote: > [...] > This looks like the result of applying the diff but not running config > [...] Thanks for the clue bat. It's working fine on a Thinkpad T400. -- Gregor

Re: inteldrm(4) diff that needs testing

On Sun, Oct 25, 2015 at 08:20:50AM -0700, Philip Guenther wrote: > On Sun, Oct 25, 2015 at 5:43 AM, Gregor Best wrote: > > Hi Mark, > > > > On Sat, Oct 24, 2015 at 11:48:01PM +0200, Mark Kettenis wrote: > >> [...] > >> This diff needs to be tested on a wide range of hardware.

Re: inteldrm(4) diff that needs testing

> Date: Sat, 24 Oct 2015 23:48:01 +0200 (CEST) > From: Mark Kettenis > > The diff below makes inteldrm(4) attach directly to pci(4) instead of > vga(1). Because inteldrm(4) depends on intagp(4), this also make > intagp(4) a child of inteldrm(4). Ultimately I'd like to

Re: inteldrm(4) diff that needs testing

* Jonathan Gray [2015-10-25 05:51]: > On Sat, Oct 24, 2015 at 11:48:01PM +0200, Mark Kettenis wrote: > > The diff below makes inteldrm(4) attach directly to pci(4) instead of > > vga(1). Because inteldrm(4) depends on intagp(4), this also make > > intagp(4) a child of

sed: better error message

$ sed s/a/b/ /nofile sed: 0: /nofile: /nofile That message doesn't tell me a lot, let's better write strerror(errno) if fopen returns NULL: $ ./sed s/a/b/ /nofile sed: 0: /nofile: No such file or directory Index: main.c === RCS

Re: inteldrm(4) diff that needs testing

> Date: Sun, 25 Oct 2015 15:50:51 +0100 > From: Stefan Sperling > > On Sat, Oct 24, 2015 at 11:48:01PM +0200, Mark Kettenis wrote: > > The diff below makes inteldrm(4) attach directly to pci(4) instead of > > vga(1). Because inteldrm(4) depends on intagp(4), this also make > >

Re: inteldrm(4) diff that needs testing

On Sat, Oct 24, 2015 at 11:48:01PM +0200, Mark Kettenis wrote: > The diff below makes inteldrm(4) attach directly to pci(4) instead of > vga(1). Because inteldrm(4) depends on intagp(4), this also make > intagp(4) a child of inteldrm(4). Ultimately I'd like to integrate > intagp(4) into

rtadvd: pledge() and pidfile() are in a boat

So I took look at which pledge requests rtadvd could use. Turns out it can't call pledge early, because it attempts to retrieve IPV6CTL_FORWARDING and pledge currently denies it. rtadvd is the only user of IPV6CTL_FORWARDING in base, so IMO it doesn't call for a change in kern_pledge.c. There