Re: Memory corruptions in bc(1)

On Thu, Nov 19, 2015 at 05:52:39PM -0500, Michael McConville wrote: > I'm already cache-thrashing with all of my side projects, so if anyone's > interested I'll leave this to them. > > A few days ago, I wanted to try American Fuzzy Lop (afl), and bc(1) > seemed like a good first target: it

Re: Memory corruptions in bc(1)

On Fri, Nov 20, 2015 at 11:52:16AM +0100, Otto Moerbeek wrote: > On Thu, Nov 19, 2015 at 05:52:39PM -0500, Michael McConville wrote: > > > I'm already cache-thrashing with all of my side projects, so if anyone's > > interested I'll leave this to them. > > > > A few days ago, I wanted to try

Re: trunk vs busy ports

> On 20 Nov 2015, at 11:23 PM, Reyk Floeter wrote: > > On Fri, Nov 20, 2015 at 03:36:40PM +1000, David Gwynne wrote: >> IFF_OACTIVE means the hardware ring is full, not if it is busy. >> >> perhaps a better check is to see whether there are pending packets >> on the send

Re: ntpd pledge, needs "unix" to talk to ntpctl

> Andreas Kusalananda K=C3=A4h=C3=A4ri writes: > > > Hi, > > > > I noticed that ntpd would die if I tried to use ntpctl to check on it: > > > > [...] > > 29946 ntpd CALL poll(0xda8993ab5c0,4,1000) > > 29946 ntpd RET poll 1 > > 29946 ntpd CALL

Re: ntpd pledge, needs "unix" to talk to ntpctl

On Fri, Nov 20, 2015 at 02:07:46PM +0100, J??r??mie Courr??ges-Anglas wrote: > Andreas Kusalananda K??h??ri writes: > > > Hi, > > > > I noticed that ntpd would die if I tried to use ntpctl to check on it: > > > > [...] > > 29946 ntpd CALL poll(0xda8993ab5c0,4,1000)

Re: trunk vs busy ports

On Fri, Nov 20, 2015 at 11:27:05PM +1000, David Gwynne wrote: > > > On 20 Nov 2015, at 11:23 PM, Reyk Floeter wrote: > > > > On Fri, Nov 20, 2015 at 03:36:40PM +1000, David Gwynne wrote: > >> IFF_OACTIVE means the hardware ring is full, not if it is busy. > >> > >> perhaps a

Re: serious watchdog timeout issues with em driver

On 19/11/15(Thu) 17:54, Sonic wrote: > Have serious problems for over 7 weeks now with em driver, > specifically any rev of if_em.c > 1.305. Starting with rev 1.306, > released on 2015/09/30 and continuing to -current, watchdog timeouts > rue the day. Unfortunately rev 1.305 no longer builds with

rt_ifp and icmp6

Some if_get() love in icmp6. ok? Index: netinet6/icmp6.c === RCS file: /cvs/src/sys/netinet6/icmp6.c,v retrieving revision 1.177 diff -u -p -r1.177 icmp6.c --- netinet6/icmp6.c3 Nov 2015 21:39:34 - 1.177 +++

rt_ifp and icmp

The first rt_ifp of the day, make use of if_get() inside icmp_mtudisc(). ok? Index: netinet/ip_icmp.c === RCS file: /cvs/src/sys/netinet/ip_icmp.c,v retrieving revision 1.145 diff -u -p -r1.145 ip_icmp.c --- netinet/ip_icmp.c 30

Interesting if_get() case

This is an interesting case to understand why we're using interface indexes instead pointers. When the code below will be executed without being serialized with ifdetach(), it might have to deal with an invalid ``ipforward_rt''. By "invalid" here I mean a route entry pointing to a detached ifp.

Re: ntpd pledge, needs "unix" to talk to ntpctl

Reyk Floeter writes: > On Fri, Nov 20, 2015 at 02:07:46PM +0100, J??r??mie Courr??ges-Anglas wrote: >> Andreas Kusalananda K??h??ri writes: >> >> > Hi, >> > >> > I noticed that ntpd would die if I tried to use ntpctl to check on it: >> > >> > [...]

Re: serious watchdog timeout issues with em driver

On Fri, Nov 20, 2015 at 8:12 AM, Martin Pieuchot wrote: > I just committed a revert to 1.305 keeping the API changes needed for > the driver to build. > > This should bring your stability back, please let us know if that's not > the case. The kernel/driver builds with those

Use symbolic name instead of hardcoded value on telnet(1)

Use symbolic name instead of hardcoded value on telnet(1): Index: commands.c === RCS file: /cvs/src/usr.bin/telnet/commands.c,v retrieving revision 1.79 diff -u -p -u -r1.79 commands.c --- commands.c 13 Nov 2015 17:04:48 -

Re: trunk vs busy ports

On 20.11.2015. 6:36, David Gwynne wrote: > IFF_OACTIVE means the hardware ring is full, not if it is busy. > > perhaps a better check is to see whether there are pending packets > on the send queue? > > i could also argue we dont need the check at all, but this is less > of a semantic change.

Re: trunk vs busy ports

On Fri, Nov 20, 2015 at 03:36:40PM +1000, David Gwynne wrote: > IFF_OACTIVE means the hardware ring is full, not if it is busy. > > perhaps a better check is to see whether there are pending packets > on the send queue? > > i could also argue we dont need the check at all, but this is less > of

sppp(4) PP_NOFRAMING

Currently pppoe(4) is the only user of sppp(4) and it uses PP_NOFRAMING. Do we expect sppp(4) to be used for anything other than pppoe(4) in the future? If not, we can simplify things by removing the code to support framing. Diff also removes some useless ifdefs while there. Index: if_pppoe.c

Re: sppp(4) PP_NOFRAMING

> On 20 Nov 2015, at 9:36 PM, Stuart Henderson wrote: > > Currently pppoe(4) is the only user of sppp(4) and it uses PP_NOFRAMING. > Do we expect sppp(4) to be used for anything other than pppoe(4) in the > future? If not, we can simplify things by removing the code to

Re: trunk vs busy ports

> On 20 Nov 2015, at 8:18 PM, Martin Pieuchot wrote: > > On 20/11/15(Fri) 15:36, David Gwynne wrote: >> IFF_OACTIVE means the hardware ring is full, not if it is busy. > > As discussed earlier, I'd still love to have a document (manpage?) > describing these flags so we can

Re: trunk vs busy ports

On 20.11.2015. 13:26, Hrvoje Popovski wrote: > On 20.11.2015. 6:36, David Gwynne wrote: >> IFF_OACTIVE means the hardware ring is full, not if it is busy. >> >> perhaps a better check is to see whether there are pending packets >> on the send queue? >> >> i could also argue we dont need the check

Re: Use symbolic name instead of hardcoded value on telnet(1)

Ricardo Mestre writes: > Use symbolic name instead of hardcoded value on telnet(1): Committed, thanks. > Index: commands.c > === > RCS file: /cvs/src/usr.bin/telnet/commands.c,v > retrieving revision 1.79

Re: Use symbolic name instead of hardcoded value on telnet(1)

That was fast, thank you! In the meantime I found a few more offenders, patch below. PS: I previously sent a patch for route, which also uses shutdown with a number, but for now I'm still waiting for comments on that one. Index: gnu/usr.bin/cvs/src/client.c

Re: trunk vs busy ports

On 20/11/15(Fri) 15:36, David Gwynne wrote: > IFF_OACTIVE means the hardware ring is full, not if it is busy. As discussed earlier, I'd still love to have a document (manpage?) describing these flags so we can agree on when to use them. > perhaps a better check is to see whether there are

Re: does openssl get to use dns?

"Todd T. Fries" writes: > To demonstrate: > > openssl s_client -connect www.google.com:443 Heh. > A fix, probably not the full or correct one: ok jca@ do_accept(), in s_socket.c calls gethostbyaddr, then gethostbyname if the former fails... > Index: openssl.c >

Re: Interesting if_get() case

Hello, thanks for detailed explanation. > + else { > + struct ifnet *destifp; > + > + destifp = if_get(rt->rt_ifidx); > + if (destifp != NULL) > + destmtu =

afterboot - ntpd now on by default

Ping. Index: afterboot.8 === RCS file: /cvs/src/share/man/man8/afterboot.8,v retrieving revision 1.149 diff -u -p -r1.149 afterboot.8 --- afterboot.8 24 Sep 2015 15:07:55 - 1.149 +++ afterboot.8 26 Sep 2015 16:22:07 - @@

Re: rt_ifp and icmp

On Fri, Nov 20, 2015 at 02:31:23PM +0100, Martin Pieuchot wrote: > The first rt_ifp of the day, make use of if_get() inside icmp_mtudisc(). > > ok? > OK (however you are probably better to wait for more experienced one OK) BTW I like the way rt_ifidx is defined, it's smart way to move forward

Re: rt_ifp and icmp6

Hello, OK regards sasha On Fri, Nov 20, 2015 at 02:33:44PM +0100, Martin Pieuchot wrote: > Some if_get() love in icmp6. > > ok? >

Re: Use symbolic name instead of hardcoded value on telnet(1)

Ricardo Mestre writes: > That was fast, thank you! In the meantime I found a few more offenders, > patch below. It is unclear to me whether the cvs patch should be committed. Most of those calls *may* go away soon, along with the surrounding code. > PS: I previously

Re: serious watchdog timeout issues with em driver

> Date: Fri, 20 Nov 2015 14:12:52 +0100 > From: Martin Pieuchot > > On 19/11/15(Thu) 17:54, Sonic wrote: > > Have serious problems for over 7 weeks now with em driver, > > specifically any rev of if_em.c > 1.305. Starting with rev 1.306, > > released on 2015/09/30 and

Re: Memory corruptions in bc(1)

ok Otto Moerbeek(o...@drijf.net) on 2015.11.20 14:22:12 +0100: > On Fri, Nov 20, 2015 at 11:52:16AM +0100, Otto Moerbeek wrote: > > > On Thu, Nov 19, 2015 at 05:52:39PM -0500, Michael McConville wrote: > > > > > I'm already cache-thrashing with all of my side projects, so if anyone's > > >

typo in tcsetpgrp.3

ok? Index: lib/libc/termios/tcsetpgrp.3 === RCS file: /cvs/src/lib/libc/termios/tcsetpgrp.3,v retrieving revision 1.11 diff -u -p -r1.11 tcsetpgrp.3 --- lib/libc/termios/tcsetpgrp.312 Dec 2013 22:44:22 - 1.11 +++

Re: rt_ifp and pf(4)

Hello, I have just nit comments, feel free to ignore them. 1) would it be possible to use closing #endif guards as follows: #endif /* NCARP */ 2) another nit here: > @@ -5607,6 +5616,8 @@ pf_route(struct mbuf **m, struct pf_rule > done: > if (r->rt != PF_DUPTO) >

Re: [PATCH 1/2] flex 2.5.39

On Thu, Nov 19, 2015 at 06:53:45PM -0500, Ted Unangst wrote: > Serguey Parkhomovsky wrote: > > * renamed parse.c, parse.h, scan.c, skel.c with init prefix so compiling > > flex outside of obj by accident wouldn't clobber the bootstrap files > > Do you remember what caused you to skip using the

netstat -P - no namelist

Hello - I used to use netstat -P to view PCB information. Running -current, I get 'no namelist' now. Any ideas? 0xff0397c4da50 tcp 0 0 127.0.0.1.33845127.0.0.1.18333 ESTABLISHED # netstat -P 0xff0397c4da50 netstat: no namelist Thanks, David

Add V4L2_FMT_FLAG_EMULATED to videoio.h

I would like to add V4L2_FMT_FLAG_EMULATED to sys/videoio.h as libv4l (https://github.com/jasperla/openbsd-wip/tree/master/multimedia/libv4l) returns the flag for emulated (i.e., not natively supported by your webcam) video formats. In turn some userspace applications (like the SIP user-agent

pledge monop(6)

Hi! pledge right at the top to rpath to read the cardfiles at the beginning, and wpath cpath to write the save game at any time of the game. Also a KNF. Index: monop.c === RCS file: /cvs/src/games/monop/monop.c,v retrieving revision

Re: serious watchdog timeout issues with em driver

On Fri, Nov 20, 2015 at 12:37 PM, Mark Kettenis wrote: > Thanks Martin. All is fine now. System booted with no errors and no watchdog timeouts. Thanks to all. Chris

Re: trunk vs busy ports

On Fri, Nov 20, 2015 at 9:00 AM, Reyk Floeter wrote: > On Fri, Nov 20, 2015 at 11:27:05PM +1000, David Gwynne wrote: > > > > > On 20 Nov 2015, at 11:23 PM, Reyk Floeter wrote: > > > > > > On Fri, Nov 20, 2015 at 03:36:40PM +1000, David Gwynne wrote: > > >>

pledge for nsd

Tested with and without zone transfers, forced writing of zones to disk and adding and removing zones at run time. Is the order of pledges in main() correct? OK? diff --git nsd.c nsd.c index 2420a65..d2084b7 100644 --- nsd.c +++ nsd.c @@ -,6 +,11 @@ main(int argc, char *argv[])

[patch] cwm: Preserve stacking order during cycling

Hi, After cycling through many windows, the original window may be obscured by many others, and if you still want to see its contents you end up doing the Alt-Tab-Tab-Tab-Tab-Tab, Alt-Tab, Alt-Tab dance. This patch adds restacking of windows during cycling. Hold Alt, press Tab and a window will

Re: sunfire v120 gem interfaces

On Fri, Nov 13, 2015 at 12:36:40PM +1000, David Gwynne wrote: > > > On 13 Nov 2015, at 12:16, Ryan Freeman wrote: > > > > On Tue, Nov 10, 2015 at 08:27:36PM +1000, David Gwynne wrote: > >> any joy? i mean, failure? > > > > Well I got something different. I've noticed the

Re: [patch] fortune(6): fix missing negative in manpage

On Thu, Nov 19, 2015 at 08:10:08AM -0800, Serguey Parkhomovsky wrote: > If you are willing to be offended, then quit using -o? It should be the > opposite. > > Index: fortune.6 > === > RCS file:

Re: [patch] tail(1) follow multiple files

This is broken: $ echo moo | tail -c +2 >From an older working system: $ echo moo | tail -c +2 oo Noticed while trying to package /usr/ports/sysutils/firmware/ulpt.

Re: [patch] tail(1) follow multiple files

Stuart Henderson wrote: > This is broken: > > $ echo moo | tail -c +2 > > > From an older working system: > > $ echo moo | tail -c +2 > oo yes, same as the case with lines which i hack/fixed. martijn sent me a patch, pending review.