Re: dev/rnd.c more explicit_bzero

2016-12-12 Thread Theo de Raadt
That's information is not a secret. > Some functions in rnd have a timespec; make sure to zero it > as already done with other buffers. Also do buf in > dequeue_randomness(). > > - Michael > > > Index: src/sys/dev/rnd.c > === >

dev/rnd.c more explicit_bzero

2016-12-12 Thread Michael W. Bombardieri
Hi, Some functions in rnd have a timespec; make sure to zero it as already done with other buffers. Also do buf in dequeue_randomness(). - Michael Index: src/sys/dev/rnd.c === RCS file: /cvs/src/sys/dev/rnd.c,v retrieving revision

make ifconfig print vnetids in hex too

2016-12-12 Thread David Gwynne
so things will look like this: vlan9: flags=8002 mtu 1500 lladdr 00:00:00:00:00:00 index 11 priority 0 llprio 3 vlan: 70 parent interface: vnetid: 70 (0x46) parent: none groups: vlan status: no carrier vxlan0:

stop letting interface up/down fail silently

2016-12-12 Thread David Gwynne
at the moment if ifconfig foo0 up fails, nothing says so because the kernel doesnt propagate the return code from the IFFLAGS ioctl back to userland. it also reports a link state change before it actually tries to bring the interface up or down. the diff below shuffles the SIOCSIFFLAGS handling

route(8) flush fix

2016-12-12 Thread Martin Pieuchot
This is a just a cosmetic fix. Currently the netmask of flushed routes is not printed correctly. The diff below fixes that. ok? Index: route.c === RCS file: /cvs/src/sbin/route/route.c,v retrieving revision 1.192 diff -u -p

Re: improve gre handling in tcpdump

2016-12-12 Thread Stefan Sperling
On Mon, Dec 12, 2016 at 01:02:55PM +1000, David Gwynne wrote: > gre can do more things than tcpdump currently thinks it can. > > specifically, gre can be carried by ipv6, and it can encapsulate > more than just ip and ppp packets. > > as such, this tells tcpdump to look at gre inside ipv6

Re: route(8) flush fix

2016-12-12 Thread Stefan Sperling
On Mon, Dec 12, 2016 at 10:53:42AM +0100, Martin Pieuchot wrote: > This is a just a cosmetic fix. Currently the netmask of flushed routes > is not printed correctly. The diff below fixes that. > > ok? ok stsp@ > > Index: route.c >

Re: Proxy ARP and npppd (tun)

2016-12-12 Thread Martin Pieuchot
On 09/12/16(Fri) 19:42, Erik Lax wrote: > Hi, > > In previous OpenBSD versions (5.9 and eariler) it was possible to do > proxy-arp with the npppd server if the proxy-arp was setup before the > npppd connection was made. As of 6.0 (and todays snapshots) proxy arp > and npppd (tun interfaces) seems

ifconfig and tunnels using ipv6 link local addresses

2016-12-12 Thread David Gwynne
the system is inconsistent wrt to tunnels and ipv6 link local addresses. there are three things to consider here: 1. configuring addresses on a tunnel 2. using addresses to encapsulate traffic 3. reading the addresses a tunnel uses the ioctls used for 1 and 3 use sockaddr_in6 to pass v6

Re: efifb(4): WSDISPLAYIO_{GET,SET}PARAM ioctl support

2016-12-12 Thread YASUOKA Masahiko
comitted. Thanks! On Sun, 11 Dec 2016 10:32:59 +0100 Anton Lindqvist wrote: > This allows the brightness on my Dell Latitude 3160 to be adjusted > through wsconsctl(1). > > Index: arch/amd64/amd64/efifb.c >

Re: bpf_mtap(9) w/o KERNEL_LOCK

2016-12-12 Thread Martin Pieuchot
On 07/12/16(Wed) 00:44, Alexander Bluhm wrote: > On Mon, Nov 28, 2016 at 04:01:14PM +0100, Martin Pieuchot wrote: > > @@ -717,7 +753,9 @@ bpfioctl(dev_t dev, u_long cmd, caddr_t > > *(u_int *)addr = size = bpf_maxbufsize; > > else if (size <

umb: aggregate packets on tx

2016-12-12 Thread Gerhard Roth
The current umb(4) implementation needs one USB transfer for every packet that is sent. With the following patch, we can now aggregate several packets from the ifq into one single USB transfer. This may speed up the tx path. And even if it doesn't, at least it reduces the number of transfers

Re: dhcrelay(8): filter BOOTREPLY packets

2016-12-12 Thread Jeremie Courreges-Anglas
Rafael Zalamena writes: > This diff makes dhcrelay(8) drop packets that were not meant for us. > This is a safety check suggested by jca@ to avoid relaying packets with > the address of other relays. > > ok? ok In the commit message please mention that the most likely

Re: multicast: propagate rdomain for add_vif

2016-12-12 Thread Martin Pieuchot
On 12/12/16(Mon) 16:09, Rafael Zalamena wrote: > After trying to run igmpproxy daemon in different rdomains I noted that > it fails with the following message: > " > ERRO: MRT_ADD_VIF; Errno(49): Can't assign requested address > " > > In the following line: > " > if ( setsockopt( MRouterFD,

Re: [patch] turn igmpstat into a set of percpu counters

2016-12-12 Thread Martin Pieuchot
On 11/12/16(Sun) 19:24, Dimitris Papastamos wrote: > Hi, > > I converted the igmp stats to use percpu counters. This work is > basically the same as what dlg@ did for other parts of the stack. > I looked at the diff and adjusted it for igmp. ok mpi@ > > diff --git a/sys/netinet/igmp.c

Re: bpf_mtap(9) w/o KERNEL_LOCK

2016-12-12 Thread Martin Pieuchot
On 10/12/16(Sat) 23:01, Jonathan Matthew wrote: > On Mon, Nov 28, 2016 at 04:01:14PM +0100, Martin Pieuchot wrote: > > Last diff to trade the KERNEL_LOCK for a mutex in order to protect data > > accessed inside bpf_catchpacket(). > > > > Note about the multiples data structures: > > > > -

multicast: propagate rdomain for add_vif

2016-12-12 Thread Rafael Zalamena
After trying to run igmpproxy daemon in different rdomains I noted that it fails with the following message: " ERRO: MRT_ADD_VIF; Errno(49): Can't assign requested address " In the following line: " if ( setsockopt( MRouterFD, IPPROTO_IP, MRT_ADD_VIF, (char *), sizeof(

Re: umb: aggregate packets on tx

2016-12-12 Thread Bryan Vyhmeister
On Mon, Dec 12, 2016 at 02:50:50PM +0100, Gerhard Roth wrote: > The current umb(4) implementation needs one USB transfer for every packet > that is sent. With the following patch, we can now aggregate several > packets from the ifq into one single USB transfer. > > This may speed up the tx path.

Fix formatting of spamd.conf.5

2016-12-12 Thread Larry Hynes
Add missing 'e's at EOL for the heise.de message. Index: spamd.conf.5 === RCS file: /cvs/src/share/man/man5/spamd.conf.5,v retrieving revision 1.16 diff -u -p -r1.16 spamd.conf.5 --- spamd.conf.51 Jun 2016 21:57:03 -

Re: multicast: propagate rdomain for add_vif

2016-12-12 Thread Mike Belopuhov
On Mon, Dec 12, 2016 at 16:15 +0100, Martin Pieuchot wrote: > On 12/12/16(Mon) 16:09, Rafael Zalamena wrote: > > After trying to run igmpproxy daemon in different rdomains I noted that > > it fails with the following message: > > " > > ERRO: MRT_ADD_VIF; Errno(49): Can't assign requested address >

Re: multicast: propagate rdomain for add_vif

2016-12-12 Thread Martin Pieuchot
On 12/12/16(Mon) 16:35, Mike Belopuhov wrote: > On Mon, Dec 12, 2016 at 16:15 +0100, Martin Pieuchot wrote: > > [...] > > Why pass the socket to add_vif() when you only need the rdomain? > > > > It makes add_vif take same arguments as some other functions called > from ip_mrouter_set in that