Re: acme-client -t switch?

2017-03-07 Thread Devin Reade
Expanding on my previous email, it looks like the git version of acme-client has a different implementation than what was implemented in the version first committed (and later removed) from the OpenBSD CVS sources. The latter (CVS) version was calling "doas sh ..." whereas the former (git)

xenocara: honor CC, CXX, CXXFLAGS

2017-03-07 Thread Christian Weisgerber
I noticed that the xenocara build uses "gcc" and "g++" everywhere if those exist at build time. It's the result of an omission: CC, CXX, and CXXFLAGS simply aren't passed into the build and the GNU configure defaults are used. Straightforward fix. OK? PS: Does anybody remember why we need to

Re: xenocara: honor CC, CXX, CXXFLAGS

2017-03-07 Thread Matthieu Herrb
On Tue, Mar 07, 2017 at 09:26:01PM +0100, Christian Weisgerber wrote: > I noticed that the xenocara build uses "gcc" and "g++" everywhere > if those exist at build time. It's the result of an omission: > CC, CXX, and CXXFLAGS simply aren't passed into the build and the > GNU configure defaults

pf: time since uptime instead of wall clock?

2017-03-07 Thread Patrick Wildt
Hi, currently the pf status struct contains the time since pf was enabled as seen on the wall clock. This means when time drifts, or is set to some earlier value, the time will be off. If we use time since uptime it always increments and shows how long pf has been running compared to its

Re: arm64 SMP support, diff #3/5

2017-03-07 Thread Jonathan Gray
On Tue, Mar 07, 2017 at 02:28:06AM -0500, Dale Rahn wrote: > > Updated diff, this has changed a bit since the psci driver has changed. > > diff --git a/sys/dev/fdt/psci.c b/sys/dev/fdt/psci.c > index b24613a275c..2ba500ea718 100644 > --- a/sys/dev/fdt/psci.c > +++ b/sys/dev/fdt/psci.c > @@ -29,14

Unneeded splnet()/splx() in carp(4)

2017-03-07 Thread Martin Pieuchot
carp(4), as a pseudo-interface, is always executed in the 'softnet' thread. Using splnet()/splx() might have been relevant when link-state handlers where directly executed from hardware interrupt handlers. But nowadays everything is run under the NET_LOCK() in a thread context, so let's get rid

Re: Fix style.9 offenders in includes

2017-03-07 Thread Jeremie Courreges-Anglas
Frederic Cambus writes: > Hi tech@, > > Here is a diff to fix style.9 offenders in includes. > > Prototypes should not have variable names associated with the types. IIRC some people just disagree with this rule. Variable names can help the developer, but can also clash with

routing sockets & splsoftnet()

2017-03-07 Thread Martin Pieuchot
Remove unnecessary splsoftnet()/splx() dances. Routing sockets do not need the NET_LOCK() and in the code below the SPL has been raised to shut up an assert, so they are no longer needed. ok? Index: net/rtsock.c === RCS file:

Mention maximum number of allowed fonts in wsfontload.8

2017-03-07 Thread Frederic Cambus
Hi tech@, WSDISPLAY_MAXFONTCOUNT macro was introduced in sys/dev/wscons/wsconsio.h (revision 1.75) to limit the number of fonts that can be loaded. Reflect that in the man page as well. Comments? OK? Index: usr.sbin/wsfontload/wsfontload.8

Re: 11n support for athn(4)

2017-03-07 Thread Stefan Sperling
On Tue, Mar 07, 2017 at 07:12:43AM +0200, Timo Myyrä wrote: > I didn't think it would improve things yet but I had the antenna so I'd figure > I'd stick it in the AP while I'm tweaking it anyway. > > Speaking of 5Ghz, my AP uses athn chipset AR9280 which seems to support 2.4Ghz > and 5Ghz. Can I

Sync nfs_connect w/ sys_connect

2017-03-07 Thread Martin Pieuchot
This code is mostly a copy of what's done in sys_connect(), so sync it to use solock()/sosleep()/sounlock() instead of splsoftnet()/splx(). ok? Index: nfs/nfs_socket.c === RCS file: /cvs/src/sys/nfs/nfs_socket.c,v retrieving

Fix style.9 offenders in includes

2017-03-07 Thread Frederic Cambus
Hi tech@, Here is a diff to fix style.9 offenders in includes. Prototypes should not have variable names associated with the types. Comments? OK? Index: bsd_auth.h === RCS file: /cvs/src/include/bsd_auth.h,v retrieving revision

Re: 11n support for athn(4)

2017-03-07 Thread Stuart Henderson
On 2017/03/07 10:40, Stefan Sperling wrote: > On Tue, Mar 07, 2017 at 07:12:43AM +0200, Timo Myyrä wrote: > > Can OpenBSD AP work on both frequencies at the same time or is that > > something > > not yet supported? > > No, that won't work. The hardware can do 'multi-BSS' which we don't > yet

newfs_ext2fs: lost+found ifdefs

2017-03-07 Thread Carlin Bingham
lost+found is always created and always has been, do the ifdefs need to stick around? -- Carlin Index: sbin/newfs_ext2fs/mke2fs.c === RCS file: /cvs/src/sbin/newfs_ext2fs/mke2fs.c,v retrieving revision 1.16 diff -u -p -u -r1.16

Re: priq: proposed change in the behavior

2017-03-07 Thread Mike Belopuhov
On 7 March 2017 at 10:13, Martin Pieuchot wrote: > On 06/03/17(Mon) 23:13, Mike Belopuhov wrote: >> On Thu, Mar 02, 2017 at 14:23 +0100, Mike Belopuhov wrote: >> > On Thu, Mar 02, 2017 at 10:35 +1000, David Gwynne wrote: >> > > the current code has been very careful not to free

Re: priq: convert to mbuf lists

2017-03-07 Thread Mike Belopuhov
On 7 March 2017 at 02:32, David Gwynne wrote: > >> On 2 Mar 2017, at 21:19, Mike Belopuhov wrote: >> >> On Thu, Mar 02, 2017 at 10:11 +0100, Martin Pieuchot wrote: >>> On 02/03/17(Thu) 01:16, Mike Belopuhov wrote: On 2 March 2017 at 00:56, David

USB use-after-fruit

2017-03-07 Thread Martin Pieuchot
ehrhardt@ reported to me a use-after-free in USB polling mode, turns out it's a design problem. That means there's a lot of them. That's scary. Diff below is a small piece of a huge fix. It concerns root hub codes. To keep it short, it is not safe to dereference ``xfer'' after having called

ip_ipip.c / gif(4) percpu counters

2017-03-07 Thread Jeremie Courreges-Anglas
I failed to find a nice place where to initialize the counters. The code that uses counters is reachable even if gif(4) isn't compiled in. I can think of 3 obvious ways to call the init function. 1. call ipip_init() through .pr_init. The idea would be to call ipip_init() once per protosw

etherip(4) counters tweak

2017-03-07 Thread Jeremie Courreges-Anglas
The diff below renames the members of struct etheripstat to match other *stat counters: "etherip_foo" -> "etherips_foo". It also moves them all to u_int64_t to mkae the conversion to percpu counters cleaner. https://codesearch.debian.net/search?q=etheripstat returns no match and shells/nsh

Re: ip_ipip.c / gif(4) percpu counters

2017-03-07 Thread Alexander Bluhm
On Tue, Mar 07, 2017 at 06:16:30PM +0100, Jeremie Courreges-Anglas wrote: > > I failed to find a nice place where to initialize the counters. The > code that uses counters is reachable even if gif(4) isn't compiled in. > > I can think of 3 obvious ways to call the init function. > > 1. call

Re: etherip(4) counters tweak

2017-03-07 Thread Alexander Bluhm
On Tue, Mar 07, 2017 at 06:53:56PM +0100, Jeremie Courreges-Anglas wrote: > > The diff below renames the members of struct etheripstat to match other > *stat counters: "etherip_foo" -> "etherips_foo". It also moves them all > to u_int64_t to mkae the conversion to percpu counters cleaner. > >

Re: tcpdump: etherip fix

2017-03-07 Thread David Gwynne
> On 8 Mar 2017, at 16:29, Jeremie Courreges-Anglas wrote: > > > https://tools.ietf.org/html/draft-housley-etherip-01 > > still proposes a 1 byte header, the first nibble is the version (2). > The published RFC specifies version 3 and a two bytes header. > >

Re: acme-client -t switch?

2017-03-07 Thread Stuart Henderson
On 2017/03/07 13:24, Devin Reade wrote: > Expanding on my previous email, it looks like the git version of > acme-client has a different implementation than what was implemented > in the version first committed (and later removed) from the OpenBSD > CVS sources. The latter (CVS) version was

tcsetpgrp(3) can set errno to EINTR

2017-03-07 Thread Todd C. Miller
If tcsetpgrp() is called by a background process and there is a SIGTTOU handler installed without SA_RESTART set, tcsetpgrp() will return -1 and set errno to EINTR. Index: lib/libc/termios/tcsetpgrp.3 === RCS file:

acme-client missing man-page bug item?

2017-03-07 Thread Devin Reade
I'm testing a git-based version of acme-client on OpenBSD 6.0 at the moment and visually comparing source with that in CVS, but this is relevant to OpenBSD 6.1 so bear with me here. In the git version in revokeproc.c about line 237 we see the following comment following the "Parse the SAN line"

acme-client -t switch?

2017-03-07 Thread Devin Reade
So I was looking to use acme-client's "-t" switch to orchestrate the creation of certificates for non-HTTPS use and off-machine use. However I see that it was removed in main.c version 1.15 in the OpenBSD source tree. (I'm currently testing acme-client via git on OpenBSD 6.0.) Would folks be