Re: file: replace fgetln with getline(3)

2017-07-02 Thread Nicholas Marriott
Right, I wasn't clear - I didn't mean "why is getline better than fgetln", I was asking "why do you want to change fgetln to getline in this code". It is fine if the answer is "I am worried that another developer might copy or modify the code and mess it up" rather than "the way file is using

Re: file: replace fgetln with getline(3)

2017-07-02 Thread Nicholas Marriott
I'm not wild about magic_load calling err(), but it is probably more pain to do nicely than it is worth it for now. This is fine, ok nicm On Sun, Jul 02, 2017 at 01:03:13AM -0400, Bryan Steele wrote: > On Sat, Jul 01, 2017 at 08:48:18PM -0400, Bryan Steele wrote: > > On Sat, Jul 01, 2017 at

Re: netstat(1) print PID for sockets.

2017-07-02 Thread Job Snijders
On Sat, Jul 01, 2017 at 08:50:36PM +0200, Sebastian Benoit wrote: > Sebastian Benoit(be...@openbsd.org) on 2017.07.01 20:40:17 +0200: > > oks for this? > > /* filter listening sockets out unless -a is set */ > - if (!aflag && istcp && kf->t_state <= TCPS_LISTEN) > + if (!(aflag ||

Re: file: replace fgetln with getline(3)

2017-07-02 Thread Ingo Schwarze
Hi Nic, Nicholas Marriott wrote on Sun, Jul 02, 2017 at 08:48:28AM +0100: > Possibly fgetln(3) CAVEATS could benefit from some of what you have > written here, although it is all in the manual already just in several > places. Inspecting the manual page again, i don't think it needs longer

Re: add simple ifstated regression test script

2017-07-02 Thread Rob Pierce
> From: "Sebastian Benoit" > To: "Rob Pierce" > Cc: "tech" > Sent: Sunday, July 2, 2017 12:29:07 PM > Subject: Re: add simple ifstated regression test script > Rob Pierce(r...@2keys.ca) on 2017.07.02 12:06:25 -0400: > > I am currently using

Re: file: replace fgetln with getline(3)

2017-07-02 Thread Nicholas Marriott
Possibly fgetln(3) CAVEATS could benefit from some of what you have written here, although it is all in the manual already just in several places. Or at least a link to getline(3)? On Sun, Jul 02, 2017 at 12:26:19AM +0200, Ingo Schwarze wrote: > Hi, > > Nicholas Marriott wrote on Sat, Jul 01,

Re: add simple ifstated regression test script

2017-07-02 Thread Sebastian Benoit
Rob Pierce(r...@2keys.ca) on 2017.07.02 12:06:25 -0400: > I am currently using this regression script for basic ifstated sanity testing. > > Still a work in progress. Requesting commit for safe keeping. Hi, this should go into /usr/src/regress/usr.sbin/ifstated (which does not esist yet).

Re: ifstated whitespace var assignment diff

2017-07-02 Thread Stefan Sperling
On Sat, Jul 01, 2017 at 11:59:59PM -0400, Rob Pierce wrote: > Remove variable assignment in declaration and add whitespace to improve > readability. No functional change. > > Rob Fine with me. I think either style is fine, though. > > Index: ifstated.c >

ifstated ifsd_config variable name change

2017-07-02 Thread Rob Pierce
Second diff to rename additional "always" variable in struct ifsd_config. Requested by stsp@. Rob Index: ifstated.c === RCS file: /cvs/src/usr.sbin/ifstated/ifstated.c,v retrieving revision 1.47 diff -u -p -r1.47 ifstated.c ---

Re: ifstated unused variable

2017-07-02 Thread Stefan Sperling
On Sun, Jul 02, 2017 at 12:32:27AM -0400, Rob Pierce wrote: > Remove unused variable from header file. ok by me. > > Index: ifstated.h > === > RCS file: /cvs/src/usr.sbin/ifstated/ifstated.h,v > retrieving revision 1.12 > diff -u

Re: ifstated unused variable

2017-07-02 Thread Sebastian Benoit
Thanks, i commited all three. /Benno Rob Pierce(r...@2keys.ca) on 2017.07.02 00:32:27 -0400: > Remove unused variable from header file. > > Index: ifstated.h > === > RCS file: /cvs/src/usr.sbin/ifstated/ifstated.h,v > retrieving

Re: install.sub: ieee80211_{scan,config}: Allow quoted SSIDs

2017-07-02 Thread Robert Peichaer
On Thu, Jun 15, 2017 at 12:09:20AM +0200, Klemens Nanni wrote: > Instead of ignoring SSIDs containing whitespaces, slightly adjust the > commands to take everything in between 'nwid ' and ' chan' as SSID; if > it has double quotes at start *and* end, simply remove those. > > This enables users to

Re: vi(1): remove stub settings

2017-07-02 Thread Martin Natano
On Fri, Jun 30, 2017 at 09:19:31AM -0600, Anthony J. Bentley wrote: > > Here's a diff that updates the STANDARDS section in the manual. > I think it will be enough to talk about our POSIX compliance. POSIX > discusses its differences from historical ex/vi in great detail, > including an explicit

Re: rename variable in ifstated

2017-07-02 Thread Stefan Sperling
On Sat, Jul 01, 2017 at 05:53:54PM -0400, Rob Pierce wrote: > never.never say always.always. > > Rename one of the "always" variables to "body" for improved readability. > > No functional change. > > >From ifstated.conf(5): > > "Each state consistes of an init block and a body. The init block

Re: rename variable in ifstated

2017-07-02 Thread Rob Pierce
On Sun, Jul 02, 2017 at 02:56:06PM +0200, Stefan Sperling wrote: > On Sat, Jul 01, 2017 at 05:53:54PM -0400, Rob Pierce wrote: > > never.never say always.always. > > > > Rename one of the "always" variables to "body" for improved readability. > > > > No functional change. > > > > >From

add simple ifstated regression test script

2017-07-02 Thread Rob Pierce
I am currently using this regression script for basic ifstated sanity testing. Still a work in progress. Requesting commit for safe keeping. Regards, Rob Index: usr.sbin/ifstated/ifstated.sh === RCS file:

Re: install.sub: ieee80211_{scan,config}: Allow quoted SSIDs

2017-07-02 Thread Klemens Nanni
Thanks for looking into it. On Sun, Jul 02, 2017 at 04:32:43PM +, Robert Peichaer wrote: ieee80211_scan() - Extract the needed information (nwid, bssid) using a very specific sed expression. Any line, not matching this expr is ignored. - Remove leading and trailing double-quotes in

armv7 bus space fixes

2017-07-02 Thread Artturi Alm
Hi, diff to get rid of bus_space_asm_generic.S, changing a4x bus space to use armv7 bs, which might be considered a bug fix, since generic_ misses the v7 "dsb sy"s, and does add the six missing ones to a4x. unfortunately some less useless bus_dma_tags fixes snuck in. -Artturi diff --git

systemd compat for doas

2017-07-02 Thread Ted Unangst
If the username starts with a digit, but isn't a number, treat it like root. Index: doas.c === RCS file: /cvs/src/usr.bin/doas/doas.c,v retrieving revision 1.72 diff -u -p -r1.72 doas.c --- doas.c 27 May 2017 09:51:07 -

lock(1): report remaining time with getitimer(2)

2017-07-02 Thread Scott Cheloha
Hi, There's an edge case in lock(1) where, after you've reserved a terminal for a finite time, if the system time is changed you get an inaccurate report of the remaining time left on the reservation. This is because we subtract the result of time(3) at the beginning of the program from the

Re: [patch] Remove binc from vi(1)

2017-07-02 Thread Martijn van Duren
Any takers? On 06/22/17 21:32, Martijn van Duren wrote: > Hello tech@, > > Attached a patch to remove the binc function from vi and replace it with > recallocarray. The functions effectively do the same thing since > BINC_{GOTO,RET} already do the nlen > llen comparison. I've run > this without

rebound listen address

2017-07-02 Thread Ted Unangst
I received a similar diff from Angelos a while back, though I turned it down on the grounds that rebound wasn't ready to be a recursive resolver. But I think we're in better shape now. This adds a -l address option to specify the listening address, turning rebound into a lightweight partial

ifstated readability diff

2017-07-02 Thread Rob Pierce
Remove obvious clear_config() comments and misleading state_change() comments. Also relocate do_action() calls for the init block from change_state() to occur with the corresponding do_action() calls for the body block within the calling function for improved readability. No functional change.

armv7 a4x dsb fix

2017-07-02 Thread Artturi Alm
Hi, just the bug fix, so this diff leaves the unused relics around and so, but better than current/nothing, and hopefully small enough to get looked at. -Artturi diff --git a/sys/arch/arm/armv7/armv7_a4x_io.S b/sys/arch/arm/armv7/armv7_a4x_io.S index 3fa09faa4c2..5e9db421853 100644 ---

Re: file: replace fgetln with getline(3)

2017-07-02 Thread Nicholas Marriott
Brilliant, looks good to me, ok nicm On Sun, Jul 02, 2017 at 06:23:35PM +0200, Ingo Schwarze wrote: > Hi Nic, > > Nicholas Marriott wrote on Sun, Jul 02, 2017 at 08:48:28AM +0100: > > > Possibly fgetln(3) CAVEATS could benefit from some of what you have > > written here, although it is all in

Re: systemd compat for doas

2017-07-02 Thread Martijn van Duren
Where would this be needed and make sense? I wasn't aware of this systemd behaviour until now, but a quick google search shows me that it's seen by many as a bug and I tend to agree. A type-O shouldn't imply root access. martijn@ On 07/02/17 20:59, Ted Unangst wrote: > If the username

arm/armv7 KNF - sad shit.

2017-07-02 Thread Artturi Alm
Hi, would anyone be willing to accept diffs to recover from this? I mean the overlooking of this from style(9), that's making my eyes bleed: "There should be no space between the function name and the argument list." ^about prototypes. tbh., i wanted to punch someone in the