Re: remove noises at reboot in azalia(4)

2017-08-10 Thread Alexandre Ratchov
On Thu, Aug 10, 2017 at 10:39:36AM -0400, Theo Buehler wrote: > > Here's a diff that takes these comments into account. I've been running > with this since quite some time and it silences the annoying noises. > > Can we get this in? > I'm running with exactly the same diff, but forgot to

Re: rtadvd: simplify route message handling

2017-08-10 Thread Jeremie Courreges-Anglas
On Thu, Aug 10 2017, Florian Obser wrote: > On Tue, Aug 08, 2017 at 11:08:14AM +0200, Jeremie Courreges-Anglas wrote: >> >> So rtadvd has this complex code that tries to parse multiple routing >> messages, when it actually reads only one message at a time from the >> routing

Re: remove noises at reboot in azalia(4)

2017-08-10 Thread Theo Buehler
On Wed, Jul 05, 2017 at 03:32:23PM +0200, Alexandre Ratchov wrote: > On Wed, Jun 28, 2017 at 04:17:30PM +0200, Manuel Giraud wrote: > > Hi, > > > > This patch removes noises in speaker (or headphone) when rebooting > > (tested on only one Conexant CX20724 chip) > > > > Thanks. Works for me and

Re: caesar(6) documents incorrect frequencies

2017-08-10 Thread Theo de Raadt
> On Tue, Aug 01, 2017 at 08:41:32AM -0500, Matthew Martin wrote: > > On Tue, Aug 01, 2017 at 07:38:28AM -0600, Theo de Raadt wrote: > > > > On Tue, Aug 01, 2017 at 07:28:39AM -0600, Theo de Raadt wrote: > > > > > I've known about ETAONRISHetc basically forever. Where is this new > > > > > order

rtadvd: open ioctl socket up front

2017-08-10 Thread Florian Obser
No need to constantly re-open a socket. Just open it up front and keep it around. diff --git if.c if.c index 9c6acd0e049..e04b6027fae 100644 --- if.c +++ if.c @@ -65,6 +65,8 @@ static void get_iflist(char **buf, size_t *size); static void parse_iflist(struct if_msghdr ***ifmlist_p, char *buf,

missing check for vnode limit in getcwd()

2017-08-10 Thread Sebastien Marie
Hi, getcwd(3) (or __getcwd(2)) could successfully return with invalid result, due to a missing check on path traversal limit. __getcwd(2) computes a limit to the max vnode number to traverse. In short, if your buffer is too small to contains the pathname for N vnodes, there is no need to read

Re: sobind() & socket lock

2017-08-10 Thread Alexander Bluhm
On Wed, Aug 09, 2017 at 07:34:51PM -0400, Martin Pieuchot wrote: > Diff below move solock()/sounlock() outside of sobind(). It's the > next logical step to merge all the lock/unlock dances in nfs_connect(). > > ok? OK bluhm@ > Index: kern/uipc_socket.c >

Re: vmd vioblk writer thread

2017-08-10 Thread Mike Larkin
On Thu, Aug 10, 2017 at 12:43:38PM -0400, Ted Unangst wrote: > this moves writes into a thread. we need to do reads too, but the write side > is much easier... could use a little more testing. > Reads ok to me, I'll try in my tree today. -ml > > Index: virtio.c >

Re: rtadvd: simplify route message handling

2017-08-10 Thread Florian Obser
On Tue, Aug 08, 2017 at 11:08:14AM +0200, Jeremie Courreges-Anglas wrote: > > So rtadvd has this complex code that tries to parse multiple routing > messages, when it actually reads only one message at a time from the > routing socket. The diff below attempts to acknowledge this and tries > to

Re: rtadvd: simplify route message handling

2017-08-10 Thread Florian Obser
On Thu, Aug 10, 2017 at 11:04:10AM -0400, Jeremie Courreges-Anglas wrote: > On Thu, Aug 10 2017, Florian Obser wrote: > > On Tue, Aug 08, 2017 at 11:08:14AM +0200, Jeremie Courreges-Anglas wrote: > >> > >> So rtadvd has this complex code that tries to parse multiple routing

vmd vioblk writer thread

2017-08-10 Thread Ted Unangst
this moves writes into a thread. we need to do reads too, but the write side is much easier... could use a little more testing. Index: virtio.c === RCS file: /cvs/src/usr.sbin/vmd/virtio.c,v retrieving revision 1.49 diff -u -p