Re: don't spam console with pflogd exiting messages, misc cleanup

Bryan Steele(bry...@openbsd.org) on 2017.09.05 16:17:46 -0400: > pflogd(8) currently spams the console on shutdown if syslogd wins the > race to die, this logging probably comes from the fact that pflogd was > largely based on syslogd. i looked at that some time ago: a and found that lot of our

Re: tcpdump fork+exec?

On Thu, Sep 07, 2017 at 12:27:18AM -0400, Bryan Steele wrote: > Hi, > > This turned out easier then pflogd thanks to the existing privsep design > work done by [otto@] and canacar@ many years ago. While tcpdump isn't a > daemon in the traditional sense, it isn't so uncommon for people to have >

Re: don't spam console with pflogd exiting messages, misc cleanup

On Thu, Sep 07, 2017 at 12:05:11PM +0200, Sebastian Benoit wrote: > The reason you see the message on the console on halt and reboot is, because > syslogd is gone at that point, so the message goes to the console instead. pflogd(8) explicitly requests this behavior.

Re: don't spam console with pflogd exiting messages, misc cleanup

On Thu, Sep 07, 2017 at 01:16:18PM +0200, Alexander Bluhm wrote: > On Thu, Sep 07, 2017 at 12:05:11PM +0200, Sebastian Benoit wrote: > > The reason you see the message on the console on halt and reboot is, because > > syslogd is gone at that point, so the message goes to the console instead. > >

Re: SSHFP with EDNS0/DNSSEC

On 07/12/17 18:49, Jeremie Courreges-Anglas wrote: Eric Faurot writes: On Wed, Jul 12, 2017 at 07:45:36AM +0200, Christian Barthel wrote: Hi, earlier this year, jca@ worked on support for DNSSEC and the EDNS0 extension [1] and committed this work at [2] (thanks!). I tried

Re: SSHFP with EDNS0/DNSSEC

On Thu, Sep 07 2017, Andreas Bartelt wrote: > On 07/12/17 18:49, Jeremie Courreges-Anglas wrote: >> Eric Faurot writes: >> >>> On Wed, Jul 12, 2017 at 07:45:36AM +0200, Christian Barthel wrote: Hi, earlier this year, jca@ worked on support for

Re: [patch] Mention syspatch(8) in afterboot(8)

On Tue, Sep 05, 2017 at 01:31:49PM +0200, Jesper Wallin wrote: > Hi, > > Now when syspatch(8) is available and has been tested for a few months, > perhaps mention it in afterboot(8) under the Errata section? > > > Jesper Wallin > hi. i committed a tweaked version of this diff. thanks for the

more pax warning fixes

Hi, this fixes the following clang warnings: /usr/src/bin/pax/tar.c:1257:11: warning: comparison of integers of different signs: 'unsigned long' and 'long' [-Wsign-compare] if (len > end - p) { ~~~ ^ ~~~ /usr/src/bin/pax/tar.c:1262:12: warning: comparison

Re: SSE2 instructions emitted in libcompiler_rt

Christian Weisgerber: > > Maybe this would already help? Would at least not throw stones into the > > way of the next person doing an upgrade of compiler-rt... > -snip- > > Yes, that's better... but errors out: > make: don't know how to make floatdixf.c.c (prerequisite of: floatdixf.c.o) Oh,

Re: SSE2 instructions emitted in libcompiler_rt

Patrick Wildt: > Maybe this would already help? Would at least not throw stones into the > way of the next person doing an upgrade of compiler-rt... -snip- Yes, that's better... but errors out: make: don't know how to make floatdixf.c.c (prerequisite of: floatdixf.c.o) -- Christian "naddy"

Re: don't spam console with pflogd exiting messages, misc cleanup

> On Thu, Sep 07, 2017 at 12:05:11PM +0200, Sebastian Benoit wrote: > > The reason you see the message on the console on halt and reboot is, because > > syslogd is gone at that point, so the message goes to the console instead. > > pflogd(8) explicitly requests this behavior. > >

Re: ksh: histptr and undefined pointer comparisons

On Thu, Aug 31 2017, Jeremie Courreges-Anglas wrote: > I've noticed this some time ago and, while it doesn't seem to be > a problem in practice, it's still undefined. C says what happens with > pointers: > - within the bounds of an array > - one past the last element of an array

preliminary kabylake support for inteldrm

Hi! It turns out that the changes to get kabylake to work are quiet minimal so I took a stab at it and backported all the relevant kabylake commits from linux-4.8.y to our drm tree. I did not touch anything outside of dev/pci/drm/i915 on purprose, so that the update work of kettenis@ is only

Re: don't spam console with pflogd exiting messages, misc cleanup

On 2017/09/07 16:40, Theo de Raadt wrote: > > On Thu, Sep 07, 2017 at 12:05:11PM +0200, Sebastian Benoit wrote: > > > The reason you see the message on the console on halt and reboot is, > > > because > > > syslogd is gone at that point, so the message goes to the console instead. > > > >

Re: more pax warning fixes

On Thu, Sep 07, 2017 at 09:53:50PM +0200, Otto Moerbeek wrote: > So make len long and add a value check to make sure the unsigned long > to long assignment is safe. > > OK? OK bluhm@ > Index: tar.c > === > RCS file:

fix m_getuio coverty finding

Hi, Coverty complains that we check top == NULL and further down in m_getuio() we access top->m_pkthdr.len without check. See CID 1452933. In fact top cannot be NULL there. top is initialized with NULL and nextp is set to m is allocated with M_WAIT, so it is not NULL. When the loop is

fix sorflush() coverty finding

Hi, Coverty complains that the return value of sblock() is not checked in sorflush(), but in other places it is. See CID 1453099. The flags SB_NOINTR and M_WAITOK should avoid failure. As I am trying to find a race in this area for years, I would like to put an assert here. ok? bluhm Index:

[PATCH v3 1/2] VMD: Place log_debug statements in key places

Add log_debug statements in key places to assist with troubleshooting. diff --git usr.sbin/vmd/config.c usr.sbin/vmd/config.c index 9ea87eb86e8..7c1eed2697a 100644 --- usr.sbin/vmd/config.c +++ usr.sbin/vmd/config.c @@ -81,14 +81,18 @@ config_purge(struct vmd *env, unsigned int reset)

[PATCH v3 0/2] VMD: Prevent from crashing

This patch series contains: 1) Place plenty of log_debug statements in key places to assist with troubleshooting and debugging 2) Add new error code when attempting to stop a non-running vm (used by vmctl) Prevent vmd from crashing with updated logic when stopping a vm Difference

[PATCH v3 2/2] VMD: Prevent vmd crashing when stopping a stopped vm

* Fix logic handling stopping a VM. Prevents VMD from crashing. * Add additional error code to notify the user that a vm cannot be stopped when not running. * Add additional log_debug statements. diff --git usr.sbin/vmctl/vmctl.c usr.sbin/vmctl/vmctl.c index 64d82ca847d..d1517d0d26d 100644 ---

Re: more pax warning fixes

On Thu, Sep 07, 2017 at 02:30:20PM -0600, Todd C. Miller wrote: > Why not just use strtol() then? The check against MINXHDRSZ > will catch any negative values. > > - todd Indeed, better diff, -Otto Index: tar.c === RCS

Re: more pax warning fixes

On Thu, Sep 7, 2017 at 10:01 PM, Otto Moerbeek wrote: > On Thu, Sep 07, 2017 at 02:30:20PM -0600, Todd C. Miller wrote: > > > Why not just use strtol() then? The check against MINXHDRSZ > > will catch any negative values. > > Indeed, better diff, > ok guenther@