Re: interface tx mitigation, with NET LOCK fixes

2018-01-08 Thread Alexander Bluhm
On Mon, Jan 08, 2018 at 03:07:34PM +0100, Martin Pieuchot wrote: > Well if_start() is a driver function. It should not require the > NET_LOCK(). pf(4) has been fixed to not be re-entrant so the same > thing has to be done for pseudo-driver. I like the fact that your > diff is defining a new

cloned interface malloc wait

2018-01-08 Thread Alexander Bluhm
Hi, Creating a cloned interface could return ENOMEM during a temporary memory shortage. As it is invoked from a system call, it should not fail and wait instead. ok? bluhm Index: net/if_bridge.c === RCS file:

Re: LibreSSL patch for AIX

2018-01-08 Thread Kinichiro Inoguchi
Hi, I would like to see that patch. Since I thought autotools could adjust the differences between OSs, I didn't know that a special patch needed for AIX. Best regards, Kinichiro Inoguchi

azalia_free_dmamem()

2018-01-08 Thread Michael W. Bombardieri
Hello, This free function in azalia driver can be converted to void because it has nothing useful to return. The old return value was never used. azalia's other free function azalia_freem() is already void. - Michael Index: azalia.c

Re: ksh: State of NOTES and PROJECTS

2018-01-08 Thread Klemens Nanni
On Mon, Jan 08, 2018 at 02:23:48AM +0100, Jeremie Courreges-Anglas wrote: > On Sat, Jan 06 2018, Klemens Nanni wrote: > > Looking at the CVS log one can see that other legacies such as ChangeLog > > have already been zapped. NOTES and PROJECTS have seen sporadic minor > > updates

Re: interface tx mitigation, with NET LOCK fixes

2018-01-08 Thread Hrvoje Popovski
On 8.1.2018. 2:13, David Gwynne wrote: > this is tx mitigation again, ie, defer calling an interfaces start > routine until at least 4 packets are queued, or a task fires. > > the task firing is a problem for things like gif or vxlan that encap > a packet in ip and send it through the ip stack

Re: ksh: remove unused param from kb_add()

2018-01-08 Thread Anton Lindqvist
On Sun, Jan 07, 2018 at 12:26:22PM -0700, Todd C. Miller wrote: > In kb_add(), the args parameter is always NULL. Noticed by anton@ ok anton@

Re: ifdef bwfm_pci_debug_console()

2018-01-08 Thread Patrick Wildt
On Mon, Jan 08, 2018 at 10:53:48AM +0800, Michael W. Bombardieri wrote: > Hello, > > I noticed that calls to the function bwfm_pci_debug_console() > are wrapped in ifdef but the function itself isn't. > > - Michael Fixed that and also changed it so it only prints it when we're running with a

LibreSSL patch for AIX

2018-01-08 Thread Garrick Trowsdale
Hello, LibreSSL up to version 2.5.0 builds under AIX 5.3, 6.1 and 7.1 with the IBM XLC compiler without any patches. LibreSSL 2.5.1 introduced use of the -export-symbols linker flag and corresponding symbol files: libressl-2.5.1/crypto/crypto.sym libressl-2.5.1/crypto/crypto_portable.sym

Re: ksh: State of NOTES and PROJECTS

2018-01-08 Thread Klemens Nanni
On Mon, Jan 08, 2018 at 03:06:32PM +0100, Jeremie Courreges-Anglas wrote: > On Mon, Jan 08 2018, Jeremie Courreges-Anglas wrote: > > On Mon, Jan 08 2018, Klemens Nanni wrote: > > Looks good, except you give no rationale for moving the FPATH quirk > > from "known

Re: ifconfig & wpa keys

2018-01-08 Thread Jeremie Courreges-Anglas
On Mon, Jan 08 2018, Martin Pieuchot wrote: > On 06/01/18(Sat) 09:24, Theo de Raadt wrote: >> We used to try to create ifconfig output that someone could cut'n'paste >> back in as input, when it was reasonable. Therefore ifconfig output >> was a human hint suggesting what

sosetstate/soclrstate

2018-01-08 Thread Martin Pieuchot
Diff below changes the type of `so_state' and `so_error' to int. It also introduces two new wrappers to set & clear state bits atomically. My goal is to prevent a second CPU from reading garbage when looking at these two fields in filt_soread() and filt_sowrite(). The values might be outdated

Re: ifconfig & wpa keys

2018-01-08 Thread Martin Pieuchot
On 06/01/18(Sat) 09:24, Theo de Raadt wrote: > We used to try to create ifconfig output that someone could cut'n'paste > back in as input, when it was reasonable. Therefore ifconfig output > was a human hint suggesting what ifconfig command takes as input. > > But this one doesn't bother me,

Re: mess with regression tests

2018-01-08 Thread Alexander Bluhm
On Fri, Jan 05, 2018 at 07:01:56PM +0300, Sergey Bronnikov wrote: > I have updated patch for bin/ed and now the most part of tests are > works. I have converted your work into a single Makefile. It is easier to have everything in one place. So mkscripts.sh and ckscripts.sh are implemented as

Re: ksh: Update comments

2018-01-08 Thread Sebastian Benoit
commited, thanks Klemens Nanni(k...@posteo.org) on 2018.01.08 23:13:39 +0100: > There were left behind in the recent unifdef JOB commit. > > diff --git a/bin/ksh/jobs.c b/bin/ksh/jobs.c > index c2742ebf72c..7f528f7e68d 100644 > --- a/bin/ksh/jobs.c > +++ b/bin/ksh/jobs.c > @@ -921,7 +921,7 @@

ksh: Update comments

2018-01-08 Thread Klemens Nanni
There were left behind in the recent unifdef JOB commit. diff --git a/bin/ksh/jobs.c b/bin/ksh/jobs.c index c2742ebf72c..7f528f7e68d 100644 --- a/bin/ksh/jobs.c +++ b/bin/ksh/jobs.c @@ -921,7 +921,7 @@ j_async(void) /* Make j the last async process * - * If jobs are compiled in then this

Re: sosetstate/soclrstate

2018-01-08 Thread Alexander Bluhm
On Mon, Jan 08, 2018 at 03:50:14PM +0100, Martin Pieuchot wrote: > ok? OK bluhm@ with a few remarks. > @@ -1422,12 +1422,12 @@ somove(struct socket *so, int wait) > > /* Receive buffer did shrink by len bytes, adjust oob. */ > state = so->so_state; > - so->so_state &=

Re: ksh: State of NOTES and PROJECTS

2018-01-08 Thread Jeremie Courreges-Anglas
On Mon, Jan 08 2018, Klemens Nanni wrote: [...] > See attached diff for the first NOTES changes. [...] > Regarding "POSIX sh questions", we should probably unreference the 1992 > standard. > > POSIX.1-2008, 2.6.2 Parameter Expansion: > > In each case that a value of

Re: interface tx mitigation, with NET LOCK fixes

2018-01-08 Thread Theo Buehler
On Mon, Jan 08, 2018 at 11:13:33AM +1000, David Gwynne wrote: > this is tx mitigation again, ie, defer calling an interfaces start > routine until at least 4 packets are queued, or a task fires. > > the task firing is a problem for things like gif or vxlan that encap > a packet in ip and send it

Re: malloc cleanup and small optimization (step 3)

2018-01-08 Thread Otto Moerbeek
On Wed, Jan 03, 2018 at 01:56:43PM +0100, Otto Moerbeek wrote: > Hi, > > this is mostly kshe's work, with an additional change on the cache > maintenance by me. > > I did not take the ffs change yet, since I want to measure the impact > separately. no feedback :-( I'm going to commit this

Re: make mpls_input take struct ifnet *ifp as an argument

2018-01-08 Thread Alexander Bluhm
On Mon, Jan 08, 2018 at 11:49:05AM +1000, David Gwynne wrote: > i want this so it makes mpls_input have the same function signature > as all the other protocol input functions we care about. > > it also helps mpls_input because it looks up the interface the mpls > packet was received on, but it's

Re: interface tx mitigation, with NET LOCK fixes

2018-01-08 Thread Martin Pieuchot
On 08/01/18(Mon) 11:13, David Gwynne wrote: > this is tx mitigation again, ie, defer calling an interfaces start > routine until at least 4 packets are queued, or a task fires. > > the task firing is a problem for things like gif or vxlan that encap > a packet in ip and send it through the ip

Re: ksh: State of NOTES and PROJECTS

2018-01-08 Thread Jeremie Courreges-Anglas
On Mon, Jan 08 2018, Jeremie Courreges-Anglas wrote: > On Mon, Jan 08 2018, Klemens Nanni wrote: > > [...] > >> See attached diff for the first NOTES changes. > > [...] > >> Regarding "POSIX sh questions", we should probably unreference the 1992 >> standard. >>

Re: make mpls_input take struct ifnet *ifp as an argument

2018-01-08 Thread Claudio Jeker
On Mon, Jan 08, 2018 at 11:50:54AM +0100, Alexander Bluhm wrote: > On Mon, Jan 08, 2018 at 11:49:05AM +1000, David Gwynne wrote: > > i want this so it makes mpls_input have the same function signature > > as all the other protocol input functions we care about. > > > > it also helps mpls_input