ix0/1/2/3 at pci8 dev 0 function 0 "Intel X553 SFP+" rev 0x11: msi, address 00:30:18:xxxxxxx

2018-09-17 Thread sven falempin
Dear Tech reader, I am recently working on Intel(R) Atom(TM) CPU C3758 intel devices. SFP Intel card are not working in 6.3/current openBSD base I did patch intel driver reading netbsd, freebsd and intel code of ixgbe driver. I am now transferring data between two openBSD at ~1.50 Gb/s for

Re: csh: simplify strsave()

2018-09-17 Thread Todd C. Miller
On Mon, 17 Sep 2018 15:53:06 +0200, Martijn van Duren wrote: > It should be safe. There are 5 instances where any() isn't called with > a string literal: Thanks for checking. OK millert@ for the diff. - todd

Re: csh: simplify strsave()

2018-09-17 Thread Michael Mikonos
On Mon, Sep 17, 2018 at 09:06:16AM -0600, Todd C. Miller wrote: > On Mon, 17 Sep 2018 15:53:06 +0200, Martijn van Duren wrote: > > > It should be safe. There are 5 instances where any() isn't called with > > a string literal: > > Thanks for checking. OK millert@ for the diff. > > - todd Also

csh: remove macros xmalloc,xcalloc,xreallocarray

2018-09-17 Thread Michael Mikonos
Hello, In csh(1) the functions Malloc(), Calloc() & Reallocarray() are always called via the macros (which don't really do anything). This patch renames the functions and deletes the macros. Does this look OK? - Michael Index: csh.h

Re: Linux DRM

2018-09-17 Thread Theo de Raadt
Thomas de Grivel wrote: > Le lun. 3 sept. 2018 à 23:33, Philip Guenther a écrit : > > > > On Mon, Sep 3, 2018 at 11:46 AM Thomas de Grivel wrote: > >> > >> I was browsing the DRM code ported from Linux and it's a terrible > >> mess, is there any ongoing project to clean up that codebase or >

Re: bsd.rd failure in VirtualBox

2018-09-17 Thread David Higgs
On Sun, Sep 16, 2018 at 1:15 PM, Johan Huldtgren wrote: > On 2018/09/16 10:52, David Higgs wrote: >> On Sun, Sep 16, 2018 at 10:17 AM, David Higgs wrote: >>> On Sat, Sep 15, 2018 at 10:05 PM, Philip Guenther >>> wrote: On Sat, Sep 15, 2018 at 11:59 AM David Higgs wrote: > > I

Re: more user_from_uid(3)

2018-09-17 Thread Theo Buehler
On Mon, Sep 17, 2018 at 11:14:40AM -0600, Todd C. Miller wrote: > Two more pontential places where user_from_uid(3) makes sense. > These were in my large diff but got lost chopping it up into smaller > pieces. I don't mind the slight change of behavior in write(1) in an unlikely branch, but how

Re: pwd_mkdb(8): estimate correct number of hash table elements

2018-09-17 Thread Theo Buehler
On Mon, Sep 17, 2018 at 11:08:04AM -0600, Todd C. Miller wrote: > Since we store each entry 3 times the estimate of the number of > elements needs to be 3x the number of entries. > > Also set the bucket size to be the optimal file system block size > instead of hard-coding to 4096. ok tb

ral(4): add RT3290 support

2018-09-17 Thread James Hastings
Ported from original vendor driver. RT3290 is similar to RT5390 but integrates WLAN + Bluetooth on single chip. Bluetooth not supported. New 4kb firmware at /etc/firmware/ral-rt3290 for this chip only. New routines to read efuse rom and control wlan core. Tested on RT3090 and RT5390. Index:

Re: rdist: use passwd/group caches

2018-09-17 Thread Theo Buehler
On Sun, Sep 16, 2018 at 07:55:19AM -0600, Todd C. Miller wrote: > Any rdist users out there? The way rdist does group caching (stash > the struct group pointer) will stop working in the future so I'd > like to get these changes in before then. Perhaps we can give potential testers a bit more

more user_from_uid(3)

2018-09-17 Thread Todd C. Miller
Two more pontential places where user_from_uid(3) makes sense. These were in my large diff but got lost chopping it up into smaller pieces. - todd Index: usr.bin/write/write.c === RCS file: /cvs/src/usr.bin/write/write.c,v

pwd_mkdb(8): estimate correct number of hash table elements

2018-09-17 Thread Todd C. Miller
Since we store each entry 3 times the estimate of the number of elements needs to be 3x the number of entries. Also set the bucket size to be the optimal file system block size instead of hard-coding to 4096. - todd Index: usr.sbin/pwd_mkdb/pwd_mkdb.c

Re: csh: remove macros xmalloc,xcalloc,xreallocarray

2018-09-17 Thread Todd C. Miller
On Mon, 17 Sep 2018 23:55:32 +0800, Michael Mikonos wrote: > In csh(1) the functions Malloc(), Calloc() & Reallocarray() > are always called via the macros (which don't really do anything). > This patch renames the functions and deletes the macros. > Does this look OK? OK millert@ - todd

Re: more user_from_uid(3)

2018-09-17 Thread Todd C. Miller
On Tue, 18 Sep 2018 03:30:39 +0200, Theo Buehler wrote: > I don't mind the slight change of behavior in write(1) in an unlikely > branch, but how about doing this instead? > > if ((login = user_from_uid(myuid, 1)) == NULL) > login = "???"; > > either way ok.

mandoc: typo fix (?) in mandoc.1

2018-09-17 Thread Sascha Paunovic
Hi, while reading mandoc(1), I noticed that under the PostScript output section, it said the line-height was 1.4m, while it is 1.4em. I doubt the line-height is approximately as tall as a 5th grader, so let's clarify this: diff --git usr.bin/mandoc/mandoc.1 usr.bin/mandoc/mandoc.1 index

memory leak in amdisplay_attach()

2018-09-17 Thread Jonathan Gray
Index: amdisplay.c === RCS file: /cvs/src/sys/arch/armv7/omap/amdisplay.c,v retrieving revision 1.7 diff -u -p -r1.7 amdisplay.c --- amdisplay.c 25 Oct 2017 14:34:22 - 1.7 +++ amdisplay.c 18 Sep 2018 05:12:41 - @@ -272,6

memory leaks in bwfm

2018-09-17 Thread Jonathan Gray
Index: bwfm.c === RCS file: /cvs/src/sys/dev/ic/bwfm.c,v retrieving revision 1.54 diff -u -p -r1.54 bwfm.c --- bwfm.c 25 Jul 2018 20:37:11 - 1.54 +++ bwfm.c 18 Sep 2018 05:21:30 - @@ -1297,6 +1297,7 @@

smtpctl.8 typo

2018-09-17 Thread Michael Mikonos
Hello, My spell-checker found the following typo this morning. OK? - Michael Index: smtpctl.8 === RCS file: /cvs/src/usr.sbin/smtpd/smtpctl.8,v retrieving revision 1.63 diff -u -p -u -r1.63 smtpctl.8 --- smtpctl.8 14 May 2018

[patch] Use the same backlog parameter for listen() function in netcat.c

2018-09-17 Thread Nan Xiao
Hi tech@, Since netcat can only process one connection at one time, maybe UNIX-domain socket can use the same backlog parameter for listen() function as network socket, thanks! diff --git netcat.c netcat.c index 341e7e5..b6fd199 100644 --- netcat.c +++ netcat.c @@ -894,7 +894,7 @@

Re: unveil for audioctl

2018-09-17 Thread Ricardo Mestre
And of course I missed disabling unveil(2) just right the first call... Index: audioctl.c === RCS file: /cvs/src/usr.bin/audioctl/audioctl.c,v retrieving revision 1.35 diff -u -p -u -r1.35 audioctl.c --- audioctl.c 31 May 2017

unveil for audioctl

2018-09-17 Thread Ricardo Mestre
Hi, This adds unveil(2) to audioctl(1) which only needs rw to the access control device, which by default is /dev/audioctl0, but can be manipulated via args. OK? Index: audioctl.c === RCS file:

fix memory leak in ieee80211_end_scan()

2018-09-17 Thread Ricardo Mestre
Hi, This plugs a resource leak in ieee80211_end_scan() when background scanning support was added to iwn(4). Noticed by Coverity ID 1473310. OK? Index: ieee80211_node.c === RCS file: /cvs/src/sys/net80211/ieee80211_node.c,v

Re: unveil for audioctl

2018-09-17 Thread Alexandre Ratchov
On Mon, Sep 17, 2018 at 01:27:03PM +0100, Ricardo Mestre wrote: > And of course I missed disabling unveil(2) just right the first call... > > Index: audioctl.c > === > RCS file: /cvs/src/usr.bin/audioctl/audioctl.c,v > retrieving

Re: csh: simplify strsave()

2018-09-17 Thread Martijn van Duren
On 09/15/18 14:16, Todd C. Miller wrote: > On Sat, 15 Sep 2018 12:42:22 +0200, Martijn van Duren wrote: > >> While here, should we also remove any in favour of strchr? Only >> difference seems to be the return type (bool vs pointer). > > Note that any(NULL, ch) is safe whereas strchr(NULL, ch)

Re: fdformat: reformat usage()

2018-09-17 Thread Robert Klein
On Sun, 16 Sep 2018 22:48:01 +0100 Jason McIntyre wrote: > On Wed, Sep 12, 2018 at 05:40:49PM +0100, Jason McIntyre wrote: > > On Wed, Sep 12, 2018 at 11:50:18AM +0200, Sascha Paunovic wrote: > > > Since C99, string literal concatenation is provided, allowing the > > > number of printf() calls

inpcb table and socket lock

2018-09-17 Thread Alexander Bluhm
Hi, I want to reduce the scope of the net lock and finally get a mutex per inpcb or socket. A step in this direction is to remove the net lock for netstat -an. Introduce a global mutex that protects the tables and hashes for the internet PCBs. To detect detached PCB, set its inp_socket field

Re: bgpd roa-set backend

2018-09-17 Thread Claudio Jeker
On Fri, Sep 14, 2018 at 04:59:51PM +0200, Claudio Jeker wrote: > This diff extends the existing trie code for prefix-set to also work with > roa-set. Unlike prefix-set there is no need for a prefixlen mask during > lookup, instead the source-as needs to be checked and also if the > prefixlen of

Re: fdformat: reformat usage()

2018-09-17 Thread Robert Klein
(sorry, if this turns up twice, first attempt didn't show up for a couple of hours; updated doc patch below) On Sun, 16 Sep 2018 22:48:01 +0100 Jason McIntyre wrote: > On Wed, Sep 12, 2018 at 05:40:49PM +0100, Jason McIntyre wrote: > > On Wed, Sep 12, 2018 at 11:50:18AM +0200, Sascha Paunovic

Re: fdformat: reformat usage()

2018-09-17 Thread Jason McIntyre
On Mon, Sep 17, 2018 at 02:40:49PM +0200, Robert Klein wrote: > > > > ok, so here's the diff i propose. yay? nay? > > jmc > > > > Index: fdformat.c > > === > > RCS file: /cvs/src/usr.sbin/fdformat/fdformat.c,v > > retrieving

Re: Change to mailer.conf(5) man page

2018-09-17 Thread Jason McIntyre
On Sun, Sep 16, 2018 at 10:58:28PM +0100, Jason McIntyre wrote: > On Sun, Sep 16, 2018 at 05:49:58PM -0400, Matt Schwartz wrote: > > Yes, the comment should go as it is superfluous. Let me know if you > > decide you want the BUGS section after all and I will re-do the patch. > > thanks, but at

Always call bridge_iflist `bif'

2018-09-17 Thread Martin Pieuchot
I'd like to always use the same name of `bridge_iflist', it helps me deal with the different data structures and their relation with `ifp'. Diff below use `bif' everywhere, ok? No intentional functional change. Index: net/if_bridge.c

Re: Always call bridge_iflist `bif'

2018-09-17 Thread Alexander Bluhm
On Mon, Sep 17, 2018 at 10:20:51AM -0300, Martin Pieuchot wrote: > I'd like to always use the same name of `bridge_iflist', it helps me > deal with the different data structures and their relation with `ifp'. > > Diff below use `bif' everywhere, ok? Yes, p was a very unspecific name. OK bluhm@

Re: fix memory leak in ieee80211_end_scan()

2018-09-17 Thread Jonathan Gray
On Mon, Sep 17, 2018 at 10:27:30AM +0100, Ricardo Mestre wrote: > Hi, > > This plugs a resource leak in ieee80211_end_scan() when background scanning > support was added to iwn(4). Noticed by Coverity ID 1473310. > > OK? ok > > Index: ieee80211_node.c >

memory leak in ihidev_hid_command()

2018-09-17 Thread Jonathan Gray
Index: ihidev.c === RCS file: /cvs/src/sys/dev/i2c/ihidev.c,v retrieving revision 1.17 diff -u -p -r1.17 ihidev.c --- ihidev.c25 Aug 2018 18:32:05 - 1.17 +++ ihidev.c18 Sep 2018 05:15:37 - @@ -361,6 +361,7 @@