parse.y: strndup() in cmdline_symset()

2018-11-01 Thread Michael Mikonos
Hello, When I updated cmdline_symset() in parse.y in the following commit I missed src/sbin/{iked,ipsecctl,pfctl}/parse.y. OK to update them? https://marc.info/?l=openbsd-cvs=153631079505256=2 Index: iked/parse.y === RCS file:

Re: bgpd, Adj-RIB-Out support

2018-11-01 Thread Denis Fondras
On Wed, Oct 31, 2018 at 10:02:05PM -0400, David Higgs wrote: > On Wed, Oct 31, 2018 at 6:58 PM Sebastian Benoit wrote: > > > > On a phone, saw some typos and such, sorry no diff. > > [benoit@border2:~]$ cat before > > RDE memory statistics > > 715727 IPv4 unicast network entries using

Re: bgpd, Adj-RIB-Out support

2018-11-01 Thread Claudio Jeker
On Wed, Oct 31, 2018 at 11:55:51PM +0100, Sebastian Benoit wrote: > Denis Fondras(open...@ledeuns.net) on 2018.10.31 21:02:17 +0100: > > On Wed, Oct 31, 2018 at 04:24:49PM +0100, Claudio Jeker wrote: > > > This diff introduces a real Adj-RIB-Out. It is the minimal change to > > > introduce the new

snmpctl segfault

2018-11-01 Thread Martijn van Duren
When experimenting with snmpd I found the following crash: $ snmpctl snmp walk 127.0.0.1 oid 1 Segmentation fault (core dumped) The problem is a NULL dereference in ber_free_elements: #0 0x0370920d24ca in ber_free_elements (root=0x0) at

Xenocara: disable xdm-authorization-1 cleanly

2018-11-01 Thread Matthieu Herrb
Hi, The XDM-AUTHORIZATION-1 protocol is currenly disabled in xenocara. It makes sense: this auth protocol doesn't work with IPv6, is relying on weak DES encryption and only useful with XDMP which isn't supported by xenodm. But it's currently only disabled as a side-effect of a buggy check in

Re: top: merge duplicate code into helper functions

2018-11-01 Thread Todd C. Miller
On Wed, 31 Oct 2018 23:38:58 +0100, Klemens Nanni wrote: > New diff free of side-effects in filteruser(), rest unchanged. OK millert@ - todd

Re: bgpd, Adj-RIB-Out support

2018-11-01 Thread Sebastian Benoit
Claudio Jeker(cje...@diehard.n-r-g.com) on 2018.11.01 10:38:41 +0100: > On Wed, Oct 31, 2018 at 11:55:51PM +0100, Sebastian Benoit wrote: > > Denis Fondras(open...@ledeuns.net) on 2018.10.31 21:02:17 +0100: > > > On Wed, Oct 31, 2018 at 04:24:49PM +0100, Claudio Jeker wrote: > > > > This diff

Re: top: accept UIDs

2018-11-01 Thread Ted Unangst
Klemens Nanni wrote: > This makes `top -U 0' and "u-1000" work. > > Overview: > > "kn" ok"10kn"ok if "10kn" exists else error > "-kn"ok"-10kn" ok if "10kn" exists else error > "1000" ok"--1000" error, negative UID and "-1000" not valid >

Re: top: accept UIDs

2018-11-01 Thread Todd C. Miller
On Thu, 01 Nov 2018 21:04:03 +0100, Klemens Nanni wrote: > Here's a diff that tries UIDs only if username lookup fails. OK millert@ - todd

Re: wdc(4): remove unnecessary if/else block

2018-11-01 Thread Stuart Henderson
On 2018/11/01 23:00, Frederic Cambus wrote: > Hi tech@, > > Remove unnecessary if/else block, both branches are identical. We can > in fact use the ATA_DELAY macro directly. > > Coverity CID 1453008. > > Comments? OK? > > Index: dev/ata/ata_wdc.c >

Re: top: accept UIDs

2018-11-01 Thread Jason McIntyre
On Thu, Nov 01, 2018 at 10:27:18PM +0100, Klemens Nanni wrote: > On Thu, Nov 01, 2018 at 09:20:10PM +, Jason McIntyre wrote: > > while with the current behaviour it made sense to document it that way, > > once you change it, it just sounds odd. it should really be wrapped into > > the first

getent: prefer usernames over UIDs

2018-11-01 Thread Klemens Nanni
Prompted by tedu@'s recent reply, here's a fix for getent(1) to lookup keys as UIDs only if the username lookup fails to prevent clobbering numerical usernames. $ getent passwd 1000 kn kn:*:1000:1000:Klemens Nanni:/home/kn:/bin/ksh kn:*:1000:1000:Klemens

Re: pcidevs update for VIA HD Audio device

2018-11-01 Thread Mike Larkin
On Thu, Nov 01, 2018 at 11:07:21PM +0100, Frederic Cambus wrote: > Hi tech@, > > Add ID for a VIA HD Audio device found on my HP t5570 Thin Client. > > While there, update URL for the vendor ID search engine. > > Comments? OK? > ok mlarkin > Index: sys/dev/pci/pcidevs >

Re: getent: prefer usernames over UIDs

2018-11-01 Thread Ted Unangst
Klemens Nanni wrote: > Prompted by tedu@'s recent reply, here's a fix for getent(1) to lookup > keys as UIDs only if the username lookup fails to prevent clobbering > numerical usernames. yes, this is how it should be. please fix group lookup as well.

wdc(4): remove unnecessary if/else block

2018-11-01 Thread Frederic Cambus
Hi tech@, Remove unnecessary if/else block, both branches are identical. We can in fact use the ATA_DELAY macro directly. Coverity CID 1453008. Comments? OK? Index: dev/ata/ata_wdc.c === RCS file: /cvs/src/sys/dev/ata/ata_wdc.c,v

Re: top: accept UIDs

2018-11-01 Thread Ted Unangst
Klemens Nanni wrote: > On Thu, Nov 01, 2018 at 02:56:38PM -0400, Ted Unangst wrote: > > this looks to be in the wrong order. if 1000 is a username, that should be > > matched first before numeric lookup. > Preferring UIDs indeed clobbers usernames with the respective numerical > username. > >

pcidevs update for VIA HD Audio device

2018-11-01 Thread Frederic Cambus
Hi tech@, Add ID for a VIA HD Audio device found on my HP t5570 Thin Client. While there, update URL for the vendor ID search engine. Comments? OK? Index: sys/dev/pci/pcidevs === RCS file: /cvs/src/sys/dev/pci/pcidevs,v retrieving

Re: top: accept UIDs

2018-11-01 Thread Klemens Nanni
On Thu, Nov 01, 2018 at 02:56:38PM -0400, Ted Unangst wrote: > this looks to be in the wrong order. if 1000 is a username, that should be > matched first before numeric lookup. Preferring UIDs indeed clobbers usernames with the respective numerical username. However, other parts in base such as

Re: top: accept UIDs

2018-11-01 Thread Jason McIntyre
On Thu, Nov 01, 2018 at 09:04:03PM +0100, Klemens Nanni wrote: > On Thu, Nov 01, 2018 at 02:56:38PM -0400, Ted Unangst wrote: > > this looks to be in the wrong order. if 1000 is a username, that should be > > matched first before numeric lookup. > Preferring UIDs indeed clobbers usernames with the

Re: top: accept UIDs

2018-11-01 Thread Klemens Nanni
On Thu, Nov 01, 2018 at 09:20:10PM +, Jason McIntyre wrote: > while with the current behaviour it made sense to document it that way, > once you change it, it just sounds odd. it should really be wrapped into > the first sentence. sth like: > > Show only those processes owned by

Re: getent: prefer usernames over UIDs

2018-11-01 Thread Klemens Nanni
On Thu, Nov 01, 2018 at 06:37:15PM -0400, Ted Unangst wrote: > yes, this is how it should be. please fix group lookup as well. Was in the queue for a separate diff, here it goes together. Index: getent.c === RCS file:

Re: wdc(4): remove unnecessary if/else block

2018-11-01 Thread Klemens Nanni
OK

Re: getent: prefer usernames over UIDs

2018-11-01 Thread Todd C. Miller
On Fri, 02 Nov 2018 00:45:06 +0100, Klemens Nanni wrote: > On Thu, Nov 01, 2018 at 06:37:15PM -0400, Ted Unangst wrote: > > yes, this is how it should be. please fix group lookup as well. > Was in the queue for a separate diff, here it goes together. Looks good. OK millert@ - todd

top: accept UIDs

2018-11-01 Thread Klemens Nanni
This makes `top -U 0' and "u-1000" work. Overview: "kn" ok"10kn"ok if "10kn" exists else error "-kn"ok"-10kn" ok if "10kn" exists else error "1000" ok"--1000" error, negative UID and "-1000" not valid "-1000" ok"--10kn" error,