Re: [patch] improve strptime(3) %z timezone parsing

On Fri, 10 May 2019 23:06:21 +0200, Ingo Schwarze wrote: > The following patch preserves the parsing behaviour > and correctly stores the number of seconds into tm_gmtoff. That one looks correct. OK millert@ - todd

Re: enable pfctl to flush all rules and tables

Hello, Petr Hoffmann pointed out three nits off-list. we are better to use errx() instead of fprintf() + exit here: +pfctl_get_anchors(int dev, int opts) +{ + + if (pfra.pfra == NULL) + errx(1, + "%s failed to allocate main anchor, can't continue\n", +

Re: [patch] improve strptime(3) %z timezone parsing

Hi, > That one looks correct. OK millert@ Committed, thanks for checking! While here, i noticed ugly preprocessor macros. Let's make our future life easier by unifdefing a bit. When compiling with -g0, there is no object change. Note that if TM_ZONE is not defined, wcsftime.c doesn't

Re: [patch] improve strptime(3) %z timezone parsing

On Fri, 10 May 2019 16:52:35 +0200, Ingo Schwarze wrote: > I failed to find any users that do *not* expect seconds. > So my conclusion is that the documentation is right and > what the code in strptime.c does is wrong. Yes, tm_gmtoff is in seconds. > Here is a patch to fix the code. OK

Re: [patch] improve strptime(3) %z timezone parsing

Ingo Schwarze wrote: > Ouch. No, it does not. Thanks for spotting the regression. > > The following patch preserves the parsing behaviour > and correctly stores the number of seconds into tm_gmtoff. oops, missed that case too. this looks correct.

Re: [patch] improve strptime(3) %z timezone parsing

Hi Todd, Todd C. Miller wrote on Fri, May 10, 2019 at 02:08:45PM -0600: > On Fri, 10 May 2019 16:52:35 +0200, Ingo Schwarze wrote: >> Here is a patch to fix the code. > OK millert@ for that part. Thanks, committed. >> The change to %Z is exactly what Hiltjo sent. >> The current code for %z is

Re: [patch] improve strptime(3) %z timezone parsing

On Sat, 11 May 2019 00:30:35 +0200, Ingo Schwarze wrote: > While here, i noticed ugly preprocessor macros. > Let's make our future life easier by unifdefing a bit. > When compiling with -g0, there is no object change. No objection, OK millert@ - todd

Proper prototype for upgrade() in boot code

See subject -- :wq Claudio Index: cmd.h === RCS file: /cvs/src/sys/stand/boot/cmd.h,v retrieving revision 1.17 diff -u -p -r1.17 cmd.h --- cmd.h 8 Apr 2019 13:55:46 - 1.17 +++ cmd.h 8 May 2019 23:12:10 -

fix tcpdump localtime caching

The comment above priv_localtime() says, the obtained localtime (from the privileged process) is cached for about one minute. However, since the according if statement compares the wrong variable, the caching doesn't happen. This bug is there since the very first file version (from 15+ years

ssl(8), fix text about web browsers and SAN

it's standard behaviour for web browsers to not use hostnames in Subject at all but require SAN. current ssl(8) text suggests "some new" and "deprecated" rather than "stopped supporting". comments/ok? Index: ssl.8 === RCS file:

Re: ssl(8), fix text about web browsers and SAN

I was just stumbling over this as well when I did the relayd: SNI diff. OK reyk On Fri, May 10, 2019 at 1:50 PM Stuart Henderson wrote: > it's standard behaviour for web browsers to not use hostnames in > Subject at all but require SAN. current ssl(8) text suggests "some new" > and

Re: ssl(8), fix text about web browsers and SAN

Stuart Henderson wrote: > it's standard behaviour for web browsers to not use hostnames in > Subject at all but require SAN. current ssl(8) text suggests "some new" > and "deprecated" rather than "stopped supporting". > > comments/ok? I was trying to avoid argument "but my browser still works"

Re: SMR lists for bridge(4)

On 08/05/19(Wed) 17:09, Martin Pieuchot wrote: > Diff below pushes the KERNEL_LOCK() further down into bridge(4). > > With it bridge_enqueue() now only takes the lock for rules. Rules could > easily be protected by a mutex but I wanted to keep this change small. > > The list of interface and

Re: [patch] improve strptime(3) %z timezone parsing

Ingo Schwarze wrote: > Now let's get to the more serious part. > Hiltjo observed that %Z and %z produce wrong results. > > First of all, neither POSIX nor XPG define tm_gmtoff nor %Z nor %z: > > https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/time.h.html >

Re: [patch] improve strptime(3) %z timezone parsing

Hi Ted, Ted Unangst wrote on Thu, May 09, 2019 at 04:16:40PM -0400: > Ingo Schwarze wrote: >> I'm not mixing anything else into this diff. The other bugs should >> be handled separately. > Works for me. (with additional comment removal) Thanks for checking, committed. Now let's get to the

Re: Proper prototype for upgrade() in boot code

> Date: Fri, 10 May 2019 14:47:54 +0200 > From: Claudio Jeker > > See subject ok kettenis@ > -- > :wq Claudio > > Index: cmd.h > === > RCS file: /cvs/src/sys/stand/boot/cmd.h,v > retrieving revision 1.17 > diff -u -p -r1.17

bgpd refactor UPDATE attribute writer

This change is from a much larger patch I'm working on. This cleans up up_generate_attr() from a hardcoded implementation to a loop-switch construct. This way attributes are always dumped in ascending order as suggested by the RFC and adding special attributes is simpler than in the current way.

switch(4): port protection man page updates

Hi, These are the manpage updates to go with the port protection diffs for switch(4). Thanks, Ayaka Index: sbin/ifconfig/ifconfig.8 === RCS file: /cvs/src/sbin/ifconfig/ifconfig.8,v retrieving revision 1.334 diff -u -p -u

Re: switch(4): port protection man page updates

On Fri, May 10, 2019 at 09:18:06AM -0700, Ayaka Koshibe wrote: > These are the manpage updates to go with the port protection diffs for > switch(4). Wording is identical to that in ifconfig(8), fine with me. Thanks for taking care of bridge(4) as well. OK kn