sort: don't do top level comparison when invoked with -c

2020-03-23 Thread Richard Ipsum
Hi, I found a bug in OpenBSD's sort utility, related to a previous bug I found.[1] The fix I provided for that bug excluded the top level comparison when -k was in use. Recently I discovered that there are other cases where OpenBSD's sort does not produce the correct results. I've appended these

slaacd: Reduce maximum IPv6 PIO lifetimes

2020-03-23 Thread Fernando Gont
Folks/Florian, This reduces the maximum PIO lifetimes on the host-side, as discussed in https://tools.ietf.org/html/draft-gont-6man-slaac-renum-05#section-4.1.2 This helps improve the reaction of IPv6 SLAAC to renumbering events, and also helps limit the time-span of damage in the event of

Untangle proc * in VOP_*

2020-03-23 Thread Martin Pieuchot
Most of the VOP_* methods include an argument of type "struct proc *" called `a_p'. This pointer is always set to `curproc' as confirmed by the diff below. The diff has been though base build with NFS on amd64 and sparc64 as well as a full port bulk on amd64 and is in the current octeon port

Re: Saving stack frames in dt(4)

2020-03-23 Thread Martin Pieuchot
On 19/03/20(Thu) 15:37, Martin Pieuchot wrote: > People are starting to capture kernel stack traces and produce > Flamegraphs. Those traces currently include the frames used by > dt(4) itself: > > dt_pcb_ring_get+0x11d > dt_prov_profile_enter+0x6e > hardclock+0x1a9 >

Re: sort: don't do top level comparison when invoked with -c

2020-03-23 Thread Todd C . Miller
GNU sort on Linux behaves the same as the OpenBSD sort when run in the C locale. $ LANG=C sort -c -d -f input.txt sort: input.txt:2: disorder: - $ LANG=C sort -c -d -i input.txt sort: input.txt:2: disorder: - Since our C library doesn't really support other locales I think this is the

Re: tar confused error messages

2020-03-23 Thread Todd C . Miller
On Sun, 22 Mar 2020 11:41:55 +0100, Marc Espie wrote: > If tar can't create intermediate directories due to permission > issues, the resulting message is confusing: > > ./tar xf gcc.tar gcc-8.3.0/include/obstack.h > tar: Unable to create gcc-8.3.0/include/obstack.h: No such file or directory > >

rtsock: redundant NULL pointer check

2020-03-23 Thread Tobias Heider
It seems that there is no way 'rtm' could actually be NULL here, which means we can get rid of the check. ok? Index: net/rtsock.c === RCS file: /mount/openbsd/cvs/src/sys/net/rtsock.c,v retrieving revision 1.297 diff -u -p -r1.297

umidi: missing NULL checks

2020-03-23 Thread Tobias Heider
In alloc_all_jacks() the variables 'sc_in_jacks' and 'sc_out_checks' are set to NULL if 'sc_in_num_jacks' and 'sc_out_num_jacks' are 0. Further down both are dereferenced unconditionally. I added explicit NULL checks where I think they belong. I think 'sc_in_ep' and 'sc_out_ep' can also be NULL,

snmpd(8): Remove restricted socket

2020-03-23 Thread Martijn van Duren
snmpd's normal socket is pretty much deprecated and the restricted variant is even more useless. In other words lets pick it apart one step at a time. This diff removes the restricted keyword and related code. While here I also removed the unimplemented IMSG_CTL_RELOAD logic. For those wondering

Re: [PLEASE TEST] acpi(4): acpi_sleep(): tsleep(9) -> tsleep_nsec(9)

2020-03-23 Thread Scott Cheloha
On Sun, Mar 15, 2020 at 09:55:53PM -0500, Scott Cheloha wrote: > > [...] > > This is a straightforward ticks-to-milliseconds conversion, but IIRC > pirofti@ wanted me to get some tests before committing it. > > The only users of acpi_sleep() are (a) acpitz(4) and (b) any AML code > that uses

Re: Untangle proc * in VOP_*

2020-03-23 Thread Ted Unangst
On 2020-03-23, Martin Pieuchot wrote: > Most of the VOP_* methods include an argument of type "struct proc *" > called `a_p'. This pointer is always set to `curproc' as confirmed by > the diff below. The diff has been though base build with NFS on amd64 > and sparc64 as well as a full port bulk