[PATCH 1/2] gost: add missing error reporting

2020-03-26 Thread dbaryshkov
From: Dmitry Baryshkov Add few more error reports to help debugging. Sponsored by ROSA Linux. Signed-off-by: Dmitry Baryshkov --- src/lib/libcrypto/gost/gostr341001_ameth.c | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git

[PATCH 2/2] gost: use ECerror to report EC errors

2020-03-26 Thread dbaryshkov
From: Dmitry Baryshkov GOST code uses GOSTerror(EC_R_foo) to report several errors. Use ECerror(EC_R_foo) instead to make error messages match error code. Sponsored by ROSA Linux. Signed-off-by: Dmitry Baryshkov --- src/lib/libcrypto/gost/gostr341001_ameth.c | 2 +-

[PATCH] gostr341001: support unwrapped private keys support

2020-03-26 Thread Dmitry Baryshkov
GOST private keys can be wrapped in OCTET STRING, INTEGER or come unwrapped. Support the latter format. Sponsored by ROSA Linux Signed-off-by: Dmitry Baryshkov --- src/lib/libcrypto/gost/gostr341001_ameth.c | 75 -- 1 file changed, 70 insertions(+), 5 deletions(-) diff

[PATCH] ec: add support for several more GOST curves

2020-03-26 Thread dbaryshkov
From: Dmitry Baryshkov Add support for GOST curves defined by RFC 7836 and draft-deremin-rfc4491-bis. Add aliases for 256-bit GOST curves (see draft-smyshlyaev-tls12-gost-suites). Sponsored by ROSA Linux. Signed-off-by: Dmitry Baryshkov --- src/lib/libcrypto/ec/ec_curve.c | 158

Re: umidi: missing NULL checks

2020-03-26 Thread Alexandre Ratchov
On Mon, Mar 23, 2020 at 10:51:06PM +0100, Tobias Heider wrote: > In alloc_all_jacks() the variables 'sc_in_jacks' and 'sc_out_checks' > are set to NULL if 'sc_in_num_jacks' and 'sc_out_num_jacks' are 0. > Further down both are dereferenced unconditionally. I added explicit NULL > checks where I

PATCH: configurable tiling in cwm(1)

2020-03-26 Thread Uwe Werler
Hello @tech, with this diff https://marc.info/?l=openbsd-tech=149192690925713=2 the behaviour of cwm changed so vtile and htile always use 50% of the screen. This is a reasonable default but sometimes I want to have the master windows be bigger. Inspired by this patch

Re: softraid_raid5: possible NULL dereference

2020-03-26 Thread Mark Kettenis
> Date: Thu, 26 Mar 2020 01:03:26 +0100 > From: Tobias Heider > > sr_block_get() returns dma_alloc(length, PR_NOWAIT | PR_ZERO) which may be > NULL if the memory pool is depleted. > The result is used as 'dst' argument to memcpy() in the following call to > sr_raid5_regenerate(), resulting in a

Re: softraid_raid5: possible NULL dereference

2020-03-26 Thread Stefan Sperling
On Thu, Mar 26, 2020 at 01:03:26AM +0100, Tobias Heider wrote: > sr_block_get() returns dma_alloc(length, PR_NOWAIT | PR_ZERO) which may be > NULL if the memory pool is depleted. > The result is used as 'dst' argument to memcpy() in the following call to > sr_raid5_regenerate(), resulting in a

Re: Add missing #ifdefs to pppx_if_destroy()

2020-03-26 Thread Vitaliy Makkoveev
On Thu, Mar 26, 2020 at 11:56:27AM +0100, Martin Pieuchot wrote: > On 26/03/20(Thu) 13:34, Vitaliy Makkoveev wrote: > > Add missing #ifdefs to pppx_if_destroy() as it done in > > pipex_destroy_session(). Also remove unnecessary cast. > > What's the point of such #ifdef? I understand the current

Add missing #ifdefs to pppx_if_destroy()

2020-03-26 Thread Vitaliy Makkoveev
Add missing #ifdefs to pppx_if_destroy() as it done in pipex_destroy_session(). Also remove unnecessary cast. Index: sys/net/if_pppx.c === RCS file: /cvs/src/sys/net/if_pppx.c,v retrieving revision 1.76 diff -u -p -r1.76 if_pppx.c

Re: Add missing #ifdefs to pppx_if_destroy()

2020-03-26 Thread Martin Pieuchot
On 26/03/20(Thu) 13:34, Vitaliy Makkoveev wrote: > Add missing #ifdefs to pppx_if_destroy() as it done in > pipex_destroy_session(). Also remove unnecessary cast. What's the point of such #ifdef? I understand the current code is not coherent, but does this reduce the binary size? For a case in

MSI-X for ix(4) again

2020-03-26 Thread Martin Pieuchot
Previous diff had a bug in the interrupt handler refactoring that showed up on i386. The version below has been tested on i386 and doesn't seem to cause any regression. Here's the original explanation, diff below has msix toggle to "off": > Diff below allows ix(4) to establish two MSI-X

Re: Add missing #ifdefs to pppx_if_destroy()

2020-03-26 Thread Vitaliy Makkoveev
On Thu, Mar 26, 2020 at 01:46:29PM +0100, Martin Pieuchot wrote: > Does the diff below works for you? Are you ok with the direction? Any > comment? Diff works for me, Except you missed switch in the and of pppx_add_session() and pipex_add_session(). Index: sys/net/if_pppx.c

Re: Add missing #ifdefs to pppx_if_destroy()

2020-03-26 Thread Martin Pieuchot
On 26/03/20(Thu) 14:41, Vitaliy Makkoveev wrote: > On Thu, Mar 26, 2020 at 11:56:27AM +0100, Martin Pieuchot wrote: > > On 26/03/20(Thu) 13:34, Vitaliy Makkoveev wrote: > > > Add missing #ifdefs to pppx_if_destroy() as it done in > > > pipex_destroy_session(). Also remove unnecessary cast. > > >