fix pppac(4) without pipex

2020-04-12 Thread YASUOKA Masahiko
Hi, The diff followings fixes panics when using pppac(4) with "pipex no". Index: sys/net/if_pppx.c === RCS file: /cvs/src/sys/net/if_pppx.c,v retrieving revision 1.83 diff -u -p -r1.83 if_pppx.c --- sys/net/if_pppx.c 10 Apr 2020

Re: Simplify NET_LOCK() variations

2020-04-12 Thread Vitaliy Makkoveev
> On 12 Apr 2020, at 16:26, Martin Pieuchot wrote: > > The existing variations of the NET_LOCK() macros are confusing. We're > now all aware of this fact. So let's keep them simple to prevent future > mistakes :) > > The diff below reduces the current set of methods to the following: > >

Simplify NET_LOCK() variations

2020-04-12 Thread Martin Pieuchot
The existing variations of the NET_LOCK() macros are confusing. We're now all aware of this fact. So let's keep them simple to prevent future mistakes :) The diff below reduces the current set of methods to the following: NET_LOCK()/NET_UNLOCK() NET_ASSERT_LOCKED()

Re: Simplify NET_LOCK() variations

2020-04-12 Thread Visa Hankala
On Sun, Apr 12, 2020 at 03:26:14PM +0200, Martin Pieuchot wrote: > The existing variations of the NET_LOCK() macros are confusing. We're > now all aware of this fact. So let's keep them simple to prevent future > mistakes :) > > The diff below reduces the current set of methods to the

Re: switch powerpc to MI mplock

2020-04-12 Thread Otto Moerbeek
On Fri, Apr 10, 2020 at 09:31:24AM +0200, Martin Pieuchot wrote: > In order to reduce the differences with other architecture and to be able > to use WITNESS on powerpc I'm proposing the diff below that makes use of > the MI mp (ticket) lock implementation for powerpc. > > This has been tested

Re: Simplify NET_LOCK() variations

2020-04-12 Thread Mark Kettenis
> Date: Sun, 12 Apr 2020 14:38:55 + > From: Visa Hankala > > On Sun, Apr 12, 2020 at 03:26:14PM +0200, Martin Pieuchot wrote: > > The existing variations of the NET_LOCK() macros are confusing. We're > > now all aware of this fact. So let's keep them simple to prevent future > > mistakes

Implement acpi_getprop()

2020-04-12 Thread Mark Kettenis
Implement the equivalent of OF_getprop() for device-tree-like properties in ACPI land. Needed for the upcomong Raspberry Pi4 network interface driver. ok? Index: dev/acpi/acpi.c === RCS file: /cvs/src/sys/dev/acpi/acpi.c,v

Raspberry Pi4 Ethernet support

2020-04-12 Thread Mark Kettenis
The diff below adds support for the Ethernet interface on the Raspberry Pi4. The new driver is called bse(4) for Broadcom SoC Ethernet ;). It is a port of the NetBSD driver (where the driver is called genet(4), but over here we prefer short names for our network drivers). There have been many

Re: Simplify NET_LOCK() variations

2020-04-12 Thread Mark Kettenis
> From: "Theo de Raadt" > Date: Sun, 12 Apr 2020 10:28:59 -0600 > > > + if ((p->p_flag & P_SYSTEM) && > > + (strncmp(p->p_p->ps_comm, "softnet", 7) == 0)) > > Wow that is ugly. A better approach might be to store a pointer to the softnet task's struct proc in a global variable

Re: slaacd(8): honour rdomain we are running in

2020-04-12 Thread Denis Fondras
On Sun, Apr 12, 2020 at 07:53:23PM +0200, Florian Obser wrote: > OK? > OK denis@ > diff --git slaacd.c slaacd.c > index 58f15bcda37..dae2eab3434 100644 > --- slaacd.c > +++ slaacd.c > @@ -755,7 +755,7 @@ configure_gateway(struct imsg_configure_dfr *dfr, uint8_t > rtm_type) >

Re: Simplify NET_LOCK() variations

2020-04-12 Thread Theo de Raadt
> + if ((p->p_flag & P_SYSTEM) && > + (strncmp(p->p_p->ps_comm, "softnet", 7) == 0)) Wow that is ugly.

Re: Remove some customization from our perl build

2020-04-12 Thread Theo de Raadt
Andrew Hewus Fresh wrote: > On Fri, Apr 10, 2020 at 07:34:21PM -0600, Todd C. Miller wrote: > > On Fri, 10 Apr 2020 18:17:33 -0700, Andrew Hewus Fresh wrote: > > > > > Recently it was pointed out that we don't link /usr/lib/libperl.so.* to > > > libm the way is expected for code that also links

slaacd(8): honour rdomain we are running in

2020-04-12 Thread Florian Obser
OK? diff --git slaacd.c slaacd.c index 58f15bcda37..dae2eab3434 100644 --- slaacd.c +++ slaacd.c @@ -755,7 +755,7 @@ configure_gateway(struct imsg_configure_dfr *dfr, uint8_t rtm_type) rtm.rtm_version = RTM_VERSION; rtm.rtm_type = rtm_type; rtm.rtm_msglen = sizeof(rtm); -

Re: slaacd(8): honour rdomain we are running in

2020-04-12 Thread Sebastian Benoit
Florian Obser(flor...@openbsd.org) on 2020.04.12 19:53:23 +0200: > OK? yes, this is probably better than having it configurable via option. > diff --git slaacd.c slaacd.c > index 58f15bcda37..dae2eab3434 100644 > --- slaacd.c > +++ slaacd.c > @@ -755,7 +755,7 @@ configure_gateway(struct

Re: Remove some customization from our perl build

2020-04-12 Thread Andrew Hewus Fresh
On Fri, Apr 10, 2020 at 07:34:21PM -0600, Todd C. Miller wrote: > On Fri, 10 Apr 2020 18:17:33 -0700, Andrew Hewus Fresh wrote: > > > Recently it was pointed out that we don't link /usr/lib/libperl.so.* to > > libm the way is expected for code that also links to libperl. That led > > me to go

Re: Simplify NET_LOCK() variations

2020-04-12 Thread Alexandr Nedvedicky
Hallo, On Sun, Apr 12, 2020 at 07:02:43PM +0200, Mark Kettenis wrote: > > From: "Theo de Raadt" > > Date: Sun, 12 Apr 2020 10:28:59 -0600 > > > > > + if ((p->p_flag & P_SYSTEM) && > > > + (strncmp(p->p_p->ps_comm, "softnet", 7) == 0)) > > > > Wow that is ugly. > > A better