Re: ldpd engine process exits with pledge "cpath"

2020-06-20 Thread wlund
Hi! Ricardo Mestre wrote: > this is getting in my nerves, I made a wrong assumption here and I > prefer to commit this than backout my previous commit so I'm asking for > commits for the below. attached. I hope I understood your intention. > > On 14:43 Fri 19 Jun , Ricardo Mestre wrote: >

Re: ldpd engine process exits with pledge "cpath"

2020-06-20 Thread Remi Locherer
On Fri, Jun 19, 2020 at 02:43:00PM +0100, Ricardo Mestre wrote: > mea culpa, but I'd rather just remove the unlink of the socket. > > OK? Diff reads OK to me. We had the same discussion in 2018 for ripd: https://marc.info/?l=openbsd-tech=154101413029926=2 Note to self: ospfd should get the

Re: userland clock_gettime proof of concept

2020-06-20 Thread Mark Kettenis
> From: Christian Weisgerber > Date: Sat, 20 Jun 2020 01:20:33 - (UTC) > > On 2020-06-19, Mark Kettenis wrote: > > > I'm talking about *skew*, not drift. If there is a significant drift > > you already knock out the TSC. > > > > What's needed is: > > > > 1. A bit of research of what an

Re: Retire

2020-06-20 Thread Christian Weisgerber
On 2020-06-19, "Theo de Raadt" wrote: > Well... they something in ports might still look at them in > > Can someone from ports speak about this? I have started an amd64 bulk build without . -- Christian "naddy" Weisgerber na...@mips.inka.de

Re: pppx(4): remove panics

2020-06-20 Thread Vitaliy Makkoveev
yasuoka@ privately pointed I was wrong about KASSERT(). I fixed my diff. These checks are useless and I guess they make understanding harder so I removed panic() from pppx_if_destoy() too. Index: sys/net/if_pppx.c === RCS file:

lfence for rdtsc

2020-06-20 Thread Mark Kettenis
RDTSC is not a serializing instruction; to make sure we get the TSC value corresponding to the position of RDTSC in te instruction stream we need a barrier. Linux uses LFENCE on machines where it is available. FreeBSD seems to prefer MFENCE for AMD CPUs but uses LFENCE for Intel CPUs. For now

Re: bcmtmon - Broadcom BCM2711 temperature monitor (RPI4)

2020-06-20 Thread Mark Kettenis
> From: Al Poole > Date: Sat, 13 Jun 2020 20:33:11 +0100 > > Hi, > > This introduces temperature driver for the Raspberry PI 4 named bcmtmon. > > bcmtmon because of bcmtemp(4) and (!strncmp("bcmt", snsrdev.xname, 4)) > > @kettenis has been advising me and answering questions. Thanks, I made

Re: userland clock_gettime proof of concept

2020-06-20 Thread Christian Weisgerber
On 2020-06-19, Paul Irofti wrote: > I have addressed your comments bellow, except for the CPU skew one. That > code disables TSC for all CPUs, not just for PRIMARY. Would you like to > walk and add code for every CPU to check the drift and then disable the > TSC? It seems a little too much... >

Re: userland clock_gettime proof of concept

2020-06-20 Thread Christian Weisgerber
On 2020-06-20, Christian Weisgerber wrote: > I can't get this revision of the diff to work on amd64: > * patch source > * build and install kernel, reboot > * make build > * reboot -> "Process (pid 1) got signal 11" > > I'm at a loss. As part of the "make build", the new libc is installed > and

ftp(1) double free

2020-06-20 Thread Jeremie Courreges-Anglas
Small bug, but still... naddy@ reported a double free when interrupting (^C) ftp(1) at the end or url_get(). If that happens, the SIGINT handler longjmps and the cleanup path is taken a second time. To avoid this, restore the previous SIGINT handler in each possible error path. I chose to

Re: userland clock_gettime proof of concept

2020-06-20 Thread Mark Kettenis
> From: Christian Weisgerber > Date: Sat, 20 Jun 2020 19:57:06 - (UTC) > > On 2020-06-19, Paul Irofti wrote: > > > I have addressed your comments bellow, except for the CPU skew one. That > > code disables TSC for all CPUs, not just for PRIMARY. Would you like to > > walk and add code for