Re: OpenBSD.calendar patch

2020-06-29 Thread Jason McIntyre
On Sat, Jun 27, 2020 at 11:56:49AM -0700, jungle boogie wrote: > Hi Friends, > > Here's a small patch to the OpenBSD.calendar. I didn't want to spend too > much time on this until I find out if it would be accepted. > morning. i think if such a file is worth having, it's worth updating.

Re: 11n Tx aggregation for iwm(4)

2020-06-29 Thread Uwe Werler
Woahhh, was also trying 5GHz (and tcpbench against one of our bsd servers in DMZ): 469651560 bytes sent over 85.291 seconds bandwidth min/avg/max/std-dev = 3.475/43.927/87.071/29.809 Mbps 6 new output block ack agreements 0 output block ack agreements timed out (Tomorrow @work

Re: route add ::/0 ...

2020-06-29 Thread Martin Pieuchot
On 28/06/20(Sun) 20:41, YASUOKA Masahiko wrote: > Hi, > > When "::/0" is used as "default", > > # route add ::/0 fe80::1%em0 > add net ::/0: gateway fe80::1%em0: Invalid argument > > route command trims the sockaddr to { .len = 2, .family = AF_INET6 } > for "::/0", but rtable_satoplen()

Re: route add ::/0 ...

2020-06-29 Thread YASUOKA Masahiko
Hi, On Mon, 29 Jun 2020 10:12:23 +0200 Martin Pieuchot wrote: > On 28/06/20(Sun) 20:41, YASUOKA Masahiko wrote: >> Hi, >> >> When "::/0" is used as "default", >> >> # route add ::/0 fe80::1%em0 >> add net ::/0: gateway fe80::1%em0: Invalid argument >> >> route command trims the sockaddr

Re: 11n Tx aggregation for iwm(4)

2020-06-29 Thread Uwe Werler
Hi Stefan, for me the patch works in mode 11n: before (OpenBSD 6.7-current (GENERIC.MP) #304: Fri Jun 26 02:08:50 MDT 2020) bandwidth min/avg/max/std-dev = 2.354/12.319/15.391/3.850 Mbps with patch (OpenBSD 6.7-current (GENERIC.MP) #0: Mon Jun 29 09:35:24 GMT 2020) bandwidth min/avg/max/std-dev

Re: fsck_ffs: faster with lots of cylinder groups

2020-06-29 Thread Otto Moerbeek
On Sun, Jun 21, 2020 at 03:35:21PM +0200, Otto Moerbeek wrote: > Hi, > > both phase 1 and phase 5 need cylinder group metadata. This diff > keeps the cg data read in phase 1 in memory to be used by phase 5 if > possible. From FreeBSD. > > -Otto > > On an empty 30T fileystem: > > $

Re: 11n Tx aggregation for iwm(4)

2020-06-29 Thread Sebastian Benoit
Sebastian Benoit(be...@openbsd.org) on 2020.06.29 16:18:03 +0200: > Stefan Sperling(s...@stsp.name) on 2020.06.26 14:45:53 +0200: > > This patch adds support for 11n Tx aggregation to iwm(4). > > > > Please help with testing if you can by running the patch and using wifi > > as usual. Nothing

Re: fix races in if_clone_create()

2020-06-29 Thread Hrvoje Popovski
On 29.6.2020. 10:59, Vitaliy Makkoveev wrote: > I reworked tool for reproduce. Now I avoided fork()/exec() route and it > takes couple of minutes to take panic on 4 cores. Also some screenshots > attached. > > I hope anyone else will try it. Hi, i'm getting panic quite fast :) i will leave box

Re: Stuck in Needbuf state, trying to understand (6.7)

2020-06-29 Thread Bob Beck
On Sun, Jun 28, 2020 at 12:18:06PM -0400, sven falempin wrote: > On Sun, Jun 28, 2020 at 2:40 AM Bryan Linton wrote: > > > On 2020-06-27 19:29:31, Bob Beck wrote: > > > > > > No. > > > > > > I know *exactly* what needbuf is but to attempt to diagnose what your > > > problem is we need exact

Re: Stuck in Needbuf state, trying to understand (6.7)

2020-06-29 Thread sven falempin
On Mon, Jun 29, 2020 at 11:44 AM Bob Beck wrote: > On Sun, Jun 28, 2020 at 12:18:06PM -0400, sven falempin wrote: > > On Sun, Jun 28, 2020 at 2:40 AM Bryan Linton wrote: > > > > > On 2020-06-27 19:29:31, Bob Beck wrote: > > > > > > > > No. > > > > > > > > I know *exactly* what needbuf is but

Re: 11n Tx aggregation for iwm(4)

2020-06-29 Thread Sebastian Benoit
Stefan Sperling(s...@stsp.name) on 2020.06.26 14:45:53 +0200: > This patch adds support for 11n Tx aggregation to iwm(4). > > Please help with testing if you can by running the patch and using wifi > as usual. Nothing should change, except that Tx speed may potentially > improve. If you have time

Re: route add ::/0 ...

2020-06-29 Thread YASUOKA Masahiko
On Mon, 29 Jun 2020 18:45:07 +0900 (JST) YASUOKA Masahiko wrote: > On Mon, 29 Jun 2020 10:12:23 +0200 > Martin Pieuchot wrote: >> On 28/06/20(Sun) 20:41, YASUOKA Masahiko wrote: >>> Hi, >>> >>> When "::/0" is used as "default", >>> >>> # route add ::/0 fe80::1%em0 >>> add net ::/0: gateway

Re: Stuck in Needbuf state, trying to understand (6.7)

2020-06-29 Thread Bob Beck
> Awesome, thanks! > > I will test that, ASAP, > do not hesitate to slay dragon, > i heard the bathing in the blood pool is good for the skin > > Little concern, I did the test without the MFS and ran into issues , > anyway i get back to you (or list ?) when i have test report with patched >

Re: fix races in if_clone_create()

2020-06-29 Thread Vitaliy Makkoveev
On Sat, Jun 27, 2020 at 12:10:24PM +0200, Martin Pieuchot wrote: > On 27/06/20(Sat) 00:35, Vitaliy Makkoveev wrote: > > On Fri, Jun 26, 2020 at 09:12:16PM +0200, Martin Pieuchot wrote: > > > On 26/06/20(Fri) 16:56, Vitaliy Makkoveev wrote: > > > > if_clone_create() has the races caused by context

Re: fix races in if_clone_create()

2020-06-29 Thread Vitaliy Makkoveev
On Sat, Jun 27, 2020 at 12:10:24PM +0200, Martin Pieuchot wrote: > On 27/06/20(Sat) 00:35, Vitaliy Makkoveev wrote: > > On Fri, Jun 26, 2020 at 09:12:16PM +0200, Martin Pieuchot wrote: > > > On 26/06/20(Fri) 16:56, Vitaliy Makkoveev wrote: > > > > if_clone_create() has the races caused by context

Re: route add ::/0 ...

2020-06-29 Thread Klemens Nanni
On Mon, Jun 29, 2020 at 11:55:10PM +0900, YASUOKA Masahiko wrote: > The function mask_addr() doesn't mask address for IPv4 and IPv6. Does > any address family other than IPv4 or IPv6 require #1142:1148? The > function seems to just trim the trailing zero. Is it neccesaary? And > it causes the

Re: fix races in if_clone_create()

2020-06-29 Thread Vitaliy Makkoveev
screenshot

Use klist_invalidate() in knote_processexit()

2020-06-29 Thread Visa Hankala
knote_processexit() uses knote_remove() to clear any remaining knotes from >ps_klist when process `pr' exits. All EVFILT_PROC knotes are removed by the KNOTE(>ps_klist, NOTE_EXIT) call. However, ps_klist can contain EVFILT_SIGNAL knotes after the KNOTE(). To reserve knote_remove() for the kqueue

Re: Stuck in Needbuf state, trying to understand (6.7)

2020-06-29 Thread sven falempin
On Mon, Jun 29, 2020 at 12:12 PM Bob Beck wrote: > > > Awesome, thanks! > > > > I will test that, ASAP, > > do not hesitate to slay dragon, > > i heard the bathing in the blood pool is good for the skin > > > > Little concern, I did the test without the MFS and ran into issues , > > anyway i get

harmonize locking annotations

2020-06-29 Thread Anton Lindqvist
Hi, I think we all agree that global locks should be represented using uppercase letters in locking annotations. This is an attempt to harmonize the existing annotations. Comments? OK? Index: dev/dt/dt_dev.c === RCS file:

Re: fix races in if_clone_create()

2020-06-29 Thread Vitaliy Makkoveev
On Mon, Jun 29, 2020 at 04:27:50PM +0200, Hrvoje Popovski wrote: > On 29.6.2020. 10:59, Vitaliy Makkoveev wrote: > > I reworked tool for reproduce. Now I avoided fork()/exec() route and it > > takes couple of minutes to take panic on 4 cores. Also some screenshots > > attached. > > > > I hope

Re: Stuck in Needbuf state, trying to understand (6.7)

2020-06-29 Thread sven falempin
On Mon, Jun 29, 2020 at 12:58 PM sven falempin wrote: > > > On Mon, Jun 29, 2020 at 12:12 PM Bob Beck wrote: > >> >> > Awesome, thanks! >> > >> > I will test that, ASAP, >> > do not hesitate to slay dragon, >> > i heard the bathing in the blood pool is good for the skin >> > >> > Little

Re: route add ::/0 ...

2020-06-29 Thread Klemens Nanni
On Tue, Jun 30, 2020 at 09:00:30AM +0900, YASUOKA Masahiko wrote: > inet_makenetandmask() had required another treatment. > > Also -prefixlen 0 for -inet has a bug > > % doas ./obj/route -T100 add -inet 0.0.0.0 -prefixlen 0 127.0.0.1 > add net 0.0.0.0: gateway 127.0.0.1 > % netstat -nrf inet

Re: route add ::/0 ...

2020-06-29 Thread YASUOKA Masahiko
On Mon, 29 Jun 2020 19:18:17 +0200 Klemens Nanni wrote: > On Mon, Jun 29, 2020 at 11:55:10PM +0900, YASUOKA Masahiko wrote: >> The function mask_addr() doesn't mask address for IPv4 and IPv6. Does >> any address family other than IPv4 or IPv6 require #1142:1148? The >> function seems to just

if_delgroup(): Add size to free(9) call

2020-06-29 Thread Klemens Nanni
Interface groups are allocated as follows: struct ifg_group * if_creategroup(const char *groupname) { struct ifg_group*ifg; if ((ifg = malloc(sizeof(*ifg), M_TEMP, M_NOWAIT)) == NULL) return (NULL);

Re: wg(4): encapsulated transport checksums

2020-06-29 Thread richard . n . procter
Hi Jason, On 27/06/2020, at 10:09 PM, Jason A. Donenfeld wrote: > [...] I thought I'd lay out my understanding of the matter, > and you can let me know whether or not this corresponds with what you > had in mind: > [...] My main concern is the end-to-end TCP or UDP transport checksum of the