Re: httpd: another log related leak

2020-12-31 Thread Claudio Jeker
On Thu, Dec 31, 2020 at 11:21:44AM +0100, Theo Buehler wrote: > msg is allocated by vasprintf, and is leaked on return of server_sendlog. > vasprintf calculates the length of the string, so we can zap a needless > call to strlen while there. > > Index: server.c >

httpd: another log related leak

2020-12-31 Thread Theo Buehler
msg is allocated by vasprintf, and is leaked on return of server_sendlog. vasprintf calculates the length of the string, so we can zap a needless call to strlen while there. Index: server.c === RCS file:

Re: Thread local data setup and destruct

2020-12-31 Thread Alexander Bluhm
On Tue, Dec 29, 2020 at 04:07:19PM +0100, Otto Moerbeek wrote: > This workds better, checking the flags does not work if the thread is > already on the road to desctruction. This diff survived a full regress run on amd64. bluhm > Index: asr/asr.c >

Re: libc/regex: more regular error handling

2020-12-31 Thread Todd C . Miller
On Thu, 31 Dec 2020 07:29:51 +, Miod Vallat wrote: > The REQUIRE macro is used to check for a condition, and set an error in > the parse struct if it is not satisfied. > > This changes it from ((condition) || function call) to a, IMHO more > readable, if() test. OK millert@ - todd

Re: libc/regex: drop more unused data

2020-12-31 Thread Todd C . Miller
On Thu, 31 Dec 2020 07:25:19 +, Miod Vallat wrote: > re_guts catspace[] is only written to (via categories[]), and never used > for anything, so don't bother keeping that. OK millert@ - todd

Re: libc/regex: const'r'us

2020-12-31 Thread Todd C . Miller
On Thu, 31 Dec 2020 07:27:49 +, Miod Vallat wrote: > Spencer's code was written before const was a thing, but we can do > better. Neither regcomp(3) nor regex(3) modify the strings they are > being passed, so we can keep internal pointers as const as well and > avoid {dub,spur}ious casts. > >

Re: login_passwd.c (etc.) and auth_mkvalue(3) returning NULL

2020-12-31 Thread Todd C . Miller
On Thu, 31 Dec 2020 15:27:02 +1100, Ross L Richardson wrote: > It could, of course, just use a fixed string rather than the "%s" format, > although the latter is certainly clear(er) and consistent. I originally had a fixed string but decided that using the "%s" format was clearer. > With

Re: ftp(1): handle HTTP 308

2020-12-31 Thread Lucas
Weekly bump Index: fetch.c === RCS file: /home/cvs/src/usr.bin/ftp/fetch.c,v retrieving revision 1.198 diff -u -p -r1.198 fetch.c --- fetch.c 18 Oct 2020 20:35:18 - 1.198 +++ fetch.c 24 Dec 2020 14:03:03 - @@

drm(4) memory allocation diff

2020-12-31 Thread Mark Kettenis
The diff below changes the emulated Linux memory allocation functions a bit such that they only use malloc(9) for allocations smaller than a page. This reduces pressure on the "interrupt safe" map and hopefully will avoid the uvm_mapent_alloc: out of static map entries messages that some

Re: uvm_fault: amap & anon locking

2020-12-31 Thread Mark Kettenis
> Date: Wed, 30 Dec 2020 11:19:41 -0300 > From: Martin Pieuchot > > Diff below adds some locking to UVM's amap & anon data structures that > should be enough to get the upper part of the fault handler out of the > KERNEL_LOCK(). > > This diff doesn't unlock the fault handler, I'd suggest to do

Re: libc/regex: const'r'us

2020-12-31 Thread Todd C . Miller
All three committed, thanks. - todd