Re: interface group name validation

2021-02-10 Thread Vitaliy Makkoveev
On Tue, Feb 09, 2021 at 11:08:09PM +0100, Alexander Bluhm wrote: > Hi, > > Next try to fix syzkaller crash > https://syzkaller.appspot.com/bug?id=54e16dc5bce6929e14b42e2f1379f1c18f62be43 > > Interface group names must fit into IFNAMSIZ and be unique. But > the kernel makes the unique check

Re: RTR support for bgpd

2021-02-10 Thread Claudio Jeker
On Tue, Jan 26, 2021 at 10:31:40AM +0100, Claudio Jeker wrote: > This diff adds initial RTR (RPKI to Router) support to bgpd. > Instead of loading the roa-set table via the configuration bgpd will use > RTR to load the RPKI table from one or multiple RTR servers. > This has the benefit that in

isakmpd link dynamically

2021-02-10 Thread Alexander Bluhm
Hi, Every time we ship a libcrypto erratum, we have to relink isakmpd. I think that isakmpd and iked are in /sbin due to a historic mistake. Probably it is for people who mount /usr via NFS over IPsec. Moving isakmpd to /usr/sbin is hard, linking dynamically is easy. Lines stolen from iked. Is

Re: pppac(4): remove `sc_dead' logic

2021-02-10 Thread YASUOKA Masahiko
ok yasuoka Thanks, On Tue, 9 Feb 2021 12:06:08 +0300 Vitaliy Makkoveev wrote: > `sc_dead' is used to prevent pppac_ioctl() be called on dying pppac(4) > interface. But now if_detach() makes dying `ifp' inaccessible and waits > for references which are in-use. This logic is not required anymore.

smptd(8) expand.c: Remove unnecessary assignment

2021-02-10 Thread Martin Vahlensieck
Hi esc is always zero at that point, so no need to store zero in it. Diff with extra context. Best, Martin --- a/usr.sbin/smtpd/expand.c +++ b/usr.sbin/smtpd/expand.c @@ -198,37 +198,36 @@ expand_line_split(char **line, char **ret) i = 0; for (s = *line; (*s) && (i <

Re: video(4) multiple opens

2021-02-10 Thread Martin Pieuchot
On 09/02/21(Tue) 20:35, Marcus Glocker wrote: > jca@ has recently committed a change to video(4) to allow the same > process to do multiple opens on the same video device to satisfy > certain applications, and start to go in to the V4L2 "1.1.4 Multiple > Opens" specification direction as described

Move single_thread_set() out of KERNEL_LOCK()

2021-02-10 Thread Martin Pieuchot
Diff below extends the scope of the SCHED_LOCK() to no longer require the KERNEL_LOCK() when iterating over `ps_thread'. This is enough to make progress without having to introduce new mechanism. ok? Index: kern/kern_exit.c === RCS

route sockets: simplify route_attach() error path

2021-02-10 Thread Vitaliy Makkoveev
Do soreserve() before `rop' allocation. It doesn't require protocol control block be attached to socket. Also we always call `pr_attach' in thread context so we always have `curproc'. ok? Index: sys/net/rtsock.c === RCS file:

Re: isakmpd link dynamically

2021-02-10 Thread Vitaliy Makkoveev
On Wed, Feb 10, 2021 at 06:33:49PM +0100, Alexander Bluhm wrote: > Hi, > > Every time we ship a libcrypto erratum, we have to relink isakmpd. > I think that isakmpd and iked are in /sbin due to a historic mistake. > Probably it is for people who mount /usr via NFS over IPsec. > > Moving isakmpd

Re: isakmpd link dynamically

2021-02-10 Thread Theo de Raadt
Alexander Bluhm wrote: > Hi, > > Every time we ship a libcrypto erratum, we have to relink isakmpd. > I think that isakmpd and iked are in /sbin due to a historic mistake. > Probably it is for people who mount /usr via NFS over IPsec. That was the reason originally. Today I am not sure it

Re: isakmpd link dynamically

2021-02-10 Thread Theo de Raadt
Oh wait I misread. When I re-ordered rc in Slovenia many years ago, I got it right. So, I think we should move these two daemons. Addendum: shared library linking increases the .so footprint, and cross-.so ROP attacks are a tiny bit more difficult in OpenBSD.

Re: [PATCH] [www] faq/current.html - fix formatting

2021-02-10 Thread Raf Czlonka
Ping. On Tue, Feb 02, 2021 at 01:45:25AM GMT, Raf Czlonka wrote: > Hello, > > Fix formatting of the snmpd.conf configuration snippet. > > While there: > > - reduce whitespace from three to two lines as per the comment: > >