Re: Secure by default

2021-02-19 Thread Stuart Henderson
On 2021/02/19 20:27, sivasubramanian muthusamy wrote: > Dear Flint, > > During installation I didn't connect the network, but after installation, > Yes. What would I do with a Computer that isn't connected? My use case is > all about Internet :) Other use cases are available.

Re: Secure by default

2021-02-19 Thread sivasubramanian muthusamy
Dear Flint, During installation I didn't connect the network, but after installation, Yes. What would I do with a Computer that isn't connected? My use case is all about Internet :) On Sun, Feb 14, 2021, 02:49 flint pyrite wrote: > I am not sure about your use case but to myself, my computer

ping graphical display

2021-02-19 Thread Stuart Henderson
This diff adds something similar to cisco's ping display, giving a visual display of good/dropped pings. Any interest in it? Example output (with a couple of ^T during the run): $ ping -g 192.168.41.21 PING 192.168.41.21 (192.168.41.21): 56 data bytes

Re: ping graphical display

2021-02-19 Thread Stuart Henderson
On 2021/02/19 15:19, Stuart Henderson wrote: > This diff adds something similar to cisco's ping display, giving a > visual display of good/dropped pings. Any interest in it? Example > output (with a couple of ^T during the run): (as is traditional I forgot to update usage(), I've fixed that

Re: relayd check script memory explosion

2021-02-19 Thread Theo Buehler
On Mon, Feb 15, 2021 at 12:03:42PM +1000, Jonathan Matthew wrote: > It's fairly easy to accidentally configure relayd to try to run check scripts > faster than they finish, for example if you have a check interval of one > second and the check script makes a tcp connection to a host that doesn't >

Re: rpki-client: recallocarray conversions

2021-02-19 Thread Claudio Jeker
On Fri, Feb 19, 2021 at 10:27:06AM +0100, Theo Buehler wrote: > As discussed a few days ago, there are a few reallocarray + memset that > can be directly handled by recallocarray. Fine with me. > Index: main.c > === > RCS file:

rpki-client: recallocarray conversions

2021-02-19 Thread Theo Buehler
As discussed a few days ago, there are a few reallocarray + memset that can be directly handled by recallocarray. Index: main.c === RCS file: /cvs/src/usr.sbin/rpki-client/main.c,v retrieving revision 1.101 diff -u -p -r1.101 main.c

Re: rpki-client extra paranoia

2021-02-19 Thread Theo Buehler
On Fri, Feb 19, 2021 at 10:54:29AM +0100, Claudio Jeker wrote: > Better to make sure that all URI we ingest are sensitive. Similar check > is already done in cert.c so also do it for the TAL files (even though > these are normally controled by the user). > > OK? ok > -- > :wq Claudio > >

rpki-client extra paranoia

2021-02-19 Thread Claudio Jeker
Better to make sure that all URI we ingest are sensitive. Similar check is already done in cert.c so also do it for the TAL files (even though these are normally controled by the user). OK? -- :wq Claudio Index: tal.c === RCS file:

Re: occasional SSIGSEGV on C++ exception handling

2021-02-19 Thread Mark Kettenis
> Date: Fri, 19 Feb 2021 10:57:30 +0100 > From: Otto Moerbeek > > Hi, > > working on PowerDNS Recursor, once in a while I'm seeing: > > #0 0x09fd67ef09dc in > libunwind::UnwindInfoSectionsCache::CacheTree_RB_INSERT_COLOR > (this=, > head=0x9fd67efc8e8 , elm=0x9fca04be900) > at >

Re: occasional SSIGSEGV on C++ exception handling

2021-02-19 Thread Otto Moerbeek
On Fri, Feb 19, 2021 at 12:45:58PM +0100, Mark Kettenis wrote: > > Date: Fri, 19 Feb 2021 10:57:30 +0100 > > From: Otto Moerbeek > > > > Hi, > > > > working on PowerDNS Recursor, once in a while I'm seeing: > > > > #0 0x09fd67ef09dc in > >

occasional SSIGSEGV on C++ exception handling

2021-02-19 Thread Otto Moerbeek
Hi, working on PowerDNS Recursor, once in a while I'm seeing: #0 0x09fd67ef09dc in libunwind::UnwindInfoSectionsCache::CacheTree_RB_INSERT_COLOR (this=, head=0x9fd67efc8e8 , elm=0x9fca04be900) at /usr/src/gnu/lib/libcxxabi/../../../gnu/llvm/libunwind/src/AddressSpace.hpp:243 243

Re: occasional SSIGSEGV on C++ exception handling

2021-02-19 Thread Mark Kettenis
> Date: Fri, 19 Feb 2021 16:43:10 +0100 > From: Otto Moerbeek > > On Fri, Feb 19, 2021 at 01:06:43PM +0100, Otto Moerbeek wrote: > > > On Fri, Feb 19, 2021 at 12:45:58PM +0100, Mark Kettenis wrote: > > > > > > Date: Fri, 19 Feb 2021 10:57:30 +0100 > > > > From: Otto Moerbeek > > > > > > > >

Re: ping graphical display

2021-02-19 Thread Landry Breuil
On Fri, Feb 19, 2021 at 03:19:49PM +, Stuart Henderson wrote: > This diff adds something similar to cisco's ping display, giving a > visual display of good/dropped pings. Any interest in it? Example > output (with a couple of ^T during the run): fwiw, noping from net/liboping in ports has

Re: ping graphical display

2021-02-19 Thread Stuart Henderson
On 2021/02/19 15:19, Stuart Henderson wrote: > This diff adds something similar to cisco's ping display, giving a > visual display of good/dropped pings. Any interest in it? Example > output (with a couple of ^T during the run): > > $ ping -g 192.168.41.21 > PING 192.168.41.21 (192.168.41.21):

Re: ping graphical display

2021-02-19 Thread Leo Unglaub
Hey, i really like this representation of the results. Very usefull to keep an eye on a lot of hosts during network related debugging. Works fine for me. This just as feedback for you. Greetings Leo Am 19.02.2021 um 16:19 schrieb Stuart Henderson: This diff adds something similar to cisco's

Re: occasional SSIGSEGV on C++ exception handling

2021-02-19 Thread Otto Moerbeek
On Fri, Feb 19, 2021 at 01:06:43PM +0100, Otto Moerbeek wrote: > On Fri, Feb 19, 2021 at 12:45:58PM +0100, Mark Kettenis wrote: > > > > Date: Fri, 19 Feb 2021 10:57:30 +0100 > > > From: Otto Moerbeek > > > > > > Hi, > > > > > > working on PowerDNS Recursor, once in a while I'm seeing: > > >

Re: ping graphical display

2021-02-19 Thread Daniel Gracia
As a WISP manager always experiencing spaced-but-repeated packet-loss mayhem, I'm loving it. El vie, 19 feb 2021 a las 16:22, Stuart Henderson () escribió: > > This diff adds something similar to cisco's ping display, giving a > visual display of good/dropped pings. Any interest in it? Example >

Re: if calloc() needs nmemb and size, why doesn't freezero()?

2021-02-19 Thread Luke Small
malloc(3) already speaks to programmers who might use int multiplication and telling them to test for int multiplication overflow in malloc(), so you presume that they are already prepared to use something smaller than size_t, when you could have just said: “only use size_t variables for integer

Re: if calloc() needs nmemb and size, why doesn't freezero()?

2021-02-19 Thread Theo de Raadt
Luke Small wrote: > malloc(3) already speaks to programmers who might use int multiplication and > telling > them to test for int multiplication overflow in malloc(), so you presume that > they are > already prepared to use something smaller than size_t, when you could have > just said: >

Re: if calloc() needs nmemb and size, why doesn't freezero()?

2021-02-19 Thread Luke Small
> > > In the manpage you could succinctly state: > > > > In malloc(3): > > “If you use smaller integer types than size_t for ‘nmemb’ and ‘size’, > then > multiplication in freezero() may need to be cast to size_t to avoid > integer overflow: > > freezero(ptr, (size_t)nmemb * (size_t)size);” > >

Re: if calloc() needs nmemb and size, why doesn't freezero()?

2021-02-19 Thread Todd C . Miller
On Fri, 19 Feb 2021 10:38:13 -0600, Luke Small wrote: > In malloc(3): > “If you use smaller integer types than size_t for ‘nmemb’ and ‘size’, then > multiplication in freezero() may need to be cast to size_t to avoid integer > overflow: > freezero(ptr, (size_t)nmemb * (size_t)size);” > Or maybe

Re: if calloc() needs nmemb and size, why doesn't freezero()?

2021-02-19 Thread Luke Small
I agree it can overflow. But if you use the same variables with the same values plugged into ptr = calloc(nmemb, size); as you use in freezero(ptr, (size_t)nmemb * size); If it can overflow, it will have done it already in calloc(). On Fri, Feb 19, 2021 at 12:23 PM Todd C. Miller wrote: >

Re: doas needs doas.conf

2021-02-19 Thread Theo de Raadt
Jan Stary wrote: > Say explicitly that doas needs doas.conf to exist, > and point to the example one. > > Jan > > > Index: doas.1 > === > RCS file: /cvs/src/usr.bin/doas/doas.1,v > retrieving revision 1.25 > diff -u -p

Teach rpki-client some https

2021-02-19 Thread Claudio Jeker
Some TAL files now include an https URI where the TA can be fetched from. With this diff rpki-client will download the TA from https unless that fails and then fall back to rsync. This is not yet perfect but the diff is already large enough (adding a full event based https client based on ftp

doas needs doas.conf

2021-02-19 Thread Jan Stary
Say explicitly that doas needs doas.conf to exist, and point to the example one. Jan Index: doas.1 === RCS file: /cvs/src/usr.bin/doas/doas.1,v retrieving revision 1.25 diff -u -p -r1.25 doas.1 --- doas.1 16 Jan 2021

Re: if calloc() needs nmemb and size, why doesn't freezero()?

2021-02-19 Thread Luke Small
I used the verbiage: “malloc(3)” as a general all-encompassing manpage which includes malloc(), calloc(), freezero(), etc. Sorry for the confusion. > In malloc(3): >> > “If you use smaller integer types than size_t for ‘nmemb’ and ‘size’, >> then >> > multiplication in freezero() may need to be

Re: ping graphical display

2021-02-19 Thread Stuart Henderson
Canvassing opinions on having . and ! this way around. I'm using . for response, ! for no response, which makes more sense to me but it's been pointed out that it's the opposite of what cisco does so it might confuse some people.

Re: switch(4): fix netlock assertion within ifpromisc()

2021-02-19 Thread Hrvoje Popovski
On 19.2.2021. 21:50, Vitaliy Makkoveev wrote: > As it was reported [1] switch(4) triggers NET_ASSERT_LOCKED() while > we perform ifconfig(8) destroy. ifpromisc() requires netlock to be held. > This is true while switch_port_detach() and underlay ifpromisc() called > through switch_ioctl(). But

switch(4): fix netlock assertion within ifpromisc()

2021-02-19 Thread Vitaliy Makkoveev
As it was reported [1] switch(4) triggers NET_ASSERT_LOCKED() while we perform ifconfig(8) destroy. ifpromisc() requires netlock to be held. This is true while switch_port_detach() and underlay ifpromisc() called through switch_ioctl(). But while we destroy switch(4) interface we call ifpromisc()