Re: arm64: make cwfg(4) report battery information to apm(4)

2021-03-23 Thread Klemens Nanni
On Wed, Mar 24, 2021 at 12:49:51AM +0100, Jeremie Courreges-Anglas wrote: > >> > @@ -202,6 +217,12 @@ cwfg_attach(struct device *parent, struc > >> > > >> > sensor_task_register(sc, cwfg_update_sensors, 5); > >> > > >> > +#if NAPM > 0 > >> > +/* make sure we have the apm

mg: interactive evaluation

2021-03-23 Thread Mark Lumsden
This diff gives mg the ability to have an interactive session with interpreter.c via the 'eval-current-buffer' command. With this diff the interactive mode is switched off by default of course. So if you are in the habit of evaluting startup files you won't see any difference. With this diff

pcn(4): use ifq_dequeue instead of ifq_deq_begin/commit/rollback

2021-03-23 Thread David Gwynne
this follows the more standard order for fitting a packet onto a tx ring. it also uses the more modern m_defrag pattern for heavily fragmented packets. Works For Me(tm). ok? Index: if_pcn.c === RCS file:

Re: athn(4): switch Tx rate control to RA

2021-03-23 Thread Kevin Lo
On Tue, Mar 23, 2021 at 06:01:27PM +0100, Stefan Sperling wrote: > > This switches athn(4) to the new RA Tx rate adaptation module. > Tests on athn(4) PCI devices are welcome. > USB devices don't need to be tested in this case Tx rate adaptation > is taken care of by firmware. > > I could only

Re: wsconsctl.conf: mention mouse.tp.tapping in example

2021-03-23 Thread Klemens Nanni
On Tue, Mar 23, 2021 at 02:00:43AM +0100, Ulf Brosziewski wrote: > On 3/22/21 10:19 PM, Klemens Nanni wrote: > > On Mon, Mar 22, 2021 at 08:18:45PM +0100, Klemens Nanni wrote: > >> I was too stupid to look at `wsconsctl' output (which needs root) and > >> only looked here. > >> > >> Mailing the

Re: veb(4) exceeds 1514 byte frame size while bridge(4) doesn't?

2021-03-23 Thread David Gwynne
On Sun, Mar 21, 2021 at 04:24:24PM +0100, Jurjen Oskam wrote: > Hi, > > When trying out veb(4), I ran into a situation where TCP sessions across a > veb(4) bridge stalled while the exact same config using bridge(4) worked fine. > > After some investigation, it seems that veb(4) adds an FCS to

cwm: add last-group command

2021-03-23 Thread Omar Polo
Hello tech@, The attached patch adds a last-group command for cwm. Admittedly, last-group probably makes sense only in sticky group mode; all it does is switching to the last group. I've been happily using this since last summer, I'm quite confident it's not 100% broken. I haven't added a

Re: Fix iwx wrong ac indexs.

2021-03-23 Thread Stefan Sperling
On Thu, Mar 18, 2021 at 10:32:54PM +0800, zxystd wrote: > Hi Stefan, > I agree, we had better using the ac array directly. > According to our tests, this actually takes effect for speed improving, > before this fix, iwx can run up to about 60mbps download and 20mbps upload > which is slower than

Re: sdmmc(4) off-by-one on boundary check

2021-03-23 Thread Theo de Raadt
Marcus Glocker wrote: > Index: sys/dev/sdmmc/sdmmc_scsi.c > === > RCS file: /cvs/src/sys/dev/sdmmc/sdmmc_scsi.c,v > retrieving revision 1.59 > diff -u -p -u -p -r1.59 sdmmc_scsi.c > --- sys/dev/sdmmc/sdmmc_scsi.c15 Oct 2020

sdmmc(4) off-by-one on boundary check

2021-03-23 Thread Marcus Glocker
I recently got a Raspberry Pi 3 Model B Plus (Rev 1.3). After installing current the first thing during boot which I get is: ... starting network reordering libraries: done. starting early daemons: syslogd pflogd ntpd. starting RPC daemons:. savecore: no core dump bcmsdhost0: transfer timeout!

Re: wsconsctl.conf: mention mouse.tp.tapping in example

2021-03-23 Thread Raf Czlonka
On Tue, Mar 23, 2021 at 11:26:19AM GMT, Klemens Nanni wrote: > On Tue, Mar 23, 2021 at 02:00:43AM +0100, Ulf Brosziewski wrote: > > On 3/22/21 10:19 PM, Klemens Nanni wrote: > > > On Mon, Mar 22, 2021 at 08:18:45PM +0100, Klemens Nanni wrote: > > >> I was too stupid to look at `wsconsctl' output

UVM return(val)

2021-03-23 Thread Martin Pieuchot
Diff below convert multiple "return(val)" and "return (val)" to "return val". I only changed those that help decrease the size of the diff with NetBSD or didn't change anything. ok? Index: uvm/uvm_amap.c === RCS file:

mg: buffer pointer change after eread()

2021-03-23 Thread Mark Lumsden
When reading in from the modeline in buffer.c, mg uses a pointer called bufp pointing to a buffer called bufn. It would seem to make sense to use bufp in any further processing. These functions don't: switch-to-buffer-other-window (poptobuffer()) kill-buffer

Re: sdmmc(4) off-by-one on boundary check

2021-03-23 Thread Theo de Raadt
That is what I envisioned. It is just an off-by-one on the bounds check. Marcus Glocker wrote: > On Tue, Mar 23, 2021 at 08:29:06AM -0600, Theo de Raadt wrote: > > > Marcus Glocker wrote: > > > > > Index: sys/dev/sdmmc/sdmmc_scsi.c > > >

Re: sdmmc(4) off-by-one on boundary check

2021-03-23 Thread Mark Kettenis
> From: "Theo de Raadt" > Date: Tue, 23 Mar 2021 08:29:06 -0600 > > Marcus Glocker wrote: > > > Index: sys/dev/sdmmc/sdmmc_scsi.c > > === > > RCS file: /cvs/src/sys/dev/sdmmc/sdmmc_scsi.c,v > > retrieving revision 1.59 > > diff -u

Re: UVM return(val)

2021-03-23 Thread Mike Larkin
On Tue, Mar 23, 2021 at 01:52:20PM +0100, Martin Pieuchot wrote: > Diff below convert multiple "return(val)" and "return (val)" to > "return val". I only changed those that help decrease the size > of the diff with NetBSD or didn't change anything. > > ok? > I read through these and agree this

Re: sdmmc(4) off-by-one on boundary check

2021-03-23 Thread Marcus Glocker
On Tue, Mar 23, 2021 at 08:29:06AM -0600, Theo de Raadt wrote: > Marcus Glocker wrote: > > > Index: sys/dev/sdmmc/sdmmc_scsi.c > > === > > RCS file: /cvs/src/sys/dev/sdmmc/sdmmc_scsi.c,v > > retrieving revision 1.59 > > diff -u -p

Re: sdmmc(4) off-by-one on boundary check

2021-03-23 Thread Theo de Raadt
Mark Kettenis wrote: > > > Index: sys/dev/sdmmc/sdmmc_scsi.c > > > === > > > RCS file: /cvs/src/sys/dev/sdmmc/sdmmc_scsi.c,v > > > retrieving revision 1.59 > > > diff -u -p -u -p -r1.59 sdmmc_scsi.c > > > ---

Re: athn(4): switch Tx rate control to RA

2021-03-23 Thread Klemens Nanni
On Tue, Mar 23, 2021 at 06:01:27PM +0100, Stefan Sperling wrote: > This switches athn(4) to the new RA Tx rate adaptation module. > Tests on athn(4) PCI devices are welcome. > USB devices don't need to be tested in this case Tx rate adaptation > is taken care of by firmware. > > I could only test

athn(4): switch Tx rate control to RA

2021-03-23 Thread Stefan Sperling
This switches athn(4) to the new RA Tx rate adaptation module. Tests on athn(4) PCI devices are welcome. USB devices don't need to be tested in this case Tx rate adaptation is taken care of by firmware. I could only test on AR9285 so far, but the result looks promising. diff

Re: wsconsctl.conf: mention mouse.tp.tapping in example

2021-03-23 Thread Ulf Brosziewski
Thanks for the report. The logging shows that the contacts are recognized, so we have indeed to look at the filters of the driver. Two filters are relevant here: The first and essential one checks whether the duration of a contact exceeds the "tapping timeout" (180ms by default). The second

Re: OPENBSD-PF-MIB, use DisplayString not OCTET STRING

2021-03-23 Thread Martijn van Duren
On Mon, 2021-03-22 at 09:00 +, Stuart Henderson wrote: > On 2021/03/22 00:20, Martijn van Duren wrote: > > There's two things I'd like to know before going further with this: > > > > 1) according to RFC2578 section 3.6: > > (1)  registration: the definition of a particular item is registered

wsmouse(4): make tap detection less restrictive

2021-03-23 Thread Ulf Brosziewski
In order to distinguish tap gestures from short movements, the touchpad input driver in wsmouse checks whether the distance between the initial and the last position of a touch exceeds the 'maxdist' limit. Some touchpads provide unreliable coordinates when more than one contact is being made

Re: athn(4): switch Tx rate control to RA

2021-03-23 Thread Mikolaj Kucharski
On Tue, Mar 23, 2021 at 06:01:27PM +0100, Stefan Sperling wrote: > This switches athn(4) to the new RA Tx rate adaptation module. > Tests on athn(4) PCI devices are welcome. > USB devices don't need to be tested in this case Tx rate adaptation > is taken care of by firmware. > > I could only test

Re: athn(4): switch Tx rate control to RA

2021-03-23 Thread Mikolaj Kucharski
On Tue, Mar 23, 2021 at 08:52:12PM +0100, Stefan Sperling wrote: > On Tue, Mar 23, 2021 at 07:47:08PM +, Mikolaj Kucharski wrote: > > I also have third system, with the same athn(4) card (only mac address > > is different in `dmesg | grep athn` output), but it acts as a Wi-Fi > > client and is

Re: wsconsctl.conf: mention mouse.tp.tapping in example

2021-03-23 Thread Klemens Nanni
On Tue, Mar 23, 2021 at 05:52:10PM +0100, Ulf Brosziewski wrote: > Thanks for the report. The logging shows that the contacts are recognized, > so we have indeed to look at the filters of the driver. Two filters are > relevant here: The first and essential one checks whether the duration of > a

Re: athn(4): switch Tx rate control to RA

2021-03-23 Thread Mikolaj Kucharski
On Tue, Mar 23, 2021 at 07:06:33PM +, Mikolaj Kucharski wrote: > On Tue, Mar 23, 2021 at 06:01:27PM +0100, Stefan Sperling wrote: > > This switches athn(4) to the new RA Tx rate adaptation module. > > Tests on athn(4) PCI devices are welcome. > > USB devices don't need to be tested in this

Re: athn(4): switch Tx rate control to RA

2021-03-23 Thread Stefan Sperling
On Tue, Mar 23, 2021 at 07:47:08PM +, Mikolaj Kucharski wrote: > I also have third system, with the same athn(4) card (only mac address > is different in `dmesg | grep athn` output), but it acts as a Wi-Fi > client and is connected to OpenBSD athn(4)-based access point from > my previous email

Re: wsconsctl.conf: mention mouse.tp.tapping in example

2021-03-23 Thread Ulf Brosziewski
On 3/23/21 8:31 PM, Klemens Nanni wrote: > On Tue, Mar 23, 2021 at 05:52:10PM +0100, Ulf Brosziewski wrote: >> Thanks for the report. The logging shows that the contacts are recognized, >> so we have indeed to look at the filters of the driver. Two filters are >> relevant here: The first and

Re: snmp(1) Fix some ranges and types

2021-03-23 Thread Martijn van Duren
Any takers? On Tue, 2021-03-02 at 22:50 +0100, Martijn van Duren wrote: > Live and learn. While working on a regress test I found that I > misunderstood some types when I wrote this code. According to RFC2578: > - timeticks is a 32 bit unsigned int > - counter32 is a 32 bit unsigned int > -

snmp(1) adjust for OPENBSD-PF-MIB

2021-03-23 Thread Martijn van Duren
Index: mib.h === RCS file: /cvs/src/usr.bin/snmp/mib.h,v retrieving revision 1.9 diff -u -p -r1.9 mib.h --- mib.h 14 Dec 2020 07:44:26 - 1.9 +++ mib.h 23 Mar 2021 20:52:03 - @@ -1193,7 +1193,7 @@ {

Re: wsmouse(4): make tap detection less restrictive

2021-03-23 Thread Klemens Nanni
On Tue, Mar 23, 2021 at 09:29:09PM +0100, Ulf Brosziewski wrote: > In order to distinguish tap gestures from short movements, the touchpad > input driver in wsmouse checks whether the distance between the initial > and the last position of a touch exceeds the 'maxdist' limit. Some > touchpads

Re: systat(1) sticky help

2021-03-23 Thread Martijn van Duren
ping On Tue, 2021-03-09 at 19:33 +0100, Martijn van Duren wrote: > I send out an earlier version of this diff to Anindya with some positive > feedback. Instead of claiming another binding, why not make help, order > and view a toggle? I see no reason why this information should disappear > on the

Re: arm64: make cwfg(4) report battery information to apm(4)

2021-03-23 Thread Jeremie Courreges-Anglas
On Mon, Mar 22 2021, Klemens Nanni wrote: > Better diff at the end thanks to jca's eyeballing, see comments inline. > > kettenis: I see room for improvement in our subsystems and their > interactions, but I don't think the current situation is bad enough to > leave those bits out for now. > >

Re: wsmouse(4): make tap detection less restrictive

2021-03-23 Thread Ulf Brosziewski
On 3/23/21 10:39 PM, Klemens Nanni wrote: > On Tue, Mar 23, 2021 at 09:29:09PM +0100, Ulf Brosziewski wrote: >> In order to distinguish tap gestures from short movements, the touchpad >> input driver in wsmouse checks whether the distance between the initial >> and the last position of a touch

Re: wsmouse(4): make tap detection less restrictive

2021-03-23 Thread Klemens Nanni
On Wed, Mar 24, 2021 at 12:10:20AM +0100, Ulf Brosziewski wrote: > This means we have two distinct issues here. On the Thinkpad, it's > coordinates, on the Pinebook, it's the timing - as your logs have shown, > there are either overlong delays between some reports, or the clock is > irregular.