bgpd fix add-path capability encoding

Dumb copy paste error. The add-path capability is 4byte per AFI/SAFI the 2 + is from graceful restart where two extra bytes are at the front of the AFI/SAFI list. -- :wq Claudio Index: session.c === RCS file:

bgpd refactor some common code for add-path

Adjust the way nlri get extracted from the MP attrs. Instead of switch statements with a while loop for each case move the while loop out and only do the nlri_get_* call in the switch statement. The mpp and mplen adjustmens and the call to rde_update_update and rde_update_withdraw are also moved

Re: [External] : Re: parallel forwarding vs. bridges

Hello, new diff still looks good to me. I could just catch typos in comment. > > I've been running versions of this diff in production at work, and have > hit a few panics and asserts. All the issues we've hit should be > addressed in this diff. > > The first issue was that pfsync

Re: disklabel(8): reduce usage()

On Tue, 22 Jun 2021 13:34:43 +0100, Jason McIntyre wrote: > diff to reduce verbosity in disklabel(8) usage. before: OK. Should we also remove SEEALSO from sbin/disklabel/Makefile and distrib/special/disklabel/Makefile? - todd

Re: crontab(1): reduce usage()

On Tue, 22 Jun 2021 13:42:19 +0100, Jason McIntyre wrote: > diff to reduce verbosity in crontab(1) usage. before: OK millert@ - todd

Re: rdist(1): reduce usage()

On Tue, 22 Jun 2021 13:56:46 +0100, Jason McIntyre wrote: > this one is more problematic. it uses two functions, getdistoptlist and > msgprusage, which i think are only used within usage. so i killed them > too. OK millert@ - todd

adb(4/macppc): fix adb_cuda_tickle() prototype

We seem to cast adb_cuda_tickle() to a void pointer to bypass timeout_set(9)'s type checking The actual function takes no parameters, but the timeout layer doesn't know that. Eek. This is no good. The fix is trivial. Add an unused void pointer parameter to adb_cuda_tickle(). ok? Index:

Re: tset(1): reduce usage()

On Tue, Jun 22, 2021 at 05:52:34PM +0200, Theo Buehler wrote: > I think we should pull the assignment up. Our execve(2) guarantees that > argc >= 1, so it's safe to do *argv. We need to do this before calling > the internal err() the first time as that uses _nc_progname() internally. Even better,

iwm/iwx: firmware HT protection flags fix

According to zxystd from OpenIntelWireless, the following change fixed fatal firmware errors seen during HT protection updates for them. I have not seen the issue myself, but I don't think this change can hurt. If it fixes firmware errors in an edge case, all the better. This essentially aligns

Re: ypmatch(1): reduce usage()

On Tue, 22 Jun 2021 13:44:27 +0100, Jason McIntyre wrote: > diff to reduce verbosity in ypmatch(1) usage. before: OK millert@ - todd

Re: locate(1): reduce usage()

On Tue, 22 Jun 2021 13:49:35 +0100, Jason McIntyre wrote: > diff to reduce verbosity in locate(1) usage. before: OK millert@ - todd

Re: disklabel(8): reduce usage()

On Tue, Jun 22, 2021 at 12:36:02PM -0600, Todd C. Miller wrote: > On Tue, 22 Jun 2021 13:34:43 +0100, Jason McIntyre wrote: > > > diff to reduce verbosity in disklabel(8) usage. before: > > OK. Should we also remove SEEALSO from sbin/disklabel/Makefile > and distrib/special/disklabel/Makefile?

bgpd fix bad free() call when deflating aspath

I changed the way up_generate_attr() calls aspath_deflate() but did not realize that aspath_deflate() frees the pdata at the end. That free should no longer happen but for that also the mrt case where aspath_deflate() needs to be adjusted. With this both the mrt and as0 integration test pass

Re: add table_procexec in smtpd

June 22, 2021 11:14 PM, "Aisha Tammy" wrote: >> [...] >> >> WRT to handshake, it has multiple uses ranging from ensuring the addons get >> their configuration >> from the daemon to synchronising the daemon start with addons readiness. >> Remember, we didn’t have this with filters and realised

Re: add table_procexec in smtpd

> >> First, if the two implementations are not going to coexists, > >> we can just replace table_proc.c. > > > > True, though proc-exec was the name used for filters so it may be a good to > > unify and drop the legacy “proc” name. > > This will be hidden to users so quite frankly it’s a

Re: Z590 chipset + i7 10700 CPU - slowness, sysctl hw.cpuspeed/setperf weirdness

Mark Kettenis writes: > Sounds like Intel changed the way CPU frequency scaling is implemented > on these new CPUs. Somebody will have to look into this, but many > OpenBSD developers prefer to buy machines with AMD CPU which is > probably why this hasn't happened yet. For those joining us on

scsi(8): reduce usage()

hi. diff to reduce verbosity in scsi(8) usage. before: $ /sbin/scsi -Z scsi: unknown option -- Z Usage: scsi -f device -d debug_level# To set debug level scsi -f device -m page [-P pc] # To read mode pages scsi -f device [-v] [-s seconds] -c cmd_fmt

crontab(1): reduce usage()

hi. diff to reduce verbosity in crontab(1) usage. before: $ /usr/bin/crontab -Z crontab: unknown option -- Z usage: crontab [-u user] file crontab [-e | -l | -r] [-u user] (default operation is replace, per 1003.2) -e (edit user's crontab) -l

locate(1): reduce usage()

hi. diff to reduce verbosity in locate(1) usage. before: $ /usr/bin/locate -Z locate: unknown option -- Z usage: locate [-bciS] [-d database] [-l limit] pattern ... default database: `/var/db/locate.database' or $LOCATE_PATH after: $ /usr/obj/usr.bin/locate/locate/locate -Z locate: unknown

Re: tls_load_file.3: tls_config_set_*_file() load files into memory

On Tue, Jun 22, 2021 at 06:35:44AM +0100, Jason McIntyre wrote: > > -sets the files from which the public certificate, and private key will be > > read. > > +loads two files from which the public certificate, and private key will be > > read. > > this is a weird place for a comma. i would

disklabel(8): reduce usage()

hi. diff to reduce verbosity in disklabel(8) usage. before: $ /sbin/disklabel -Z disklabel: unknown option -- Z usage: disklabel[-Acdtv] [-h | -p unit] [-T file] disk (read) disklabel -w [-Acdnv] [-T file] disk disktype [packid] (write) disklabel -e [-Acdnv] [-T file]

mkuboot(8): reduce usage()

hi. diff to reduce verbosity in mkuboot(8) usage. i don;t have the means to build this one. ok? jmc Index: mkuboot.c === RCS file: /cvs/src/usr.sbin/mkuboot/mkuboot.c,v retrieving revision 1.10 diff -u -p -r1.10 mkuboot.c ---

tset(1): reduce usage()

hi. diff to reduce verbosity in tset(1) usage. before: $ /usr/bin/tset -Z tset: unknown option -- Z Usage: tset [-cIQqrsVw] [-] [-e ch] [-i ch] [-k ch] [-m mapping] [terminal] Options: -c set control characters -e ch erase character -I no initialization strings

lex(1): reduce usage()

hi. diff to reduce verbosity in flex/lex usage. before: $ /usr/bin/lex --help Usage: lex [OPTIONS] [FILE]... Generates programs that perform pattern-matching on text. Table Compression: -Ca, --align trade off larger tables for better memory alignment -Ce, --ecsconstruct

Re: scsi(8): reduce usage()

> Date: Tue, 22 Jun 2021 13:30:11 +0100 > From: Jason McIntyre > Content-Type: text/plain; charset=us-ascii > Content-Disposition: inline > > hi. > > diff to reduce verbosity in scsi(8) usage. before: > > $ /sbin/scsi -Z > scsi: unknown option -- Z > Usage: > > scsi -f device -d debug_level

ypmatch(1): reduce usage()

hi. diff to reduce verbosity in ypmatch(1) usage. before: $ /usr/bin/ypmatch -Z ypmatch: unknown option -- Z usage: ypmatch [-kt] [-d domain] key ... mapname ypmatch -x where mapname may be either a mapname or a nickname for a map. -k prints keys as well as values.

rdist(1): reduce usage()

hi. diff to reduce verbosity in rdist(1) usage. before: $ /usr/bin/rdist -Z rdist: unknown option -- Z usage: rdist [-DFnV] [-A num] [-a num] [-c mini_distfile] [-d var=value] [-f distfile] [-L remote_logopts] [-l local_logopts] [-M maxproc] [-m host] [-o distopts] [-P rsh-path]

Re: tset(1): reduce usage()

On Tue, Jun 22, 2021 at 02:19:32PM +, Klemens Nanni wrote: > On Tue, Jun 22, 2021 at 01:47:13PM +0100, Jason McIntyre wrote: > > after: > > > > $ /usr/obj/usr.bin/tset/tset -Z > > tset: unknown option -- Z > > usage: tset [-cIQqrsVw] [-] [-e ch] [-i ch] [-k ch] [-m mapping] [terminal] > > OK

Re: tset(1): reduce usage()

On Tue, Jun 22, 2021 at 03:57:08PM +0100, Jason McIntyre wrote: > On Tue, Jun 22, 2021 at 02:19:32PM +, Klemens Nanni wrote: > > On Tue, Jun 22, 2021 at 01:47:13PM +0100, Jason McIntyre wrote: > > > after: > > > > > > $ /usr/obj/usr.bin/tset/tset -Z > > > tset: unknown option -- Z > > >

iwm/iwx: fix mac context task synchronization

The mac context task gets triggered by changing parameters in beacons received from our AP while ic_state indicates that we are in RUN state. This can happen during regular operation and while a background scan is in progress. When a background scan has found a new AP, we trigger a RUN -> AUTH

Re: tset(1): reduce usage()

On Tue, Jun 22, 2021 at 03:22:34PM +, Klemens Nanni wrote: > On Tue, Jun 22, 2021 at 03:57:08PM +0100, Jason McIntyre wrote: > > On Tue, Jun 22, 2021 at 02:19:32PM +, Klemens Nanni wrote: > > > On Tue, Jun 22, 2021 at 01:47:13PM +0100, Jason McIntyre wrote: > > > > after: > > > > > > > >

Re: tls_load_file.3: tls_config_set_*_file() load files into memory

On Tue, Jun 22, 2021 at 01:29:59PM +, Klemens Nanni wrote: > On Tue, Jun 22, 2021 at 06:35:44AM +0100, Jason McIntyre wrote: > > > -sets the files from which the public certificate, and private key will > > > be read. > > > +loads two files from which the public certificate, and private key

Re: lex(1): reduce usage()

Jason McIntyre wrote: > hi. > > diff to reduce verbosity in flex/lex usage. before: This seems better. Rather than telling people to run --help, which is now usage(), just run usage(). Also usage() does not need to exit(), since all calls to usage() are followed by FLEX_EXIT(). [This is a

Re: tset(1): reduce usage()

On Tue, Jun 22, 2021 at 01:47:13PM +0100, Jason McIntyre wrote: > after: > > $ /usr/obj/usr.bin/tset/tset -Z > tset: unknown option -- Z > usage: tset [-cIQqrsVw] [-] [-e ch] [-i ch] [-k ch] [-m mapping] [terminal] OK kn

Re: amd64: softintr_dispatch: remove kernel lock

On Mon, Jun 21, 2021 at 02:04:30PM +, Visa Hankala wrote: > On Thu, May 27, 2021 at 07:40:26PM -0500, Scott Cheloha wrote: > > On Sun, May 23, 2021 at 09:05:24AM +, Visa Hankala wrote: > > > When a CPU starts processing a soft interrupt, it reserves the handler > > > to prevent concurrent

Re: lex(1): reduce usage()

On Tue, Jun 22, 2021 at 07:50:10AM -0600, Theo de Raadt wrote: > Jason McIntyre wrote: > > > hi. > > > > diff to reduce verbosity in flex/lex usage. before: > > This seems better. Rather than telling people to run --help, which is > now usage(), just run usage(). Also usage() does not need

Re: mkuboot(8): reduce usage()

> Date: Tue, 22 Jun 2021 13:36:47 +0100 > From: Jason McIntyre > > hi. > > diff to reduce verbosity in mkuboot(8) usage. i don;t have the means to > build this one. > > ok? ok kettenis@ > Index: mkuboot.c > === > RCS file:

Re: tset(1): reduce usage()

On Tue, Jun 22, 2021 at 03:22:34PM +, Klemens Nanni wrote: > On Tue, Jun 22, 2021 at 03:57:08PM +0100, Jason McIntyre wrote: > > On Tue, Jun 22, 2021 at 02:19:32PM +, Klemens Nanni wrote: > > > On Tue, Jun 22, 2021 at 01:47:13PM +0100, Jason McIntyre wrote: > > > > after: > > > > > > > >