Re: iwx(4): Whitespace fix

2021-07-20 Thread Stefan Sperling
On Mon, Jul 19, 2021 at 09:20:17PM -0400, Ashton Fagg wrote: > Found this while poking around - an extra newline in if_iwx.c. > > Index: sys/dev/pci/if_iwx.c > === > RCS file: /cvs/src/sys/dev/pci/if_iwx.c,v > retrieving revision

Re: forwarding in parallel ipsec workaround

2021-07-20 Thread Martin Pieuchot
On 19/07/21(Mon) 17:53, Alexander Bluhm wrote: > Hi, > > I found why the IPsec workaround did not work. > > At init time we set ifiq->ifiq_softnet = net_tq(ifp->if_index + > idx), but the workaround modifies net_tq() at runtime. Modifying > net_tq() at runtime is bad anyway as task_add() and

Re: ix(4)/riscv64: Make ix(4) work when MSI-X interrupts aren't available

2021-07-20 Thread Jonathan Matthew
On Mon, Jul 19, 2021 at 07:37:10PM -0400, Ashton Fagg wrote: > I have an Intel 82599 10 gigabit ethernet card I wanted to get working > on my SiFive Unmatched board. > > I found the ix(4) driver has some weirdness around MSI-X > interrupts. While the driver supports operating both with and

Re: parallel ipsec workaround

2021-07-20 Thread Vitaliy Makkoveev
On Tue, Jul 20, 2021 at 03:41:32PM +0200, Alexander Bluhm wrote: > Hi, > > The current workaround to disable parallel IPsec does not work. > Variable nettaskqs must not change at runtime. Interface input > queues choose the thread during init with ifiq_softnet = net_tq(). > So it cannot be

Re: ix(4)/riscv64: Make ix(4) work when MSI-X interrupts aren't available

2021-07-20 Thread Mark Kettenis
> Date: Tue, 20 Jul 2021 21:55:56 +1000 > From: Jonathan Matthew > > On Mon, Jul 19, 2021 at 07:37:10PM -0400, Ashton Fagg wrote: > > I have an Intel 82599 10 gigabit ethernet card I wanted to get working > > on my SiFive Unmatched board. > > > > I found the ix(4) driver has some weirdness

Re: forwarding in parallel ipsec workaround

2021-07-20 Thread Alexander Bluhm
On Tue, Jul 20, 2021 at 10:08:09AM +0200, Martin Pieuchot wrote: > On 19/07/21(Mon) 17:53, Alexander Bluhm wrote: > > Hi, > > > > I found why the IPsec workaround did not work. > > > > At init time we set ifiq->ifiq_softnet = net_tq(ifp->if_index + > > idx), but the workaround modifies net_tq()

Re: forwarding in parallel ipsec workaround

2021-07-20 Thread Alexander Bluhm
On Tue, Jul 20, 2021 at 02:26:02PM +0200, Alexander Bluhm wrote: > > Note that having multiple threads competing for an exclusive rwlock will > > generate unnecessary wakeup/sleep cycles every time the lock is released. > > It is valuable to keep this in mind as it might add extra latency when > >

parallel ipsec workaround

2021-07-20 Thread Alexander Bluhm
Hi, The current workaround to disable parallel IPsec does not work. Variable nettaskqs must not change at runtime. Interface input queues choose the thread during init with ifiq_softnet = net_tq(). So it cannot be modified after pfkeyv2_send() sets the first SA in kernel. Also changing the

Re: pipex(4): use per-CPU counters for session statistics

2021-07-20 Thread Alexander Bluhm
On Tue, Jul 20, 2021 at 02:25:34AM +0300, Vitaliy Makkoveev wrote: > With bluhm@'s "forwarding in parallel" diff pipex(4) session could be > accessed in parallel through (*ifp->if_input) -> ether_input(). > > Except statistics and MPPE data PPPOE sessions are mostly immutable. We > have only

unwind(8): WIP support using a custom CA

2021-07-20 Thread Lucas
Hi tech@, I decided to give it a shot at specifying a custom CA for DoT validation in unwind(8). Patch at the bottom. Selfish reason for this is that I run my own DoT resolver, using a self-signed certificate. Am able to use unbound to query it, but the lack of support for a custom CA in unwind

Re: crypto error ipsec counter

2021-07-20 Thread Vitaliy Makkoveev
ok mvs@ > On 21 Jul 2021, at 02:13, Alexander Bluhm wrote: > > Hi, > > Propagate the crypto errors and count them in ipsec. This is part > of a larger diff where I disable the crypto queues for ipsec. I > think it cannot happen, but errors should always be checked. > > tq is never NULL. >

Re: vscsi/iscsid: wait for scsi_probe to complete after connections are established

2021-07-20 Thread Ashton Fagg
Friendly ping. Ashton Fagg writes: > I have been working on fixing an issue (which was partially fixed by a > diff I sent in earlier this year) with iscsid. With iscsi disks in > /etc/fstab, sometimes the devices aren't fully up and ready before fsck > tries to run - causing the machine to go

Re: nanosleep.2: miscellaneous cleanup

2021-07-20 Thread Theo de Raadt
> [EFAULT] foo points outside the process's allocated address space. > > But i don't really i like that. The word "allocated" makes me wonder > because it sounds too much like malloc(3) for my taste. > Usually, pointers to automatic and to static objects are acceptable, > too, and are those

nanosleep.2: miscellaneous cleanup

2021-07-20 Thread Scott Cheloha
Hi, The nanosleep.2 page could use some cleanup. Here's a bunch of fixes, rewrites, etc. I've included my notes on the changes below. I have some (mostly stylistic) questions in there, too. -- DESCRIPTION - We suspend the calling thread, not the calling process. - Note that we block for

Re: nanosleep.2: miscellaneous cleanup

2021-07-20 Thread Scott Cheloha
On Tue, Jul 20, 2021 at 06:26:45PM -0600, Theo de Raadt wrote: > I think this is excessively verbose for such a simple function, especially > the addition of examples. > > There are many APIs which are hundreds of times more complicated which > don't have this level of detailing, and I would

Re: nanosleep.2: miscellaneous cleanup

2021-07-20 Thread Ingo Schwarze
Hi Scott, Scott Cheloha wrote on Tue, Jul 20, 2021 at 05:20:16PM -0500: > The nanosleep.2 page could use some cleanup. Here's a bunch of fixes, > rewrites, etc. > > I've included my notes on the changes below. I have some (mostly > stylistic) questions in there, too. Thanks for explaining

Re: nanosleep.2: miscellaneous cleanup

2021-07-20 Thread Theo de Raadt
I think this is excessively verbose for such a simple function, especially the addition of examples. There are many APIs which are hundreds of times more complicated which don't have this level of detailing, and I would argue such manual pages have the correct tone and complexity. It stops

Re: update xf86-video-amdgpu to latest git

2021-07-20 Thread rgc
@tech i've been using this patch for a week i've experience 4 hangs ... X hangs ... network is alive so i can do a safe reboot via ssh. last hang occured just 5 mins ago while watching some YouTube videos. 2 behaviours: - video/screen freezes indifinitely, which requires me to login via ssh and

Re: nanosleep.2: miscellaneous cleanup

2021-07-20 Thread Theo de Raadt
Scott Cheloha wrote: > I'm not wed to keeping all the examples. What if we merge examples 1 > and 2 and dumb the result down a bit? Are you teaching people how to fill a structure, how to perform a loop, or that they need to check errno? I don't see the point of having any example. Do we

crypto error ipsec counter

2021-07-20 Thread Alexander Bluhm
Hi, Propagate the crypto errors and count them in ipsec. This is part of a larger diff where I disable the crypto queues for ipsec. I think it cannot happen, but errors should always be checked. tq is never NULL. I know that tdb->tdb_odrops++ is not MP safe. I have just copied the code. My

Re: ix(4)/riscv64: Make ix(4) work when MSI-X interrupts aren't available

2021-07-20 Thread Jonathan Matthew
On Tue, Jul 20, 2021 at 02:21:39PM +0200, Mark Kettenis wrote: > > Date: Tue, 20 Jul 2021 21:55:56 +1000 > > From: Jonathan Matthew > > > > On Mon, Jul 19, 2021 at 07:37:10PM -0400, Ashton Fagg wrote: > > > I have an Intel 82599 10 gigabit ethernet card I wanted to get working > > > on my SiFive