tcpdump: fix -Wunused-but-set-variable warning

2022-01-29 Thread Christian Weisgerber
usr.sbin/tcpdump: fix -Wunused-but-set-variable warning All "infile" handling was moved into priv_exec() when tcpdump was priviledge separated. The options are scanned both in priv_exec() and in main(), so the empty case needs to remain in the latter. ok? M usr.sbin/tcpdump/tcpdump.c diff

ypldap: fix -Wunused-but-set-variable warnings

2022-01-29 Thread Christian Weisgerber
usr.sbin/ypldap: fix -Wunused-but-set-variable warnings * "wrlen" has been write-only since the code was imported. * Removing "dns_pid" replicates ntpd/ntp.c 1.122 (aece4353519f). * yp_check() looks like unfinished code. Rather than removing it we can ifdef it out. ok? M

Re: [PATCH v2 3/3] script(1): fix exit status wording, use 125 for general failure

2022-01-29 Thread наб
On Fri, Jan 28, 2022 at 06:32:07PM -0800, Philip Guenther wrote: > On Fri, Jan 28, 2022 at 5:28 AM наб > wrote: > > This is a base-line attempt at separating errors from the child from the > > ones from script itself ‒ 125 is the general-purpose code in POSIX > > utilities that exec() (with 126

Summary of remaining "set but not used" warnings

2022-01-29 Thread Christian Weisgerber
First up, note that clang 13 does not produce those "variable foo set but not used" warnings by default. They need to be enabled by -Wunused-but-set-variable or, more typically, as part of -Wall. Here are the remaining warnings seen in a "make build": bin/ksh required arguments to macros

Re: Add rtable capability to login.conf

2022-01-29 Thread Ted Unangst
I believe it would be better to add setrtable to id pledge. On 2022-01-29, Matthew Martin wrote: > It would be nice to have the ability to set a user's rtable upon login. > This would be useful both for road warrior VPN setups (put both the VPN > interface and user in an rdomain other than 0) and

Re: Add rtable capability to login.conf

2022-01-29 Thread Theo de Raadt
> I believe it would be better to add setrtable to id pledge. That's right.

Re: IPv6 privacy extensions

2022-01-29 Thread Marcel Logen
Florian Obser wrote: > slaacd(8) used to never renew temporary addresses but would form a new > one once the pltime reached 0. This was because I misunderstood what the > RFC was saying and did not appreciate what would hapen. > If there is a huge difference between pltime and vltime in router >

Missing UBSan libs

2022-01-29 Thread Greg Steuck
I notice people keep sending fixes to problems reported by UBSan. I wanted to join the club, but the trivial thing listed at https://clang.llvm.org/docs/UndefinedBehaviorSanitizer.html doesn't work: $ cat a.cc; clang++ -fsanitize=undefined a.cc; ./a.out int main(int argc, char **argv) { int k =

Add rtable capability to login.conf

2022-01-29 Thread Matthew Martin
It would be nice to have the ability to set a user's rtable upon login. This would be useful both for road warrior VPN setups (put both the VPN interface and user in an rdomain other than 0) and to differentiate users in firewall rules on the gateway or unbound views on a resolver. The below patch

Re: Add rtable capability to login.conf

2022-01-29 Thread Matthew Martin
On Sat, Jan 29, 2022 at 07:10:00PM -0500, Ted Unangst wrote: > I believe it would be better to add setrtable to id pledge. Makes the diff quite a bit shorter too. diff --git include/login_cap.h include/login_cap.h index d9a4c2c349c..1e831b6471a 100644 --- include/login_cap.h +++