Re: Use installboot(8) in install.md of riscv64

2022-02-02 Thread Mark Kettenis
> Date: Wed, 2 Feb 2022 14:16:03 + > From: Visa Hankala > > On Tue, Feb 01, 2022 at 10:55:03AM -0700, Theo de Raadt wrote: > > Mark Kettenis wrote: > > > > > Maybe we should rename the file to efi_installboot.c and/or rearrange > > > the code slightly such that is becomes more obvious that

Re: Missing UBSan libs

2022-02-02 Thread Jeremie Courreges-Anglas
On Mon, Jan 31 2022, Greg Steuck wrote: > Patrick Wildt writes: > >> regarding the missing userpace support: Since a few clang updates ago >> we import more than just the builtins of compiler-rt. This means we >> should have at least some related code in our tree, even if it is not >>

Re: [macppc] mpcpcibr buglet

2022-02-02 Thread Mark Kettenis
> Date: Wed, 2 Feb 2022 10:47:59 + > From: Miod Vallat > > On PowerMac11,2 systems, the PCIe bus attaches as: > > mpcpcibr0 at mainbus0 pci: u4-pcie > pci0 at mpcpcibr0 bus 0 > > However none of the devices attached to pci0 will appear in pcidump. > > This is caused by an incorrect bus

Re: Use installboot(8) in install.md of riscv64

2022-02-02 Thread Visa Hankala
On Tue, Feb 01, 2022 at 10:55:03AM -0700, Theo de Raadt wrote: > Mark Kettenis wrote: > > > Maybe we should rename the file to efi_installboot.c and/or rearrange > > the code slightly such that is becomes more obvious that the name of > > the file is indeed the only difference. > > And

[macppc] mpcpcibr buglet

2022-02-02 Thread Miod Vallat
On PowerMac11,2 systems, the PCIe bus attaches as: mpcpcibr0 at mainbus0 pci: u4-pcie pci0 at mpcpcibr0 bus 0 However none of the devices attached to pci0 will appear in pcidump. This is caused by an incorrect bus number during attachment of the pci(4) subdevice. The following diff queries the

Re: amd64: simplify TSC sync testing

2022-02-02 Thread Jason McIntyre
On Wed, Feb 02, 2022 at 04:52:40PM +, Stuart Henderson wrote: > This definitely wants testing on Ryzen ThinkPads (e.g. E485/E585/X395/T495s) > or Inspiron 5505, I see user TSC disabled on a lot of those in dmesglog. > > hi. here are the results from a 5505. was the timecounter meant to

Re: Use installboot(8) in install.md of riscv64

2022-02-02 Thread Theo de Raadt
That's a good step. Visa Hankala wrote: > On Tue, Feb 01, 2022 at 10:55:03AM -0700, Theo de Raadt wrote: > > Mark Kettenis wrote: > > > > > Maybe we should rename the file to efi_installboot.c and/or rearrange > > > the code slightly such that is becomes more obvious that the name of > > >

Re: amd64: simplify TSC sync testing

2022-02-02 Thread Stuart Henderson
This definitely wants testing on Ryzen ThinkPads (e.g. E485/E585/X395/T495s) or Inspiron 5505, I see user TSC disabled on a lot of those in dmesglog. On 2022/01/27 10:28, Scott Cheloha wrote: > Hi, > > sthen@ complained recently about a multisocket system not being able > to use the TSC in

Re: amd64: simplify TSC sync testing

2022-02-02 Thread Scott Cheloha
> On Feb 2, 2022, at 13:29, Stuart Henderson wrote: > > Thanks for testing. > >> On 2022/02/02 13:51, Dave Voutila wrote: >> >> Jason McIntyre writes: >> >>> On Wed, Feb 02, 2022 at 04:52:40PM +, Stuart Henderson wrote: This definitely wants testing on Ryzen ThinkPads (e.g.

Re: Use installboot(8) in install.md of riscv64

2022-02-02 Thread Miod Vallat
> Index: usr.sbin/installboot/armv7_installboot.c > === > RCS file: src/usr.sbin/installboot/armv7_installboot.c,v > retrieving revision 1.11 > diff -u -p -r1.11 armv7_installboot.c > --- usr.sbin/installboot/armv7_installboot.c 20

Re: amd64: simplify TSC sync testing

2022-02-02 Thread Dave Voutila
Jason McIntyre writes: > On Wed, Feb 02, 2022 at 04:52:40PM +, Stuart Henderson wrote: >> This definitely wants testing on Ryzen ThinkPads (e.g. E485/E585/X395/T495s) >> or Inspiron 5505, I see user TSC disabled on a lot of those in dmesglog. >> >> > > hi. > > here are the results from a

Re: amd64: simplify TSC sync testing

2022-02-02 Thread Stuart Henderson
Thanks for testing. On 2022/02/02 13:51, Dave Voutila wrote: > > Jason McIntyre writes: > > > On Wed, Feb 02, 2022 at 04:52:40PM +, Stuart Henderson wrote: > >> This definitely wants testing on Ryzen ThinkPads (e.g. > >> E485/E585/X395/T495s) > >> or Inspiron 5505, I see user TSC disabled

Re: Use installboot(8) in install.md of riscv64

2022-02-02 Thread Theo de Raadt
Miod Vallat wrote: > > Index: usr.sbin/installboot/armv7_installboot.c > > === > > RCS file: src/usr.sbin/installboot/armv7_installboot.c,v > > retrieving revision 1.11 > > diff -u -p -r1.11 armv7_installboot.c > > ---

m_pullup alingment crash armv7 sparc64

2022-02-02 Thread Alexander Bluhm
Hi, With the new m_pullup() code, I see crashes on armv7 and sparc64. regress/sbin/slaacd sends some IPv6 ND6 packets over pair(4) from scapy. It crashes after m_pullup() in ipv6_check(). run-parse-ra ifconfig pair1 destroy 2>/dev/null || true ifconfig pair2 destroy 2>/dev/null ||

Re: amd64: simplify TSC sync testing

2022-02-02 Thread Dave Voutila
Stuart Henderson writes: > Thanks for testing. > > On 2022/02/02 13:51, Dave Voutila wrote: >> >> Jason McIntyre writes: >> >> > On Wed, Feb 02, 2022 at 04:52:40PM +, Stuart Henderson wrote: >> >> This definitely wants testing on Ryzen ThinkPads (e.g. >> >> E485/E585/X395/T495s) >> >> or

if_wg: Missing DPRINTF newline

2022-02-02 Thread Matthew Martin
Two DPRINTFs in sys/net/if_wg.c are missing a newline. diff --git if_wg.c if_wg.c index 13c48f42c54..a3efd577dbc 100644 --- if_wg.c +++ if_wg.c @@ -2156,7 +2156,7 @@ wg_output(struct ifnet *ifp, struct mbuf *m, struct sockaddr *sa, } if (m->m_pkthdr.ph_loopcnt++ > M_MAXLOOP) {

Re: if_wg: Missing DPRINTF newline

2022-02-02 Thread Jason McIntyre
On Wed, Feb 02, 2022 at 07:46:39PM -0600, Matthew Martin wrote: > Two DPRINTFs in sys/net/if_wg.c are missing a newline. > if this is committed, the committer may also want to question the dodgy capitals in "Delay Unsupported". jmc > > diff --git if_wg.c if_wg.c > index

Re: amd64: simplify TSC sync testing

2022-02-02 Thread Mohamed Aslan
Hello, I can confirm the same behaviour with this patch applied. $ sysctl kern.timecounter kern.timecounter.tick=1 kern.timecounter.timestepwarnings=0 kern.timecounter.hardware=i8254 kern.timecounter.choice=i8254(0) tsc(-1000) acpihpet0(1000) acpitimer0(1000) $ sysctl hw hw.machine=amd64