apm -m means one of two things now

With the recent change to apm -m, reporting either the battery lifetime or the estimated time to charge (thank you), the manpage seems to have been left behind. While here, tweak some of the wording: - "in minutes" or "in percent" is not parenthetical; say it explicitly - surely -a displays the

Re: unlock mmap(2) for anonymous mappings

On Mon, Feb 07, 2022 at 02:12:52PM +0100, Mark Kettenis wrote: > > Date: Mon, 7 Feb 2022 12:11:42 + > > From: Klemens Nanni > > > > On Mon, Feb 07, 2022 at 12:41:27PM +0100, Mark Kettenis wrote: > > > So there is the existing UVM_MAP_REQ_WRITE(). Compared to > > > vm_map_assert_wrlock()

Re: rpki-client: plug leak in http_parse_header()

On Thu, Feb 10, 2022 at 08:44:08AM +0100, Theo Buehler wrote: > On Thu, Feb 10, 2022 at 07:51:45AM +0100, Theo Buehler wrote: > > At this point conn->last_modified may or may not be allocated. > > If it is, overriting it will leak 30 bytes. > > rrdp_input_handler() has a leak of the same kind. >

Re: fw_update(8): lock pkg database while running

On 2022/02/10 08:42, Marc Espie wrote: > On Wed, Feb 09, 2022 at 07:30:46PM -0800, Andrew Hewus Fresh wrote: > > I was reminded that fw_update(8) updates the package database without > > locking currently. That can cause issues when running it concurrently > > with pkg_add, for example starting

Re: rpki-client: plug leak in http_parse_header()

On Thu, Feb 10, 2022 at 11:45:06AM +0100, Theo Buehler wrote: > > > Index: rrdp.c > > > === > > > RCS file: /cvs/src/usr.sbin/rpki-client/rrdp.c,v > > > retrieving revision 1.21 > > > diff -u -p -r1.21 rrdp.c > > > --- rrdp.c

Re: rpki-client: disk space warning on btrfs

On Thu, Feb 10, 2022 at 09:13:25AM +0100, Theo Buehler wrote: > This is purely cosmetic. I did some testing on fedora which ships with > btrfs by default. btrfs is special in that df -i and other tools always > report 0 inodes. As a consequence, each rpki-client run prints the disk > space

rpki-client print crl data

This adds the needed bits to print CRL files. Using ASN1_INTEGER_get() is probably bad at least I think there is the possibility the serial number wont fit in the long. I hope tb@ has a better solution :) I created x509_get_time() to streamline the ASN1_TIME to time_t conversion and replaced a

Re: fw_update(8): lock pkg database while running

On 2022/02/09 19:30, Andrew Hewus Fresh wrote: > I was reminded that fw_update(8) updates the package database without > locking currently. That can cause issues when running it concurrently > with pkg_add, for example starting `pkg_add -u` in one terminal and > `sysupgrade` in another. > > This

Re: rpki-client: plug leak in http_parse_header()

> > Index: rrdp.c > > === > > RCS file: /cvs/src/usr.sbin/rpki-client/rrdp.c,v > > retrieving revision 1.21 > > diff -u -p -r1.21 rrdp.c > > --- rrdp.c 23 Jan 2022 12:09:24 - 1.21 > > +++ rrdp.c 10 Feb 2022 07:41:54 - >

Re: unlock mmap(2) for anonymous mappings

> Date: Thu, 10 Feb 2022 10:19:20 + > From: Klemens Nanni > > On Mon, Feb 07, 2022 at 02:12:52PM +0100, Mark Kettenis wrote: > > > Date: Mon, 7 Feb 2022 12:11:42 + > > > From: Klemens Nanni > > > > > > On Mon, Feb 07, 2022 at 12:41:27PM +0100, Mark Kettenis wrote: > > > > > So there

Re: rpki-client print crl data

On Thu, Feb 10, 2022 at 03:02:15PM +0100, Claudio Jeker wrote: > This adds the needed bits to print CRL files. > Using ASN1_INTEGER_get() is probably bad at least I think there is the > possibility the serial number wont fit in the long. I hope tb@ has a > better solution :) According to RFC

Re: rpki-client print crl data

On Thu, Feb 10, 2022 at 04:09:40PM +0100, Theo Buehler wrote: > On Thu, Feb 10, 2022 at 03:02:15PM +0100, Claudio Jeker wrote: > > This adds the needed bits to print CRL files. > > Using ASN1_INTEGER_get() is probably bad at least I think there is the > > possibility the serial number wont fit in

Re: rpki-client: disk space warning on btrfs

On Thu, 10 Feb 2022 09:13:25 +0100, Theo Buehler wrote: > This is purely cosmetic. I did some testing on fedora which ships with > btrfs by default. btrfs is special in that df -i and other tools always > report 0 inodes. As a consequence, each rpki-client run prints the disk > space warning,

Re: rpki-client print crl data

On Thu, Feb 10, 2022 at 04:20:40PM +0100, Claudio Jeker wrote: > On Thu, Feb 10, 2022 at 04:09:40PM +0100, Theo Buehler wrote: > > On Thu, Feb 10, 2022 at 03:02:15PM +0100, Claudio Jeker wrote: > > > This adds the needed bits to print CRL files. > > > Using ASN1_INTEGER_get() is probably bad at

Re: more MAKEDEV cleanup

On 05/04/21(Mon) 09:25, Miod Vallat wrote: > The following diff attempts to clean up a few loose ends in the current > MAKEDEV files: > > - remove no-longer applicable device definitions (MSCP and SMD disks, > this kind of thing). > - makes sure all platforms use the same `ramdisk' target for >

Re: rewritten vxlan(4)

On Fri, Mar 05, 2021 at 05:09:29PM +1000, David Gwynne wrote: > On Thu, Mar 04, 2021 at 03:36:19PM +1000, David Gwynne wrote: > > as the subject says, this is a rewrite of vxlan(4). > > > > vxlan(4) relies on bridge(4) to implement learning, but i want to be > > able to remove bridge(4) one day.

adding MIME type for XSLT

XSLT is a well-established XML-based language for stylesheets. It has been around since the late 90s; the most recent version was finalized in 2017 (see https://www.w3.org/TR/xslt-30/). The mime.types file bundled with OpenBSD 7.0 -- typically used with httpd -- doesn't include this common

superfluous words in lib/libc/gen/statvfs.3 and sys/sys/statvfs.h

Hello, there seem to be some superfluous words in lib/libc/gen/statvfs.3 and sys/sys/statvfs.h . "(unit f_frsize)" can be removed since in the man page it is explicitely mentioned directly below: " The fields of type fsblkcnt_t are reported in units of f_frsize. " For sys/sys/statvs.h I left them

Re: more MAKEDEV cleanup

> What happened to this? I need to split this into orthogonal diffs, and also since this will expose an issue in makefs(8), I need to polish and send a fix for makefs first...

Re: wskbd_set_mixervolume

On Wed, Feb 09, 2022 at 09:13:58AM +0100, Alexandre Ratchov wrote: > On Tue, Feb 08, 2022 at 06:59:39PM +0100, Anton Lindqvist wrote: > > On Tue, Feb 08, 2022 at 07:32:38AM +0100, Alexandre Ratchov wrote: > > > On Mon, Feb 07, 2022 at 06:55:21PM +0100, Anton Lindqvist wrote: > > > > On Mon, Feb

yacc(1): skeleton.c: remove outdated comment

Hi yysccsid was removed in 1.30 back in 2009. Best, Martin Index: skeleton.c === RCS file: /cvs/src/usr.bin/yacc/skeleton.c,v retrieving revision 1.40 diff -u -p -r1.40 skeleton.c --- skeleton.c 3 Feb 2021 01:10:10 -

Unlock getsockname(2) syscall

For inet and UNIX sockets it fills passed 'sockaddr' structure with socket's address. For key management and route domain sockets it just returns error. ok? Index: sys/kern/syscalls.master === RCS file:

Re: rpki-client: check crl validity times

On Wed, Feb 09, 2022 at 08:14:55PM +0100, Claudio Jeker wrote: > On Wed, Feb 09, 2022 at 02:59:41PM +0100, Theo Buehler wrote: > > We should not use CRLs if now isn't between thisUpdate and nextUpdate. > > This also ensures that thisUpdate <= nextUpdate. While the verifier will > > catch all this,

rpki-client: disk space warning on btrfs

This is purely cosmetic. I did some testing on fedora which ships with btrfs by default. btrfs is special in that df -i and other tools always report 0 inodes. As a consequence, each rpki-client run prints the disk space warning, which seems a bit silly. Should we special case the 0 inodes case?