Re: rpki-client: TZ=UTC + localtime -> gmtime?

2022-04-22 Thread Claudio Jeker
On Fri, Apr 22, 2022 at 12:28:21AM +0200, Sebastian Benoit wrote: > Claudio Jeker(cje...@diehard.n-r-g.com) on 2022.04.20 15:12:57 +0200: > > On Wed, Apr 20, 2022 at 03:00:15PM +0200, Theo Buehler wrote: > > > Found this when looking at the timezone issue a couple of weeks back and > > > then

Re: [External] : Re: Provide memory barriers in refcnt_rele() and refcnt_finalize()

2022-04-22 Thread Alexandr Nedvedicky
Hello, I must admit I'm still kind of lost here. The email from kettenis@ with comment from linux helped a bit, but still my understanding is really blurry here. Let me share my view on the recent example from visa@. > > > > Above, thread A would need a barrier before the release. Otherwise >

kstats for re(4)

2022-04-22 Thread David Gwynne
re(4) hardware has some useful counters that are worth looking at: dlg@router ~$ kstat re-stats re0:0:re-stats:0 TxOk: 12697 packets RxOk: 22919 packets TxEr: 0 packets RxEr: 0 packets MissPkt: 0 packets FAE: 8371 packets

OpenBSD Errata: April 22, 2022 (wifi)

2022-04-22 Thread Alexander Bluhm
Errata patch for wireless drivers in the kernel has been released for OpenBSD 7.1. Binary updates for the amd64, i386 and arm64 platform are available via the syspatch utility. Source code patches can be found on the respective errata page: https://www.openbsd.org/errata71.html

Re: obscure vi crash, fix

2022-04-22 Thread Theo Buehler
On Fri, Apr 22, 2022 at 09:26:39AM -0600, Todd C. Miller wrote: > Another thing I noticed while testing the fix is that in cl_term_init() > while processing the command mapping there is a missing NULL check. > However, the check _is_ present for the input mapping loop. The > following diff makes

vi: apply expandtab to the output of a ! command

2022-04-22 Thread Todd C . Miller
[I originally sent this a year ago but didn't follow up.] This is consistent with vim's expandtab behavior. >From nvi2 (Craig Leres): https://github.com/lichray/nvi2/commit/7d3f43559026e0927032a105b217850feaefec66 I know most of us don't use expandtab but it is helpful when dealing with a

Re: rpki-client: TZ=UTC + localtime -> gmtime?

2022-04-22 Thread Mark Kettenis
> Date: Fri, 22 Apr 2022 00:28:21 +0200 > From: Sebastian Benoit > > Claudio Jeker(cje...@diehard.n-r-g.com) on 2022.04.20 15:12:57 +0200: > > On Wed, Apr 20, 2022 at 03:00:15PM +0200, Theo Buehler wrote: > > > Found this when looking at the timezone issue a couple of weeks back and > > > then

Re: obscure vi crash, fix

2022-04-22 Thread Todd C . Miller
Another thing I noticed while testing the fix is that in cl_term_init() while processing the command mapping there is a missing NULL check. However, the check _is_ present for the input mapping loop. The following diff makes the two loops consistent. I'm not sure whether this is worth doing

add sendmmsg and recvmmsg systemcalls

2022-04-22 Thread Moritz Buhl
Hi tech@, I implemented the sendmmsg and recvmmsg system calls by copying the NetBSD implementation and adjusting it. The idea behind the mmsg system calls is to do less systemcalls per msghdr and thus improving throughput. This should allow faster processing of packages (UDP, raw IP) in

Re: pf igmp icmp6 multicast router alert

2022-04-22 Thread Theo de Raadt
Florian Obser wrote: > That's my gut feeling as well. But I don't have any hard evidence that > that is actually correct. However, since we learned that router-alert is > an actual problem it is also a good incremental step. How many years did it take to notice this bug? Surely this was

Re: vi: apply expandtab to the output of a ! command

2022-04-22 Thread Theo Buehler
On Fri, Apr 22, 2022 at 09:30:39AM -0600, Todd C. Miller wrote: > [I originally sent this a year ago but didn't follow up.] > > This is consistent with vim's expandtab behavior. ok tb

Re: obscure vi crash, fix

2022-04-22 Thread Todd C . Miller
On Fri, 22 Apr 2022 17:38:56 +0200, Theo Buehler wrote: > I would use an extra variable. The simplification alone is a good > argument to do it: Yes, that is nicer. OK millert@ - todd

Re: pf igmp icmp6 multicast router alert

2022-04-22 Thread Alexander Bluhm
On Thu, Apr 21, 2022 at 09:10:02PM +0200, Alexander Bluhm wrote: > The option I have ever seen in the wild is router alert. So it may > be better to allow IGMP and ICMP6 multicast if router alert is the > only option in the packet. This diff implements exactly that. I have only compile tested

Re: [External] : Re: pf igmp icmp6 multicast router alert

2022-04-22 Thread Alexandr Nedvedicky
Hello, Looks like time has come to tweak a tuning knob from paranoia towards 'get network working' I have just few nits, see below. thanks and regards sashan > > int > +pf_walk_option(struct pf_pdesc *pd, struct ip *h, int off, int end, > +u_short *reason) > +{ > + uint8_t type,

Re: UPDATE: xterm 372

2022-04-22 Thread Matthieu Herrb
On Sun, Mar 27, 2022 at 10:54:43AM +0200, Matthieu Herrb wrote: > Hi, > > the patch below updates xterm to version 372. Please test, especially > if you use or depend on less common features, and report any issues. > Note that the new status line code is not enabled in Xenocara. > > to apply: >

Compare pointer value with NULL in openssl(1) pkcs12

2022-04-22 Thread Kinichiro Inoguchi
I would like to do some clean up for openssl(1) pkcs12. This diff changes pointer value checking to explicit comparison with NULL, and no functional changes here. This works fine for me on my local pc. ok? Index: pkcs12.c === RCS

Re: errata70.html - update the 7.1 link

2022-04-22 Thread Otto Moerbeek
On Fri, Apr 22, 2022 at 07:22:18PM -0400, Horia Racoviceanu wrote: > - change 7.1 link from errata70.html to errata71.html > Index: errata70.html > === > RCS file: /cvs/www/errata70.html,v > retrieving revision 1.25 > diff -u -p