Re: pluart(4): fifo support

2022-04-30 Thread Anton Lindqvist
On Sun, Mar 13, 2022 at 04:17:07PM +0100, Mark Kettenis wrote: > > Date: Fri, 11 Mar 2022 07:53:13 +0100 > > From: Anton Lindqvist > > > > On Tue, Mar 08, 2022 at 01:44:47PM +, Visa Hankala wrote: > > > On Tue, Mar 08, 2022 at 08:04:36AM +0100, Anton Lindqvist wrote: > > > > On Mon, Mar 07,

dhcpleased(8): be more lenient with host name and domain name options

2022-04-30 Thread Florian Obser
As found by n18fuhtm AT tutanota.com there are dhcp servers that send a domain name option with length 1 and a single \0. We strip trailing \0 and then end up with length 0. This is a protocol violation, the minimum length for domain name option is 1, and we ignore the lease. So we are not going

install btrace scripts

2022-04-30 Thread Alexander Bluhm
Hi, Can we install the btrace scripts to /usr/share/btrace/ ? The directory already exists, only the Makefile is not linked to the build. And I would like to use #! to make them executable. ok? bluhm Index: share/Makefile ===

Re: EVFILT_USER and kevent(2)

2022-04-30 Thread Ted Unangst
On 2022-04-30, Visa Hankala wrote: > I am in two minds about EVFILT_USER. On the one hand, having it on > OpenBSD might help with ports. On the other hand, it makes the kernel > perform a task that userspace can already handle using existing > interfaces. I agree you could do this with just a

Re: EVFILT_USER and kevent(2)

2022-04-30 Thread Joerg Sonnenberger
Am Sat, Apr 30, 2022 at 10:05:05PM +0100 schrieb Stuart Henderson: > On 2022/04/30 13:51, Visa Hankala wrote: > > I am in two minds about EVFILT_USER. On the one hand, having it on > > OpenBSD might help with ports. > > No opinion on the addition, but I don't think we ran into this in ports > so

Re: pluart(4): fifo support

2022-04-30 Thread Mark Kettenis
> Date: Sat, 30 Apr 2022 09:40:24 +0200 > From: Anton Lindqvist > > On Sun, Mar 13, 2022 at 04:17:07PM +0100, Mark Kettenis wrote: > > > Date: Fri, 11 Mar 2022 07:53:13 +0100 > > > From: Anton Lindqvist > > > > > > On Tue, Mar 08, 2022 at 01:44:47PM +, Visa Hankala wrote: > > > > On Tue,

Re: install btrace scripts

2022-04-30 Thread Ted Unangst
On 2022-04-30, Alexander Bluhm wrote: > Hi, > > Can we install the btrace scripts to /usr/share/btrace/ ? The > directory already exists, only the Makefile is not linked to the > build. > > And I would like to use #! to make them executable. It's weird to have exec files in share? I think

Re: ssh-keygen(1): resident fido2 keys

2022-04-30 Thread Florian Obser
On 2022-04-29 19:24 +01, Jason McIntyre wrote: > what we probably want is a simple overview of these devices in > DESCRIPTION. but that's not simple. the page is already a bruiser. i > mean, it discusses what constitues a good password/phrase! where to go > from there? > > i note that the other

EVFILT_USER and kevent(2)

2022-04-30 Thread Visa Hankala
It has been asked in the past if OpenBSD's kevent(2) should implement user event filters, also known as EVFILT_USER. This filter type originates from FreeBSD but is now available also on DragonFly BSD, NetBSD, and macOS. Below is an implementation of EVFILT_USER. The logic should be fairly

Re: install btrace scripts

2022-04-30 Thread Theo de Raadt
>On 2022-04-30, Alexander Bluhm wrote: >> Hi, >> >> Can we install the btrace scripts to /usr/share/btrace/ ? The >> directory already exists, only the Makefile is not linked to the >> build. >> >> And I would like to use #! to make them executable. > >It's weird to have exec files in share?

Re: EVFILT_USER and kevent(2)

2022-04-30 Thread Stuart Henderson
On 2022/04/30 13:51, Visa Hankala wrote: > I am in two minds about EVFILT_USER. On the one hand, having it on > OpenBSD might help with ports. No opinion on the addition, but I don't think we ran into this in ports so far. There is software in ports which can use it but it can all work without

Re: install btrace scripts

2022-04-30 Thread Alexander Bluhm
On Sat, Apr 30, 2022 at 02:03:28PM -0600, Theo de Raadt wrote: > >On 2022-04-30, Alexander Bluhm wrote: > >> Hi, > >> > >> Can we install the btrace scripts to /usr/share/btrace/ ? The > >> directory already exists, only the Makefile is not linked to the > >> build. > >> > >> And I would like

Re: Potential NULL dereference id_entry

2022-04-30 Thread Jonathan Gray
On Sat, Apr 30, 2022 at 07:54:12PM -0600, Ted Bullock wrote: > in radeondrm_attach_kms:508 could potentially fail and result in a NULL > dereference at line 510. Check this with KASSERT(). This can not happen. drm_pciprobe() uses drm_find_description() if it returned NULL the driver would not

remove duplicate fbnode declaration for sparc64

2022-04-30 Thread Ted Bullock
In sys/dev/pci/radeon/radeon_kms.c:505 The *fbnode* variable is defined for sparc64 and macppc, this is is a redefine on sparc64, as it is already defined at sys/arch/sparc64/include/fbvar.h:71 fbnode is an OFW artifact for the default framebuffer pci device. This variable is global on sparc64

Potential NULL dereference id_entry

2022-04-30 Thread Ted Bullock
in radeondrm_attach_kms:508 could potentially fail and result in a NULL dereference at line 510. Check this with KASSERT(). diff 5fbcee9a5968b225053e9e1b0363430e36326626 /usr/src blob - 94f38e8769827e9c649147689a9ca6f889d1464f file + sys/dev/pci/drm/radeon/radeon_kms.c ---

no gawking in makesyscalls

2022-04-30 Thread Ted Unangst
I don't think we need to concern ourselves with cross awk compatibility here. Despite the misleading comment, /usr/bin/awk supports toupper. Index: makesyscalls.sh === RCS file: /home/cvs/src/sys/kern/makesyscalls.sh,v retrieving