Re: ahci at fdt where the firmware doesnt help

2023-04-07 Thread Mark Kettenis
> Date: Fri, 7 Apr 2023 07:58:02 +1000 > From: David Gwynne > > the banana pi r2 pro has a usable sata port, but ahci wasnt finding > anything attached to it. > > the fdt glue looked like it assumed the boot loader did a lot of > work to get things going. however, i havent figured out how to >

Re: acpithinkpad: don't setup non-existent temp sensors

2023-04-07 Thread Klemens Nanni
05.04.2023 03:45, joshua stein пишет: > acpithinkpad sets up a hard-coded number of temperature sensors and > doesn't check the result of aml_evalinteger when polling, so for all > invalid sensors it ends up reporting the value of the previous > successful sensor check resulting in this (for a

OF_getpropstr()

2023-04-07 Thread David Gwynne
turns out OF_getprop is like memcpy, but sometimes you want something like strlcpy. this is what OF_getpropstr aims to provide. i know openfirm.h is used on other archs that don't use fdt as their backend, but i figure we can port this wrapper over to them as need demands. ok? Index: fdt.c

Re: cleanup vmm_start_vm, simplifying fd cleanup

2023-04-07 Thread Mike Larkin
On Fri, Apr 07, 2023 at 12:07:07PM -0400, Dave Voutila wrote: > > Dave Voutila writes: > > > In vmd, the vmm process forks to create the resulting vm process. After > > this fork, the vmm parent process closes all the file descriptors > > pointing to the vm's devices (cdrom, kernel, disks, nics,

Re: cleanup vmm_start_vm, simplifying fd cleanup

2023-04-07 Thread Dave Voutila
Dave Voutila writes: > In vmd, the vmm process forks to create the resulting vm process. After > this fork, the vmm parent process closes all the file descriptors > pointing to the vm's devices (cdrom, kernel, disks, nics, etc.). > > The logic was a bit funky, so this change relies on the fact

Re: use labels in the device tree to init interface descriptions

2023-04-07 Thread Claudio Jeker
On Fri, Apr 07, 2023 at 04:53:52PM +1000, David Gwynne wrote: > ethernet interfaces in device trees can have a "label" property which > is generally used (when it is used) to identify which connector it is on > the case or something like that. eg, eth2 in the turris omnia device > tree has 'label

use labels in the device tree to init interface descriptions

2023-04-07 Thread David Gwynne
ethernet interfaces in device trees can have a "label" property which is generally used (when it is used) to identify which connector it is on the case or something like that. eg, eth2 in the turris omnia device tree has 'label = "wan"' on the mvneta interface. ive been using labels in the dts

Re: MALLOC_STATS: dump internal state and leak info via utrace(2)

2023-04-07 Thread Otto Moerbeek
On Wed, Apr 05, 2023 at 10:54:19AM +0200, Otto Moerbeek wrote: > Hi, > > This is work in progress. I have to think if the flags to kdump I'm > introducing should be two or a single one. > > Currently, malloc.c can be compiled with MALLOC_STATS defined. If run > with option D it dumps its state

bgpd rib_get/rib_add change

2023-04-07 Thread Claudio Jeker
This diff switches rib_get and rib_add to work on struct pt_entry pointers and introduces rib_get_addr() which works like rib_get before. I want to use rib_get and rib_add in the flowspec code. Long term I want to push struct pt_entry further out and closer to the NLRI handling in the input path

Re: use labels in the device tree to init interface descriptions

2023-04-07 Thread Theo de Raadt
Claudio Jeker wrote: > On Fri, Apr 07, 2023 at 04:53:52PM +1000, David Gwynne wrote: > > ethernet interfaces in device trees can have a "label" property which > > is generally used (when it is used) to identify which connector it is on > > the case or something like that. eg, eth2 in the turris

Re: bgpd rib_get/rib_add change

2023-04-07 Thread Theo Buehler
On Fri, Apr 07, 2023 at 02:35:29PM +0200, Claudio Jeker wrote: > This diff switches rib_get and rib_add to work on struct pt_entry > pointers and introduces rib_get_addr() which works like rib_get before. > I want to use rib_get and rib_add in the flowspec code. ok tb

Re: use labels in the device tree to init interface descriptions

2023-04-07 Thread Mark Kettenis
> From: "Theo de Raadt" > Date: Fri, 07 Apr 2023 05:39:00 -0600 > > Claudio Jeker wrote: > > > On Fri, Apr 07, 2023 at 04:53:52PM +1000, David Gwynne wrote: > > > ethernet interfaces in device trees can have a "label" property which > > > is generally used (when it is used) to identify which

Re: arp input remove kernel lock

2023-04-07 Thread Hrvoje Popovski
On 6.4.2023. 22:46, Alexander Bluhm wrote: > Hi, > > When removing these kernel locks from the ARP input path, the machine > runs stable in my tests. Caller if_netisr() grabs the exclusive > netlock and that should be sufficent for in_arpinput() and arpcache(). > > To stress the ARP resolver I

cleanup vmm_start_vm, simplifying fd cleanup

2023-04-07 Thread Dave Voutila
In vmd, the vmm process forks to create the resulting vm process. After this fork, the vmm parent process closes all the file descriptors pointing to the vm's devices (cdrom, kernel, disks, nics, etc.). The logic was a bit funky, so this change relies on the fact we can attempt the close(2) call

Re: cleanup vmm_start_vm, simplifying fd cleanup

2023-04-07 Thread Florian Obser
On 2023-04-07 10:51 -04, Dave Voutila wrote: > In vmd, the vmm process forks to create the resulting vm process. After > this fork, the vmm parent process closes all the file descriptors > pointing to the vm's devices (cdrom, kernel, disks, nics, etc.). > > The logic was a bit funky, so this

Re: cleanup vmm_start_vm, simplifying fd cleanup

2023-04-07 Thread Theo de Raadt
Florian Obser wrote: > On 2023-04-07 10:51 -04, Dave Voutila wrote: > > In vmd, the vmm process forks to create the resulting vm process. After > > this fork, the vmm parent process closes all the file descriptors > > pointing to the vm's devices (cdrom, kernel, disks, nics, etc.). > > > > The

Re: cleanup vmm_start_vm, simplifying fd cleanup

2023-04-07 Thread Dave Voutila
"Theo de Raadt" writes: > Florian Obser wrote: > >> On 2023-04-07 10:51 -04, Dave Voutila wrote: >> > In vmd, the vmm process forks to create the resulting vm process. After >> > this fork, the vmm parent process closes all the file descriptors >> > pointing to the vm's devices (cdrom,