Add another Lenovo NVMe device id

2023-04-27 Thread Kevin Lo
Found in my x1 extreme gen 1: nvme0 at pci4 dev 0 function 0 vendor "Lenovo", unknown product 0x0006 rev 0x00: msix, NVMe 1.2 ok? Index: sys/dev/pci/pcidevs === RCS file: /cvs/src/sys/dev/pci/pcidevs,v retrieving revision 1.2032

Re: mg: rework adjustname() and drop expandtilde()

2023-04-27 Thread Omar Polo
Please disregard for now; this introduces an issue since in main() paths are resolved from the working directory of the current buffer so `mg foo/bar' works (i.e. opens $PWD/foo/bar) but `mg foo/bar foo/baz' doesn't since it first opens $PWD/foo/bar and then foo/baz relatively to it, i.e.

arm64 install.md: fix softraid crypto installation on Mac

2023-04-27 Thread Caspar Schutijser
I was trying to install OpenBSD on the arm64 MacBook Air with softraid crypto (that's the "Encrypt the root disk?" question in the installer). Right now that does not work out of the box. In a regular install, md_prep_fdisk is careful and leaves the EFI Sys partition alone with the "if disk_has

Re: Remove kernel lock from rtfree(9)

2023-04-27 Thread Vitaliy Makkoveev
> On 27 Apr 2023, at 15:16, Alexander Bluhm wrote: > > On Wed, Apr 26, 2023 at 11:17:37PM +0300, Vitaliy Makkoveev wrote: >> Route timers and route labels protected by corresponding mutexes. `ifa' >> uses references counting for protection. No protection required for `rt' >> passed to

Re: Remove kernel lock from rtfree(9)

2023-04-27 Thread Klemens Nanni
On Thu, Apr 27, 2023 at 03:22:10PM +0300, Vitaliy Makkoveev wrote: > > On 27 Apr 2023, at 15:16, Alexander Bluhm wrote: > > > > On Wed, Apr 26, 2023 at 11:17:37PM +0300, Vitaliy Makkoveev wrote: > >> Route timers and route labels protected by corresponding mutexes. `ifa' > >> uses references

Re: Remove kernel lock from rtfree(9)

2023-04-27 Thread Alexander Bluhm
On Thu, Apr 27, 2023 at 03:47:40PM +0300, Vitaliy Makkoveev wrote: > > > > On 27 Apr 2023, at 15:40, Alexander Bluhm wrote: > > > > On Thu, Apr 27, 2023 at 03:22:10PM +0300, Vitaliy Makkoveev wrote: > >>> On 27 Apr 2023, at 15:16, Alexander Bluhm wrote: > >>> > >>> On Wed, Apr 26, 2023 at

apmd: zap dead cancel code

2023-04-27 Thread Klemens Nanni
#if 0 since import, APM_CANCEL does not appear anywhere else. OK? Index: apmd.c === RCS file: /cvs/src/usr.sbin/apmd/apmd.c,v retrieving revision 1.111 diff -u -p -r1.111 apmd.c --- apmd.c 8 Mar 2023 04:43:13 - 1.111

Re: Remove kernel lock from rtfree(9)

2023-04-27 Thread Alexander Bluhm
On Thu, Apr 27, 2023 at 03:22:10PM +0300, Vitaliy Makkoveev wrote: > > On 27 Apr 2023, at 15:16, Alexander Bluhm wrote: > > > > On Wed, Apr 26, 2023 at 11:17:37PM +0300, Vitaliy Makkoveev wrote: > >> Route timers and route labels protected by corresponding mutexes. `ifa' > >> uses references

Re: fill_file(): use solock_shared() to protect socket data

2023-04-27 Thread Claudio Jeker
On Thu, Apr 27, 2023 at 01:55:33PM +0300, Vitaliy Makkoveev wrote: > Now only direct netlock used for inet sockets protection. The unlocked > access to all other sockets is safe, but we could lost consistency for a > little. Since the solock() used for sockets protection, make locking > path

changlist: add apmd(8) hooks

2023-04-27 Thread Klemens Nanni
Would be nice to record changes to critical scripts run on state changes and have modifications recorded through security(8). Feedback? Objection? OK? Index: changelist === RCS file: /cvs/src/etc/changelist,v retrieving revision

Re: Remove kernel lock from rtfree(9)

2023-04-27 Thread Alexander Bluhm
On Wed, Apr 26, 2023 at 11:17:37PM +0300, Vitaliy Makkoveev wrote: > Route timers and route labels protected by corresponding mutexes. `ifa' > uses references counting for protection. No protection required for `rt' > passed to rt_mpls_clear() because only current thread owns it. > > ok? I have

Re: fill_file(): use solock_shared() to protect socket data

2023-04-27 Thread Alexander Bluhm
On Thu, Apr 27, 2023 at 02:54:38PM +0200, Claudio Jeker wrote: > On Thu, Apr 27, 2023 at 01:55:33PM +0300, Vitaliy Makkoveev wrote: > > Now only direct netlock used for inet sockets protection. The unlocked > > access to all other sockets is safe, but we could lost consistency for a > > little.

Re: fill_file(): use solock_shared() to protect socket data

2023-04-27 Thread Vitaliy Makkoveev
On Thu, Apr 27, 2023 at 02:54:38PM +0200, Claudio Jeker wrote: > On Thu, Apr 27, 2023 at 01:55:33PM +0300, Vitaliy Makkoveev wrote: > > Now only direct netlock used for inet sockets protection. The unlocked > > access to all other sockets is safe, but we could lost consistency for a > > little.

ws(4): swap saved x/y values if axes are swapped

2023-04-27 Thread bentley
If a touchscreen is rotated (Option "Rotate" "CW" in ws(4)), then when a finger slides purely horizontally or purely vertically across the screen, the cursor jumps to a *diagonal* line starting at the corner, as if x and y were equal. The problem manifests here, in wsReadInput(): if

malloc: less unlock/lock dancing

2023-04-27 Thread Otto Moerbeek
This was introduced to not stall other threads while mmap is called by a thread. But now that mmap is unlocked, I believe it is no longer useful. A full build is slighlty faster with this. But this also needs testing with you favorite multithreaded program. -Otto Index: stdlib/malloc.c

Re: urtwn: support new chip RTL8188FTV

2023-04-27 Thread Stefan Sperling
On Thu, Apr 27, 2023 at 01:38:04PM +0800, Kevin Lo wrote: > Hi, > > The diff below adds initial support for RTL8188FTV adapters. > RTL8188FTV is an 802.11b/g/n, 1T1R chipset. > The firmware file comes from Linux's rtl8188fufw.bin [1]. > > Tested with Comfast CF-WU710N v4 on amd64. > > Test

fill_file(): use solock_shared() to protect socket data

2023-04-27 Thread Vitaliy Makkoveev
Now only direct netlock used for inet sockets protection. The unlocked access to all other sockets is safe, but we could lost consistency for a little. Since the solock() used for sockets protection, make locking path common and use it. Make it shared because this is read-only access to sockets

Re: changlist: add apmd(8) hooks

2023-04-27 Thread Klemens Nanni
On Thu, Apr 27, 2023 at 10:53:03AM +, Klemens Nanni wrote: > Would be nice to record changes to critical scripts run on state changes > and have modifications recorded through security(8). > > Feedback? Objection? OK? This gets ugly if you use binary files instead of scripts, so we'd either

Re: arm64 install.md: fix softraid crypto installation on Mac

2023-04-27 Thread Klemens Nanni
Another approach would be to make installboot(8) -p to retain existing EFI Sys partitions instead of always recreating them. This way, it was nothing to do with softraid, but installing on machines like Apple arm64 depends on existing non-OpenBSD partitions and files on them. We hacked

Re: Remove kernel lock from rtfree(9)

2023-04-27 Thread Vitaliy Makkoveev
> On 27 Apr 2023, at 15:40, Alexander Bluhm wrote: > > On Thu, Apr 27, 2023 at 03:22:10PM +0300, Vitaliy Makkoveev wrote: >>> On 27 Apr 2023, at 15:16, Alexander Bluhm wrote: >>> >>> On Wed, Apr 26, 2023 at 11:17:37PM +0300, Vitaliy Makkoveev wrote: Route timers and route labels

Re: arm64 install.md: fix softraid crypto installation on Mac

2023-04-27 Thread Mark Kettenis
> Op 27-04-2023 13:52 CEST schreef Klemens Nanni : > > > Another approach would be to make installboot(8) -p to retain existing > EFI Sys partitions instead of always recreating them. I don't think it is the job of installboot(8) to device whether the ESP should be retained or not. If you

Re: DIOCGETRULE is slow for large rulesets (2/3)

2023-04-27 Thread Alexandr Nedvedicky
Hello, Hello, On Thu, Apr 27, 2023 at 10:41:53AM +1000, David Gwynne wrote: > > t could be NULL here. just do the unit check inside the loop? > > > > > if (t->pft_unit != unit) > > return (NULL); > > > > return (t); > > } > > > > just return NULL on unit

Re: Small diff for 73.html

2023-04-27 Thread Andras Farkas
Oops! Thank you for the explanation. On Thu, Apr 27, 2023 at 3:37 PM Jonathan Gray wrote: > > On Thu, Apr 27, 2023 at 03:24:06PM -0900, Andras Farkas wrote: > > Small diff for 73.html: fixes incorrect link to amdgpu man page. > > amdgpu(4) is the xorg driver, it is intentionally drm.4 > > > > >

Re: Small diff for 73.html

2023-04-27 Thread Jonathan Gray
On Thu, Apr 27, 2023 at 03:24:06PM -0900, Andras Farkas wrote: > Small diff for 73.html: fixes incorrect link to amdgpu man page. amdgpu(4) is the xorg driver, it is intentionally drm.4 > > SHA512 (73diff) = >

Re: OpenBSD 7.2 on Oracle Cloud

2023-04-27 Thread Aaron Mason
On Tue, Apr 25, 2023 at 10:53 PM Aaron Mason wrote: > > On Mon, Apr 24, 2023 at 3:47 PM Aaron Mason wrote: > > > > On Fri, Apr 21, 2023 at 2:50 PM Aaron Mason > > wrote: > > > > > > On Fri, Apr 21, 2023 at 1:39 PM Aaron Mason > > > wrote: > > > > > > > > On Fri, Apr 7, 2023 at 3:25 AM Antun

Small diff for 73.html

2023-04-27 Thread Andras Farkas
Small diff for 73.html: fixes incorrect link to amdgpu man page. SHA512 (73diff) = b3a2afb78744cddfaa148d1bfcd825af376dc4e168e12116e49f1f16614cdc108f001b8fd592eb884e7fcf6e342da527fb437dba991fc583fbc85ef9f98b85e3 Index: 73.html ===