Re: iked: introduce print_addr()

2023-06-13 Thread Claudio Jeker
On Tue, Jun 13, 2023 at 10:57:06AM +0200, Theo Buehler wrote: > There are a lot of print_host() calls that have an explicit cast and > pass NULL, 0 as second and third arguments. This is responsible for a > lot of awkward line wrapping. The exlicit casts can be avoided by > using a function with a

iked: introduce print_addr()

2023-06-13 Thread Theo Buehler
There are a lot of print_host() calls that have an explicit cast and pass NULL, 0 as second and third arguments. This is responsible for a lot of awkward line wrapping. The exlicit casts can be avoided by using a function with a void * argument. This is no less typesafe than having explicit casts.

Re: First step towards improved unlocking in the VFS layer.

2023-06-13 Thread Theo de Raadt
Thordur I. Bjornsson wrote: > On Mon, Jun 12, 2023 at 9:15 PM Bob Beck wrote: > > > > On Mon, Jun 12, 2023 at 11:01:18AM -0600, Theo de Raadt wrote: > > > + KASSERTMSG(1, "Ich Habe eine Rotweinflarsche in meinem Arsche"); > > > That part of the diff is not OK. If everyone did this, we

Re: all platforms, main(): call clockqueue_init() just before sched_init_cpu()

2023-06-13 Thread Mark Kettenis
> Date: Mon, 12 Jun 2023 19:09:59 -0500 > From: Scott Cheloha > > We need to initialize the per-CPU clockintr_queue struct before we can > call clockintr_establish() from sched_init_cpu(). > > Initialization is done with a call to clockqueue_init(). Currently we > call it during

Re: iked: introduce print_addr()

2023-06-13 Thread Tobias Heider
On Tue, Jun 13, 2023 at 10:57:06AM +0200, Theo Buehler wrote: > There are a lot of print_host() calls that have an explicit cast and > pass NULL, 0 as second and third arguments. This is responsible for a > lot of awkward line wrapping. The exlicit casts can be avoided by > using a function with a

Re: ix(4): allocate less memory for tx buffers

2023-06-13 Thread Alexander Bluhm
On Fri, Jun 09, 2023 at 08:10:22PM +0200, Jan Klemkow wrote: > On Fri, Jun 09, 2023 at 06:59:57PM +0200, Jan Klemkow wrote: > > On Fri, Jun 09, 2023 at 06:11:38PM +0200, Jan Klemkow wrote: > > > TSO packets are limited to MAXMCLBYTES (64k). Thus, we don't need to > > > allocate IXGBE_TSO_SIZE

Re: First step towards improved unlocking in the VFS layer.

2023-06-13 Thread Bob Beck
> On Jun 13, 2023, at 7:59 AM, Theo de Raadt wrote: > > Thordur I. Bjornsson wrote: > >> On Mon, Jun 12, 2023 at 9:15 PM Bob Beck wrote: >>> >>> On Mon, Jun 12, 2023 at 11:01:18AM -0600, Theo de Raadt wrote: + KASSERTMSG(1, "Ich Habe eine Rotweinflarsche in meinem Arsche");

csh(1), ksh(1), time(1): print durations with millisecond precision

2023-06-13 Thread Scott Cheloha
This patch bumps the precision of durations printed by csh(1), ksh(1), and time(1) from centiseconds to milliseconds. The csh(1) and ksh(1) builtins "time" and "times" are affected. My thinking is: - All practical OpenBSD platforms have a timecounter with at least millisecond precision. -