vmd(8): disambiguate logging for vm's and devices.

2023-09-23 Thread Dave Voutila
It annoys me how all the log messages from different vmd vm's blur together. Here is a diff that makes them distinguishable. It also fixes dynamic toggling of verbosity levels in virtio devices using `vmctl log`, and now preserves the verbosity across vm reboots. I chose the pattern "vm/ and

Re: vmd(8): disambiguate logging for vm's and devices.

2023-09-23 Thread Mischa
Hi Dave, I like it a lot! Mischa On 2023-09-23 19:50, Dave Voutila wrote: It annoys me how all the log messages from different vmd vm's blur together. Here is a diff that makes them distinguishable. It also fixes dynamic toggling of verbosity levels in virtio devices using `vmctl log`, and

Re: powerpc64 BOOT kernel question

2023-09-23 Thread Theo de Raadt
Mark Kettenis wrote: > > Date: Fri, 22 Sep 2023 23:19:30 + > > From: Klemens Nanni > > > > Does the tiny kexec kernel actually need network, bio(4) or HID devices? > > octeon/BOOT does not have any of this. > > Well, we do need the USB keyboard stuff to allow users to type at the >

Re: powerpc64 BOOT kernel question

2023-09-23 Thread Klemens Nanni
On Sat, Sep 23, 2023 at 09:55:03AM -0600, Theo de Raadt wrote: > Mark Kettenis wrote: > > > > Date: Fri, 22 Sep 2023 23:19:30 + > > > From: Klemens Nanni > > > > > > Does the tiny kexec kernel actually need network, bio(4) or HID devices? > > > octeon/BOOT does not have any of this. > > >

Re: Send international text with mail(1) proposal and patches]

2023-09-23 Thread Walter Alejandro Iglesias
> On Thu, Sep 21, 2023 at 02:12:50PM +0200, Stefan Sperling wrote: > > Your implementation lacks proper bounds checking. It accesses > > s[i + 3] based purely on the contents of the input string, without > > checking whether len < i + 3. Entering the while (i != len) loop with You surely meant

Re: prevent re-upgrade in powerpc64 boot loader

2023-09-23 Thread Klemens Nanni
On Sat, Sep 23, 2023 at 01:11:32PM +0200, Mark Kettenis wrote: > > Date: Thu, 21 Sep 2023 22:30:01 + > > From: Klemens Nanni > > > > In comparison to MI boot which only cares about /bsd.upgrade's x bit, > > powerpc64 rdboot just wants a regular file. > > > > Require and strip u+x before

rpki-client: pass talid to callers of cert_parse_ee_cert()

2023-09-23 Thread Theo Buehler
This is a boring mechanical diff that splits some of the noise out of a larger diff that Job will send out and explain in detail soon. In itself it changes nothing. For a given product we will need to know the originating TA for additional checks in cert_parse_ee_cert(). The callers of

Re: prevent re-upgrade in powerpc64 boot loader

2023-09-23 Thread Mark Kettenis
> Date: Thu, 21 Sep 2023 22:30:01 + > From: Klemens Nanni > > In comparison to MI boot which only cares about /bsd.upgrade's x bit, > powerpc64 rdboot just wants a regular file. > > Require and strip u+x before execution to prevent sysupgrade(8) loop. > I'm new to powerpc64 and can't think

vmt(4): use shared netlock to protect ifnet data within vmt_tclo_broadcastip()

2023-09-23 Thread Vitaliy Makkoveev
This makes ifnet protection consistent. Execute vmt_tclo_tick() timeout handler in process context to allow context switch within vmt_tclo_broadcastip(). Index: sys/dev/pv/vmt.c === RCS file: /cvs/src/sys/dev/pv/vmt.c,v retrieving

rpki-client: refactor sbgp_assysnum() and sbgp_ipaddrblk()

2023-09-23 Thread Theo Buehler
This is a second chunk split out of the diff mentioned in my previous mail. It factors the parsing of ASIdentifiers and IPAddrBlocks out of sbgp_assysnum() and sbgp_ipaddrblk() and makes the latter only extract the info from the X509_EXTENSION. This should not change anything, but the logic is a

Re: Send international text with mail(1) proposal and patches]

2023-09-23 Thread Crystal Kolipe
On Sat, Sep 23, 2023 at 12:10:41PM +0200, Walter Alejandro Iglesias wrote: > > On Thu, Sep 21, 2023 at 02:12:50PM +0200, Stefan Sperling wrote: > > > Your implementation lacks proper bounds checking. It accesses > > > s[i + 3] based purely on the contents of the input string, without > > >

Re: powerpc64 BOOT kernel question

2023-09-23 Thread Mark Kettenis
> Date: Fri, 22 Sep 2023 23:19:30 + > From: Klemens Nanni > > Does the tiny kexec kernel actually need network, bio(4) or HID devices? > octeon/BOOT does not have any of this. Well, we do need the USB keyboard stuff to allow users to type at the bootloader prompt no? The USB mouse is

hotplug(4): simplify buffer cleanup on device close

2023-09-23 Thread Vitaliy Makkoveev
`evqueue' is simple circular buffer. Its pretty enough to set head equal to tail to make it empty. Index: sys/dev/hotplug.c === RCS file: /cvs/src/sys/dev/hotplug.c,v retrieving revision 1.24 diff -u -p -r1.24 hotplug.c ---

Re: Send international text with mail(1) - proposal and patches

2023-09-23 Thread Walter Alejandro Iglesias
Hi Ingo, On Thu, Sep 21, 2023 at 03:04:24PM +0200, Ingo Schwarze wrote: > In general, the tool for checking the validity of UTF-8 strings > is a simple loop around mblen(3) if you want to report the precise > positions of errors found, or simply mbstowcs(3) with a NULL pwcs > argument if you are

vmd(8): fix deadlock during pausing

2023-09-23 Thread Dave Voutila
vmd has a sneaky little deadlock hidden in the pause logic related to the use of mutexes and condition variables. When pausing, the vcpu is holding the "run" mutex. It then sleeps waiting for the unpause condition. If the event thread is trying to assert an irq, it will try to lock that "run"