pf passes packet if limit reached

2023-10-10 Thread Alexander Bluhm
Hi, The behaviour of the PFRULE_SRCTRACK and max_states check was unintentionally changed by this commit. revision 1.964 date: 2016/01/25 18:49:57; author: sashan; state: Exp; lines: +18 -10; commitid: KeemoLxcm7FS1oYy; - plugging massive pf_state_key leak OK

bgpd: fix handling of non-transitive ext communities

2023-10-10 Thread Claudio Jeker
See https://github.com/openbgpd-portable/openbgpd-portable/issues/64 The handling of non-transitive ext communities causes encoding errors in for regular communities. The problem is that the start and end points of the loop are calculated like this: for (l = 0; l < comm->nentries; l++) {

Re: tcp syn cache unlock

2023-10-10 Thread Scott Cheloha
On Fri, Oct 06, 2023 at 03:41:39PM +0200, Alexander Bluhm wrote: > On Fri, Oct 06, 2023 at 03:47:31PM +0300, Vitaliy Makkoveev wrote: > > On Fri, Oct 06, 2023 at 02:14:52PM +0200, Alexander Bluhm wrote: > > > > @@ -718,11 +743,13 @@ softclock(void *arg) > > > >

Re: pf_pull_hdr useless action pointer and fragment logic

2023-10-10 Thread Alexandr Nedvedicky
Hello, On Mon, Oct 09, 2023 at 08:07:35PM +0200, Alexander Bluhm wrote: > Hi, > > pf_pull_hdr() allows to pass an action pointer parameter as output > value. This is never used, all callers pass a NULL argument. Remove > ACTION_SET() entirely. > > The logic if (fragoff >= len) in

malloc: more info in error message for write-after-free with option D

2023-10-10 Thread Otto Moerbeek
Hi, This diff adds better error reporting for write-after-free or the more general write of free memory if malloc option D is active. Knowing the place where allocations were done often helps to find out where the overwrite happened. If option D is active malloc now saves caller info in a

Re: CVS: cvs.openbsd.org: src

2023-10-10 Thread Stuart Henderson
On 2023/10/09 14:55, Todd C. Miller wrote: > CVSROOT: /cvs > Module name: src > Changes by: mill...@cvs.openbsd.org 2023/10/09 14:55:33 > > Modified files: > usr.sbin/smtpd : smtp_session.c > > Log message: > Add Message-Id as needed for messages received on the submission port. >

Re: mail(1) MIME support [PATCH]

2023-10-10 Thread Walter Alejandro Iglesias
Added random number to Message-ID to get more unique string. Index: cmd3.c === RCS file: /cvs/src/usr.bin/mail/cmd3.c,v retrieving revision 1.30 diff -u -p -r1.30 cmd3.c --- cmd3.c 8 Mar 2023 04:43:11 - 1.30 +++

Re: CVS: cvs.openbsd.org: src

2023-10-10 Thread Todd C . Miller
On Tue, 10 Oct 2023 10:14:10 -0700, Chris Cappuccio wrote: > The Message-ID should be added to any message that doesn't have one. > An existing Message-ID should not be removed or changed. > > The RFC says it "MAY be applied when necessary by an originating SMTP server" > so the port numbers

Re: tcp syn cache unlock

2023-10-10 Thread Vitaliy Makkoveev
On Tue, Oct 10, 2023 at 09:06:23AM -0500, Scott Cheloha wrote: > On Fri, Oct 06, 2023 at 03:41:39PM +0200, Alexander Bluhm wrote: > > On Fri, Oct 06, 2023 at 03:47:31PM +0300, Vitaliy Makkoveev wrote: > > > On Fri, Oct 06, 2023 at 02:14:52PM +0200, Alexander Bluhm wrote: > > > > > @@ -718,11

Re: CVS: cvs.openbsd.org: src

2023-10-10 Thread Todd C . Miller
On Tue, 10 Oct 2023 10:50:08 +0100, Stuart Henderson wrote: > Presumably 465 should be treated the same, though the hardcoded ports > don't feel entirely right here - this is presumably something that would > want adding for any connection which is allowed to relay .. Yes, I think so.

Re: pf passes packet if limit reached

2023-10-10 Thread Alexandr Nedvedicky
On Tue, Oct 10, 2023 at 02:53:15PM +0200, Alexander Bluhm wrote: > Hi, > > The behaviour of the PFRULE_SRCTRACK and max_states check was > unintentionally changed by this commit. > > > revision 1.964 > date: 2016/01/25 18:49:57; author: sashan; state: Exp; lines:

Re: CVS: cvs.openbsd.org: src

2023-10-10 Thread Chris Cappuccio
Todd C. Miller [mill...@openbsd.org] wrote: > On Tue, 10 Oct 2023 10:50:08 +0100, Stuart Henderson wrote: > > > Presumably 465 should be treated the same, though the hardcoded ports > > don't feel entirely right here - this is presumably something that would > > want adding for any connection

initial Intel Elkhart Lake Ethernet support / dwqe(4) at pci

2023-10-10 Thread Stefan Sperling
This patch adds enough code to get Elkart Lake devices with PCI Vendor ID 8086 and Product ID 4ba0 to attach and pass traffic. dwqe0 at pci0 dev 29 function 1 "Intel Elkhart Lake Ethernet" rev 0x11: rev 0x52, address xx:xx:xx:xx:xx:xx eephy0 at dwqe0 phy 1: 88E1512 10/100/1000 PHY, rev. 1 #

Re: initial Intel Elkhart Lake Ethernet support / dwqe(4) at pci

2023-10-10 Thread Stefan Sperling
On Tue, Oct 10, 2023 at 08:41:37PM +0200, Mark Kettenis wrote: > So the GMAC_VERSION #define is simply wrong. We should commit the > diff attached and drop the sc_core stuff you added below. That means all our supported chips are GMAC4 and later? Good to know. > > + switch

Re: I can't get contributors for my C project. Can you help?

2023-10-10 Thread chaosesquet...@yahoo.com
Bruce Perens; Thank's for responding. I mean that. No one else ever does :( *Message Main Body: Where am I supposed to send it? Every opensource forum I go to is basically shut down now: even slashdot (they don't even allow new registrations). No one seems to use C anymore: even though it's not

Can you help our opensource project (file formats)?

2023-10-10 Thread chaosesquet...@yahoo.com
We want the unreal map file types. http://sf.net/p/chaosesqueanthology /tickets/2/ .t3d and .unr file formats

Re: initial Intel Elkhart Lake Ethernet support / dwqe(4) at pci

2023-10-10 Thread Mark Kettenis
> Date: Tue, 10 Oct 2023 19:40:31 +0200 > From: Stefan Sperling > > This patch adds enough code to get Elkart Lake devices with PCI > Vendor ID 8086 and Product ID 4ba0 to attach and pass traffic. > > dwqe0 at pci0 dev 29 function 1 "Intel Elkhart Lake Ethernet" rev 0x11: rev > 0x52, address

bt(5), btrace(8): support modulo operator ('%')

2023-10-10 Thread Scott Cheloha
This adds support for the modulo operator to btrace(8). I was trying to use it like this: $start = nsecs; /* ... */ $elapsed = nsecs - $start; printf("%d.%09d seconds\n", $elapsed / 10, $elapsed % 10); and noticed it was missing. ok?

Re: pf log drop default rule

2023-10-10 Thread Alexandr Nedvedicky
Hello, I'm fine with it. OK sashan On Wed, Oct 11, 2023 at 12:28:20AM +0200, Alexander Bluhm wrote: > Hi, > > If a packet is malformed, it is dropped by pf(4). The rule referenced > in pflog(4) is the default rule. As the default rule is a pass > rule, tcpdump prints "pass" although the

Re: initial Intel Elkhart Lake Ethernet support / dwqe(4) at pci

2023-10-10 Thread Mark Kettenis
> Date: Tue, 10 Oct 2023 20:49:46 +0200 > From: Stefan Sperling > > On Tue, Oct 10, 2023 at 08:41:37PM +0200, Mark Kettenis wrote: > > So the GMAC_VERSION #define is simply wrong. We should commit the > > diff attached and drop the sc_core stuff you added below. > > That means all our

pf log drop default rule

2023-10-10 Thread Alexander Bluhm
Hi, If a packet is malformed, it is dropped by pf(4). The rule referenced in pflog(4) is the default rule. As the default rule is a pass rule, tcpdump prints "pass" although the packet is actually dropped. I have reports from genua and OPNsense users who are confused by the output. With the

bwfm(4): support scan v3

2023-10-10 Thread Mark Kettenis
The firmware for the BCM4388 has yet another version of the "escan" command. But we can treat it the same as v2 since it just added a new parameter in place of some padding. We just set that new parameter to zero, which doesn't change anything. As a bonus this adds some missing htole16() calls.