Re: vlan tagging surgery

2014-04-21 Thread Claudio Jeker
On Sun, Apr 20, 2014 at 06:45:46PM +0200, Henning Brauer wrote: so, on vlan, to insert the vlan tag, we right now: -copy (most of) the existing ethernet header into a ether_vlan_header on the stack -fill the extra fields (tag, inside ether type) in ether_vlan_header -set the ether type

Re: Remove RX offload hack from gem(4), hme(4), hme(4/sparc)

2014-04-21 Thread Claudio Jeker
On Sat, Apr 19, 2014 at 09:30:27PM +0200, Christian Weisgerber wrote: This removes a RX offload hack similar to the one just deleted from sk(4). These chips can only add 16-bit words starting from some offset, and so the driver gives them the likely start of the TCP/UDP payload and then tries

Re: [patch ping.c] replace malloc memset with calloc

2014-04-22 Thread Claudio Jeker
On Tue, Apr 22, 2014 at 12:45:25AM -0400, Peter Malone wrote: Hi, malloc memset can be replaced with calloc in ping.c. Please see below for patch details: Index: ping.c === RCS file: /cvs/src/sbin/ping/ping.c,v retrieving

Re: IPv6 by default

2014-04-29 Thread Claudio Jeker
On Tue, Apr 29, 2014 at 08:57:57AM -0400, Simon Perreault wrote: Le 2014-04-28 18:43, Kenneth Westerback a écrit : Why is the burden on everyone to provide 'valid' objections? I know that what I proposed cannot go in at the moment. It's my end goal. Now what I want is to have a clear

Re: [RFC] Ai_ADDRCONFIG^WAIAIAIAIAIAIAEEEEEEEEE tweaks?

2014-05-03 Thread Claudio Jeker
On Sat, May 03, 2014 at 10:03:30AM +0200, Paul de Weerd wrote: On Fri, May 02, 2014 at 11:20:38PM +0200, Jérémie Courrèges-Anglas wrote: | I'm not referring to SLAAC. I'm referring to addresses that are | configured on interfaces without the user even requesting them. | link-local

MI MTU size for lo(4)

2014-05-13 Thread Claudio Jeker
With KAME the MTU size of the loopback interface became strange and is actually dependend on the architecture. I see no point in all this just go back to the way it was long long long ago and just use 32k as the MTU. AFAIK all of this was only done to test large IPv6 packets but why MHLEN and MLEN

Big routing table diff

2014-05-13 Thread Claudio Jeker
The last three hackathons I got sucked into one ugly dark corner of the network stack. Our radix tree implementation one one particular bug in it that caused bgpd and ospfd to freak out on semi regular basis. After a fair amount of versions tested by myself and benno@ I think it is time to send

Re: Big routing table diff

2014-05-14 Thread Claudio Jeker
On Wed, May 14, 2014 at 12:11:30PM +0200, Martin Pieuchot wrote: On 13/05/14(Tue) 19:25, Claudio Jeker wrote: The last three hackathons I got sucked into one ugly dark corner of the network stack. Our radix tree implementation one one particular bug in it that caused bgpd and ospfd to freak

Re: UPDATE: xf86-input-synaptics 1.8.0

2014-05-14 Thread Claudio Jeker
On Tue, May 13, 2014 at 02:03:57PM +0600, Alexandr Shadchin wrote: Hi, This diff updates xf86-input-synaptics to the latest release 1.8.0. Comments ? OK ? Running with this on a Thinkpad X240 and it works for me just fine. Using the following config: Section InputClass Identifier

Re: NOINET6 by default

2014-05-15 Thread Claudio Jeker
On Wed, May 14, 2014 at 11:29:20PM +0200, Henning Brauer wrote: so as discussed recently having the inet6 link-local addrs on every interface by default is stupid and a security risk. this diff fixes that. well, really two independent parts. one: set the NOINET6 flag by default on each and

Re: NOINET6 by default

2014-05-15 Thread Claudio Jeker
On Thu, May 15, 2014 at 05:48:16AM +0200, Henning Brauer wrote: * Reyk Flöter reyk.floe...@googlemail.com [2014-05-15 01:04]: On 15.05.2014, at 00:46, Henning Brauer lists-openbsdt...@bsws.de wrote: * Mark Kettenis mark.kette...@xs4all.nl [2014-05-15 00:15]: I don't think this is a good

Re: recvmsg, fd passing and soreceive

2014-05-15 Thread Claudio Jeker
On Wed, May 14, 2014 at 10:03:35PM -0700, Philip Guenther wrote: On Wed, May 14, 2014 at 10:02 PM, Philip Guenther guent...@gmail.comwrote: On Wed, May 14, 2014 at 4:58 AM, Jérémie Courrèges-Anglas j...@wxcvbn.orgwrote: ... So here's the diff I came up with: - set MSG_TRUNC for

Re: NOINET6 by default

2014-05-15 Thread Claudio Jeker
On Thu, May 15, 2014 at 06:58:53AM +0200, Jérémie Courrèges-Anglas wrote: Paul de Weerd we...@weirdnet.nl writes: [...] This makes a whole lot of sense to me. Please make OpenBSD the first OS to do (this part of) v6 in a sensible way. Actually that makes me laugh. Sensible, weeeh.

Re: NOINET6 by default

2014-05-16 Thread Claudio Jeker
On Fri, May 16, 2014 at 12:43:52AM -0500, Todd T. Fries wrote: Penned by Henning Brauer on 20140516 0:26.37, we have: | * Claudio Jeker cje...@diehard.n-r-g.com [2014-05-15 09:33]: | On Wed, May 14, 2014 at 11:29:20PM +0200, Henning Brauer wrote: | so as discussed recently having the inet6

Re: diff: add tuning variables to config(8)

2014-06-17 Thread Claudio Jeker
On Mon, Jun 16, 2014 at 11:35:07AM -0600, Theo de Raadt wrote: Followings are our kernel variables' default: - sb_max: 256K - tcbhash_size: 128 - udbhash_size: 128 These variables are sometime too small for busy server or gateway. I'd like to modify config(8) to

Re: Kill unused (cached) routes

2014-07-09 Thread Claudio Jeker
On Wed, Jul 09, 2014 at 04:56:13PM +0200, Bret Lambert wrote: On Wed, Jul 09, 2014 at 04:52:06PM +0200, Martin Pieuchot wrote: While looking at route refcounting issues I found some unused fields... Ok to kill them? These appear to have been part of a plan of deep and evil magic; the

Re: diff: Option to use duids in /etc/dumpdates

2014-07-10 Thread Claudio Jeker
On Thu, Jul 10, 2014 at 04:28:49PM +0200, Alexander Hall wrote: On 07/09/14 23:44, Alexander Hall wrote: While looking at this, I noticed we don't support specifying the duid for the device to dump. Thinking a bit more, I'm forming a different approach for this. Hold on. Hm, the

Re: DNS control port additions to /etc/services

2014-07-15 Thread Claudio Jeker
On Tue, Jul 15, 2014 at 05:53:36PM +0200, Antoine Jacoutot wrote: On Tue, Jul 15, 2014 at 05:51:46PM +0200, Mark Kettenis wrote: Date: Tue, 15 Jul 2014 17:17:45 +0200 From: Antoine Jacoutot ajacou...@bsdfrog.org But be careful, this is not a user-editable file anymore, so we need

Re: route(8) -sa

2014-07-22 Thread Claudio Jeker
On Tue, Jul 22, 2014 at 10:06:35AM +0100, Stuart Henderson wrote: On 2014/07/22 11:01, Martin Pieuchot wrote: Anybody is using the -sa modifier of route(8)? A sockaddr in hexa, really? What's your use case? That only seems useful in situations where modifying route(8) would be a better

Re: bgpctl: enlarge columns for 4-byte ASN display

2014-07-27 Thread Claudio Jeker
Not a big fan since this makes the bgpctl show output no longer fit 80 chars and so will wrap lines on default terminals. While it is OK to increase the size it should be taken away from other fields in some whay. An option would be to drop the OutQ since that field has only limited value IMO.

Re: bgpctl: enlarge columns for 4-byte ASN display

2014-07-27 Thread Claudio Jeker
On Sun, Jul 27, 2014 at 03:36:06PM +0100, Stuart Henderson wrote: On 2014/07/27 11:15, Claudio Jeker wrote: Not a big fan since this makes the bgpctl show output no longer fit 80 chars and so will wrap lines on default terminals. While it is OK to increase the size it should be taken away

Re: minphys woes

2014-09-03 Thread Claudio Jeker
On Wed, Sep 03, 2014 at 07:51:25PM +0200, Stefan Fritsch wrote: On Tuesday 02 September 2014 15:22:16, Philip Guenther wrote: From physio(9): minphys A device specific routine called to determine the maximum transfer size that the device's strategy routine can

Re: splnet() and SIOCSIFADDR

2014-09-03 Thread Claudio Jeker
On Wed, Sep 03, 2014 at 03:25:34PM +0200, Martin Pieuchot wrote: Drivers that need a splnet() protection inside their SIOCSIFADDR generally raise the spl level themselves, so we should not need to do that in in{6,}_ifinit(). One exception to this rule is, as always, carp(4)... So the diff

Re: Fix slow DHCP requests in /etc/netstart

2014-09-26 Thread Claudio Jeker
On Fri, Sep 26, 2014 at 01:36:24PM +0100, Stuart Henderson wrote: On 2014/09/26 07:42, Alexander Hall wrote: Before performing a dhcp request, /etc/netstart explicitly takes the interface down. As noted (by me) at g2k14, and also at work, this results in a significant delay in getting the

Re: Local routes and loopback or p2p interfaces

2014-10-02 Thread Claudio Jeker
On Thu, Oct 02, 2014 at 10:31:04AM +0200, Martin Pieuchot wrote: Most of the local routes added on a system contain the link-layer address of the interface they are attached too. It is like that because these routes must be compatible with the cloned routes for ARP or ND. But for loopback

em(4) fix for Intel I218 chip

2014-10-12 Thread Claudio Jeker
This seems to be enough to help em(4) in modern laptops like the X240 to no longer generate watchdog timeouts on high throughput. This should only affect I218 but tests on different em(4) devices would not hurt. -- :wq Claudio Index: if_em_hw.c

Re: em(4) fix for Intel I218 chip

2014-10-13 Thread Claudio Jeker
On Mon, Oct 13, 2014 at 01:50:45PM -0400, Brad wrote: On 12/10/14 3:53 PM, Claudio Jeker wrote: This seems to be enough to help em(4) in modern laptops like the X240 to no longer generate watchdog timeouts on high throughput. This should only affect I218 but tests on different em(4) devices

Re: A system without interface?

2014-10-14 Thread Claudio Jeker
On Tue, Oct 14, 2014 at 11:01:46AM +0200, Martin Pieuchot wrote: On 08/10/14(Wed) 14:29, Martin Pieuchot wrote: I'm looking after the uses of the global list of interface. These ones are pointless, you always have at least one interface on your system. Ok? Anyone? OK. But we should

Re: Should we allow to configure twice the same IP?

2014-10-29 Thread Claudio Jeker
On Tue, Oct 28, 2014 at 11:55:57AM +0100, Martin Pieuchot wrote: There's nothing that prevent you to configure the same IPv4 address on different interfaces in the same routing domain. But does it make sense? Yes, it does make sense. I abuse this feature to get unnumbered point-to-point

Better bgpd reload (step 1)

2013-07-11 Thread Claudio Jeker
This is the first step to make bgpd reload non blocking in the RDE. It also speeds up the reload time a fair bit in some cases (mainly if you run with multiple RIBs and have larger filtersets) and it should also fix a few edge cases on reloads. I already sent out an earlier version of this diff

Re: netbt, Bluetooth kernel code

2013-07-13 Thread Claudio Jeker
On Sat, Jul 13, 2013 at 02:52:02AM +0100, Tony Sidaway wrote: On 13/07/2013, Theo de Raadt dera...@cvs.openbsd.org wrote: Whoa. I think USB was just called a good model. Good? I'm not sure on that point. A better idea for a model? Yeah, kind of like much less worse. I'll readily

Re: route rmx_expire time_t

2013-07-20 Thread Claudio Jeker
On Fri, Jul 19, 2013 at 07:41:41PM +0200, Alexander Bluhm wrote: Hi, For 64 bit time_t the routing message rmx_expire field has to be changed from u_int to int64_t. I will do that after ABI unlock. I would like to prepare the /sbin/route source for this change. ok? I was thinking of

Re: preparations for IP_SENDSRCADDR / (un)tangle pcb_bind...

2013-08-06 Thread Claudio Jeker
On Tue, Aug 06, 2013 at 09:24:13PM +0200, Christopher Zimmermann wrote: Hi, I'm currently working towards an IP_SENDSRCADDR implementation. As a first step I moved the calls to in_pcbrehash() from in_pcb(dis)connect() and in_pcbbind() to the call sites of those functions. This should save

Re: preparations for IP_SENDSRCADDR / race condition in6_pcbsetport()

2013-08-07 Thread Claudio Jeker
On Wed, Aug 07, 2013 at 03:20:12PM +0200, Christopher Zimmermann wrote: On Wed, 7 Aug 2013 07:11:38 +0200 Claudio Jeker cje...@diehard.n-r-g.com wrote: On Tue, Aug 06, 2013 at 09:24:13PM +0200, Christopher Zimmermann wrote: Hi, I'm currently working towards an IP_SENDSRCADDR

Re: carp ifdef inet6

2013-08-11 Thread Claudio Jeker
On Sun, Aug 11, 2013 at 09:17:24PM +0200, Alexander Bluhm wrote: Hi, In the common IPv4 and IPv6 file ip_carp.c an #ifdef INET6 is missing. Especially the IN6_IS_ADDR_LINKLOCAL() macro should not be necessary in IPv4 only code. ok? Sure. bluhm Index: netinet/ip_carp.c

Re: ipv6 atomic draft - rfc6946 diff

2013-08-22 Thread Claudio Jeker
On Thu, Aug 22, 2013 at 08:53:50AM +0200, Peter Hessler wrote: Have you verified that we follow the RFC, and not just -00 of the draft? The RFC actually mentions that OpenBSD-current as of 2012 is following the specification so I think this is OK. On 2013 Aug 21 (Wed) at 23:40:12 -0700

Re: openbsd ioctl fix (in6.c)

2013-08-22 Thread Claudio Jeker
On Wed, Aug 21, 2013 at 09:59:56AM -0700, Loganaden Velvindron wrote: I'm not sure if applies to OpenBSD as well, but NetBSD also disallowed SIOCSIFDSTADDR for ioctl. http://cvsweb.netbsd.org/bsdweb.cgi/src/sys/netinet6/in6.c?annotate=1.166only_with_tag=MAIN 1.2 itojun374:

Re: defer routing table updates on link state changes

2013-09-11 Thread Claudio Jeker
On Tue, Aug 27, 2013 at 01:39:14PM +0200, Martin Pieuchot wrote: On 26/08/13(Mon) 13:36, Mike Belopuhov wrote: hi, in order to make our life a bit easier and prevent rogue accesses to the routing table from the hardware interrupt context violating all kinds of spl assumptions we would

Re: Split rtinit()

2013-09-11 Thread Claudio Jeker
On Thu, Aug 29, 2013 at 11:20:56AM +0200, Martin Pieuchot wrote: On 27/08/13(Tue) 10:44, Kenneth R Westerback wrote: On Tue, Aug 27, 2013 at 03:38:49PM +0200, Martin Pieuchot wrote: So I started to play with the routine table and I'm slowly trying to unify the various code paths to add

Re: openbsd ioctl fix (in6.c)

2013-10-02 Thread Claudio Jeker
On Tue, Oct 01, 2013 at 10:25:45AM +0200, Martin Pieuchot wrote: On 30/09/13(Mon) 14:17, Loganaden Velvindron wrote: On Mon, Sep 30, 2013 at 10:51:47PM +0200, Alexander Bluhm wrote: On Wed, Sep 18, 2013 at 12:01:10AM -0700, Loganaden Velvindron wrote: Index: in6.c

Re: ip6_mroute.c m_free() - m_freem()

2013-10-04 Thread Claudio Jeker
On Fri, Oct 04, 2013 at 12:17:41AM -0700, Loganaden Velvindron wrote: Hi, I came across this small diff in netbsd. It fixes a small case of mbuf leak possibility. This is correct. OK claudio@ Index: sys/netinet6/ip6_mroute.c

Re: getifaddrs() netmasks with af=0 on vlan/lo

2013-10-04 Thread Claudio Jeker
On Fri, Oct 04, 2013 at 11:46:42AM +0100, Stuart Henderson wrote: It seems that for some interface types (I noticed vlan and lo), a netmask with af==0 is returned by getifaddrs(). Not sure if this was always broken or introduced more recently; happens on at least 5.3 and -current so it's not

Re: routing message crash

2013-10-14 Thread Claudio Jeker
On Mon, Oct 14, 2013 at 03:21:38PM +0200, Alexander Bluhm wrote: Hi, By passing invalid rtm_flags and rtm_addrs values in the routing message, I can crash the kernel from user land. login: uvm_fault(0xfe800554b388, 0x4, 0, 1) - e fatal page fault in supervisor mode trap type 6 code 0

Re: defer routing table updates on link state changes (again)

2013-10-19 Thread Claudio Jeker
On Sat, Oct 19, 2013 at 01:26:39PM +0200, Mike Belopuhov wrote: hi, since mpi's if_index diff is now in, this should probably go in as well. it has received some testing in the meantime. original description: in order to make our life a bit easier and prevent rogue accesses to the

Re: unlimited HFSC v3: more readable, less hacks

2013-10-21 Thread Claudio Jeker
On Mon, Oct 21, 2013 at 12:04:14AM +0200, Martin Pelikan wrote: Hopefully the third time does the charm. The previous union approach to altq/newq bits was wrong, because switching back and forth was racy. This new diff then concatenates these structures like [ifqueue, hfsc_if, altq-bits],

Re: HFSC queue pusher

2013-10-30 Thread Claudio Jeker
On Mon, Oct 28, 2013 at 01:55:16AM +0100, Martin Pelikan wrote: Hi, if you noticed weak newqueue performance, it was because one component of it was missing. After a discussion with claudio I made this diff, which makes a timeout per HFSC-enabled interface and pushes the data every

Re: Re : Re: Improve routing functions

2013-11-04 Thread Claudio Jeker
On Mon, Nov 04, 2013 at 10:36:39AM -0600, Adam Thompson wrote: On 13-11-03 02:27 PM, Loïc BLOT wrote: then to explain my draft here is my own configuration, and why it could be useful to set custom priorities: [...] Without the possibility to change the priorities (and dynamically is better

Re: rdomain - rtableid confusion

2013-11-26 Thread Claudio Jeker
On Tue, Nov 26, 2013 at 12:38:48PM +0100, Martin Pieuchot wrote: These two functions take a rtableid not a rdomain as an argument, simple renaming to avoid confusion. ok? Yes. OK Index: net/if.c === RCS file:

Important bgpd fix

2014-01-01 Thread Claudio Jeker
There is a somewhat critical bug in bgpd which got hit by local friends a few weeks ago. The problem is that on session with the graceful restart capability stale routes are not properly flushed. This can lead to bad FIB entries and black holes. This happens when a router does not reconnect before

Re: rti_info and defines

2014-01-17 Thread Claudio Jeker
On Wed, Jan 08, 2014 at 12:02:25PM +0100, Martin Pieuchot wrote: I find it really difficult to understand and work with the code of rtsock.c because of the following defines: /* Sleazy use of local variables throughout file, warning */ #define dstinfo.rti_info[RTAX_DST]

report icmp error drops because of rate limiting

2014-01-18 Thread Claudio Jeker
As done in IPv6 land report how many packets are dropped because we hit the rate limiter (net.inet.icmp.errppslimit). On bigger routers it may be needed to tune that value up in case to many packets are dropped. OK? -- :wq Claudio Index: sys/netinet/icmp_var.h

remove max_datalen since it is used only once

2014-01-18 Thread Claudio Jeker
Subject sais it all. One less gloabl symbol. -- :wq Claudio Index: kern/uipc_domain.c === RCS file: /cvs/src/sys/kern/uipc_domain.c,v retrieving revision 1.33 diff -u -p -r1.33 uipc_domain.c --- kern/uipc_domain.c 20 Aug 2013

Re: rc default PF ruleset too restrictive for DHCPv6

2014-01-18 Thread Claudio Jeker
On Sat, Jan 18, 2014 at 09:57:26PM -0500, Brad wrote: On Thu, Jan 09, 2014 at 03:55:44PM -0500, Brad Smith wrote: The default PF ruleset as setup by rc is too restrictive. Have the default ruleset allow for DHCPv6. Anyone? Looks good to me. OK claudio@ Question: should we add the same

Stop the madness in radix.c

2014-01-18 Thread Claudio Jeker
We no longer use radix.c in userland since routed(8) was killed aeons ago. There is no need for this madness anymore so remove it. -- :wq Claudio Index: radix.c === RCS file: /cvs/src/sys/net/radix.c,v retrieving revision 1.34 diff

Stop the madness in radix.c take 2

2014-01-18 Thread Claudio Jeker
Here is more cleanup. Kill the MKget MKfree madness and replace it with *drummrolls* a pool(9). Makes the code a lot easier to digest. -- :wq Claudio Index: net/radix.c === RCS file: /cvs/src/sys/net/radix.c,v retrieving revision

Re: Stop the madness in radix.c take 2

2014-01-18 Thread Claudio Jeker
On Sun, Jan 19, 2014 at 06:15:06AM +0100, Mike Belopuhov wrote: On Sun, Jan 19, 2014 at 05:42 +0100, Claudio Jeker wrote: Here is more cleanup. Kill the MKget MKfree madness and replace it with *drummrolls* a pool(9). Makes the code a lot easier to digest. Better? -- :wq Claudio

More cleanup in radix.c and route.h

2014-01-19 Thread Claudio Jeker
Try to be more consistent in how various variables are setup and named. Also remove a memset that is already happeing because we use PR_ZERO on the allocation. Move to memmove to memcpy because the addrs can not overlap. Make some simple helper functions static __inline and remove one of the

Re: Cleanup rtsock crazy defines

2014-01-20 Thread Claudio Jeker
On Mon, Jan 20, 2014 at 12:38:37PM +0100, Martin Pieuchot wrote: Here's a diff that substitutes the crazy defines of rtsock.c plus some 0 - NULL conversion. There's no object change with it. ok? OK claudio makes rtsock.c not nicer but at least not worse. Index: net/rtsock.c

More radix.c cleanup

2014-01-20 Thread Claudio Jeker
Cleanup the abuse of x as the rn_addmask radix node. Since in most cases x is just used as a temp variable. Main offender is rn_addmask() which sets x once at the top uses it then late in the function and then starts reuing it for various other stuff. While there fix some for loops to while ones

Re: PATCH: fix bug in handling genmask

2014-01-21 Thread Claudio Jeker
On Wed, Jan 22, 2014 at 06:29:57AM +0800, Kieran Devlin wrote: hope this time i get the part ?poke claudio@? right a. fix a bug. b. get rid of some junk in ?mask_rnhead?. c. forbid unprivileged user to insert ?genmask' into ?mask_rnhead' bug is in this line memcmp((caddr_t

kill RN_DEBUG code

2014-01-22 Thread Claudio Jeker
The RN_DEBUG code is broken since rev 1.1 I see no reason to keep it any longer and removing the code makes the result easier to read. OK? -- :wq Claudio Index: net/radix.c === RCS file: /cvs/src/sys/net/radix.c,v retrieving

Re: RTF_HOST and netmask

2014-01-22 Thread Claudio Jeker
On Wed, Jan 22, 2014 at 11:29:59AM +0100, Martin Pieuchot wrote: Diff below kills the unused RTAX_NETMASK arguments and the global variable associated of two requests where a route to host is added or deleted. ok? OK, setting RTF_HOST and passing a netmask is crazy talk so kill it.

Re: em(4): Don't count RX overruns and missed packets as input errros

2014-02-11 Thread Claudio Jeker
On Tue, Feb 11, 2014 at 07:43:51PM +0100, Mark Kettenis wrote: Date: Tue, 11 Feb 2014 13:30:47 -0500 From: Brad Smith b...@comstyle.com Index: arch/socppc/dev/if_tsec.c === RCS file:

Re: rtinit, RTF_HOST and netmask

2014-02-11 Thread Claudio Jeker
On Tue, Feb 11, 2014 at 04:00:25PM +0100, Martin Pieuchot wrote: On 04/02/14(Tue) 10:50, Martin Pieuchot wrote: Diff below removes an old comment about bsdi4 and make it clear that netmasks are not needed for routes to host. ok? Anybody? OK claudio@ Index: net/route.c

Re: [Patch] Add rtlabel to rt_newaddrmsg

2014-02-11 Thread Claudio Jeker
On Tue, Feb 11, 2014 at 09:07:04PM +0100, Florian Riehm wrote: Hi tech@, I'm using the ospfd with redistribute rtlabel statements. If I add new addresses to interfaces with a route label, ospfd will not notice it, because the route messages don't contain the route label. Please have a look

Re: Routing issues

2014-02-17 Thread Claudio Jeker
On Mon, Feb 17, 2014 at 03:21:53PM +0100, Henning Brauer wrote: * Stuart Henderson st...@openbsd.org [2014-02-17 14:45]: Hmm. Well, I was assuming from the name and pfctl(8) description that it should be state-limit, but actually it seems that is just used for max-src-states and this case

Re: Stop abusing rcvif pointer to pass wireless nodes

2014-03-17 Thread Claudio Jeker
On Mon, Mar 17, 2014 at 11:14:24AM +0100, Martin Pieuchot wrote: On 14/03/14(Fri) 15:46, Martin Pieuchot wrote: Diff below adds a new pointer to struct pkthdr to explicitly pass some wireless nodes to the pointer without abusing the interface pointer that I'd like to kill. I kept and

Re: Stop abusing rcvif pointer to pass wireless nodes

2014-03-18 Thread Claudio Jeker
On Mon, Mar 17, 2014 at 11:41:38AM -0600, Theo de Raadt wrote: What about using a more generic name which is not bound to 80211 since the field is a generic pointer. This may allow us to use something similar in other drivers like mpe(4), gif(4), gre(4). That is basically the only thought

Re: Stop abusing rcvif pointer to pass wireless nodes

2014-03-18 Thread Claudio Jeker
On Tue, Mar 18, 2014 at 12:28:41PM +0100, Martin Pieuchot wrote: On 18/03/14(Tue) 11:26, Mike Belopuhov wrote: On 18 March 2014 07:20, Claudio Jeker cje...@diehard.n-r-g.com wrote: On Mon, Mar 17, 2014 at 11:41:38AM -0600, Theo de Raadt wrote: What about using a more generic name which

Re: Useless expensive lookup in ether_output()

2014-03-25 Thread Claudio Jeker
On Tue, Mar 25, 2014 at 11:39:30AM +0100, Martin Pieuchot wrote: Why do we do a lookup on all the addresses of the systems to know if the destination address given to ether_output() is on the carp interface? If this address is on any of our interfaces we should not even end up here. Since

support for Realtek RTS5227 Card Reader

2014-04-17 Thread Claudio Jeker
Found this in my X240, the following diff makes it work. rtsx0 at pci1 dev 0 function 0 Realtek RTS5227 Card Reader rev 0x01: msi sdmmc0 at rtsx0 scsibus4 at sdmmc0: 2 targets, initiator 0 sd1 at scsibus4 targ 1 lun 0: SD/MMC, Drive #01, SCSI2 0/direct fixed sd1: 15296MB, 512 bytes/sector,

fix for ifa RB tree corruption

2014-04-18 Thread Claudio Jeker
Bad stuff happens when the ifa lookup tree gets corrupted. In my case local traffic was suddenly no longer local and was forwarded to lo0 ad infinitum. This was caused by the usage of rdomains and destroing pseudo interfaces. The sadl address was still in rdomain 0, was therefor not found in the

Re: fix for ifa RB tree corruption

2014-04-19 Thread Claudio Jeker
On Sat, Apr 19, 2014 at 03:09:40PM +0200, Martin Pieuchot wrote: On 18/04/14(Fri) 18:12, Claudio Jeker wrote: Bad stuff happens when the ifa lookup tree gets corrupted. In my case local traffic was suddenly no longer local and was forwarded to lo0 ad infinitum. Which lookup exactly

Re: stop advertising disabling pmtud and window size increasing

2014-04-19 Thread Claudio Jeker
On Sat, Apr 19, 2014 at 06:21:40PM +0200, Henning Brauer wrote: very rarely if ever needed any more. we should not trick people into thinking they are impoving sth doing so, it's rather the opposite these days. Yes please. We should remove the buttons people should not touch unless they know

Re: tcpbench udp support + libevent.

2011-02-14 Thread Claudio Jeker
On Wed, Jan 26, 2011 at 11:34:33PM -0200, Christiano F. Haesbaert wrote: On Thu, Jan 27, 2011 at 11:31:39AM +1100, Damien Miller wrote: On Wed, 26 Jan 2011, Christiano F. Haesbaert wrote: Hi there, This diff adds udp support with PPS (packet per second) accounting and changes

Re: bgpd: fix error message enforce remote-as enabled

2011-02-14 Thread Claudio Jeker
On Thu, Jan 27, 2011 at 05:19:25PM +, Stuart Henderson wrote: fixed, thanks. On 2011/01/27 17:07, Sebastian Benoit wrote: Hi, the configuration option in bgpd.conf is called enforce neighbor-as, not enforce remote-as. /Benno --- rde.c.orig Thu Jan 27 17:02:08

Re: bgpd: fix error message enforce remote-as enabled

2011-02-15 Thread Claudio Jeker
On Mon, Feb 14, 2011 at 10:06:58PM +, Stuart Henderson wrote: On 2011/02/14 21:39, Claudio Jeker wrote: After a bit more thinking I like this version a lot better. This correctly prints the neighbor AS number in both cases 16bit and 32bit AS Number. Ok. Personally the only time

Re: plug a memleak in output_listing()

2011-02-15 Thread Claudio Jeker
On Fri, Feb 11, 2011 at 07:34:41PM -0300, Gleydson Soares wrote: plug a memleak in output_listing(); from NetBSD Index: aicasm.c === RCS file: /cvs/src/sys/dev/microcode/aic7xxx/aicasm.c,v retrieving revision 1.14 diff -u -r1.14

Re: ifconfig vlan tag range

2011-02-15 Thread Claudio Jeker
On Thu, Feb 10, 2011 at 12:08:24PM +0100, Henning Brauer wrote: * Camiel Dobbelaar c...@sentia.nl [2011-02-09 20:34]: The valid range for vlan tags in OpenBSD is 0-4095 (inclusive). not only in openbsd - that's what you can fit in the 12 bits ;) Index: ifconfig.c

Re: MicroLinear 6692 PHY for tl(4) -- Olicom 2326

2011-02-15 Thread Claudio Jeker
On Sun, Feb 13, 2011 at 05:03:03AM -0500, Loganaden Velvindron wrote: Hi, Claudio suggested to me a better way of cycling through the PHYs. Does this look good ? /*$OpenBSD: ukphy.c,v 1.20 2010/07/23 07:47:13 jsg Exp $ */ /*$NetBSD: ukphy.c,v 1.9 2000/02/02 23:34:57 thorpej Exp $

Re: MicroLinear 6692 PHY for tl(4) -- Olicom 2326

2011-02-15 Thread Claudio Jeker
On Tue, Feb 15, 2011 at 01:28:28PM +, Stuart Henderson wrote: On 2011/02/15 14:05, Claudio Jeker wrote: /* * Micro Linear PHY reports oui == 0 model == 0 */ if (MII_OUI(ma-mii_id1, ma-mii_id2) != 0 || MII_MODEL(ma-mii_id2) != 0) return (0

Re: mos(4) broadcast fix

2011-02-21 Thread Claudio Jeker
On Sun, Feb 20, 2011 at 10:59:48PM +0100, Stefan Sperling wrote: mos(4) doesn't set IFF_BROADCAST, which prevents hostapd(8) from using it. hostapd tries a SIOCGIFBRDADDR ioctl which fails with EINVAL in netinet/in.c: case SIOCGIFBRDADDR: if ((ifp-if_flags

Re: SOCK_SEQPACKET is only valid for the AF_BLUETOOTH, SOCK_RDM is dead

2011-02-24 Thread Claudio Jeker
On Thu, Feb 24, 2011 at 03:44:08PM +0100, Mike Belopuhov wrote: Currenlty socket man page mentions long dead netns stack (PF_NS) when talks about SOCK_SEQPACKET which is only valid for AF_BLUETOOTH these days. Also it mentions SOCK_RDM that is an unused SysV compat goo. I think it make sense

Re: userland PPP patch for IPv6CP + VLAN interfaces

2011-03-03 Thread Claudio Jeker
On Wed, Mar 02, 2011 at 06:47:40PM -0500, Brad wrote: Ethernet vlan(4) interfaces have valid Ethernet link layer addresses but use a different interface type (IFT_L2VLAN vs IFT_ETHER). Treat IFT_L2VLAN interfaces like IFT_ETHER interfaces when handling link layer addresses. From FreeBSD

Re: tiny imsg_init(3) correction in EXAMPLES

2011-03-04 Thread Claudio Jeker
On Fri, Mar 04, 2011 at 01:43:03PM +0500, Anton Maksimenkov wrote: Hi. I found that manpage for imsg-family have a little mistake: ... if (msgbuf_write(ibuf-w) 0) { ... It seems it should be: if (msgbuf_write(ibuf-w) 0) { Yes that's correct. I

fix some memory leaks in ospfd

2011-03-04 Thread Claudio Jeker
While searching a bigger memory leak in one of my diffs I found these others. Most of them are harmless cleanup on shutdown problems. The only one that may be problematic is the missing vertex_nexthop_clear() in vertex_free(). Please test and OK :) -- :wq Claudio Index: neighbor.c

ospfd and large lsupdates

2011-03-04 Thread Claudio Jeker
Currently ospfd has a problem when a single lsupdate is bigger then the MTU. Normaly this is not a problem but Benjamin Papillon hit this limit on a VPN hub. This diff changes the way lsupdate.c handels buffers. The buffer is changed from a MTU sized to a dynamic one that can grow up to 64k -

Re: tcpbench udp support + libevent.

2011-03-08 Thread Claudio Jeker
On Sun, Mar 06, 2011 at 04:56:05PM -0300, Christiano F. Haesbaert wrote: On Sat, Mar 05, 2011 at 12:35:58PM -0300, Christiano F. Haesbaert wrote: Rodolfo Gouveia kindly did some tests on the tcp performance after the diff with gigabits ifs. Apparently there was a significant drop in

Re: ipv6 ndp spoofing log message

2011-03-09 Thread Claudio Jeker
On Wed, Mar 09, 2011 at 01:08:47AM +0100, Alexander Bluhm wrote: Hi, In IPv4 we log a message when someone is spoofing our arp cache. Mar 9 01:03:51 q0 /bsd: arp info overwritten for 10.188.50.10 by 00:01:02:03:04:05 on ne3 Do we want a similar message for IPv6 neighbor discovery

Re: tcpbench udp support + libevent.

2011-03-09 Thread Claudio Jeker
First of all I just commited the UDP support. So this is now all in and we can work on this in tree with smaller diffs. Thanks for the work. On Tue, Mar 08, 2011 at 07:39:17PM -0300, Christiano F. Haesbaert wrote: On Tue, Mar 08, 2011 at 03:26:23PM +0100, Claudio Jeker wrote: I played a bit

ospfd: better lsack handling

2011-03-09 Thread Claudio Jeker
The way lsacks were generated always bugged me. I was not happy how the packets were filled. This new version is more like the lsupdate code. This removes another READ_BUF_SIZE and kills the stupid PKG_DEF_SIZE define. In the end nothing should change. OK? -- :wq Claudio Index: lsack.c

Re: pcap icmptype support

2011-03-21 Thread Claudio Jeker
On Wed, Feb 02, 2011 at 06:49:26PM +0100, Giovanni Bechis wrote: This diff adds support to icmptype grammar to libpcap. With this diff we can do: $ sudo tcpdump -netttv -i nfe0 icmp[icmptype] = 8 and capture only echo requests. This diff is needed for an upcoming nmap update. Comments ? ok

tcpdump fix for OSPF

2011-03-21 Thread Claudio Jeker
Some crappy systems seem to send out packets with very strange lenght fields. In my particular case the IP length is 64 bytes (overall packet) but the ospf length is 32 bytes and therefor 12 bytes short. The box seems to add some crap as padding (I bet uninitialized memory). Tcpdump does not like

Re: MicroLinear 6692 PHY for tl(4) -- Olicom 2326

2011-03-23 Thread Claudio Jeker
On Tue, Feb 15, 2011 at 12:32:20PM -0500, Loganaden Velvindron wrote: Hi, Yes, the diff does work with half/full duplex. I fixed the style issues added checks for other being NULL. To test those changes, I disabled tlphy ukphy, and tested the tl adapter with mlphy only. All modes work.

gre(4) fix for lan connections

2011-03-24 Thread Claudio Jeker
Currently it is impossible to use gre(4) for directly connected hosts because the route trick used fails in so many bad ways it is not even fun. I came to the conclusion that we don't need such bad magic tricks especially since the same can be achieved by using routing priorities. Btw. gif(4)

Include original rdomain in DIOCNATLOOK

2011-03-25 Thread Claudio Jeker
It is possible to NAT connections from one rdomain to another with pf. The problem is that this NAT is not visible in DIOCNATLOOK lookups. This causes ftp-proxy to fail handling connections that cross domains. Adding the incomming rdomain is not a big deal and will allow ftp-proxy and other

Make ftp-proxy rdomain aware

2011-03-25 Thread Claudio Jeker
This allows to do so magically twisted things like running ftp-proxy in rdomain 7 and proxy connections from rdomain 3 over it. pf setup is: anchor ftp-proxy/* pass in quick proto tcp to port ftp rtable 7 rdr-to 127.0.0.1 port 8021 and ftp-proxy is startet with route -T 7 exec ftp-proxy The

Re: NFS writes lock up system with -o tcp,-w32768

2011-03-29 Thread Claudio Jeker
On Tue, Mar 29, 2011 at 05:24:33PM +0200, Michael wrote: Hi, I already filed a PR for that on 17.12.20110 - kernel/6525. There also were some mails on misc@ about it. But noone really seemed to care. Oh, I missed that PR. Here is a possible fix. The problem was that because of the way NFS

Re: NFS writes lock up system with -o tcp,-w32768

2011-03-30 Thread Claudio Jeker
On Wed, Mar 30, 2011 at 03:07:13PM +0200, Walter Haidinger wrote: Am 29.03.2011 22:42, schrieb Claudio Jeker: Here is a possible fix. The problem was that because of the way NFS uses the socket API it did not turn of the sendbuffer scaling which reset the size of the socket back to 17376

Re: NFS writes lock up system with -o tcp,-w32768

2011-03-30 Thread Claudio Jeker
On Wed, Mar 30, 2011 at 08:34:24PM +0200, Mark Kettenis wrote: Date: Tue, 29 Mar 2011 22:42:47 +0200 From: Claudio Jeker cje...@diehard.n-r-g.com Here is a possible fix. The problem was that because of the way NFS uses the socket API it did not turn of the sendbuffer scaling which reset

  1   2   3   4   5   6   7   8   9   >