Re: fun with smtpd, (two bugs)

2014-05-10 Thread Denis Fondras
Le 10/05/2014 17:54, Creamy a écrit : table creamy db:/etc/mail/creamy.db table secrets db:/etc/mail/secrets.db accept sender creamy for domain example.com relay via smtps+auth://foo...@smtp.creamylan.lan auth secrets Shouldn't it be : accept sender creamy for domain example.com ...

Re: network autoconfig

2014-07-13 Thread Denis Fondras
from the user's PoV, there shouldn't be more needed than ifconfig if inet autoconf ifconfig if inet6 autoconf aka inet/inet6 autoconf in hostname.if. I'm curious to see what will come out of it as I cannot envision any added value of these autoconf compared to dhclient. Denis

urndis(4) manpage : add Geeksphone ONE

2011-05-08 Thread Denis Fondras
Hello tech@, Just a tiny diff to add another supported/tested phone to the manpage of urndis(4). Denis --- Index: src/share/man/man4/urndis.4 === RCS file: /cvs/src/share/man/man4/urndis.4,v retrieving revision 1.8 diff -u

Re: DNSSEC and OpenBSD default BIND

2010-08-16 Thread Denis Fondras
Hello, Following my previous message from July, 18th, I am back to BIND as my tests with nsd/unbound are not really conclusive (can't make both work with only one IP and they don't support views). So I rolled up my sleeves and started to port OpenBSD changes to BIND-9.7.1-P2. Changing

Re: bgpd.conf macros on 5.5 and up

2015-02-03 Thread Denis Fondras
Hi all, Here is a patch to revert back to 5.4 behaviour so the manual example with braces works again : # cat /etc/bgpd.conf AS 65001

Re: [Patch] New item to the Migrating to OpenBSD guide

2015-06-28 Thread Denis Fondras
This patch is regarding the fact that there are no binary updates, which is a given thing What you missed : https://stable.mtier.org/

Update to /etc/services

2015-07-26 Thread Denis Fondras
Hello, Following is a patch to add BFD specific ports (RFC5881) and move RDP entry so the list is ordered. Denis Index: etc/services === RCS file: /cvs/src/etc/services,v retrieving revision 1.93 diff -u -p -r1.93 services ---

Re: Update to /etc/services

2015-07-26 Thread Denis Fondras
Are both TCP and UDP actually used for these? If not, please only list the protocols which are used (not just reserved). Only UDP is used currently. Index: services === RCS file: /cvs/src/etc/services,v retrieving revision 1.93

Re: Weak Diffie-Hellman default in nginx port

2015-07-21 Thread Denis Fondras
On Tue, Jul 21, 2015 at 12:31:33PM +0200, lophos wrote: The nginx config (although disabled by default) supports weak Diffie Hellman cipher according to ssllabs.com test (Grade B). You'd better generate stronger DH-param than disable DHE.

Re: Bulkget & snmpd

2015-10-09 Thread Denis Fondras
On Thu, Oct 08, 2015 at 08:39:40AM +0100, Stuart Henderson wrote: > > O. And now I find Gerhard Roth's post > > > > https://marc.info/?l=openbsd-tech=143375327425321=2 > > Oh! I missed this one. Thank you very much Stuart. Denis

[patch] httpd: fcgi/PATH_INFO not handled correctly

2015-08-26 Thread Denis Fondras
Hello, While using httpd together uwsgi and Flask, I noticed that GET requests to / returned 404. The same setup with nginx was returning 200. The culprit is that PATH_INFO is not set when REQUEST_URI is /. The following patch correctly set PATH_INFO in every case. Denis Index: httpd.c

Re: virtualization support

2015-09-01 Thread Denis Fondras
> TL;DR - a native hypervisor is coming. stay tuned. > Good job ! Getting rid of systemdOS by 5.9 would be a blast :D

Re: IPv6 - 6rd support

2015-09-16 Thread Denis Fondras
On Wed, Sep 16, 2015 at 03:38:22PM +0100, Stuart Henderson wrote: > On 2015/09/16 09:39, David Hill wrote: > > So I need to attach an IP somewhere. Both the FreeBSD and NetBSD in the > > u6rd manpage say I need an IPv6 address on tun0. > > > >NetBSD 5.1 > > # ifconfig tun0 create > >

Giving love to ospf6d

2015-12-15 Thread Denis Fondras
Hello, I want to use ospf6d but it is a bit rough around the edge. A simple "ospf6ctl reload" makes it crash ! Come on, this is far from the expected OpenBSD quality :p I made a patch that make it crash less often. I still stumble on some "lost interface" or "unknown interface" from time to

Re: Giving love to ospf6d

2015-12-20 Thread Denis Fondras
Hello, Here is the second iteration of the patch. It fixes a crash and it is a refactoring. Denis Index: area.c === RCS file: /cvs/src/usr.sbin/ospf6d/area.c,v retrieving revision 1.4 diff -u -p -r1.4 area.c --- area.c 28 Dec

bgpd: print AS range

2016-06-04 Thread Denis Fondras
With the support of AS range filtering, we need to print the configuration accordingly. Before : # bgpd -dnv [...] deny from any AS 0 deny from any AS 0 deny from any AS 65535 deny from any AS 0 deny from any AS 0 deny from any AS 0 deny from any AS 4294967295 After : # bgpd -dnv [...] deny

Re: bgpd: print AS range

2016-06-05 Thread Denis Fondras
On Sun, Jun 05, 2016 at 10:28:05AM +0200, Sebastian Benoit wrote: > hei, > > thanks! i forgot that we print the config. > > ok benno@, with whitespace fixed. > Index: printconf.c === RCS file: /cvs/src/usr.sbin/bgpd/printconf.c,v

Re: bgpd: print AS range

2016-06-05 Thread Denis Fondras
> This didn't quite work, as log_as will override itself when used twice > in the same printf. > I should not have sent this late at night... Index: printconf.c === RCS file: /cvs/src/usr.sbin/bgpd/printconf.c,v retrieving

Problem with svlan(4) and bge(4)

2016-01-10 Thread Denis Fondras
Hi, Following http://article.gmane.org/gmane.os.openbsd.tech/47475, I have a similar problem with svlan(4) and em(4) (Intel 80003ES2). The main difference with bge(4) is that ping works with em(4) but not tcp/udp. (obviously my bge(4) supports IFCAP_CSUM_IPv4 and not my em(4)). Everything works

Problem with svlan(4) and bge(4)

2016-01-10 Thread Denis Fondras
Hi, I have a problem with svlan(4) and bge(4) (Broadcom BCM5721). With TCO : denis@jigai:~$ ssh root@10.20.30.210 root@10.20.30.210's password: Last login: Sun Jan 10 13:22:27 2016 from 192.168.10.10 OpenBSD 5.9-beta (GENERIC) #1: Sun Jan 10 13:25:07 CET 2016

Re: Problem with svlan(4) and bge(4)

2016-01-10 Thread Denis Fondras
On Sun, Jan 10, 2016 at 03:42:34PM +, Christian Weisgerber wrote: > You don't actually describe your interface configuration. I _guess_ > you are trying to terminate IP traffic directly on an svlan(4) > interface. That sounds very unusual. > Sorry, the configuration is actually :

Re: bgpd: fix adding a new interface and network inet connected

2016-03-22 Thread Denis Fondras
Peter, Thank you for fixing this bug that has been responsible for much of my service disruption over the months :) Denis

[Patch/bgpd] Remove unused argument from community_ext_*

2016-03-27 Thread Denis Fondras
Hi, I noticed that multiple functions from OpenBGPd declared an argument "u_int16_t neighas" that is never used. Here is a patch to remove it. Denis Index: parse.y === RCS file: /cvs/src/usr.sbin/bgpd/parse.y,v retrieving revision

OpenBGPd: expand rib list (updated for r1.295)

2017-01-20 Thread Denis Fondras
Hello, Here is a patch to expand RIB names in rules. When playing with multi-RIBs, it allows to simplify ruleset. Ex : # cat /etc/bgpd.conf [...] peer_ribs = "{ m1, m2, m3 }" deny rib m2 from any allow rib $peer_ribs from any prefix { 2001:db8:1::/48, 2001:db8:2::/48 } # bgpd -dnv [...] deny

Re: asr: support for RES_USE_DNSSEC

2017-02-25 Thread Denis Fondras
On Sat, Feb 25, 2017 at 07:24:48PM +0100, Jeremie Courreges-Anglas wrote: > > > This flag is useful for software that wants to rely on the resolver to > > perform DNSSEC validation. Among the use cases there are DANE and SSHFP > > records, and the obvious interfaces that I think are useful are >

Re: bgpd: local-as

2016-09-27 Thread Denis Fondras
> I know cisco has a similar feature. Can someone of you check how it > detects AS loops? If it does at all. I guess people expect it to work > similar to other vendors. > I expect it to work the OpenBSD way. That means it shouldn't bite me. Detect AS loop is the way to go, whatever way has

OpenBGPd: expand rib list

2017-01-07 Thread Denis Fondras
Hello, Here is a patch to expand RIB names in rules. When playing with multi-RIBs, it allows to simplify ruleset. Ex : # cat /etc/bgpd.conf [...] peer_ribs = "{ m1, m2, m3 }" deny rib m2 from any allow rib $peer_ribs from any prefix { 2001:db8:1::/48, 2001:db8:2::/48 } # bgpd -dnv [...] deny

Re: ifconfig.8: Small improvement, typofix

2017-04-04 Thread Denis Fondras
> -If the master does not advertise within three times this interval, this host > +If the master does not advertise this interval within three times, this host > I think the old phrasing is easier to understand.

[patch/route] Automatically choose default route AF

2017-07-28 Thread Denis Fondras
Hello, Here is a patch to route(8) to automatically choose the right address family when adding a default route using the "default" keyword. Index: route.8 === RCS file: /cvs/src/sbin/route/route.8,v retrieving revision 1.79 diff -u

Re: Is someone interested in resuming support for socppc?

2017-07-29 Thread Denis Fondras
On Sat, Jul 29, 2017 at 01:33:03PM +0300, Андрей Болконский wrote: > https://www.openbsd.org/socppc.html > > > The OpenBSD/socppc port was discontinued after the 5.8 release. > Otherwise, will you approve removing support for socppc from src? I am still using a RB600A.

Re: [patch/route] Allow short commands

2017-07-27 Thread Denis Fondras
Thank you for your comment. > This will lead to usage and documentation issues (aside from your > diff not including a manpage change): > You are right, I missed the manpage bits. > With your diff, someone might write somewhere > > just type "route a default 192.0.2.1" to configure a default

Re: [patch/route] Allow short commands

2017-07-27 Thread Denis Fondras
> > +1 for a specific alias for "del" though. > > I also worry about this. However the addition of a few well-selected > shortenings is OK. > Here is a patch that adds the "del" shortcut. I am not sure the usage() et man are changed the "right way" though. Index: keywords.h

[patch/route] Allow short commands

2017-07-26 Thread Denis Fondras
Hi, I use route(8) a lot and I thought being able to use shorter commands/keywords could be nice. Like : route a default 192.0.2.1 route del default Regards, Denis Index: route.c === RCS file: /cvs/src/sbin/route/route.c,v

show ASN details in bgplg(8)

2017-07-19 Thread Denis Fondras
Hi, I can be useful to display details about an ASN from the looking-glass. rt-grav-01.liopen.net> show ip bgp detail as 199881 BGP routing table entry for 2a00:6060:8000::/48 199881 Nexthop 2001:7f8:81::19:9881:1 (via 2001:7f8:81::19:9881:1) from Auvergne Wireless IPv6 (185.22.131.1)

[patch/bgpd] Move comment in rde.c

2017-07-30 Thread Denis Fondras
Hi, A comment is misplaced in rde.c. Index: rde.c === RCS file: /cvs/src/usr.sbin/bgpd/rde.c,v retrieving revision 1.368 diff -u -p -r1.368 rde.c --- rde.c 29 May 2017 13:10:40 - 1.368 +++ rde.c 30 Jul 2017

[patch/openbgpd] remove unused argument from community_ext_*

2017-05-22 Thread Denis Fondras
Hello, Here is a patch to remove "u_int16_t neighas", an unused arguments from community_ext_* functions. Index: parse.y === RCS file: /cvs/src/usr.sbin/bgpd/parse.y,v retrieving revision 1.298 diff -u -p -r1.298 parse.y --- parse.y

[patch/openbgpd] make man example works

2017-05-21 Thread Denis Fondras
Hi, bgpd.conf manual has an example with : good="{ 192.168.0.0/16, 172.16.0.0/12, 10.0.0.0/8 }" bad="{ 224.0.0.0/4 prefixlen >= 4, 240.0.0.0/4 prefixlen >= 4 }" ugly="{ 127.0.0.1/8, 169.254.0.0/16 }" deny from any prefix { $good $bad $ugly } This syntax is not valid with current parse.y. Here

[patch/bgpctl] Add support for extended communities

2017-06-03 Thread Denis Fondras
Hello, Here is a patch to allow usage of extended communities with bgpctl : bgpctl show ip bgp ext-community rt 10:10 bgpctl netw add 2001:db8:1::/64 ext soo 10:50 Denis Index: bgpctl/bgpctl.c === RCS file:

[patch/bgpctl] Add support for extended communities (updated)

2017-06-03 Thread Denis Fondras
(forgot to add the manual bit in the previous patch) Hello, Here is a patch to allow usage of extended communities with bgpctl : bgpctl show ip bgp ext-community rt 10:10 bgpctl netw add 2001:db8:1::/64 ext soo 10:50 Denis Index: bgpctl/bgpctl.8

Re: rework bgpd ext community and support origin validation state

2017-05-31 Thread Denis Fondras
Hi, A typo slipped into Claudio's patch. While at it, fix the same typo elsewhere. Denis Index: parse.y === RCS file: /cvs/src/usr.sbin/bgpd/parse.y,v retrieving revision 1.308 diff -u -p -r1.308 parse.y --- parse.y 31 May

Re: man page update for bgpctl

2017-09-21 Thread Denis Fondras
On Thu, Sep 21, 2017 at 01:07:26PM +0100, Tom Smyth wrote: > Hello > minor Grammar Correction on manual page for bgpctl > > - line144 > Take the BGP session to the specified neighbor up. > +line144 > Bring the BGP session to the specified neighbor up. Thank you. I created a proper patch. Take a

[patch] exiting bgplgsh with ^D

2017-10-04 Thread Denis Fondras
Hi, Here is a patch to make ^D (CTRL-D) escape from bgplgsh instead of displaying help. Denis Index: bgplgsh.c === RCS file: /cvs/src/usr.bin/bgplg/bgplgsh.c,v retrieving revision 1.8 diff -u -p -r1.8 bgplgsh.c --- bgplgsh.c 9

[patch bgpd] Remove unused argument

2017-10-03 Thread Denis Fondras
Hi, The "struct peer" input of merge_config() is never used. Here is a patch to remove it. Denis Index: config.c === RCS file: /cvs/src/usr.sbin/bgpd/config.c,v retrieving revision 1.67 diff -u -p -r1.67 config.c --- config.c29

Add RPKI-ROA support to OpenBGPd 2/2

2017-08-26 Thread Denis Fondras
Hi, Following the previous email, here is a patch to bgpctl(8). It adds two commands : - show validator - show rib roa-state [valid|invalid|not-found] Here is the result of each command : # bgpctl show validator id address:port pref v4 v6 0 [2a02:cdc5:9715:0:185:5:200:241]:8282 128 36655 5837

Add RPKI-ROA support to OpenBGPd 1/2

2017-08-26 Thread Denis Fondras
Hi, Here is a patch to add RPKI/ROA support to bgpd(8) (based on RFC6810). (bgpctl(8) patch in the next mail) Can someone have a look and tell me what is wrong and what must be and how to improved ? * What needs to be done (in no specific order) : - Do some benchmark - Improve error handling -

Re: [patch] exiting bgplgsh with ^D

2017-10-04 Thread Denis Fondras
On Wed, Oct 04, 2017 at 09:04:43PM +0200, Sebastian Benoit wrote: > I also noticed that the help message does not tell you to use exit to quit > ;) > I noticed this too but as ^D is a well-known command to exit a shell, I wonder if it is useful to add exit to the help message. Plus it is not

Re: forbid config reloads in ospf6d

2017-11-05 Thread Denis Fondras
Ok (for what it's worth). On Sun, Nov 05, 2017 at 03:50:42PM +0100, Jeremie Courreges-Anglas wrote: > > ospf6d consistently fails when I ask it to reload its config, even > though I have a very basic test setup: > > area 0.0.0.0 { > interface em0 { passive } > interface vether0

Re: [patch] adds include statement in dhcpd.conf

2018-05-11 Thread Denis Fondras
Hi Julien, I like the idea but implementation seems a bit naive. Do you have a working example ? While testing, I can notice a bug with line count (my latest hobby :D). $ dhcpd -dn -c /etc/examples/dhcpd.conf /etc/examples/dhcpd.conf line 21: filenameee ^ /etc/examples/dhcpd.conf line

Re: route: improve inet6_makenetandmask

2018-05-26 Thread Denis Fondras
On Sat, May 26, 2018 at 12:54:03PM +0200, Klemens Nanni wrote: > inet6_makenetandmask() parses the provided prefix length `plen' twice: > first from inside prefixlen() which sets the mask, then right again > doing almost the same dance to find out which bits to zero in the > provided address. > >

acme-client/parse.y : fix line count

2018-06-02 Thread Denis Fondras
Applying otto@'s diff to acme-client. Fixes an off-by-one line count when using include statements. Ok ? Index: parse.y === RCS file: /cvs/src/usr.sbin/acme-client/parse.y,v retrieving revision 1.21 diff -u -p -r1.21 parse.y ---

bgpd/parse.y : fix line count

2018-06-02 Thread Denis Fondras
Applying otto@'s diff to bgpd Fixes an off-by-one line count when using include statements. Ok ? Index: parse.y === RCS file: /cvs/src/usr.sbin/bgpd/parse.y,v retrieving revision 1.320 diff -u -p -r1.320 parse.y --- parse.y 26

hostapd/parse.y : fix line count

2018-06-02 Thread Denis Fondras
Applying otto@'s diff to hostapd. Fixes an off-by-one line count when using include statements. Ok ? Index: parse.y === RCS file: /cvs/src/usr.sbin/hostapd/parse.y,v retrieving revision 1.55 diff -u -p -r1.55 parse.y --- parse.y

smtpd/parse.y : fix line count

2018-06-02 Thread Denis Fondras
Applying otto@'s diff to smtpd. Fixes an off-by-one line count when using include statements. Ok ? Index: parse.y === RCS file: /cvs/src/usr.sbin/smtpd/parse.y,v retrieving revision 1.210 diff -u -p -r1.210 parse.y --- parse.y 1

eigrpd/parse.y : fix line count

2018-06-02 Thread Denis Fondras
Applying otto@'s diff to eigrpd. Fixes an off-by-one line count when using include statements. Ok ? Index: parse.y === RCS file: /cvs/src/usr.sbin/eigrpd/parse.y,v retrieving revision 1.23 diff -u -p -r1.23 parse.y --- parse.y

snmpd/parse.y : fix line count

2018-06-02 Thread Denis Fondras
Applying otto@'s diff to snmpd. Fixes an off-by-one line count when using include statements. Ok ? Index: parse.y === RCS file: /cvs/src/usr.sbin/snmpd/parse.y,v retrieving revision 1.47 diff -u -p -r1.47 parse.y --- parse.y 26

switchd/parse.y : fix line count

2018-06-02 Thread Denis Fondras
Applying otto@'s diff to switchd. Fixes an off-by-one line count when using include statements. Ok ? Index: parse.y === RCS file: /cvs/src/usr.sbin/switchd/parse.y,v retrieving revision 1.6 diff -u -p -r1.6 parse.y --- parse.y

iked/parse.y : fix line count

2018-06-02 Thread Denis Fondras
Applying otto@'s diff to iked. Fixes an off-by-one line count when using include statements. Ok ? Index: parse.y === RCS file: /cvs/src/sbin/iked/parse.y,v retrieving revision 1.71 diff -u -p -r1.71 parse.y --- parse.y 26 Apr

httpd/parse.y : fix line count

2018-06-02 Thread Denis Fondras
Applying otto@'s diff to httpd. Fixes an off-by-one line count when using include statements. Ok ? Index: parse.y === RCS file: /cvs/src/usr.sbin/httpd/parse.y,v retrieving revision 1.99 diff -u -p -r1.99 parse.y --- parse.y 23

iscsictl/parse.y : fix line count

2018-06-02 Thread Denis Fondras
Applying otto@'s diff to iscsictl. Fixes an off-by-one line count when using include statements. Ok ? Index: parse.y === RCS file: /cvs/src/usr.sbin/iscsictl/parse.y,v retrieving revision 1.11 diff -u -p -r1.11 parse.y --- parse.y

vmd/parse.y : fix line count

2018-06-02 Thread Denis Fondras
Applying otto@'s diff to vmd. Fixes an off-by-one line count when using include statements. Ok ? Index: parse.y === RCS file: /cvs/src/usr.sbin/vmd/parse.y,v retrieving revision 1.33 diff -u -p -r1.33 parse.y --- parse.y 26 Apr

ldpd/parse.y : fix line count

2018-06-02 Thread Denis Fondras
Applying otto@'s diff to ldpd. Fixes an off-by-one line count when using include statements. Ok ? Index: parse.y === RCS file: /cvs/src/usr.sbin/ldpd/parse.y,v retrieving revision 1.62 diff -u -p -r1.62 parse.y --- parse.y 26

ospf6d/parse.y : fix line count

2018-06-02 Thread Denis Fondras
Applying otto@'s diff to ospf6d. Fixes an off-by-one line count when using include statements. Ok ? Index: parse.y === RCS file: /cvs/src/usr.sbin/ospf6d/parse.y,v retrieving revision 1.31 diff -u -p -r1.31 parse.y --- parse.y

ldapd/parse.y : fix line count

2018-06-02 Thread Denis Fondras
Applying otto@'s diff to ldapd. Fixes an off-by-one line count when using include statements. Ok ? Index: parse.y === RCS file: /cvs/src/usr.sbin/ldapd/parse.y,v retrieving revision 1.28 diff -u -p -r1.28 parse.y --- parse.y 18

ypldap/parse.y : fix line count

2018-06-02 Thread Denis Fondras
Applying otto@'s diff to ypldap. Fixes an off-by-one line count when using include statements. Ok ? Index: parse.y === RCS file: /cvs/src/usr.sbin/ypldap/parse.y,v retrieving revision 1.24 diff -u -p -r1.24 parse.y --- parse.y

relayd/parse.y : fix line count

2018-06-02 Thread Denis Fondras
Applying otto@'s diff to relayd. Fixes an off-by-one line count when using include statements. Ok ? Index: parse.y === RCS file: /cvs/src/usr.sbin/relayd/parse.y,v retrieving revision 1.223 diff -u -p -r1.223 parse.y --- parse.y

regress/rtable coredump

2018-06-22 Thread Denis Fondras
When trying to add multiple time the same prefix, ./fullfeed/fullfeed throws 'Segmentation fault (core dumped)'. Here is a fix : Index: util.c === RCS file: /cvs/src/regress/sys/net/rtable/util.c,v retrieving revision 1.6 diff -u -p

uipc_domain.c : use constant instead of value

2018-06-23 Thread Denis Fondras
Cosmetic change. Index: uipc_domain.c === RCS file: /cvs/src/sys/kern/uipc_domain.c,v retrieving revision 1.55 diff -u -p -r1.55 uipc_domain.c --- uipc_domain.c 23 Nov 2017 13:45:46 - 1.55 +++ uipc_domain.c 23

Fix a kernelpanic when playing with rdomain(4) and enc(4)

2018-06-24 Thread Denis Fondras
When removing enc(4) interface from rdomain, the kernel panics randomly (memcpy() seems to copy outside of the mallocarray() boundaries) with something like : Data modified on freelist: word -35183699295756 of object 0x8059da80 size 0x8 previous type free (invalid addr

[diff] deleting lo(4) with rdomain

2018-06-23 Thread Denis Fondras
Here is a diff to allow deletion of lo(4) created by rdomain. Of course, lo(4) cannot be deleted while the rdomain is used on another interface. rtable is still available after all the interfaces are out of the rdomain though. [denis@visigoth:~] doas ifconfig em0 rdomain 3 [denis@visigoth:~]

IPv6 over VPLS

2017-12-27 Thread Denis Fondras
Hi, I am trying to make IPv6 over VPLS. I updated ldpd(8) to install MPLS route for IPv6 nexthop. I can see the routes but when pinging the destination I get "No route to host". Can someone give me a pointer for the next step ? Thank you in advance, Denis * Without the patch : mpls1# route -n

[patch] IPv6 over VPLS

2017-12-27 Thread Denis Fondras
Hi, Here are 2 patches to enable IPv6 over VPLS. One for ldpd(8) and one for the kernel. Denis Index: if_ethersubr.c === RCS file: /cvs/src/sys/net/if_ethersubr.c,v retrieving revision 1.246 diff -u -p -r1.246 if_ethersubr.c ---

remove link from oce.4

2018-01-28 Thread Denis Fondras
Hi, The link to Emulex website is not available anymore. Remove it. Denis Index: oce.4 === RCS file: /cvs/src/share/man/man4/oce.4,v retrieving revision 1.3 diff -u -p -r1.3 oce.4 --- oce.4 15 Aug 2012 18:10:06 - 1.3

Re: ospfd: prevent additional ospfd from starting

2018-08-21 Thread Denis Fondras
On Tue, Aug 21, 2018 at 05:16:47PM +0200, Remi Locherer wrote: > Hi tech, > > recently we had a short outage in our network. A script started an additional > ospfd instance because the -n flag for config test was missing. > > What then happend was not nice: > - The new ospfd unlinked the control

Re: bgpd, log updates and invalid path

2018-08-29 Thread Denis Fondras
On Wed, Aug 29, 2018 at 11:49:16AM +0200, Claudio Jeker wrote: > Currently if a path is rejected because of parse errors there is only > a generic error message logged but it is not clear which prefix caused it. > Lets make this at least more obvious when 'log updates' is used. > > OK? OK denis@

Re: bgpd: allow dumping of invalid paths via control socket

2018-08-29 Thread Denis Fondras
On Wed, Aug 29, 2018 at 01:07:33PM +0200, Claudio Jeker wrote: > This is the bgpd diff that allows bgpctl to show invalid / error paths > which act as an implicit withdraw. > > While there also fix 'bgpctl show rib in nei foo' since until now that > code actually printed the same as 'bgpctl show

Re: bgpd: allow dumping of invalid paths via control socket

2018-08-29 Thread Denis Fondras
On Wed, Aug 29, 2018 at 01:10:41PM +0200, Claudio Jeker wrote: > On Wed, Aug 29, 2018 at 01:07:33PM +0200, Claudio Jeker wrote: > > This is the bgpd diff that allows bgpctl to show invalid / error paths > > which act as an implicit withdraw. > > > > While there also fix 'bgpctl show rib in nei

bgpd, allow for bigger (prefixlist) macros

2018-09-04 Thread Denis Fondras
Hi, While generating big prefixlists macros with bgpq3 (big like as2914:as-europe-v6 for example), OpenBGPd cannot load the config file (error "string too long"). This diff implements a dynamic buffer to overcome this limitation. Index: parse.y

Re: bgpd, streamline aspath matching

2018-09-04 Thread Denis Fondras
On Tue, Sep 04, 2018 at 01:56:12PM +0200, Claudio Jeker wrote: > On Mon, Aug 27, 2018 at 12:11:43PM +0200, Claudio Jeker wrote: > > This is in preparation for introducing as-sets (a fast lookup table for > > when you want to make sure that your peering partner is realy only passing > > you traffic

Re: bgpd diff

2018-09-04 Thread Denis Fondras
On Tue, Sep 04, 2018 at 12:56:52PM +0200, Claudio Jeker wrote: > Yet another minor bgpd diff from a much bigger diff. This adds > inet4applymask() similar to inet6applymask() and starts using it in a few > places. This makes some of the INET vs INET6 cases more similar. > > OK? OK denis@ > --

Re: Fix a kernelpanic when playing with rdomain(4) and enc(4)

2018-07-08 Thread Denis Fondras
OK denis@ On Sun, Jul 08, 2018 at 02:04:56PM +0200, Jeremie Courreges-Anglas wrote: > On Sun, Jul 08 2018, Jeremie Courreges-Anglas wrote: > > On Sun, Jun 24 2018, Denis Fondras wrote: > >> When removing enc(4) interface from rdomain, the kernel panics randomly > >&

Re: bgpd, don't allocate initial aspath for update parsing

2018-07-09 Thread Denis Fondras
On Mon, Jul 09, 2018 at 05:47:11PM +0200, Claudio Jeker wrote: > Similar to the rde_filter code there is no need to path_get() the aspath > used in rde_update_dispatch(). Also makes the code a bit easier since the > cleanup can be done all the time. > looks good, compiles fine, runs well, OK

Re: bgpd: check max prefix just once

2018-07-09 Thread Denis Fondras
I am late for a comment because it has already been commited but... > @@ -1373,6 +1339,14 @@ rde_update_update(struct rde_peer *peer, > if (path_update([RIB_ADJ_IN].rib, peer, asp, prefix, prefixlen, 0)) > peer->prefix_cnt++; > > + /* max prefix checker */ > + if

Re: route: improve inet6_makenetandmask

2018-06-24 Thread Denis Fondras
On Sun, Jun 24, 2018 at 04:34:01PM +0200, Jeremie Courreges-Anglas wrote: > 3. ... why should we stop assuming that the user really means to >configure a route for a /64 if the host id part is all-zeroes? Is >this really part of what has been deprecated by RFC3587? > > I can understand

sync ldapd host*() functions with ntpd

2018-10-22 Thread Denis Fondras
Make host_*() AF-agnostic like in ntpd/pfctl/relayd host_dns() stays unchanged because of port setting. Perhaps we could handle it like in relayd ? (additional function to set port with sockaddr_storage : relay_socket_af()) Also fix lines longer than 80 chars. Regress passes, tested with this :

Re: bgpd throttling for peers

2018-10-19 Thread Denis Fondras
On Fri, Oct 19, 2018 at 05:51:20PM +0200, Claudio Jeker wrote: > On Wed, Oct 17, 2018 at 02:37:48PM +0200, Claudio Jeker wrote: > > I noticed that the throttling for peers which was added some time ago is > > incomplete. The following diff solved these issues. > > > > In rde_update_queue_runner()

Re: tcpdump: remove #ifdef INET6

2018-10-21 Thread Denis Fondras
On Sat, Sep 29, 2018 at 10:26:45PM +0200, Klemens Nanni wrote: > The build is broken with `-U INET6' anyway and I see no reason to > disable IPv6 support. > > Removing these macro guards leaves NSD and Unbound as last remaining > programs in base to have them. > > This diff also fixes an empty

httpd: sync host*() with ntpd

2018-10-21 Thread Denis Fondras
(resend with more infos by request from kn@) Sync changes to host_*() from ntpd to httpd. The diff was tested on amd64 and octeon with : - regress - curl to fetch a webpage and "listen on :: port 34125" - curl to fetch a webpage and "listen on 2001:db8::1 port 34126" - curl to fetch a webpage

httpd: sync host*() with ntpd

2018-10-21 Thread Denis Fondras
Sync changes to host_*() from ntpd to httpd. Index: parse.y === RCS file: /cvs/src/usr.sbin/httpd/parse.y,v retrieving revision 1.106 diff -u -p -r1.106 parse.y --- parse.y 7 Sep 2018 07:35:30 - 1.106 +++ parse.y

bgplg: add missing commands

2018-10-24 Thread Denis Fondras
This diff adds 2 missing commands : - show ip bgp ovs - show ip bgp ext-community Index: bgplg.h === RCS file: /cvs/src/usr.bin/bgplg/bgplg.h,v retrieving revision 1.15 diff -u -p -r1.15 bgplg.h --- bgplg.h 24 Oct 2018 09:02:48

bgplg: allow neighbors with space in name

2018-10-24 Thread Denis Fondras
I have peers with description containing spaces but bgplg won't accept that by default. I'd like some comments on that diff. It is OK for bgplgsh (show ip bgp in "Peer 1" feels OK) but not for bgplg as I have to quote the peer description in the input box (feels rather unnatural). Index: bgplg.c

Re: bgpd, Adj-RIB-Out support

2018-10-31 Thread Denis Fondras
On Wed, Oct 31, 2018 at 04:24:49PM +0100, Claudio Jeker wrote: > This diff introduces a real Adj-RIB-Out. It is the minimal change to > introduce the new RIB. This removes the update_rib introduced before 6.4 > lock because that is now replaced with a real RIB. > The code used by bgpctl show rib

Re: bgpd, Adj-RIB-Out support

2018-11-01 Thread Denis Fondras
On Wed, Oct 31, 2018 at 10:02:05PM -0400, David Higgs wrote: > On Wed, Oct 31, 2018 at 6:58 PM Sebastian Benoit wrote: > > > > On a phone, saw some typos and such, sorry no diff. > > [benoit@border2:~]$ cat before > > RDE memory statistics > > 715727 IPv4 unicast network entries using

Re: bgpd, remove some no longer needed linked lists

2018-10-31 Thread Denis Fondras
On Mon, Oct 29, 2018 at 11:08:12AM +0100, Claudio Jeker wrote: > On Mon, Oct 29, 2018 at 10:58:36AM +0100, Claudio Jeker wrote: > > With the last commit the rde_aspath no longer needs to have a list of > > prefixes and also the peer no longer need to have a list of aspaths. > > This diff removes

Re: bgpd, use correct size for ASPATH_HEADER_SIZE

2018-10-25 Thread Denis Fondras
On Thu, Oct 25, 2018 at 10:57:58AM +0200, Claudio Jeker wrote: > Currently struct aspath is defined with a placeholder for the dynamic data > part. > struct aspath { > LIST_ENTRY(aspath) entry; > int refcnt; /* reference count */ > u_int16_t

Re: bgplg: allow neighbors with space in name

2018-10-25 Thread Denis Fondras
On Thu, Oct 25, 2018 at 02:04:10PM +0100, Stuart Henderson wrote: > On 2018/10/24 17:38, Denis Fondras wrote: > > I have peers with description containing spaces but bgplg won't accept that > > by > > default. > > > > I'd like some comments on that diff. >

bgplg: fix crash (error 500)

2018-10-25 Thread Denis Fondras
Just make sure arg is not NULL in lg_getarg() before accessing. It happens when input contains an invalid character. Unrelated but while at it, abort earlier in lg_arg2argv() if there is no argument available. Index: bgplg.c === RCS

Re: bgpd: replace some more walkers with rib_dump

2018-10-25 Thread Denis Fondras
On Thu, Oct 25, 2018 at 08:51:30AM +0200, Claudio Jeker wrote: > Next step on my quest to make the RIB code better. > This changes the following things: > - network_flush is now using rib_dump_new to walk the Adj-RIB-In and > remove all dynamically added announcements > - peer_flush got

bgplg: keep all args on submit

2018-10-27 Thread Denis Fondras
When submitting a command in bgplg(8), argument is not kept in its entirety (split on space) which can be annoying ie. when querying extended community. Fix this by printing request before splitting. Index: bgplg.c === RCS file:

Re: bgpd, Adj-RIB-Out support

2018-11-03 Thread Denis Fondras
On Wed, Oct 31, 2018 at 09:02:16PM +0100, Denis Fondras wrote: > On Wed, Oct 31, 2018 at 04:24:49PM +0100, Claudio Jeker wrote: > > This diff introduces a real Adj-RIB-Out. It is the minimal change to > > introduce the new RIB. This removes the update_rib introduced before 6.4 &

bgplg: fix show ip bgp out/in

2018-10-24 Thread Denis Fondras
This may have been broken for quite some time... Fix usage message for "show ip bgp in/out" and add missing "neighbor" argument. Index: bgplg.h === RCS file: /cvs/src/usr.bin/bgplg/bgplg.h,v retrieving revision 1.14 diff -u -p

  1   2   3   4   >