Re: [patch ping.c] replace malloc memset with calloc

2014-04-22 Thread Florian Obser
Please switch it to poll(2) like ping6(8) is doing, there by side stepping the whole issue. On Tue, Apr 22, 2014 at 09:33:50AM +0200, Otto Moerbeek wrote: On Tue, Apr 22, 2014 at 02:57:54AM -0400, pe...@petermalone.org wrote: Sure - I should have spotted that. Still not there. Please use

Re: [patch ping.c] replace malloc memset with calloc

2014-04-23 Thread Florian Obser
On Tue, Apr 22, 2014 at 03:08:45PM -0400, pe...@petermalone.org wrote: Thanks Florian team. Please review the following diff. tab vs. space, more in sync with ping6 OK? diff --git ping.c ping.c index 6a13a86..29cf84c 100644 --- ping.c +++ ping.c @@ -70,6 +70,7 @@ #include ctype.h #include

Re: using -Werror-implicit-function-declaration

2014-07-10 Thread Florian Obser
/sbin: diff --git sbin/Makefile.inc sbin/Makefile.inc index 1b14860..92ca312 100644 --- sbin/Makefile.inc +++ sbin/Makefile.inc @@ -2,3 +2,4 @@ BINDIR?= /sbin LDSTATIC= ${STATIC} +CFLAGS+= -Werror-implicit-function-declaration diff --git sbin/disklabel/editor.c

Re: using -Werror-implicit-function-declaration

2014-07-11 Thread Florian Obser
usr.sbin, missing prototypes: diff --git usr.sbin/mrouted/defs.h usr.sbin/mrouted/defs.h index 4c9224a..45b060f 100644 --- usr.sbin/mrouted/defs.h +++ usr.sbin/mrouted/defs.h @@ -209,6 +209,7 @@ extern void accept_leave_message(u_int32_t src, u_int32_t dst,

Re: using -Werror-implicit-function-declaration

2014-07-11 Thread Florian Obser
usr.sbin, fix bind configure: Carefully checked that config.h and generated Makefiles don't change. diff --git usr.sbin/bind/configure usr.sbin/bind/configure index 6e280ad..db02979 100644 --- usr.sbin/bind/configure +++ usr.sbin/bind/configure @@ -4596,6 +4596,8 @@ cat confdefs.h

Re: using -Werror-implicit-function-declaration

2014-07-11 Thread Florian Obser
usr.sbin, fix nsd/unbound configure carefully checked that config.h and generated Makefiles don't change. need for _XOPEN_VERSION pointed out by guenther@ diff --git usr.sbin/nsd/configure usr.sbin/nsd/configure index d2d28c1..c2a40e8 100644 --- usr.sbin/nsd/configure +++ usr.sbin/nsd/configure

Re: using -Werror-implicit-function-declaration

2014-07-11 Thread Florian Obser
usr.sbin; enable -Werror-implicit-function-declaration: This has currently no effect on subdirs using Makefile.bsd-wrapper (bind, nginx, nsd, unbound). This is beeing worked on. With a workaround they have been tested and with the previous diffs are clean. diff --git usr.sbin/Makefile.inc

Re: recent ipv6 changes: how to pick up rtadv without an autoconf address?

2014-07-25 Thread Florian Obser
On Fri, Jul 25, 2014 at 02:28:15PM +0100, Stuart Henderson wrote: Following the recent IPv6 changes, what method should now be used to have a statically configured ipv6 address but accept router advertisements to pick up a default route? as discussed on icb:

Move sending of router solicitation packages to the kernel

2014-08-09 Thread Florian Obser
This moves sending of router solicitation packages to the kernel. With it rtsol{,d}(8) is no longer needed. Add inet6 autoconf to /etc/hostname.IF or run ifconfig IF inet6 autoconf and the kernel will start sending rtsol packages. An the following events a timer will be (re) started with a timeout

Re: Bug in gethostbyaddr and patch to solve

2014-08-26 Thread Florian Obser
On Mon, Aug 25, 2014 at 10:39:59PM -0500, Vladimir Támara Patiño wrote: Using tcpdump in a firewall with 5.5 (also happens with 5.4 and I guess with current) and certain addres of the LAN I got always a segfault. Nope, already fixed in the upcomming 5.6 release and -current.

Re: getent(1) hosts enumeration defunc

2014-10-19 Thread Florian Obser
Hi Ingo, On Sun, Oct 19, 2014 at 02:24:27AM +0200, Ingo Schwarze wrote: Hi Philip, Philip Guenther wrote on Sat, Oct 18, 2014 at 04:38:09PM -0700: Maybe we just fix getent(1) to return an error like it does for ethers? Whatever we do with gethostent(3) - maybe it's really expendable,

Re: pflow(4) without flowsrc

2013-09-02 Thread Florian Obser
On Mon, Sep 02, 2013 at 11:11:43AM +0200, Martin Pieuchot wrote: On 31/08/13(Sat) 04:28, Nathanael Rensen wrote: If no flowsrc is specified on a pflow(4) interface then the src address is determined by ip_output(). However prior to calling ip_output() pflow(4) has already calculated the UPD

INADDR_ANY in pflow(4)

2013-09-11 Thread Florian Obser
Since no one presented a case why sending from INADDR_ANY is a good thing[tm], make it clear that it won't work. The ifconfig(8) diff generates this output: $ sudo ifconfig pflow0 up $ ifconfig pflow0 pflow0: flags=1UP mtu 1492 priority: 0 pflow: sender: INVALID receiver:

Re: pflow in rdomain

2013-11-01 Thread Florian Obser
commited, thanks! On Thu, Oct 31, 2013 at 04:30:51PM +0100, Anders Berggren wrote: We tried to get pflow running in a non-default rdomain, and found this to get it going. Make sense? --- sys/net/if_pflow.c.orig Fri Sep 13 20:58:40 2013 +++ sys/net/if_pflow.cMon Sep 16 13:25:54

bgpd: fib-priority

2013-11-06 Thread Florian Obser
First stab, only lightly tested, reload is *not* working. I need to think a bit more how to handle reloads exactly. Note that if you try to shoot yourself in the foot by specifing another already used priority (e.g. 32), it will not only take of your foot but take the thigh right with it... (at

Re: bgpd: fib-priority

2013-11-09 Thread Florian Obser
now with reload working; check RTP_NONE fib-priority = RTP_MAX test reports / comments / OKs? diff --git bgpd.c bgpd.c index 9c48bb3..8ad95fe 100644 --- bgpd.c +++ bgpd.c @@ -43,7 +43,7 @@ int check_child(pid_t, const char *); intsend_filterset(struct imsgbuf *, struct

Re: pfsync(4) mangles prio in master/slave setup

2013-11-20 Thread Florian Obser
On Wed, Nov 20, 2013 at 01:38:11PM +0200, Alexey Suslikov wrote: On Wed, Nov 20, 2013 at 1:32 PM, Mike Belopuhov m...@belopuhov.com wrote: could you please add more description to this report since it's very hard to follow and interpret your mail. basically, when setup switches to slave,

tftp-proxy(8) with nat-to

2013-12-19 Thread Florian Obser
tftp-proxy(8) doesn't work if there is a nat gateway in the path from the client to the server. I considered changing the location of the tftp server in our network but that's not possibly because of reasons. (6) of RFC 1925 applies... With this tftp-proxy(8) grows another knob (-a) like

Re: tftp-proxy(8) with nat-to

2013-12-20 Thread Florian Obser
On Fri, Dec 20, 2013 at 01:17:08PM +1000, David Gwynne wrote: im glad you wrote a diff rather than simply complain that nat and tftp doesnt work. the moving parts generally look good to me apart from the struct src_addr and getopt chunks. please use sockaddr_storage instead of sockaddr in

Re: Important bgpd fix

2014-01-11 Thread Florian Obser
On Sat, Jan 11, 2014 at 03:07:37PM +, Stuart Henderson wrote: I'm running this on one router without seeing any problems yet, however it does not have any graceful-restart peers so it's not exactly a great test. Has anyone else tried this at all yet? Benno is running it on one of our

pflow(4): pflowproto 9

2014-01-23 Thread Florian Obser
Since we are in -beta you are all starting to test snapshots like crazy, right? Right?! Please do me a favor, if you're using pflow(4) test if your favorite collector works with pflowproto 10. Since the time_t cleanup (rev 1.34 of if_pflow.c) v10 no longer sends insane flows. I know it now works

Re: pflow(4): pflowproto 9

2014-01-23 Thread Florian Obser
to v10, however if you have some obscure collector maybe you can give v10 a quick spin and see if the collector accepts the flows. However you very likely need to migrate from v9 to v10 in the not to distant future. (after 5.5 of course) On Thu, Jan 23, 2014 at 10:08:04AM +, Florian Obser

Re: Simple static testcgi.c

2014-03-14 Thread Florian Obser
On Sat, Mar 01, 2014 at 02:27:44PM -0500, James Turner wrote: So I wanted to test out nginx and slowcgi. I started everything up and hit up localhost/cgi-bin/test-cgi. Whoops forgot to move /bin/sh into the chroot. Try again, shit forgot to chmod 555 test-cgi. heh, been there, done that :)

Re: bgpctl show_attr bad length fix

2014-03-18 Thread Florian Obser
Commited, thanks On Tue, Mar 18, 2014 at 08:57:40AM +, rivo nurges wrote: Hi! When show_attr reads data length from provided data it reads carbage to alen and fails afterwards. This patch fixes the problem by casting the data to u_char. While at it I noticed data gets assigned twice.

Re: pf.conf, comments and continuation lines

2011-06-14 Thread Florian Obser
anyone? On 05/19/2011 03:31 PM, Florian Obser wrote: Hi, I'm not sure if this is a bug or a feature. Consider the following pf.conf: # foo # bar #pass out \ pass out log \ label foo#bar\ tag FOO#BAZ pass out \ label foo#bar\ tag FOO#BAZ # /sbin/pfctl -vv -nf /home

Re: pf.conf, comments and continuation lines

2011-06-14 Thread Florian Obser
On 06/14/2011 12:54 PM, Jason McIntyre wrote: On Tue, Jun 14, 2011 at 09:59:22AM +0100, Stuart Henderson wrote: On 2011/06/14 09:33, Florian Obser wrote: anyone? This is just how it works. http://thread.gmane.org/gmane.os.openbsd.misc/144553/focus=144586 but doesn't explain the semantics

Re: pf.conf, comments and continuation lines

2011-06-14 Thread Florian Obser
On 06/14/2011 11:58 PM, Stuart Henderson wrote: On 2011/06/14 15:43, Jason McIntyre wrote: On Tue, Jun 14, 2011 at 03:58:46PM +0200, Florian Obser wrote: if you want to document it, i'd prefer to try and tuck it in nice and neat, without an example. how about rearranging the section

Re: parse.y: document quoting rules

2012-04-21 Thread Florian Obser
On 04/21/12 19:33, Jason McIntyre wrote: any dissention, or inaccuracies? jmc Index: pf.conf.5 === RCS file: /cvs/src/share/man/man5/pf.conf.5,v retrieving revision 1.513 diff -u -r1.513 pf.conf.5 --- pf.conf.5 31 Jan

Re: parse.y: document quoting rules

2012-04-21 Thread Florian Obser
On 04/21/12 20:45, Florian Obser wrote: I think it should apply to the whole grammar: This does not work (syntax error) pass in tag tag pass in tag /foo while this works: pass in tag tag pass in tag /foo Of course these rules combined are nonsense. What I meant to say: I

relayd: forward message-body for http DELETE method

2012-04-26 Thread Florian Obser
Hi, RFC 2616, section 4.3: A message-body MUST NOT be included in a request if the specification of the request method (section 5.1.1) does not allow sending an entity-body in requests. A server SHOULD read and forward a message-body on any request; if

AF_INET6 for inet_net(3)

2012-06-24 Thread Florian Obser
inet_net(3) claims only AF_INET is supported for inet_net_ntop() and inet_net_pton(). I take it this is no longer true since revision 1.7 of inet_net_ntop.c and inet_net_pton.c. --- inet_net.3~ Sun Jun 24 18:55:10 2012 +++ inet_net.3 Sun Jun 24 18:54:45 2012 @@ -84,10 +84,12 @@ as the

route(8): /prefixlen syntax for -inet6

2012-06-27 Thread Florian Obser
Hi, rant so route(8) drives me crazy. For some reason I always put -prefixlen before the address when adding IPv6 routes and route(8) happily accepts that: $ sudo route add -inet6 -prefixlen 32 2001:db8:: ::1 -blackhole add net 2001:db8::: gateway ::1 $ route -n show -inet6 |

Re: route(8): /prefixlen syntax for -inet6

2012-06-28 Thread Florian Obser
On Thu, Jun 28, 2012 at 09:55:57AM +0100, Stuart Henderson wrote: [...] # route add -inet6 ff55::1/96 ::1 add net ff55::1/96: gateway ::1 # route delete -inet6 ff55::1/96 route: writing to routing socket: No such process delete net ff55::1/96: not in table # route delete -inet6 ff55::/96

Re: ipv6 /sbin/route prefixlen annoyance

2012-07-08 Thread Florian Obser
On Sun, Jul 08, 2012 at 08:13:08PM +0200, Sebastian Benoit wrote: Consider route add -inet6 -prefixlen 64 2a00:cafe::: -prefixlen 56 ::1 This currently works (sets the route with /56), as does route add -inet6 -prefixlen 56 2a00:cafe::: ::1 (sets the route with /64).

Re: Huawei E303

2012-07-17 Thread Florian Obser
On Tue, Jul 17, 2012 at 11:06:38AM +0100, Stuart Henderson wrote: On 2012/07/16 20:22, Andreas Bartelt wrote: Is there a way to automatically receive a DNS resolver config for /etc/resolv.conf from the mobile ISP? (currently I use the DNS resolver at my local network...) Personally I'm

use time_uptime for various pf expirations

2012-07-28 Thread Florian Obser
Benno and me were looking into why pflow is sending flows with starttime after endtime. We believe this was introduced with this commit: CVSROOT:/cvs Module name:src Changes by: d...@cvs.openbsd.org

Re: use time_uptime for various pf expirations

2012-07-30 Thread Florian Obser
On Mon, Jul 30, 2012 at 12:07:15AM +0200, Hrvoje Popovski wrote: On 29.7.2012. 18:09, Mike Belopuhov wrote: On Sun, Jul 29, 2012 at 5:47 PM, Hrvoje Popovski wrote: Hello, i have tested your patches with torrent box behind 2 firewalls (nat, carp,pfsync). One firewall is patched and

mg: find-file file in current window

2012-08-29 Thread Florian Obser
Hi, while looking why sometimes line numbers are wrong in mg I found this: 1) mg theo.c 2) move around in file 3) C-x C-f theo.c 4) the cursor will be at the end of the buffer (sometimes one line after the end of the buffer) and the line number is not updated. If there is another file open

Re: mg: find-file file in current window

2012-08-29 Thread Florian Obser
On 08/29/12 22:25, Mark Lumsden wrote: On Wed, Aug 29, 2012 at 05:55:58PM +, Florian Obser wrote: Hi, while looking why sometimes line numbers are wrong in mg I found this: 1) mg theo.c 2) move around in file 3) C-x C-f theo.c 4) the cursor will be at the end of the buffer (sometimes

mg: wrong line number after isearch-backward

2012-09-04 Thread Florian Obser
On Tue, Sep 04, 2012 at 09:32:21AM +, Mark Lumsden wrote: If you don't mind, could you send the diff to tech@? If there are no objections, I'll commit the diff at the weekend. mark The while loop in backsrch in search.c decrements nline even if the pattern ends up not matching. 1) jot

Re: proto cksum madness

2012-09-23 Thread Florian Obser
On Thu, Sep 20, 2012 at 08:16:11PM +0200, Henning Brauer wrote: so, resurrecting, slighly updated diff. I need your help testing. This diff has a kinda high breakage potential, since there are quite a few output pathes. On the plus side breakage is easy to spot, since that'll result in bad

Re: mg: revert-buffer

2012-10-12 Thread Florian Obser
On 10/12/2012 02:49 PM, Jasper Lievisse Adriaanse wrote: Here's an updated diff that doesn't mix buffername with filenames. Index: basic.c === RCS file: /cvs/src/usr.bin/mg/basic.c,v retrieving revision 1.37 diff -p -u -r1.37

mg: be more aggressive in checkdirty

2012-10-13 Thread Florian Obser
mg currently detects a file change behind it's back only when it resumes (in ttreinit()). I need this for an upcomming patch which promts File changed on disk; really edit the buffer (y, n or r) ok? -- I'm not entirely sure you are real. Index: buffer.c

Re: mg: prompt for revert on dirty buffer

2012-10-14 Thread Florian Obser
Updated diff, on pressing the wrong key the prompt should be Please answer y, n or r. pointed out by lum@, thanks! diff --git buffer.c buffer.c index 60076bb..6bce870 100644 --- buffer.c +++ buffer.c @@ -856,11 +856,18 @@ checkdirty(struct buffer *bp) bp-b_flag |=

mg: remove b_undopos

2012-11-03 Thread Florian Obser
Found while investigating a llvm report. Since this doesn't actually do anything, the dot handling of undo (i.e. move dot to where an undo is happening) is fine afaic, I'd like to remove this. Unless someone has a diff to make this useful... Also note the rather elaborate way an int is set to

ospf6d: redistribute blackholed default

2012-12-13 Thread Florian Obser
kroute.c rev 1.69 of ospfd for ospf6d date: 2009/06/02 20:16:59; author: claudio; state: Exp; lines: +13 -3 Track reject and blackhole routes and allow them to be redistributed even though they point to the loopback.

mg: shuffle shell-command-on-region around

2012-12-18 Thread Florian Obser
Shuffle shell-command-on-region around to make pipeio() useable for other functions. (Needed for an upcomming diff for diff-buffer-with-file.) While there: - generate error message when exec fails - prevent busy wait in poll when nothing more has to be written - use return value of eread, not the

mg: diff-buffer-with-file

2012-12-18 Thread Florian Obser
before: me: *edit* *edit* C-x C-s mg: File has changed on disk since last save. Save anyway? me: uh oh now: me: *edit* *edit* C-x C-s mg: File has changed on disk since last save. Save anyway? me: no; M-x diff-buffer-with-file Comments, ok? diff --git buffer.c buffer.c index 0b16af1..a2e692f

Re: mg: shuffle shell-command-on-region around

2012-12-19 Thread Florian Obser
updated diff: - pull output buffer creation up to piperegion - pull message Shell command succeeded with no output up to piperegion - erase echo line diff --git def.h def.h index a99421c..3c7702c 100644 --- def.h +++ def.h @@ -591,6 +591,8 @@ int region_get_data(struct region *, char *,

Re: mg: diff-buffer-with-file

2012-12-19 Thread Florian Obser
updated diff: - make error message more clear when access(DIFFTOOL, X_OK) fails - name output buffer *Diff* to make it more emacs-like - make message more emacs-like when there is no diff input gsoares@, Sunil Nimmagadda diff --git buffer.c buffer.c index 0b16af1..424f3a7 100644 --- buffer.c +++

Re: evince segfaults in sse2_composite_over_n_8_8888, i386, Dec 12 snapshot

2012-12-22 Thread Florian Obser
not a ports issue] On 12/21/12 17:40, Florian Obser wrote: Hi, evince-3.6.1 segfaults with this pdf: http://gowers.files.wordpress.com/2012/02/elsevierstatementfinal.pdf I tried a known good pdf (used to work in september) and get the same bt. works for me

Re: evince segfaults in sse2_composite_over_n_8_8888, i386, Dec 12 snapshot

2012-12-22 Thread Florian Obser
On Sat, Dec 22, 2012 at 08:33:47PM +0100, Mark Kettenis wrote: Date: Sat, 22 Dec 2012 20:19:17 +0100 (CET) From: Mark Kettenis mark.kette...@xs4all.nl Date: Sat, 22 Dec 2012 18:36:53 + From: Florian Obser flor...@narrans.de 0x0298c256 sse2_composite_over_n_8_+198

Re: adduser: better locked password

2013-01-04 Thread Florian Obser
On Fri, Jan 04, 2013 at 10:11:35PM +0100, Tobias Ulmer wrote: I guess there are at least three related issues: [...] - security(8) flags empty authorized_keys files. Looking at check_passwd() it seems a .ssh directory is enough to trigger the warning. That seems a bit excessive. Anyone

mg: don't spin when stdin is lost

2013-01-14 Thread Florian Obser
this can be tested like this: EDITOR=mg cvs commit kill cvs - mg spins with 100% cpu in ttgetc While there prevent an unterminated recursion in panic (via ttclose). I'm not particularly happy with the errorhandling in ttgetc, but this is the least intrusive change. comments, oks? diff --git

mg(1): don't handroll TAILQ_REMOVE

2013-02-15 Thread Florian Obser
While the handrolled version works in this case it thrashes the TAILQ and sets a bad example. OK? diff --git a/buffer.c b/buffer.c index 0b590eb..440d9f0 100644 --- a/buffer.c +++ b/buffer.c @@ -153,7 +153,7 @@ killbuffer(struct buffer *bp) struct buffer *bp2; struct mgwin *wp;

Re: mg(1): don't handroll TAILQ_REMOVE

2013-02-15 Thread Florian Obser
On Fri, Feb 15, 2013 at 02:07:31PM +, Florian Obser wrote: While the handrolled version works in this case it thrashes the TAILQ and sets a bad example. OK? irgs, throw away undo history of the killed buffer, not current buffer. sorry about that. diff --git a/buffer.c b/buffer.c index

bgpd(8): fix sizeof(struct)

2013-03-14 Thread Florian Obser
found by llvm ok? Index: rde_rib.c === RCS file: /cvs/src/usr.sbin/bgpd/rde_rib.c,v retrieving revision 1.134 diff -u -p -r1.134 rde_rib.c --- rde_rib.c 12 Sep 2012 05:56:22 - 1.134 +++ rde_rib.c 14 Mar 2013 13:07:30

bgpd(8): fix use after free

2013-03-14 Thread Florian Obser
33% found by llvm. The -1 is propagated up from a failed calloc in kif_kr_insert/kif_kr6_insert. ok? Index: kroute.c === RCS file: /cvs/src/usr.sbin/bgpd/kroute.c,v retrieving revision 1.191 diff -u -p -r1.191 kroute.c --- kroute.c

Re: getent(1) hosts enumeration defunc (getent.c 1.6)

2013-04-26 Thread Florian Obser
On Fri, Apr 26, 2013 at 12:57:32PM +0200, MERIGHI Marcus wrote: there is no more listing (enumerating) of hosts entries. Suspect: [1] [...] [1] http://www.openbsd.org/cgi-bin/cvsweb/src/usr.bin/getent/getent.c.diff?r1=1.5;r2=1.6 OpenBSD 5.3-current (GENERIC.MP) #103: Wed Apr 24 09:33:02 MDT

pflow(4): export ingress/egress interface index

2013-05-03 Thread Florian Obser
Chris Ivancic Colin Ligertwood reported in January that the SolarWinds NetFlow Traffic Analyzer doesn't like it if the ingress/egress interface index is always 0 (v5) or not present at all (v9/v10). This keeps track on which interface a packet for a state was first observed / first left and

Re: mg(1): shell-command

2013-05-22 Thread Florian Obser
On Tue, May 21, 2013 at 07:54:31PM +, Mark Lumsden wrote: This diff modifies the shell-command-on-region function and gives us shell-command. It makes getting output from other commands into mg really easy. Comments/oks? -lum Index: def.h

changing router-ids in ospfd not working

2010-01-07 Thread Florian Obser
Hello, ospfd can't handle changing router-ids. Consider the following setup, two machines, border3 / superm: border3: border3# cat /etc/ospfd.conf router-id 10.12.95.250 redistribute static set type 2 redistribute connected set type 2 redistribute 10.12.95.250/32 set type 2

Re: mg: exit code cleanup

2014-11-13 Thread Florian Obser
Commited, thanks! On Sun, Nov 09, 2014 at 08:40:03PM +0100, Martin Natano wrote: mg(1) calls 'exit(1)' on failure, but 'exit(GOOD)' on success. In my opinion it would be more readable to just use 'exit(0)' for a normal exit. (If there really is the need for a define, EXIT_SUCCESS would be a

relayd errata Nov 17

2014-11-17 Thread Florian Obser
This patch fixes a relayd crash for the 5.6 release. untrusted comment: signature from openbsd 5.6 base private key RWR0EANmo9nqhgFKMGabOlUXoxAuey9xQyKcm0OULFMOSkyd3ReQHQjwA1psSBbqu1ex9j28D/nyEh6U8uj8f2oFZtXoHA7njAg= OpenBSD 5.6 errata 6, Nov 17, 2014: Fix for relayd crash Apply patch using:

Re: rtadvd on OpenBSD 5.6 with Comcast cable connection

2015-01-01 Thread Florian Obser
(moved to tech@) On Thu, Jan 01, 2015 at 11:51:32AM -0600, Aaron Riekenberg wrote: I found some other reports of the same problem with rtadvd logging excessive messages about router advertisements on the external non-advertising interface. From OpenBSD 5.2:

Re: 5.6, IPv6: is autoconf set by default?

2015-01-10 Thread Florian Obser
On Sat, Jan 10, 2015 at 02:07:49PM +, Stuart Henderson wrote: [moved from misc@] On 2015-01-08, Josh Grosse j...@jggimi.homeip.net wrote: On Thu, Jan 08, 2015 at 03:20:46PM +, Florian Obser wrote: [...] eui64 Fill the interface index (the lowermost 64th bit of an IPv6

Re: mg(1) segfaults on scroll-down

2015-03-24 Thread Florian Obser
Hi, On Wed, Mar 18, 2015 at 01:35:08PM +0200, Kaspars Bankovskis wrote: Hi, to reproduce the issue: (1) start mg and press Enter, until you fill up the screen and it goes on to the next screen. (2) type in at least one character (3) press M-v (or execute command scroll-down) (4) mg

Re: Small ifconfig output tweak for inet6?

2015-03-26 Thread Florian Obser
On Thu, Mar 26, 2015 at 05:46:12PM +0100, Henning Brauer wrote: * Mike Belopuhov m...@belopuhov.com [2015-03-26 14:36]: however I agree that if we do this for ipv6 we should do it for ipv4 as well but then do we care about tons of stuff out there parsing ifconfig output? that's the prime

Re: Small ifconfig output tweak for inet6?

2015-03-26 Thread Florian Obser
On Thu, Mar 26, 2015 at 01:48:03PM +0100, Martin Pieuchot wrote: How do people feel about printing the prefixlen in CIDR notation? I'm annoyed about outputs not fitting in 80 chars when using autoconf magic: -inet6 fd00::f2de:f1ff:fe6a:15d1 prefixlen 64 autoconf pltime 3594 vltime 7194

Re: Small ifconfig output tweak for inet6?

2015-03-26 Thread Florian Obser
On Thu, Mar 26, 2015 at 06:50:37PM +0100, Martin Pieuchot wrote: On 26/03/15(Thu) 17:39, Florian Obser wrote: On Thu, Mar 26, 2015 at 01:48:03PM +0100, Martin Pieuchot wrote: How do people feel about printing the prefixlen in CIDR notation? I'm annoyed about outputs not fitting in 80

Re: httpd fastcgi diff

2015-03-25 Thread Florian Obser
On Wed, Mar 25, 2015 at 10:20:53PM +0100, Tim van der Molen wrote: I'm using the hgweb.cgi Python script to serve Mercurial repositories over HTTP. When served by httpd, hgweb.cgi does not work well with the hg command-line utility. For example, this doesn't work: $ hg clone

Re: allow stateless address auto configuration when v6 forwarding is enabled

2015-03-23 Thread Florian Obser
On Mon, Mar 23, 2015 at 08:22:46PM +0100, Stefan Sperling wrote: On Mon, Mar 23, 2015 at 06:21:40PM +, Florian Obser wrote: [ this originated on misc@: https://marc.info/?t=14170362181r=1w=2 ] so there are setups out there where a router gets a default route (and maybe a prefix

allow stateless address auto configuration when v6 forwarding is enabled

2015-03-23 Thread Florian Obser
[ this originated on misc@: https://marc.info/?t=14170362181r=1w=2 ] so there are setups out there where a router gets a default route (and maybe a prefix) via SLAAC (think dsl / cable line). Currently the kernel does not accept a default route via SLAAC when forwarding is enabled. Since we

Re: Byte range implementation for httpd(8)

2015-05-02 Thread Florian Obser
Sorry for the very late reply, I'm currently very busy :/ On Fri, Apr 17, 2015 at 05:04:01AM +0200, Sunil Nimmagadda wrote: Range requests as defined in RFC7233 is required for resuming interrupted http(s) downloads for example: ftp -C http://foo.bar/install57.iso With this diff, httpd

Re: Byte range implementation for httpd(8)

2015-05-03 Thread Florian Obser
On Sun, May 03, 2015 at 01:46:56PM +0200, Sunil Nimmagadda wrote: On Sat, May 02, 2015 at 02:49:30PM +, Florian Obser wrote: Sorry for the very late reply, I'm currently very busy :/ Thank you for taking time to review it. A new patch with style nits fixed and a gratuitous NULL check

Re: [PATCH] Support If-Modified-Since header on requests in httpd

2015-05-03 Thread Florian Obser
On Sat, Apr 18, 2015 at 12:19:46PM -0500, jmp wrote: I found 'timeoff' to be useful for converting to a time_t that is in GMT; however, did not find documentation on this in the man pages. It seems to be a function dating back to at least the NetBSD fork. If there is a better time function I

Re: [PATCH] Support If-Modified-Since header on requests in httpd

2015-05-03 Thread Florian Obser
On Sun, May 03, 2015 at 11:14:48AM -0500, Kyle Thompson wrote: On Sun, May 03, 2015 at 03:00:40PM +, Florian Obser wrote: On Sat, Apr 18, 2015 at 12:19:46PM -0500, jmp wrote: RFC 7232 A recipient MUST ignore the If-Modified-Since header field if the received field-value

Re: Byte range implementation for httpd(8)

2015-05-03 Thread Florian Obser
On Sun, May 03, 2015 at 08:14:25PM +0200, Sebastian Benoit wrote: one question though: whats the reasoning behind MAX_RANGES 4? nginx seems to have a default of unlimited (which i think questionable), but what is Wasn't there a cve about this last year or so? You can try to burn cpu and io on

Re: mg(1) segfault

2015-04-04 Thread Florian Obser
On Sat, Apr 04, 2015 at 10:48:15AM -0300, Gleydson Soares wrote: mg(1) segfault. it is triggered as follows: 1- echo (start-kbd-macro) $HOME/.mg 2- open mg and type twice C-x ( find below the backtrace and a patch to fix. OK? Program received signal SIGBUS, Bus error. definemacro

Re: copy'n'paste like typo in pf.c

2015-04-05 Thread Florian Obser
On Sun, Apr 05, 2015 at 11:48:21AM +0200, Alexandr Nedvedicky wrote: Hello, when we ran PF sources through coverity we got an error as follows: 8310 if (ri-r-dst.addr.type == PF_ADDR_TABLE) 8311 pfr_update_stats(ri-r-dst.addr.p.tbl, 8312

Re: mg(1) segfault

2015-04-04 Thread Florian Obser
On Sat, Apr 04, 2015 at 03:23:45PM -0300, Gleydson Soares wrote: return (macrodef = FALSE); but we shouldn't change macrodef here. I hate the startup file. Look, this is a use after free, but I can't find it... #0 0x1b9de0b1b77f in definemacro (f=0, n=1) at

Re: [Patch] httpd - don't leak fcgi file descriptors

2015-06-09 Thread Florian Obser
On Mon, Jun 08, 2015 at 09:17:41PM +0200, Claudio Jeker wrote: On Mon, Jun 08, 2015 at 09:12:32PM +0200, Joerg Jung wrote: On Tue, Jun 02, 2015 at 05:47:47PM +0200, Claudio Jeker wrote: On Tue, Jun 02, 2015 at 01:50:35PM +0200, Joerg Jung wrote: Am 01.06.2015 um 01:25 schrieb Todd

Re: sa_family_t is not always equal to u_int8_t

2015-07-17 Thread Florian Obser
OK florian@ On Fri, Jul 17, 2015 at 01:41:17AM +0200, Alexandr Nedvedicky wrote: On Thu, Jul 16, 2015 at 11:10:06PM +, Miod Vallat wrote: cvs diff -p output: Please send unified diffs (diff -u). The easiest way is to have a diff -up line in your ~/.cvsrc file. Or diff -uNp if

httpd: hsts (rfc 6797)

2015-07-17 Thread Florian Obser
OK? diff --git httpd.conf.5 httpd.conf.5 index b3eaad8..bfca29f 100644 --- httpd.conf.5 +++ httpd.conf.5 @@ -262,6 +262,18 @@ root directory of .Xr httpd 8 and defaults to .Pa /run/slowcgi.sock . +.It Ic hsts Oo Ar option Oc +Enable HTTP Strict Transport Security. +Valid options are: +.Bl -tag

move pflow(4) to sosend(9)

2015-07-19 Thread Florian Obser
so pflow(4) shoving it's data with ip_output into the network stack seems wrong. this converts it to use sosend(9) and might even give us non-legacy IP support. tests from (heavy) pflow(4) users would be appriciated. diff --git if_pflow.c if_pflow.c index 4f3ac5e..624fdaf 100644 --- if_pflow.c

Re: [patch] update unbound forwards with dhclient nameservers

2015-07-19 Thread Florian Obser
On Sun, Jul 19, 2015 at 01:08:46PM +0200, Gregor Best wrote: Hello, the following is a patch that adds an option called `update_unbound' to dhclient.conf. With this option enabled, dhclient will call unbound-control forwards ns1 ns2 ns3 instead of rewriting /etc/resolv.conf. My

Re: [patch] update unbound forwards with dhclient nameservers

2015-07-19 Thread Florian Obser
On Sun, Jul 19, 2015 at 08:53:04PM +0200, Gregor Best wrote: On Sun, Jul 19, 2015 at 07:03:59PM +0100, Stuart Henderson wrote: [...] I'm uncertain about whether dhclient should do this at all, it seems to be the opposite of the direction dhclient has been going in recently, [...]

Re: move pflow(4) to sosend(9)

2015-07-20 Thread Florian Obser
On Mon, Jul 20, 2015 at 06:58:06PM +0200, Alexander Bluhm wrote: On Mon, Jul 20, 2015 at 01:09:07AM +, Florian Obser wrote: - s = splnet(); + s = splnet(); pflow_flush(sc); + splx(s); This splx() looks strange, too. Why flush something

Re: move pflow(4) to sosend(9)

2015-07-20 Thread Florian Obser
new diff, should address all comments: diff --git if_pflow.c if_pflow.c index 4f3ac5e..676829d 100644 --- if_pflow.c +++ if_pflow.c @@ -28,6 +28,8 @@ #include sys/timeout.h #include sys/ioctl.h #include sys/kernel.h +#include sys/socket.h +#include sys/socketvar.h #include sys/sysctl.h

Re: The router doesn't know the size of the internet...

2015-10-24 Thread Florian Obser
On Sat, Oct 24, 2015 at 06:15:48PM +0200, Sebastian Benoit wrote: > Alexander Bluhm(alexander.bl...@gmx.net) on 2015.10.24 17:21:27 +0200: > > On Sat, Oct 24, 2015 at 04:02:59PM +0200, Martin Pieuchot wrote: > > > ...at least better than OpenBSD's source code. > > > > > > This diff gets rid of

#include cleanup for ping6

2015-11-04 Thread Florian Obser
I think this is correct... OK? diff --git ping6.c ping6.c index 2c786f9..8e42ade 100644 --- ping6.c +++ ping6.c @@ -81,35 +81,29 @@ */ #include -#include #include - -#include -#include +#include #include #include #include #include #include -#include #include #include

ping6(8): cleanup getaddrinfo

2015-08-30 Thread Florian Obser
switch ping6(8) to the canonical example from getaddrinfo(3): error = getaddrinfo(..., res0); if (error) errx(1,...); [do stuff] freeaddrinfo(res0); I find this easier on the eyes: Hold on, why is it using a different struct addrinfo here? Why is it not calling freeaddrinfo(3)? Is it

remove RH0 support from ping6(8)

2015-08-30 Thread Florian Obser
RH0 has been deprecated for quite some time now in RFC 5095. It's quite useless on OpenBSD since our stack unconditionally drops packets with a RH0 header so you can't get the packet out anyway. And last but not least it might get in the way if I ever manage to unify ping(8) and ping6(8). OK?

IPv6 transport for pflow(4)

2015-09-13 Thread Florian Obser
I don't really like to store struct sockaddr_storage since it's so big. I played around with a union like pf does, but looked complicated. Thoughts? Also with this you can specify a source port. Since I was touching all those lines anyway I renamed sender to flowsrc and receiver to flowdst like

Re: IPv6 transport for pflow(4)

2015-09-13 Thread Florian Obser
On Sun, Sep 13, 2015 at 03:25:16PM +, Florian Obser wrote: > I don't really like to store struct sockaddr_storage since it's so > big. I played around with a union like pf does, but looked > complicated. > Thoughts? > > Also with this you can specify a source port. > Sin

pflow(4): reshuffle socreate(9)

2015-09-12 Thread Florian Obser
Call socreate(9) only when we have a destination ip and port. Call sobind(9) only when we have a source ip. With this we can treat sc->so != NULL as a flag if the interface is in state IFF_RUNNING. OK? diff --git if_pflow.c if_pflow.c index c70ad81..829ec72 100644 --- if_pflow.c +++ if_pflow.c

Re: ping6: out of boundary access with invalid packets

2015-09-09 Thread Florian Obser
On Tue, Sep 08, 2015 at 09:45:06PM +0200, Tobias Stoeckmann wrote: > The function pr_pack does not properly check boundaries before > accessing packet data. This could happen on short network reads or > when we receive packets that are addressed for another running ping6 > instance (see pr_pack

ping(8) / ping6(8) source address

2015-11-29 Thread Florian Obser
Inspired by the traceroute / traceroute6 merge. At least reduces the diff in the option parser :) OK? diff --git ping/ping.c ping/ping.c index f5ccaca..4944f77 100644 --- ping/ping.c +++ ping/ping.c @@ -110,7 +110,7 @@ int options; #defineF_SO_DEBUG 0x0040 /*

Re: rtadvd: remove router renumbering support

2015-11-30 Thread Florian Obser
yes please. while in there you should deleted the commented .Fl m from the man page, too. OK florian@ On Mon, Nov 30, 2015 at 08:12:32PM +0100, Jeremie Courreges-Anglas wrote: > > ie. https://tools.ietf.org/html/rfc2894 > > This code has been rotting since a long time, only activated during two

Re: rtadvd: useless argument/checks in if.c:get_next_msg()

2015-11-30 Thread Florian Obser
OK florian@ On Mon, Nov 30, 2015 at 01:58:16PM +0100, Jeremie Courreges-Anglas wrote: > > Hi, > > get_next_msg() takes an "ifindex" argument, and contains code to check > whether the interface affected by a routing message is "the correct > one". Those tests have always been meaningless since

  1   2   3   4   5   6   7   8   >