Re: LibreSSL OPENSSL_malloc... removal

2014-04-22 Thread Ingo Schwarze
Hi, Vadim Lebedev wrote on Tue, Apr 22, 2014 at 01:17:16PM +: Theo de Raadt deraadt at cvs.openbsd.org writes: Vadim Lebedev wrote: The removal of OPENSSL_malloc/OPENSSL_free ... etc will cause a LOT of pain Which is why they are not removed. I was alarmed by this:

Re: Fix loop test in vipw

2014-04-26 Thread Ingo Schwarze
Hi, On Tue, Apr 22, 2014 at 01:29:03AM +, Ben Cornett wrote: The following corrects the termination condition on the write loop in copyfile. From inspection, i say the patch is clearly correct. I was unable to find any condition where the bug might actually hit: The file descriptor `to'

Re: Remove ln -F

2014-05-06 Thread Ingo Schwarze
Hi, if somebody wants to commit, ok schwarze@. Otherwise, i'm accepting OKs. See inline for a note on the history. Yours, Ingo Tristan Le Guern wrote on Mon, May 05, 2014 at 03:06:12PM +0200: This patch removes the undocumented ln flag -F, which forces the creation of a hard link for a

Re: Remove ln -F

2014-05-07 Thread Ingo Schwarze
Hi, Philip Guenther wrote on Tue, May 06, 2014 at 09:35:18AM -0700: On Tue, May 6, 2014 at 9:18 AM, Kenneth Westerback wrote: On 6 May 2014 11:45, Ingo Schwarze schwa...@usta.de wrote: if somebody wants to commit, ok schwarze@. Otherwise, i'm accepting OKs. See inline for a note

Re: Support for LC_TIME

2014-05-07 Thread Ingo Schwarze
Hi, POSIX doesn't require support for any locales except POSIX and C. While LC_CTYPE and LC_COLLATE make some sense, LC_MONETARY, LC_NUMERIC, and LC_TIME are badly overengineered, pointless bloat, causing nothing but surprising, erratic behaviour and portability problems when trying to parse

Re: zless is less

2014-05-07 Thread Ingo Schwarze
Hi Vadim, Vadim Zhukov wrote on Sat, May 03, 2014 at 05:44:26PM +0400: Just run into the following issue with zmore/zless: if you have PAGER envvar set, it's no matter whatever you'll call, zmore or zless - it'll always run $PAGER. The problem is that I have PAGER=/usr/bin/more but

Re: [PATCH] rcs void casts

2014-05-07 Thread Ingo Schwarze
Hi Fritjof, Fritjof Bornebusch wrote on Wed, May 07, 2014 at 10:32:05PM +0200: there are a few void casts in rcs. But I have a question about that. Are these casts really necessary? No, they are not necessary. I've read that the compiler warns, because of unused variables. But no compiler

Re: Fix loop test in vipw

2014-05-07 Thread Ingo Schwarze
, Ingo On Sat, Apr 26, 2014 at 10:52:50PM +0200, Ingo Schwarze wrote: On Tue, Apr 22, 2014 at 01:29:03AM +, Ben Cornett wrote: The following corrects the termination condition on the write loop in copyfile. From inspection, i say the patch is clearly correct. I was unable to find any

Re: Support for LC_TIME

2014-05-08 Thread Ingo Schwarze
Hi, Marc Espie wrote on Thu, May 08, 2014 at 07:20:52PM +0200: On Thu, May 08, 2014 at 12:07:30PM +0200, Stefan Sperling wrote: On Wed, May 07, 2014 at 07:44:51PM +0200, Ingo Schwarze wrote: While LC_CTYPE and LC_COLLATE make some sense, LC_MONETARY, LC_NUMERIC, and LC_TIME are badly

Re: compare memcmp with 0

2014-06-20 Thread Ingo Schwarze
Hi Theo, Theo de Raadt wrote on Thu, Jun 19, 2014 at 09:58:01PM -0600: It could be argued that the bcmp manual page does a poor job documenting this. It should use the mandoc blink tag. OK? It's not perfect yet because when you nest blink tags, it already switches back to non-blinking mode

Re: missing .Pa in spamdb.8

2014-06-22 Thread Ingo Schwarze
Hi Jan, committed, thanks. Ingo Jan Stary wrote on Sun, Jun 22, 2014 at 02:06:51PM +0200: Index: usr.sbin/spamdb/spamdb.8 === RCS file: /cvs/src/usr.sbin/spamdb/spamdb.8,v retrieving revision 1.17 diff -u -p -u -p -r1.17

Re: infnan.3

2014-06-22 Thread Ingo Schwarze
Hi Jan, i don't like this particular patch. It's obvious that whole page needs a content update by a VAX expert. Quibbling over formatting details is not going to fix it. Having old-fashioned formatting actually makes it even more obvious how old-fashioned the content is. Regarding the macros

Re: infnan.3

2014-06-22 Thread Ingo Schwarze
Hi Ted, Ted Unangst wrote on Sun, Jun 22, 2014 at 12:57:18PM -0400: On Sun, Jun 22, 2014 at 17:39, Ingo Schwarze wrote: i don't like this particular patch. It's obvious that whole page needs a content update by a VAX expert. Quibbling over formatting details is not going to fix it. Having

Re: infnan.3

2014-06-24 Thread Ingo Schwarze
Hi, Theo de Raadt wrote on Tue, Jun 24, 2014 at 09:09:49AM -0600: Ingo Schwarze wrote: It's obvious that whole page needs a content update by a VAX expert. that is correct. All the rest of the discussion is moot. Only miod and martynas can swing this the right way. I disagree with Ted

Re: Rename MAP_ANON to MAP_ANONYMOUS

2014-06-30 Thread Ingo Schwarze
Hi Matthew, so in a nutshell, mmap(2) was originally a BSD idea and first implemented in SunOS? And there is no doubt that *BSD always had MAP_ANON and never MAP_ANONYMOUS and that SunOS primarily defines MAP_ANON and MAP_ANONYMOUS only for /* (source compatibility) */, right? And that the

Re: daily(8) scratch and junk files removal

2014-07-02 Thread Ingo Schwarze
Hi Stuart, Stuart Henderson wrote on Wed, Jul 02, 2014 at 01:36:21PM +0100: I think this is correct. Any nay-sayers? ok schwarze@ On 2014/07/01 19:07, Rafael Zalamena wrote: I noticed a problem in one of my OpenBSD installation where tmux(1) would lose its session socket after a few

Re: Patch for caesar(6)

2014-07-03 Thread Ingo Schwarze
Hi David, David Crosby wrote on Thu, Jul 03, 2014 at 07:44:12AM -0600: This little patch fixes a compiler warning (found with WARNINGS turned on), A correct fix for that is below. OK to commit it? unambiguates the printit function, and removes an unnecessary comment. Even though we don't

Re: Patch for caesar(6)

2014-07-03 Thread Ingo Schwarze
Hi, David Crosby wrote on Thu, Jul 03, 2014 at 07:44:12AM -0600: This little patch fixes a compiler warning i just committed my version of the fix. Thanks to David for reporting the issue and to Miod for checking my patch. Yours, Ingo

Re: daily(8) scratch and junk files removal

2014-07-03 Thread Ingo Schwarze
Hi Rafael, Rafael Zalamena wrote on Wed, Jul 02, 2014 at 02:21:25PM -0300: I've made a quick test and there is no problem in 'tmux-*' existing in /var/tmp after a reboot. Running 'tmux attach' in a socket with no tmux process controlling just spits out: 'no sessions' and if you run 'tmux' a

Re: usr.bin/man: use getlist(char *) instead of hand-rolled equivalent in config(char *)

2014-07-17 Thread Ingo Schwarze
Hi, Kent R. Spillner wrote on Wed, Jun 04, 2014 at 10:01:12AM -0500: config(char *) contains a hand-rolled version of getlist(char *). Indeed. The only difference is that the hand-rolled version includes a NULL check before the strcmp. You misread the code. There is no NULL check for the

Re: man.cgi: clean exit when absent or empty manpath.conf

2014-07-18 Thread Ingo Schwarze
Salut Sebastien, Sébastien Marie wrote on Fri, Jul 18, 2014 at 08:50:17AM +0200: Starting to play with man.cgi (src/usr.bin/mandoc/cgi.c), Thank you for testing. it seems that man.cgi will segfault if configuration file is absent or empty. Here a patch that display error message and 505,

Re: [DIFF] sftp-server.8, sshd_config.5 after syslog_r change

2014-07-28 Thread Ingo Schwarze
Theo de Raadt wrote on Fri, Jul 18, 2014 at 03:04:28PM -0600: Unfortunately, no. The ssh manual pages are also used by the -portable effort. We do not bother documenting these divergences; there is little harm. Actually you could submit a new diff which suggest that logging might need a

Re: [DIFF] sftp-server.8, sshd_config.5 after syslog_r change

2014-07-28 Thread Ingo Schwarze
Theo de Raadt wrote on Mon, Jul 28, 2014 at 09:20:36AM -0600: The mention of sendsyslog is not acceptable. When this man page shows up on some other system, it will be an Xr pointing to nowhere. The information is too specific. Frankly, noone will care. Old systems will continue doing

Re: cvs log -r1.x vs. -r 1.x

2014-07-28 Thread Ingo Schwarze
Hi Stefan, Stefan Sperling wrote on Tue, Jul 15, 2014 at 12:17:08PM +0200: cvs log -r1.x shows the log entry for HEAD, instead of the log entry for 1.x as cvs -r 1.x does. The typos in this sentence confused me so thoroughly that when first looking at your mail, i didn't get your intent at

Re: Is there a repo for the latest LibreSSL portable?

2014-08-10 Thread Ingo Schwarze
Hi Nick, i'm not speaking for LibreSSL, but about OpenBSD subprojects in general; i'm running src/usr.bin/mandoc (portable version: mdocml.bsd.lv). Nicholas Wilson wrote on Sun, Aug 10, 2014 at 02:05:16PM +0100: Certainly from my point of view it would make things simpler if LibreSSL were run

Re: improve ldomctl(8) man page

2014-08-12 Thread Ingo Schwarze
Hi Stefan, Stefan Sperling wrote on Fri, Aug 08, 2014 at 08:56:30PM +0200: I can never remember the exact steps of configuring logical domains on sparc64 without referencing the undeadly article at http://undeadly.org/cgi?action=articlesid=20121214153413 It would be nice if this

new rc.conf(8) manual

2014-08-19 Thread Ingo Schwarze
Hi, while working on rcctl(8), i noticed that the rc.conf(8) manual is of... err, how can i express it politely... somewhat doubtful quality. Here is a stab at it. As a first step, i moved all the examples from the DESCRIPTION to the EXAMPLES esction. After that, the DESCRIPTION section was

Re: new rc.conf(8) manual

2014-08-19 Thread Ingo Schwarze
Hi Robert, Robert Peichaer wrote on Wed, Aug 20, 2014 at 12:39:51AM +0200: In the Base system daemon configuration variables section, in the last paragraph this is incorrect. ... including a string containing only a single blank character, ... Looking at the _rc_parse_conf() code in

Re: apmd hangs

2014-09-09 Thread Ingo Schwarze
Hi Mark, Mark Kettenis wrote on Mon, Sep 08, 2014 at 11:35:36PM +0200: The more code documentation I read, the more I'm convinced that coordinating state changes between logical processors isn't necessary and actually is responsible for the hangs people have been seeing. So here is a diff

Re: apmd hangs

2014-09-09 Thread Ingo Schwarze
Hi David, David Coppa wrote on Tue, Sep 09, 2014 at 07:44:47PM +0200: On Tue, Sep 9, 2014 at 7:27 PM, Ingo Schwarze schwa...@usta.de wrote: i'm sorry to say it makes no difference for me (i'm not opposed to the diff, though). On my laptop, building ports works fine, running firefox works

Re: apmd hangs

2014-09-09 Thread Ingo Schwarze
Hi Amit, Amit Kulkarni wrote on Tue, Sep 09, 2014 at 08:47:22PM -0500: A basic rule of thumb when building ports: raise your /etc/login.conf limits...especially datasize-cur needs to be 2G and datasize-max needs to be 3G. The reason being there are some ports where the linker blows up to 2G

Re: [PATCH] fix overflow handling in dd(1)

2014-09-14 Thread Ingo Schwarze
Hi, Todd C. Miller wrote on Fri, Sep 12, 2014 at 09:23:31AM -0600: On Thu, 11 Sep 2014 22:03:04 -0700, William Orr wrote: I'm resubmitting this patch since the source tree was locked last time I submitted. Any thoughts? I think we've discussed this one to death already. It looks fine to

Re: [PATCH] Add -d flag to du(1)

2014-09-16 Thread Ingo Schwarze
Hi, On 9/15/2014 10:58 PM, William Orr wrote: This diff adds a flag to du(1) to limit the depth of results that are displayed to the user. The semantics are equivalent to FreeBSD's, where it is mutually exclusive with -a and -s, and du -d 0 is equivalent to du -s. Thoughts? I think it's

Re: chmod.c undefined behavior

2014-09-24 Thread Ingo Schwarze
Hi Matti, Matti Karnaattu wrote on Wed, Sep 24, 2014 at 12:10:47PM +0300: I noticed that chmod.c have uninitialized variable char *ep that was used. Your analysis is wrong. The variable ep is explicitly initialized by strtoul() before being used in main(). This diff clarify what I mean.

Re: chmod.c undefined behavior

2014-09-24 Thread Ingo Schwarze
Hi Matti, Matti Karnaattu wrote on Wed, Sep 24, 2014 at 12:55:14PM +0300: I got confused for that monster main function. That is definitely overly complex I strongly disagree. That main function is good, standard style. Actually, it's good enough to be shown off as an example. A small

Re: chmod.c undefined behavior

2014-09-24 Thread Ingo Schwarze
Hi David, David Carlier wrote on Wed, Sep 24, 2014 at 10:19:57AM +0100: On 24 September 2014 10:10, Matti Karnaattu mkarnaa...@gmail.com wrote: I noticed that chmod.c have uninitialized variable char *ep that was used. This diff clarify what I mean. I might be wrong, You are. but why

Re: chmod.c undefined behavior

2014-09-24 Thread Ingo Schwarze
Hi Miod, Miod Vallat wrote on Wed, Sep 24, 2014 at 04:27:26PM +0200: There is only one goto in chmod.c. If you consider it unnecessary, I'd advise you to read the code again, and pay attention to the comment explaining that particular chunk. Heh. Read the code is almost always good advice

Re: chmod.c undefined behavior

2014-09-24 Thread Ingo Schwarze
Hi Matti, Matti Karnaattu wrote on Wed, Sep 24, 2014 at 08:14:27PM +0300: I think that it is not defined enough unambiguously, how ideal code looks like. It reduces motivation to improve code better, if it is not defined, what is better. style(9) is good, but it would be better if there is

Re: chmod.c undefined behavior

2014-09-24 Thread Ingo Schwarze
Hi Matti, Matti Karnaattu wrote on Wed, Sep 24, 2014 at 09:14:45PM +0300: Thanks for your patience. I feel like I'm querying preferred coding style by this way. That's not the *goal*, but it's an unavoidable side effect, and the more it succeeds, the easier everuthing gets for both sides.

Re: chmod.c undefined behavior

2014-09-24 Thread Ingo Schwarze
Hi Matti, Matti Karnaattu wrote on Wed, Sep 24, 2014 at 09:44:52PM +0300: And that reason, why not select single component to be as a reference? It's not really needed. If you want good examples, just look for new programs or library functions recently written from scratch by experienced

Re: groupdel(8): preserve `+' line

2014-10-04 Thread Ingo Schwarze
Hi Miod, Miod Vallat wrote on Sat, Oct 04, 2014 at 12:05:48PM +: groupdel(8) That utility is grossly disgusting. It's a pity we can't delete it completely - we have no useable replacement for groupinfo(8). All the other group(8) commands could, imho, be tedu'ed... With respect to

Re: groupdel(8): preserve `+' line

2014-10-04 Thread Ingo Schwarze
Hi Theo, Theo de Raadt wrote on Sat, Oct 04, 2014 at 11:37:21AM -0600: Ingo Schwarze wrote: That utility is grossly disgusting. It's a pity we can't delete it completely [...] Why not? Well, in a non-YP environment, grep ^foobar /etc/group is just fine, but in a YP environment, i'm

another ancient bug in head(1)

2014-10-07 Thread Ingo Schwarze
Hi, while we are talking about ancient bugs in head(1), here is another one: Without the patch: $ date | head /dev/null /dev/stdin == /dev/null == == /dev/stdin == $ Oops, where did stdin go? The reopen(3) function doesn't work here, it first closes stdin, and

Re: rcctl(8): special services and flags

2014-10-09 Thread Ingo Schwarze
Hi Patrik, Patrik Lundin wrote on Thu, Oct 09, 2014 at 09:02:14PM +0200: While working on rcctl(8) support for ansible I have run into a situation I am not sure how to deal with. Basically, if the user has supplied arguments we append flags whatever the user requested and this works good.

Re: rcctl(8): Fetch default service flags

2014-10-10 Thread Ingo Schwarze
Ouch. I just noticed the following problem. There are four things a user might want: 1. Disable a service. rcctl disable service always does that, and you can compare the output of rcctl status service to NO to decide whether running that is actually needed. 2. Enable

Re: rcctl: un-hardcode /etc/rc.conf{.local}

2014-10-11 Thread Ingo Schwarze
Hi Craig, i consider system code easier to understand, more predictable, and hence easier to keep correct and secure when system files and directories are not configurable. Consequently, i don't like the direction you are taking here. Yours, Ingo Craig R. Skinner wrote on Sat, Oct 11, 2014

Re: ps: remove redundant prototype

2014-10-13 Thread Ingo Schwarze
Hi, Martin Natano wrote on Sun, Oct 12, 2014 at 07:52:47PM +0200: The findvar() function in keyword.c contains a prototype of the vcmp() function, which is already declared further up in the same file. I'm not even sure that prototype is correct, as it fails to include the 'static'

Re: share/mk/bsd.README: bsd.prog.mk only has seven targets

2014-10-13 Thread Ingo Schwarze
Hi Theo, Theo Buehler wrote on Mon, Oct 13, 2014 at 02:45:53PM +0200: This confused me quite a bit when I first read it. After lint was unhooked from the tree, there remain only seven targets in bsd.prog.mk: all, clean, cleandir, depend, includes, install, and tags. Same goes for

Re: ps: remove redundant prototype

2014-10-13 Thread Ingo Schwarze
Hi Martin, Martin Natano wrote on Sun, Oct 12, 2014 at 07:52:47PM +0200: The findvar() function in keyword.c contains a prototype of the vcmp() function, which is already declared further up in the same file. I'm not even sure that prototype is correct, as it fails to include the 'static'

corrupt output from col(1) -f

2014-10-17 Thread Ingo Schwarze
Hi, talking about ancient bugs... If you call the col(1) utility with the -f option, permitting forward half-line feeds in the output stream, and the input stream actually contains half-line feeds in either direction, you end up with corrupt output, containing meaningless escape-digitnine

Re: rm: ignorance isn't bliss

2014-10-17 Thread Ingo Schwarze
Hi Superingo, Superingo wrote on Fri, Oct 17, 2014 at 09:19:45PM +0200: I just fatfingered a ';' into a ',': $ rm a.out, cc mind.c rm: a.out,: No such file or directory rm: cc: No such file or directory In full POSIX-conformance I lost my mind. Coincidentally I had an idea. What do

errors in col(1) line number handling

2014-10-17 Thread Ingo Schwarze
Hi, after fixing column number handling in col(1), i looked at line number handling in the same file and found about a dozen issues - two definite int overflows, four potential int overflows, four potential int underflows, and a group of closely related logic errors. Because they are all more or

Re: getent(1) hosts enumeration defunc

2014-10-18 Thread Ingo Schwarze
Hi, this summer, Marcus MERIGHI reported that gethostent(3) was completely destroyed during the switch to asr, i guess unintentionally. Until somebody writes something better, i suggest to resurrect the last working version from the Attic, file gethostnamadr.c,v 1.73. I'm not attempting to do

Re: getent(1) hosts enumeration defunc

2014-10-18 Thread Ingo Schwarze
Hi Philip, Philip Guenther wrote on Sat, Oct 18, 2014 at 04:38:09PM -0700: Maybe we just fix getent(1) to return an error like it does for ethers? Whatever we do with gethostent(3) - maybe it's really expendable, maybe tons of ports depend on it, who knows - i'm fine with removing hosts

Re: getent(1) hosts enumeration defunc

2014-10-19 Thread Ingo Schwarze
Hi Theo, Theo de Raadt wrote on Sun, Oct 19, 2014 at 07:35:06AM -0600: Florian Obser wrote: You can get rid of sethostent(3)/endhostent(3) at the same time. Those have to remain stubs for a while longer, because there are ports which poke at them. Oh the joys of terseness. Florian meant

remove networks(5) support from netstat(1)

2014-10-21 Thread Ingo Schwarze
Hi, i'm slowly working towards removing support for the networks(5) database because networks(5) is broken by design. Nowadays, the only meaningful way to translate names to numbers and vice versa is via DNS. However, the networks(5) database isn't integrated with DNS in any way, even less so

Re: \c for printf(1)

2014-10-22 Thread Ingo Schwarze
Hi Philip and Frank, Philip Guenther wrote on Tue, Oct 21, 2014 at 11:38:34PM -0700: On Tue, Oct 21, 2014 at 2:29 PM, Frank Brodbeck f...@split-brain.de wrote: today I stumbled upon a script (testssl.sh) which utilizes the \c escape sequence for printf(1). As we are missing that escape

Re: Patch for Data::Dumper - CVE-2014-4330

2014-10-25 Thread Ingo Schwarze
Hi Alexander, Alexander Bluhm wrote on Fri, Oct 24, 2014 at 10:55:07PM +0200: On Fri, Oct 24, 2014 at 10:40:55PM +0200, Alexander Bluhm wrote: Here is the diff that applies to -current. I have compared it with the perl git and with Data::Dumper on CPAN. It looks correct. Confirmed. I

native UTF-8 and ISO-8859-1 *input* support for mandoc(1)

2014-10-26 Thread Ingo Schwarze
=== RCS file: preconv.c diff -N preconv.c --- /dev/null 1 Jan 1970 00:00:00 - +++ preconv.c 26 Oct 2014 19:05:12 - @@ -0,0 +1,211 @@ +/* $OpenBSD$ */ +/* + * Copyright (c) 2011 Kristaps Dzonsons krist...@bsd.lv + * Copyright (c) 2014 Ingo Schwarze schwa...@openbsd.org

man.conf(5) _subdir search order

2013-07-12 Thread Ingo Schwarze
Hi, i'm moving this thread from misc@ to tech@ because i propose a patch. When replying, please make sure you do not cross-post. Jérémie Courrèges-Anglas wrote on Fri, Jul 12, 2013 at 02:05:48PM +0200: Jan Stary h...@stare.cz writes: The mdoc(7) manpage says about .Bl that The -width

Re: update perl Module::Build in base

2013-11-01 Thread Ingo Schwarze
Hi Andrew, Andrew Fresh wrote on Wed, Oct 30, 2013 at 01:50:56PM -0700: On Wed, Oct 30, 2013 at 08:31:58PM +0100, Ingo Schwarze wrote: -'DISTRIBUTION' = 'DAGOLDEN/Module-Build-0.39_01.tar.gz', +'DISTRIBUTION' = 'LEONT/Module-Build-0.4007.tar.gz', It's only 4.003 in 5.18

fix seekdir(3), was: update perl Module::Build

2013-11-01 Thread Ingo Schwarze
kurt Exp $ */ /* - * Copyright (c) 1983, 1993 - * The Regents of the University of California. All rights reserved. + * Copyright (c) 2103 Ingo Schwarze schwa...@openbsd.org * - * Redistribution and use in source and binary forms, with or without - * modification, are permitted provided

Re: fix seekdir(3)

2013-11-02 Thread Ingo Schwarze
1.9 +++ seekdir.c 3 Nov 2013 00:23:09 - @@ -1,46 +1,71 @@ /* $OpenBSD: seekdir.c,v 1.9 2007/06/05 18:11:48 kurt Exp $ */ /* - * Copyright (c) 1983, 1993 - * The Regents of the University of California. All rights reserved. + * Copyright (c) 2013 Ingo Schwarze schwa

Re: fix seekdir(3)

2013-11-04 Thread Ingo Schwarze
04, 2013 at 12:26:34AM -0800: On Sat, Nov 2, 2013 at 5:48 PM, Ingo Schwarze schwa...@usta.de wrote: Here is an updated patch which now works correctly with Otto's regression test, with the new test i just committed, and with the test from the Perl test suite Andrew pointed out, even

Re: fix seekdir(3)

2013-11-04 Thread Ingo Schwarze
Ingo Schwarze wrote on Mon, Nov 04, 2013 at 09:51:41AM +0100: I will send a minimal one-line patch to just fix the bug and do nothing else. We should get that one in quickly. That would also be a candidate for -stable, i think. I hope to come round to that tonight. Here it is. This fixes

Re: fix seekdir(3)

2013-11-05 Thread Ingo Schwarze
Ingo Schwarze wrote on Mon, Nov 04, 2013 at 09:51:41AM +0100: I will send a minimal one-line patch to just fix the bug and do nothing else. We should get that one in quickly. Done. [...] Then i will send two cleanup patches to remove useless stuff and put the code into the right place

Re: make ftp(1) ignore leading whitespace in URLs

2013-11-05 Thread Ingo Schwarze
Hi Stefan, Stefan Sperling wrote on Tue, Nov 05, 2013 at 01:56:33PM +0100: Do others think this useful? I hit this because I made copy/paste errors. Useful? I don't know. Maybe, maybe not. But your patch is NOT OK. Try stuff like $ ftp ' foo' bar I would be surprised if you couldn't

Re: fix seekdir(3)

2013-11-05 Thread Ingo Schwarze
Ingo Schwarze wrote on Mon, Nov 04, 2013 at 09:51:41AM +0100: Then i will send two cleanup patches to remove useless stuff and put the code into the right place, not changing any functionality. Done committed (thanks to Otto and Todd for checking). Finally, we can work out how to do

Re: Weard security report

2013-11-16 Thread Ingo Schwarze
Hi Sven, sven falempin wrote on Wed, Nov 06, 2013 at 10:24:53AM -0500: Running security(8): == /var/db/cloud.json diffs (-OLD +NEW) == --- /dev/null Fri Oct 25 01:30:33 2013 +++ /var/db/cloud.json Thu Oct 17 17:21:15 2013 Previous security: == /var/db/cloud.json

Re: Add HISTORY section to locale.1

2013-12-26 Thread Ingo Schwarze
Hi Brian, Brian Callahan wrote on Wed, Dec 25, 2013 at 11:55:43PM -0700: A user asked me earlier today when our locale(1) appeared. Do we want to put that in the man page? Definitely. However, i'd suggest to reserve the wording (first) appeared in for original inventions in the operating

Re: Alter daemon scheduling priority with renice for rc.d

2013-12-28 Thread Ingo Schwarze
Hi, Craig R. Skinner wrote on Sat, Dec 28, 2013 at 09:16:23PM +: On 2013-12-19 Thu 13:43 PM |, Craig R. Skinner wrote: Enhance rc.d/rc.subr with lowered/raised daemon running priority. Replace /etc/rc.d/daemon rc_renice=X with /etc/rc.conf.local daemon_nice=X I'd hate this, or anything

Re: [PATCH] nginx.conf(5): Less EXAMPLES, more HISTORY

2014-01-11 Thread Ingo Schwarze
. +.Sh AUTHORS +.An -nosplit +The bulk of the text was semi-automatically converted +from the XML sources of +.Lk http://nginx.org/en/docs/#development +to +.Xr mdoc 7 +by +.An Florian Obser Aq Mt flor...@openbsd.org . +The description of the grammar was written by +.An Ingo Schwarze Aq Mt schwa

Re: [PATCH] nginx.conf(5): Less EXAMPLES, more HISTORY

2014-01-20 Thread Ingo Schwarze
Hi Donovan, Donovan Watteau wrote on Sat, Jan 11, 2014 at 04:18:59PM +0100: OpenBSD now provides an nginx.conf(5) manual page and I love this, thanks! But it ends with an EXAMPLES section which only deals with some horrible use of whitespace, which is not recommended. I don't get it.

Re: fix ntpd.8 rfc authors

2014-02-12 Thread Ingo Schwarze
Hi Arto, Arto Jonsson wrote on Wed, Feb 12, 2014 at 04:39:39PM +0200: University of Delaware mixup. Done, thanks. Ingo Index: ntpd.8 === RCS file: /cvs/src/usr.sbin/ntpd/ntpd.8,v retrieving revision 1.36 diff -u -p -r1.36

Re: man.conf mandoc -Tlocale

2014-02-14 Thread Ingo Schwarze
Hi Ted, Ted Unangst wrote on Thu, Feb 13, 2014 at 09:22:04PM -0500: About 20 years after the invention of utf-8, I've decided to see what all the fuss is about and experiment with uxterm and whatnot. Naturally, this means I want to see sweet fancy quotes in all my man pages instead of the

Re: upd(4) proposal

2014-02-14 Thread Ingo Schwarze
Hi, a few comments regarding the manual: Andre de Oliveira wrote on Fri, Feb 14, 2014 at 02:07:29PM +0100: diff --git a/share/man/man4/upd.4 b/share/man/man4/upd.4 new file mode 100644 index 000..5a9054d --- /dev/null +++ b/share/man/man4/upd.4 @@ -0,0 +1,96 @@ +.\ $OpenBSD$ +.\

Re: man.conf mandoc -Tlocale

2014-02-16 Thread Ingo Schwarze
Hi Ted, Ted Unangst wrote on Fri, Feb 14, 2014 at 12:42:20PM -0500: On Fri, Feb 14, 2014 at 14:02, Ingo Schwarze wrote: I even considered switching the mandoc(1) default from -Tascii to -Tlocale in general, but forgot about it again. If you like the idea, that would be something to do after

zap man.template

2014-02-16 Thread Ingo Schwarze
Hi, the file /usr/share/misc/man.template is horribly outdated and incomplete, compare it to mdoc.template in the same directory. I think deleting it completely is better than updating it, because nobody is supposed to manually write new man(7) manuals, certainly not in OpenBSD, but nowehere

Re: man.conf mandoc -Tlocale

2014-02-16 Thread Ingo Schwarze
Ouch. Correcting myself. Ingo Schwarze wrote on Sun, Feb 16, 2014 at 03:11:07PM +0100: 1. I asked around a bit and Thomas Klausner (NetBSD) mentioned that both groff and mandoc format bare, unescaped ASCII minus characters (`-', 0x2d) found in the input stream as the three-byte

Re: rm reference to obsolete functions

2014-02-21 Thread Ingo Schwarze
Hi, Jan Klemkow wrote on Wed, Jan 29, 2014 at 08:44:05PM +0100: I've made a little diff to clean up some manpages with references to the obsoleted functions usleep(1), alarm(3). Actually, i like this diff and would like to commit it, for the following reason: We include pointers in SEE ALSO

Re: fix seekdir(3)

2014-03-06 Thread Ingo Schwarze
Hi, back in November 2013, following an idea by guenther@, i cooked up another optimization for seekdir(3), then failed to send out the patch. So here it is. Philip Guenther wrote on Tue, Nov 05, 2013 at 07:57:43PM -0800: On Wed, 6 Nov 2013, Ingo Schwarze wrote: * Worst case: opendir

make mandoc -Tlocale the default

2014-03-06 Thread Ingo Schwarze
Hi, having fixed the accent issues with mandoc -Tutf8, i have checked the base system for build system issues with switching the default, the resulting fixes are included in the following patch. Anybody wants to check with ports before commit, such that we can do any necessary cleanup

Re: make mandoc -Tlocale the default

2014-03-06 Thread Ingo Schwarze
Hi Ted, Ted Unangst wrote on Thu, Mar 06, 2014 at 04:46:50PM -0500: Seems reasonable to me. I went the man.conf route because it's easier for users to revert, Oh, if somebody really insists in setting LC_CTYPE but wants to see manuals in US-ASCII anyway (huh?), adding -Tascii to mandoc in

Re: lock(1) timeout message deduplication

2014-03-12 Thread Ingo Schwarze
Hi, the analysis and the patch are correct. Besides, even though hi() does not contain anything that isn't signal safe on OpenBSD, it is still nice to have that lengthy function no longer be a signal handler. I don't really like the warnx(3) call from the bye() ALRM handler either, but that's a

Re: lock(1) timeout message deduplication

2014-03-14 Thread Ingo Schwarze
Hi Jean-Philippe, Jean-Philippe Ouellet wrote on Wed, Mar 12, 2014 at 07:11:05PM -0400: On Wed, Mar 12, 2014 at 11:09:14PM +0100, Ingo Schwarze wrote: I don't really like the warnx(3) call from the bye() ALRM handler either, but that's a separate matter. Me neither. Maybe something like

Re: security(8): check for nobody in /etc/ftpusers

2014-03-23 Thread Ingo Schwarze
Hi Arto, Arto Jonsson wrote on Sun, Mar 23, 2014 at 08:09:02PM +0200: Or should this check removed completely? Yes, and Gleydson Soares has Andrew's and my OK for removing check_ftpusers() completely. I don't think checking for nobody is needed. Hopefully, nobody will have no password set up,

Switch OpenBSD manuals to DocBook

2014-04-01 Thread Ingo Schwarze
Hi, given that Kristaps Dzonsons has recently written docbook2mdoc, http://mdocml.bsd.lv/docbook2mdoc/ which is a DocBook-XML to mdoc(7) converter, and that Eric S. Raymond's mdoc(7) to DocBook-XML converter http://www.catb.org/~esr/doclifter/ is readily available, i am going to switch

Re: ISO-8859-1 character in manpage

2011-03-16 Thread Ingo Schwarze
Hi Anthony, Anthony J. Bentley wrote on Wed, Mar 16, 2011 at 01:37:50PM -0600: $ mandoc -Tlint /usr/src/share/man/man4/udl.4 /usr/src/share/man/man4/udl.4:42:6: ERROR: skipping bad character: ignoring byte Thanks for reporting! Indeed, that character had to

Re: permit daily(8) to use DUID in /etc/fstab for ROOTBACKUP

2011-03-23 Thread Ingo Schwarze
Hi Mattieu, Mattieu Baptiste wrote on Fri, Mar 18, 2011 at 04:28:40PM +0100: This diff enables daily(8) to use DUID instead of pathname in /etc/fstab for backing up root filesystem. I see the point, but i am not thrilled. I'm not a shell expert... comments are welcome. Already now, the

Re: allow usermod to remove user from secondary groups

2011-04-12 Thread Ingo Schwarze
Hi, Frank Brodbeck wrote on Tue, Apr 12, 2011 at 07:50:22PM +0200: Here's a diff leaving -G alone and introducing -S I don't really see the point in adding functionality to adduser, useradd and friends. Both are low-quality, bloaty, mostly useless code in the first place. And each is a

Re: uname(3) return values

2011-04-18 Thread Ingo Schwarze
Hi Matthew and Joachim, Matthew Dempsky wrote on Mon, Apr 18, 2011 at 11:34:50AM -0700: The issue here (if any) is that we over-specify the *successful* return value as precisely 0, rather than generally non-negative. I like the general idea, so i'd suggest the following. Note that the exact

Re: wprintf man page

2011-04-29 Thread Ingo Schwarze
Hi Stefan, Stefan Sperling wrote on Fri, Apr 29, 2011 at 01:16:37PM +0200: Does this look alright? Based on FreeBSD's page. Looks good from the mdoc(7) side, except that we haven't support yet for measuring the width of formatted strings, so for now, better provide width strings unformatted.

Re: /etc/daily ROOTBACKUP duid patch

2011-05-09 Thread Ingo Schwarze
Hi, RD Thrush wrote on Sun, May 08, 2011 at 11:03:32AM -0400: I noticed that ROOTBACKUP stopped working when I converted the /altroot fstab entry to a disklabel UID. The attached patch seems to work for me but I'm sure there's a better way. Indeed. The existing code is already scary, and

Re: Filesystem Hierarchy Standard (FHS) and OpenBSD

2011-05-10 Thread Ingo Schwarze
Hi Jeff, Jeff Licquia wrote on Mon, May 09, 2011 at 11:33:27PM -0400: (Sorry if this isn't the proper list for this discussion. If not, please point me in the right direction.) Since your enquiry is not backed up by a patch proposing specific changes to the OpenBSD operating system, this

Re: km(4) support for AMD Family 14h processors

2011-05-31 Thread Ingo Schwarze
Hi Brad, Brad wrote on Mon, May 30, 2011 at 07:44:37PM -0400: Index: share/man/man4/km.4 [...] +.\ .%O http://support.amd.com/us/Processor_TechDocs/31116.pdf Why are the URIs commented out? Both mandoc and modern groff handle %U properly. OK for the following diff? Ingo Index: km.4

Re: make \user syntax more explicit in forward(5)

2011-05-31 Thread Ingo Schwarze
Hi Thomas, i don't use .forward(5) and am not sure whether what you say is true or false, but the form is definitely not ok. Thomas de Grivel wrote on Tue, May 31, 2011 at 08:15:28PM +0200: --- forward.5.~1.9.~ Wed May 4 17:24:22 2011 +++ forward.5 Tue May 31 19:53:17 2011 @@ -35,8 +35,8

wildcards in changelist(5)

2011-06-11 Thread Ingo Schwarze
Hi, some time ago, mk@ and matthew@ discovered a regression in security(8): Our rewrite killed changelist(5) wildcard support. I think we should put it back, the changelist(5) manual explicitly documents the feature. Comments? OKs? Yours, Ingo Index: security

Re: Small pgrep/pkill enhancement

2011-06-11 Thread Ingo Schwarze
Hi, Jonathan Perkin wrote on Tue, May 17, 2011 at 11:02:05PM +0100: Add -i to ignore case when matching process name It seems nobody picked this up, so i had a look at it. NetBSD has that since March 2005 (committed by sketch@). FreeBSD copied it from NetBSD a few days later.

counting zero-length matches in sed(1)

2011-06-18 Thread Ingo Schwarze
When a regular expression has zero-length matches in a string, both sed(1) global replacement (/g) and replacement of numbered instances (e.g. /2) are broken. This is not even limited to sed -E. Both Otto's patch and my own refactoring patch on misc@ only address global replacement and leave

source manuals: select the right one

2011-06-25 Thread Ingo Schwarze
14:36:04 - 1.41 +++ man.c 25 Jun 2011 13:46:30 - @@ -2,7 +2,7 @@ /* $NetBSD: man.c,v 1.7 1995/09/28 06:05:34 tls Exp $ */ /* - * Copyright (c) 2010 Ingo Schwarze schwa...@openbsd.org + * Copyright (c) 2010, 2011 Ingo Schwarze schwa...@openbsd.org * * Permission

  1   2   3   4   5   6   7   8   9   >