missing .Pa in spamdb.8

2014-06-22 Thread Jan Stary
Index: usr.sbin/spamdb/spamdb.8 === RCS file: /cvs/src/usr.sbin/spamdb/spamdb.8,v retrieving revision 1.17 diff -u -p -u -p -r1.17 spamdb.8 --- usr.sbin/spamdb/spamdb.829 Jun 2013 09:08:41 - 1.17 +++

Re: infnan.3

2014-06-22 Thread Jan Stary
On Jun 22 14:27:26, h...@stare.cz wrote: lib/libm/man/infnan.3 says At some time in the future, some of the useful properties of the Infinities and NaNs in the IEEE standard 754 for Binary Floating-Point Arithmetic will be simulated in UNIX on the DEC VAX Not sure about the

Re: Advanced btcoex in iwn(4)

2013-08-18 Thread Jan Stary
On Aug 10 18:12:26, ccna@gmail.com wrote: Here is a patch for advanced btcoex support in iwn(4). I know that there is no particular reason to do it due to the lack of bluetooth enabled by default. But as we already do btcoex for the cards without IWN_FLAG_ADV_BT_COEX flag I was thinking

appleagp(4) disabled

2013-08-18 Thread Jan Stary
On Aug 18 11:33:01, kette...@cvs.openbsd.org wrote: Modified files: sys/arch/macppc/conf: GENERIC Log message: Disable appleagp(4). It doesn't really work yet, and hurts certain iBook G3 models (PowerMac4,3). As I have an appleagp(4) on a MacMini, I tried to see what it does (now

a nice diff

2014-02-13 Thread Jan Stary
--- /usr/src/usr.bin/nice/nice.cTue Dec 24 17:13:20 2013 +++ ./nice.cThu Feb 13 21:20:05 2014 @@ -30,7 +30,6 @@ * SUCH DAMAGE. */ -#include sys/time.h #include sys/resource.h #include stdio.h #include stdlib.h @@ -72,7 +71,8 @@ main(int argc, char *argv[])

Re: Remove userland agp interfaces

2014-03-16 Thread Jan Stary
On Mar 12 16:44:10, mark.kette...@xs4all.nl wrote: Now that we have KMS, giving userland access to AGP through /dev/agp0 is no longer necessary. As far as I can tell none of the drivers we ship in xenocara still use this. Back when we had appleagp, my PowerBook6,1 and MacMini were happier. So

Re: installation to (W)hole disk - saner default

2012-03-07 Thread Jan Stary
On Mar 07 18:32:00, David Vasek wrote: On Wed, 7 Mar 2012, Dmitrij D. Czarkoff wrote: On Wed, 2012-03-07 at 17:32 +0100, David Vasek wrote: So if the installer finds a valid MBR which contains some partition(s), then don't make whole disk (overwriting everything) the default choice and let

getline missing in stdio(3)

2012-04-10 Thread Jan Stary
Recently, getdelim() and getline() were commited to stdio. Shouldn't they also be mentioned in stdio(3)? (While at it, fixed a grammar glitch.) Jan Index: stdio.3 === RCS file: /cvs/src/lib/libc/stdio/stdio.3,v retrieving

Re: fun with libtool for masochistic guys

2012-07-11 Thread Jan Stary
On Jul 11 10:57:21, Marc Espie wrote: Lots of fun last night and this morning. 1/ Turns out GNU libtool simply *removes* stuff it doesn't understand while linking. Case in point: libdns/ldns. It does link with libtool link cc -o somelib --export-symbols lib.def someobj.o notice the

Re: ncheck_ffs DUID support

2012-07-11 Thread Jan Stary
On Jul 11 19:18:21, Alexander Hall wrote: This adds DUID support to ncheck_ffs. Testers? ok? This indeed enables ncheck_ffs for DUIDs, but breaks ncheck_ffs for /dev/wd0x My fstab says 5d2ade1fc5a8d569.n /tmp ffs rw,softdep,nodev,nosuid 1 2 With your diff I can do 'ncheck_ffs /tmp',

Re: ncheck_ffs DUID support

2012-07-13 Thread Jan Stary
On Jul 13 11:54:11, Alexander Hall wrote: On 07/12/12 22:55, Alexander Hall wrote: On 07/11/12 23:43, Jan Stary wrote: On Jul 11 19:18:21, Alexander Hall wrote: This adds DUID support to ncheck_ffs. Testers? ok? This indeed enables ncheck_ffs for DUIDs, but breaks ncheck_ffs

Argument list too long while copying

2012-08-23 Thread Jan Stary
On current/amd64 I created a MSDOS filesystem on a CF card inserted into a USB card reader # newfs_msdos -F 32 -L SHERLOCK sd3i and tried to copy some files to it # mount /dev/sd3i /mnt # cp * /mnt cp: /mnt/202.the-hounds-of-baskerville.avi: Argument

Re: Support power saving with athn(4) in host AP mode

2012-09-10 Thread Jan Stary
On Aug 18 10:40:23, Mark Kettenis wrote: Finally got annoyed enough that my MacBook running OS X (don't ask) didn't work too well on my OpenBSD AP at home. The reason is the following caveat listed in the athn(4) man page: Host AP mode doesn't support power saving. Clients attempting

512 hardcoded into scan_ffs(8)

2012-11-02 Thread Jan Stary
Looking at the source of scan_ffs, 512 is hardcoded all over the place. Would it be an improvement to have that configurable, for the newer disks with bigger size?

cwm - cosmetic renaming diff

2013-01-04 Thread Jan Stary
Below is a cosmetic diff to current cwm which merely renames two functions. Everywhere in the code and configuration and bindings and the manpage, the function that does horizontal maximization is named hmaximize, except the actual function that ultimately gets called and does the resizing, which

cwm - Conf.bwidth vs cc-bwidth

2013-01-04 Thread Jan Stary
Here's some more cleanage for cwm: the hmaximize and vmaximize functions are, obviously, completely dual, except that hmaximize uses Conf.bwidth when adjusting for a boundary, while vmaximize uses cc-bwidth (correctly IMHO). Jan Index: client.c

Re: cwm - Conf.bwidth vs cc-bwidth

2013-01-05 Thread Jan Stary
On Jan 04 23:27:48, h...@stare.cz wrote: Here's some more cleanage for cwm: the hmaximize and vmaximize functions are, obviously, completely dual, except that hmaximize uses Conf.bwidth when adjusting for a boundary, while vmaximize uses cc-bwidth (correctly IMHO). Also, it seems that

Re: cwm - Conf.bwidth vs cc-bwidth

2013-01-05 Thread Jan Stary
On Jan 05 14:50:21, h...@stare.cz wrote: On Jan 04 23:27:48, h...@stare.cz wrote: Here's some more cleanage for cwm: the hmaximize and vmaximize functions are, obviously, completely dual, except that hmaximize uses Conf.bwidth when adjusting for a boundary, while vmaximize uses cc-bwidth

[PATCH] cwm - maximizing in each direction

2013-01-05 Thread Jan Stary
Below is a diff that enables cwm to maximize a window in a given direction (left / right / up / down) only. Only left/right is implemented actually; I want to make sure this isn't completely wrong before writing up the other half (which will be dual of course). The motivating situation for me is

userdel vs /nonexistent

2013-01-07 Thread Jan Stary
useradd treats /nonexistent specially whene creating the home dir. Should userdel also treat /nonexistent specially when deleting it? In particular, should nonexisting /nonexistent be an error? Jan Index: user.c === RCS

dhclient.conf(5) mandoc lint

2013-01-22 Thread Jan Stary
In dhclient.conf.5 at two places, text is (unnecessarily IMHO) indented in a way mandoc -Tlint complains about. Jan /usr/src/sbin/dhclient/dhclient.conf.5:299:6: WARNING: tab in non-literal context /usr/src/sbin/dhclient/dhclient.conf.5:398:6: WARNING: tab in non-literal context

Remove more .Tn markup from manpages

2015-01-15 Thread Jan Stary
Ingo, recently you removed .Tn from stdio: On Jan 13 07:02:30, schwa...@cvs.openbsd.org wrote: Modified files: lib/libc/stdio : fgetln.3 fgetwln.3 fopen.3 fputs.3 funopen.3 printf.3 tmpnam.3 Log message: remove .Tn from stdio manuals; Kaspars Bankovskis found

newsyslog hardcoded paths

2015-02-18 Thread Jan Stary
Some of the paths #define'd in newsyslog.c seem to be outfated. Jan Index: newsyslog.c === RCS file: /cvs/src/usr.bin/newsyslog/newsyslog.c,v retrieving revision 1.93 diff -u -p -r1.93 newsyslog.c --- newsyslog.c 16 Jan 2015

Re: re(4) reads the pci-e max packet size wrongly

2015-02-19 Thread Jan Stary
On Feb 19 10:01:22, j...@insec.sh wrote: On Wed, Feb 18, 2015 at 11:23:15AM +1000, David Gwynne wrote: it looks like it reads the DCSR register and then keeps everything except the MPS field. this might cause it to erronously consider the mps to be much bigger than 2048, which in turn

Re: Jan's crontab.5 diff

2015-01-08 Thread Jan Stary
. Jan - Forwarded message from Jan Stary h...@stare.cz - Date: Sat, 3 Jan 2015 21:15:58 +0100 From: Jan Stary h...@stare.cz To: m...@openbsd.org Subject: Re: Failed cron jobs are silent On Jan 03 19:05:11, open...@crowsons.com wrote: set the MAILTO variable

Re: [PATCH] pcap manpages

2015-03-27 Thread Jan Stary
On Mar 27 09:16:52, h...@stare.cz wrote: The diff below fixes what mandoc -Tlint complains about, anotates the authors' names with .An in pcap.3 and removes a bit of cruft. Damn, that was written against a non-current source. Some of the changes are already in. Here's a smaller one, just

[PATCH] pcap manpages

2015-03-27 Thread Jan Stary
The diff below fixes what mandoc -Tlint complains about, anotates the authors' names with .An in pcap.3 and removes a bit of cruft. I have more diffs lined up for this, in case someone was about to do that. Would it be beneficial to rewrite pcap-filter.3 in mdoc(7)? Jan Index:

Re: [PATCH] pcap manpages

2015-03-29 Thread Jan Stary
The diff below fixes what seem to be errors in pcap.3, either in factuality or markup or grammar. Jan --- pcap.3.orig Sun Mar 29 22:06:49 2015 +++ pcap.3 Sun Mar 29 22:16:50 2015 @@ -169,7 +169,7 @@ at packets on the network. .Fa source is a string that specifies the network

remove .Tn from /sys

2015-01-13 Thread Jan Stary
On Jan 13 07:02:30, schwa...@cvs.openbsd.org wrote: CVSROOT: /cvs Module name: src Changes by: schwa...@cvs.openbsd.org2015/01/13 07:02:30 Modified files: lib/libc/stdio : fgetln.3 fgetwln.3 fopen.3 fputs.3 funopen.3 printf.3 tmpnam.3 Log

struct sigcontext in a sa_sigaction handler

2015-04-14 Thread Jan Stary
The SYNOPSIS of sigaction(2) cites the sa_sigaction function as void (*__sa_sigaction)(int, siginfo_t *, void *); yet in the examples, the declaration is void handler(int sig, siginfo_t *sip, struct sigcontext *scp); with the role of sigcontext described. This is a

comment typos

2015-04-14 Thread Jan Stary
Comments matter the most. Jan --- /usr/include/sys/siginfo.h Tue Aug 13 07:52:26 2013 +++ ./siginfo.h Tue Apr 14 17:07:06 2015 @@ -135,7 +135,7 @@ typedef struct { int si_errno; /* error from errno.h */ union { int

Re: [PATCH] pcap manpages

2015-04-06 Thread Jan Stary
Any comments? On Mar 29 22:24:41, h...@stare.cz wrote: The diff below fixes what seem to be errors in pcap.3, either in factuality or markup or grammar. Jan --- pcap.3.orig Sun Mar 29 22:06:49 2015 +++ pcap.3Sun Mar 29 22:16:50 2015 @@ -169,7 +169,7 @@ at packets on

Re: pledge(2) in quiz(6)

2015-10-24 Thread Jan Stary
Any comments/OK? On Oct 22 13:49:28, h...@stare.cz wrote: > games/quiz.c popen()s a PAGER to display the help message. > Throw that away and let the use pipe into a PAGER if needed. > Then we can just pledge "stdio rpath". > > Jan > > > Index: quiz.c >

pledge(2) in quiz(6)

2015-10-22 Thread Jan Stary
games/quiz.c popen()s a PAGER to display the help message. Throw that away and let the use pipe into a PAGER if needed. Then we can just pledge "stdio rpath". Jan Index: quiz.c === RCS file: /cvs/src/games/quiz/quiz.c,v

Re: pidfile()

2015-10-27 Thread Jan Stary
> usr.sbin/rbootd: rbootd.c > usr.sbin/rarpd : rarpd.c > usr.sbin/mrouted: main.c > usr.bin/usbhidaction: usbhidaction.c > usr.sbin/wsmoused: wsmoused.8 wsmoused.c wsmoused.h > usr.sbin/ypserv/ypserv: Makefile ypserv.c > usr.sbin/pppd : main.c

Re: inteldrm(4) diff that needs testing

2015-10-26 Thread Jan Stary
On Oct 24 23:48:01, mark.kette...@xs4all.nl wrote: > The diff below makes inteldrm(4) attach directly to pci(4) instead of > vga(1). Because inteldrm(4) depends on intagp(4), this also make > intagp(4) a child of inteldrm(4). Ultimately I'd like to integrate > intagp(4) into inteldrm(4), but

newsyslog -r

2015-11-12 Thread Jan Stary
The -r option of newsyslog(8) removes the requirement that newsyslog runs as root. Would it also make sense to not try to send the SIGHUP to syslogd in that case? Jan Index: newsyslog.8 === RCS file:

apmd(8) messages

2015-11-16 Thread Jan Stary
When we set perf policy to high, we say "high". So when we set to low, say "low", not "manual". (Both manual high and manual low are manual.) And it's not "client reply", it's a reply to the client, right? Jan Index: apmd.c

Re: newsyslog -r

2015-11-16 Thread Jan Stary
ping On Nov 12 22:21:39, h...@stare.cz wrote: > The -r option of newsyslog(8) removes the requirement > that newsyslog runs as root. Would it also make sense > to not try to send the SIGHUP to syslogd in that case? > > Jan > > > Index: newsyslog.8 >

pledge audioctl

2015-11-17 Thread Jan Stary
I am trying to add pledge(2) to audioctl(1), but it gets SIGABRT'ed under any pledge promises. (Indeed, I have pledged everything in a desperate attempt.) Looking at gdb and a ktrace, /dev/audioctl gets opened fine, but then it fails on an ioctl in getinfo() 23472 audioctl CALL

Re: printf(3) wording

2015-11-17 Thread Jan Stary
On Nov 17 17:06:11, j...@kerhand.co.uk wrote: > On Tue, Nov 17, 2015 at 10:38:41AM +0100, Jan Stary wrote: > > I am not a native speaker, but the conversion specifiers > > are "interpreted" by printf, not "interpolated", right? > > > > Jan > &

Re: fdisk(8) -l -c -h -s manpage bits

2015-11-17 Thread Jan Stary
On Nov 17 17:21:42, j...@kerhand.co.uk wrote: > On Tue, Nov 17, 2015 at 09:36:26AM +0100, Jan Stary wrote: > > On Nov 14 14:17:08, k...@openbsd.org wrote: > > > Modified files: > > > sbin/fdisk : disk.c fdisk.c > > > > > > Log message: > &

Re: inteldrm(4) diff that needs testing

2015-11-01 Thread Jan Stary
On Oct 26 13:31:14, h...@stare.cz wrote: > On Oct 24 23:48:01, mark.kette...@xs4all.nl wrote: > > The diff below makes inteldrm(4) attach directly to pci(4) instead of > > vga(1). Because inteldrm(4) depends on intagp(4), this also make > > intagp(4) a child of inteldrm(4). Ultimately I'd like

reference syscall.h in pledge.2

2015-10-21 Thread Jan Stary
Does it make sense to reference the syscall numbers in pledge(2)? Jan --- /usr/src/lib/libc/sys/pledge.2 Thu Oct 15 00:39:04 2015 +++ ./pledge.2 Wed Oct 21 09:41:26 2015 @@ -468,6 +468,9 @@ All other paths will return .Er ENOENT . .Sh RETURN VALUES .Rv -std +.Sh FILES +.Pa

Re: sndiod_flags=NO in /etc/rc.conf on recent snapshots

2015-11-18 Thread Jan Stary
On Nov 18 12:47:01, st...@openbsd.org wrote: > On 2015/11/18 07:30, Maxim Khitrov wrote: > > On Wed, Nov 18, 2015 at 12:02 AM, Theo de Raadt > > wrote: > > >> I only just noticed that, trying to watch a video while having a web > > >> browser open at the same time, I

printf(3) wording

2015-11-17 Thread Jan Stary
I am not a native speaker, but the conversion specifiers are "interpreted" by printf, not "interpolated", right? Jan Index: printf.3 === RCS file: /cvs/src/lib/libc/stdio/printf.3,v retrieving revision 1.74 diff -u -p -r1.74

Re: fdisk(8) -l -c -h -s manpage bits

2015-11-17 Thread Jan Stary
On Nov 14 14:17:08, k...@openbsd.org wrote: > Modified files: > sbin/fdisk : disk.c fdisk.c > > Log message: > Since -l is ignored if -c/-h/-s are specified, make that combination > invalid and mention the constraint in usage(). Mention it in the manpage too. Jan Index:

apmd ignoring ENXIO on /dev/apmctl

2015-11-17 Thread Jan Stary
Upon startup, apmd(8) opens /dev/apmctl like this: if ((ctl_fd = open(fname, O_RDWR | O_CLOEXEC)) == -1) { if (errno != ENXIO && errno != ENOENT) error("cannot open device file `%s'", fname); } Why is it that we ignore ENXIO and ENOENT

no more _subdir in man.conf

2015-09-17 Thread Jan Stary
The new man.conf does not recognize _subdir Jan Index: man.1 === RCS file: /cvs/src/usr.bin/mandoc/man.1,v retrieving revision 1.11 diff -u -p -u -p -r1.11 man.1 --- man.1 16 Feb 2015 16:18:02 - 1.11 +++

Re: newsyslog -r

2015-12-03 Thread Jan Stary
ping On Nov 12 22:21:39, h...@stare.cz wrote: > The -r option of newsyslog(8) removes the requirement > that newsyslog runs as root. Would it also make sense > to not try to send the SIGHUP to syslogd in that case? > > Jan > > > Index: newsyslog.8 >

eeprom does not compile on current/macppc

2015-12-31 Thread Jan Stary
Rebuilding the userland on a current/maccppc MacMini filas with ===> usr.sbin/eeprom cc -O2 -pipe -Werror-implicit-function-declaration -c getdate.c /usr/src/usr.sbin/eeprom/getdate.y: In function 'get_date': /usr/src/usr.sbin/eeprom/getdate.y:860: error: implicit declaration of function

wump(6) does not need to fork

2015-11-30 Thread Jan Stary
- put the game description in the manpage, showing The Wumpus some damn respect by making at least a .Bl list of pits, bats, and the wump. - remove wump.info, instructions(), and pathnames.h - pledge a simple "stdio" Jan Index: Makefile

Re: pledge fish(6) plus a few more things

2015-11-30 Thread Jan Stary
On Nov 23 13:17:43, ser...@helheim.mooo.com wrote: > Declared usage() as __dead since it won't return, instructions() called > a handrolled pager (/bin/cat) using fork which I replaced for a simple > cicle of while(fgets) then fputs (greatly inspired, to not saying it was > bluntly copied, by a

Re: pledge fish(6) plus a few more things

2015-11-30 Thread Jan Stary
On Nov 30 14:16:02, h...@stare.cz wrote: > On Nov 23 13:17:43, ser...@helheim.mooo.com wrote: > > Declared usage() as __dead since it won't return, instructions() called > > a handrolled pager (/bin/cat) using fork which I replaced for a simple > > cicle of while(fgets) then fputs (greatly

Re: pledge fish(6) plus a few more things

2015-11-30 Thread Jan Stary
On Nov 30 14:16:02, h...@stare.cz wrote: > On Nov 23 13:17:43, ser...@helheim.mooo.com wrote: > > Declared usage() as __dead since it won't return, instructions() called > > a handrolled pager (/bin/cat) using fork which I replaced for a simple > > cicle of while(fgets) then fputs (greatly

Only use emails in .Mt

2015-11-30 Thread Jan Stary
Index: hack.6 === RCS file: /cvs/src/games/hack/hack.6,v retrieving revision 1.18 diff -u -p -r1.18 hack.6 --- hack.6 13 Mar 2015 19:58:40 - 1.18 +++ hack.6 30 Nov 2015 14:14:15 - @@ -211,7 +211,3 @@ wrote the

Re: sndio.1 vs -L

2015-11-18 Thread Jan Stary
On Nov 18 01:30:08, ratc...@openbsd.org wrote: > usr.bin/sndiod : sndiod.1 > say that network communication is not secure "listen _on_" an address, even if -L is disabled for now. Jan Index: sndiod.1 === RCS file:

install(1) typo

2016-02-01 Thread Jan Stary
There seems to be a "be" missing in install(1). The whole phrase seems odd to a non-native speaker like me: those options "should not be relied upon" because they are not portable, not "for portability". (But I might easily be wrong.) Jan --- install.1.orig Mon Feb 1 13:57:31

/usr/X11/README typo

2016-02-18 Thread Jan Stary
THere seems to be a typo in macppc's /usr/X11/README Jan --- README.orig Thu Feb 18 11:14:56 2016 +++ README Thu Feb 18 11:15:25 2016 @@ -12,7 +12,7 @@ hardware. If your hardware is not properly autodetect or not supported as you wish, you will have to create a configuration

faq11 typo

2016-02-18 Thread Jan Stary
--- faq11.html.orig Thu Feb 18 11:11:41 2016 +++ faq11.html Thu Feb 18 11:12:14 2016 @@ -97,7 +97,7 @@ Some X applications are very lean; others will seeming all the processor and RAM you can give them. Of course, some users just like to use X to provide a large number of

xdm in afterboot

2017-03-01 Thread Jan Stary
The transition from xdm to xenodm is not reflected in afterboot(8). Jan Index: share/man/man8/afterboot.8 === RCS file: /cvs/src/share/man/man8/afterboot.8,v retrieving revision 1.157 diff -u -p -u -p -r1.157 afterboot.8 ---

list all iwm(4) firmware files

2016-09-16 Thread Jan Stary
Index: iwm.4 === RCS file: /cvs/src/share/man/man4/iwm.4,v retrieving revision 1.18 diff -u -p -r1.18 iwm.4 --- iwm.4 28 May 2016 18:31:14 - 1.18 +++ iwm.4 16 Sep 2016 08:44:13 - @@ -71,8 +71,12 @@ which are

locale in sort(1)

2016-10-07 Thread Jan Stary
The sort(1) manpage mentions the LC_* environment variables and how they affect sorting and efficiency, but we only support LC_CTYPE, right? Would it be an omprovement to remove these from the manpage? Jan Index: sort.1 ===

tweek rcctl.8 spacing

2016-10-10 Thread Jan Stary
The postscript output of 'man -Tps rcctl' makes the 'stopped' list item of 'rcctl ls' break a line, while all the other items are compact one-liners. The diff below changes the width, which is the same for ascci, but "stopped" is slightly wider than "started" in the postscript output. Jan

Re: tweek rcctl.8 spacing

2016-10-10 Thread Jan Stary
> > The postscript output of 'man -Tps rcctl' makes the 'stopped' > > list item of 'rcctl ls' break a line, while all the other items > > are compact one-liners. The diff below changes the width, > > which is the same for ascci, but "stopped" is slightly wider > > than "started" in the postscript

Ignored .Pp in ksh.1

2016-09-30 Thread Jan Stary
The diff below removes a .Pp before an .It which mandoc complains about and ignores. Jan Index: ksh.1 === RCS file: /cvs/src/bin/ksh/ksh.1,v retrieving revision 1.181 diff -u -p -r1.181 ksh.1 --- ksh.1 27 Sep 2016

let globals be global in unexpand(1)

2016-10-10 Thread Jan Stary
In unexpand.c, the -a indicator is both a global int and a local char. Jan Index: unexpand.c === RCS file: /cvs/src/usr.bin/unexpand/unexpand.c,v retrieving revision 1.12 diff -u -p -r1.12 unexpand.c --- unexpand.c 11 Nov

rcctl ls - services and daemons

2016-10-10 Thread Jan Stary
The rcctl(8) manpage makes the distinction between 'daemons' and 'services', and the description of some items in the output of 'rcctl ls' mentions only 'daemons'. But they are both 'services and deamons' in all cases (tested with e.g. postgresql running, stopped, or failed). Jan Index:

newlines in unexpand(1)

2016-10-10 Thread Jan Stary
Why do we need to trim the newlines in unexpand(1)? The result seems to be the same without it. Jan Index: unexpand.c === RCS file: /cvs/src/usr.bin/unexpand/unexpand.c,v retrieving revision 1.12 diff -u -p -r1.12

Re: newlines in unexpand(1)

2016-10-10 Thread Jan Stary
On Oct 10 15:22:01, t...@tedunangst.com wrote: > Jan Stary wrote: > > Why do we need to trim the newlines in unexpand(1)? > > The result seems to be the same without it. > > > > Jan > > > > > > Index: unexpand.c > >

Re: let globals be global in unexpand(1)

2016-10-10 Thread Jan Stary
On Oct 10 15:30:52, t...@tedunangst.com wrote: > Jan Stary wrote: > > In unexpand.c, the -a indicator is > > both a global int and a local char. > > I think this is backwards. We want fewer globals, not more. OK, other way round. Ja

remove pathnames.h from mv(1)

2016-10-10 Thread Jan Stary
With the embedded cp.c and rm.c, the pathnames of "/bin/cp" and "/bin/rm" are not needed. Jan

remove unused flags from the cp.c inside mv(1)

2016-10-10 Thread Jan Stary
The embedded cpmain() will never have _any_ flags set, as mv.c calls it as argv[0] = from; argv[1] = to; argv[2] = NULL; cpmain(2, argv); There is probably more code that could be romoved form the embedded cp.c, along the lines of tedu's recent cleanup of the

Re: newlines in unexpand(1)

2016-11-05 Thread Jan Stary
ping On Oct 10 22:02:20, h...@stare.cz wrote: > On Oct 10 15:22:01, t...@tedunangst.com wrote: > > Jan Stary wrote: > > > Why do we need to trim the newlines in unexpand(1)? > > > The result seems to be the same without it. > > > > > >

zic(8) does not need locale.h

2016-11-05 Thread Jan Stary
Index: zic.c === RCS file: /cvs/src/usr.sbin/zic/zic.c,v retrieving revision 1.22 diff -u -p -r1.22 zic.c --- zic.c 15 Mar 2016 19:50:47 - 1.22 +++ zic.c 5 Nov 2016 13:07:52 - @@ -11,7 +11,6 @@ #include

does cron/crontab need locale?

2016-11-05 Thread Jan Stary
Index: cron.c === RCS file: /cvs/src/usr.sbin/cron/cron.c,v retrieving revision 1.74 diff -u -p -r1.74 cron.c --- cron.c 11 Jan 2016 14:23:50 - 1.74 +++ cron.c 5 Nov 2016 13:12:49 - @@ -28,7 +28,6 @@ #include

remove useless extern declaration

2016-10-19 Thread Jan Stary
extern char *optarg is already declared in unistd.h This is the only occurence in src/sbin and src/bin; others will follow in separate mails. Jan Index: bioctl.c === RCS file: /cvs/src/sbin/bioctl/bioctl.c,v retrieving

Re: iwm: rts for long frames only

2016-10-19 Thread Jan Stary
On Oct 06 17:56:50, s...@stsp.name wrote: > Stop using RTS for every data frame sent by iwm(4). > RTS adds unneccessary overhead if small data frames are sent. > > The USE_RTS flag in iwm's LQ command enables RTS unconditionally, so only > set it while the AP is enforcing protection. The flag

Re: drop unused locale junk from sort(1)

2016-10-19 Thread Jan Stary
ping On Oct 11 15:37:03, schwa...@usta.de wrote: > Jan Stary wrote on Tue, Oct 11, 2016 at 11:26:50AM +0200: > > > Feeling encouraged by Ingo's ok to remove locale from cp/rm, > > here's a diff that removes the locale stuff we don't actually do > > from the code and

Re: let head(1) understand `-' as stdin

2016-10-12 Thread Jan Stary
> > > The diff below makes head(1) recognize `-' > > > as a name for the standard input, > > > as many other utilities do. On Oct 11 23:55:26, schwa...@usta.de wrote: > > Do standards permit that extension? > > POSIX neither requires nor forbids it, but encourages consistency > among all the

Re: rm.c functions in mv(1)

2016-10-10 Thread Jan Stary
On Oct 10 12:25:39, h...@stare.cz wrote: > bin/mv has its own copies of cp.c and mv.c. > Apparently, they are modifications of cp's cp.c and rm's rm.c, > used when moving as "copy and remove the source". > > In bin/mv/rm.c, the following snippet of rm_file() confuses me: > > if

Re: let head(1) understand `-' as stdin

2016-10-12 Thread Jan Stary
On Oct 12 23:23:18, t...@math.ethz.ch wrote: > > Let me clarify the idea. > > If a filter recognizes '-' as a name for stdin, > > then stdin can be one of the _multiple_ files being processed. > > Filters that do not recognize '-' as a name, on the other hand, > > only process stdin if it is the

Re: remove unused flags from the cp.c inside mv(1)

2016-10-14 Thread Jan Stary
ping On Oct 10 21:39:16, h...@stare.cz wrote: > The embedded cpmain() will never have _any_ flags set, > as mv.c calls it as > > argv[0] = from; > argv[1] = to; > argv[2] = NULL; > cpmain(2, argv); > > There is probably more code that could be romoved > form the embedded

remove KOI8 after 5.9 is out

2016-10-14 Thread Jan Stary
Index: io.c === RCS file: /cvs/src/usr.bin/calendar/io.c,v retrieving revision 1.44 diff -u -p -r1.44 io.c --- io.c31 Aug 2016 09:38:47 - 1.44 +++ io.c14 Oct 2016 07:27:52 - @@ -89,13 +89,9 @@ cal(void)

Re: usb disk dirty after every reboot

2016-10-19 Thread Jan Stary
On Oct 16 10:14:14, s...@sfritsch.de wrote: > [moving to tech@] > > On Tuesday, 20 September 2016 08:03:32 CEST Stefan Fritsch wrote: > > On Tue, 20 Sep 2016, Darren Tucker wrote: > > > On Tue, Sep 20, 2016 at 1:43 AM, Jan Stary <h...@stare.cz> wrote: > > &g

Re: drop unused locale junk from sort(1)

2016-10-11 Thread Jan Stary
On Oct 11 15:37:03, schwa...@usta.de wrote: > > and change /var/tmp to /tmp. > > No, according to file.c, the program still writes to /var/tmp, > not to /tmp. Before changing that in the manual, we would have > to change it in the code. I sent that in a separate email; this is a leftover,

let head(1) understand `-' as stdin

2016-10-11 Thread Jan Stary
The diff below makes head(1) recognize `-' as a name for the standard input, as many other utilities do. Jan Index: head.1 === RCS file: /cvs/src/usr.bin/head/head.1,v retrieving revision 1.23 diff -u -p -r1.23 head.1 ---

Re: let head(1) understand `-' as stdin

2016-10-11 Thread Jan Stary
On Oct 11 21:27:54, j...@wxcvbn.org wrote: > Jan Stary <h...@stare.cz> writes: > > > The diff below makes head(1) recognize `-' > > as a name for the standard input, > > as many other utilities do. > > Makes sense to me. The following points could

Re: let head(1) understand `-' as stdin

2016-10-11 Thread Jan Stary
On Oct 11 13:35:34, dera...@openbsd.org wrote: > This is command used in scripts. Scripts are often portable. If one > operating system has an extension, but others don't, then those > scripts become unportable to use use of these extensions. GNU head(1) has it, Solaris does not. (I don't have

Re: hide iwn firmware error log

2016-10-11 Thread Jan Stary
On Oct 06 12:46:21, s...@stsp.name wrote: > Disable the detailed fatal firmware error log in iwn(4) by default. These are my iwm errors of today on a Dell Latitude E5570. Oct 11 16:26:56 dell /bsd: iwm0: fatal firmware error Oct 11 16:26:56 dell /bsd: iwm0: device timeout Oct 11 16:26:56 dell

enforce zero options

2016-10-12 Thread Jan Stary
Some programs in bin/ and usr.bin/ use the following idiom to make sure that there are no options present: while ((ch = getopt(argc, argv, "")) != -1) switch (ch) { case '?': default: usage();

remove locale from logname(1)

2016-10-12 Thread Jan Stary
Why does logname(1) need to setlocale? Jan Index: logname.c === RCS file: /cvs/src/usr.bin/logname/logname.c,v retrieving revision 1.9 diff -u -p -r1.9 logname.c --- logname.c 9 Oct 2015 01:37:08 - 1.9 +++

Re: enforce zero options

2016-10-12 Thread Jan Stary
On Oct 12 15:00:23, j...@wxcvbn.org wrote: > Jan Stary <h...@stare.cz> writes: > > > Some programs in bin/ and usr.bin/ use the following idiom > > to make sure that there are no options present: > > > > while ((ch = getopt(argc, argv, &q

cp.c and rm.c embedded in mv(1)

2016-10-11 Thread Jan Stary
mv's copies of cp.c and rm.c were imported about 10 months ago so that mv can avoid the fork+exec; instead, mv just calls the relevant cp/rm code itself. What was the motivation for that? Was that a step needed to have a stricter pledge() for mv (no forking and execing)? Currently, mv does not

rm.c functions in mv(1)

2016-10-10 Thread Jan Stary
bin/mv has its own copies of cp.c and mv.c. Apparently, they are modifications of cp's cp.c and rm's rm.c, used when moving as "copy and remove the source". In bin/mv/rm.c, the following snippet of rm_file() confuses me: if (S_ISDIR(sb.st_mode)) { warnx("%s: is a

Re: setlocale in cp/rm/mv

2016-10-11 Thread Jan Stary
On Oct 11 10:31:38, schwa...@usta.de wrote: > > cp(1) and rm(1) call setlocale(LC_ALL, "") but mv(1) does not. > > Why do they do that, and why mv doesn't? > > That is useless and wasteful. > > I think it comes from a time when people still thought that doing > more and more and more might bring

drop unused locale junk from sort(1)

2016-10-11 Thread Jan Stary
Feeling encouraged by Ingo's ok to remove locale from cp/rm, here's a diff that removes the locale stuff we don't actually do from the code and documentation of sort(1). Leave just LC_CTYPE which determines isblank() and case conversions. Annotate a missed -z flag while there, and change /var/tmp

ntpd.conf

2016-12-29 Thread Jan Stary
Markup a forgotten keyword. Jan Index: ntpd.conf.5 === RCS file: /cvs/src/usr.sbin/ntpd/ntpd.conf.5,v retrieving revision 1.33 diff -u -p -r1.33 ntpd.conf.5 --- ntpd.conf.5 23 Oct 2015 14:52:20 - 1.33 +++

/dev/sound

2017-03-26 Thread Jan Stary
Now that /dev/sound is gone, should AUDIO_DEV_SOUND be removed from audio.c ? Jan Index: audio.c === RCS file: /cvs/src/sys/dev/audio.c,v retrieving revision 1.161 diff -u -p -r1.161 audio.c --- audio.c 11 Mar 2017

LC_NUMERIC in awk

2017-07-26 Thread Jan Stary
Does awk really need to set and reset LC_NUMERIC? Does it need to set locale at all? Jan Index: main.c === RCS file: /cvs/src/usr.bin/awk/main.c,v retrieving revision 1.19 diff -u -p -r1.19 main.c --- main.c 22 Oct

  1   2   >