Re: tcp keep-alives sent without timestamps

2015-04-14 Thread Lauri Tirkkonen
messages. -- Lauri Tirkkonen | lotheac @ IRCnet

Re: paste(1): default to stdin if no files given

2017-12-30 Thread Lauri Tirkkonen
On Sat, Dec 30 2017 19:41:24 +0100, Klemens Nanni wrote: > On Fri, Dec 29, 2017 at 03:55:10PM +0200, Lauri Tirkkonen wrote: > > Currently paste(1) silently does nothing if it's given no file > > arguments: > > > > % printf 'hello\nworld\n'|paste > > %

paste(1): default to stdin if no files given

2017-12-29 Thread Lauri Tirkkonen
if (seq) - sequential(argv); + sequential(files); else - parallel(argv); + parallel(files); exit(0); } -- Lauri Tirkkonen | lotheac @ IRCnet

Re: update Mesa to 17.2.6

2018-01-04 Thread Lauri Tirkkonen
uhub0 port 1 configuration 1 interface 0 "Intel Rate Matching Hub" rev 2.00/0.00 addr 2 uhub3 at uhub1 port 1 configuration 1 interface 0 "Intel Rate Matching Hub" rev 2.00/0.00 addr 2 vscsi0 at root scsibus2 at vscsi0: 256 targets softraid0 at root scsibus3 at softraid0: 256 targets sd1 at scsibus3 targ 1 lun 0: <OPENBSD, SR CRYPTO, 006> SCSI2 0/direct fixed sd1: 28623MB, 512 bytes/sector, 58620593 sectors root on sd1a (1e3f2d2fd0a15e70.a) swap on sd1b dump on sd1b -- Lauri Tirkkonen | lotheac @ IRCnet

Re: update Mesa to 17.2.6

2018-01-05 Thread Lauri Tirkkonen
It too goes away when switching to intel driver, so perhaps your diff isn't quite sufficient (although granted, with Haswell the effect is so much less noticeable, it may not be a problem). -- Lauri Tirkkonen | lotheac @ IRCnet

Re: [bugfix] xterm(1) needs "cpath" pledge(2)

2018-07-29 Thread Lauri Tirkkonen
n the manpage. -- Lauri Tirkkonen | lotheac @ IRCnet

Re: md5: convert from fgetln(3) to getline(3)

2018-08-14 Thread Lauri Tirkkonen
} } + if (ferror(listfp)) + warn("%s: getline", file); + free(line); if (listfp != stdin) fclose(listfp); if (!found) warnx("%s: no properly formatted checksum lines found", file); - free(lbuf); if (sel_found != NULL) { /* * Mark found files by setting them to NULL so that we can -- Lauri Tirkkonen | lotheac @ IRCnet

Re: md5: convert from fgetln(3) to getline(3)

2018-08-14 Thread Lauri Tirkkonen
On Tue, Aug 14 2018 14:29:30 -0500, Scott Cheloha wrote: > On Tue, Aug 14, 2018 at 08:55:14PM +0300, Lauri Tirkkonen wrote: > > Hi, > > > > On Tue, Aug 14 2018 12:08:54 -0500, Scott Cheloha wrote: > > > > + len = (size_t)linelen; > > >

spamd.conf.5: document https

2018-07-20 Thread Lauri Tirkkonen
le containing a list of addresses and may be one of .Ar http , +.Ar https , .Ar ftp , .Ar file , or .Ar exec . The .Ar http , +.Ar https , .Ar ftp , and .Ar file -- Lauri Tirkkonen | lotheac @ IRCnet

paste(1): use getline instead of fgetln

2018-07-17 Thread Lauri Tirkkonen
break; if ((ch = *dp++)) putchar(ch); @@ -215,8 +208,8 @@ sequential(char **argv) } if (fp != stdin) (void)fclose(fp); - free(lbuf); } + free(line); } int -- Lauri Tirkkonen | lotheac @ IRCnet

join(1): use getline instead of fgetln

2018-07-17 Thread Lauri Tirkkonen
t;fieldcnt = 0; + bp = lp->line; while ((fieldp = strsep(, tabchar)) != NULL) { if (spans && *fieldp == '\0') continue; @@ -393,6 +395,7 @@ slurpit(INPUT *F) break;

Re: join(1): use getline instead of fgetln

2018-07-17 Thread Lauri Tirkkonen
((fieldp = strsep(, tabchar)) != NULL) { if (spans && *fieldp == '\0') continue; @@ -393,6 +395,7 @@ slurpit(INPUT *F) break; } } + free(line); } int -- Lauri Tirkkonen | lotheac @ IRCnet

Re: join(1): use getline instead of fgetln

2018-07-17 Thread Lauri Tirkkonen
; > need to unconditionally NUL-terminate lp->line. > > Perhaps something like this. you beat me to it, and yours is better (I decremented len before calculating fpos without thinking) :) -- Lauri Tirkkonen | lotheac @ IRCnet

Re: [patch] smtpd: missing space for "from local" with -T rules

2018-07-16 Thread Lauri Tirkkonen
On Wed, Jun 20 2018 12:19:43 +0300, Lauri Tirkkonen wrote: > "from local" rules are missing a space when printed out with -T rules. > > diff --git a/usr.sbin/smtpd/to.c b/usr.sbin/smtpd/to.c > index e1d399d74f2..27d5321408f 100644 > --- a/usr.sbin/smtpd/to.c &g

Re: paste(1): use getline instead of fgetln

2018-07-25 Thread Lauri Tirkkonen
On Tue, Jul 17 2018 21:14:29 +0300, Lauri Tirkkonen wrote: > In the same vein as my previous diff for join(1), make paste(1) use > getline instead of fgetln. ping. the join(1) fix was committed but this one still needs attention. -- Lauri Tirkkonen | lotheac @ IRCnet

Re: md5: convert from fgetln(3) to getline(3)

2018-09-05 Thread Lauri Tirkkonen
On Thu, Aug 23 2018 11:24:54 -0500, Scott Cheloha wrote: > On Tue, Aug 14, 2018 at 03:11:47PM -0500, Scott Cheloha wrote: > > This patch is ok cheloha@ and I can commit if someone else > > is ok, too. > > 1 week bump. Anyone else ok? no takers? -- Lauri Tirkkonen | lotheac @ IRCnet

Re: Minor cal(1) man diff

2018-09-04 Thread Lauri Tirkkonen
e name or abbreviated name of a month: in that case a calendar is displayed for that month of the current year. -- Lauri Tirkkonen | lotheac @ IRCnet

[patch] smtpd: missing space for "from local" with -T rules

2018-06-20 Thread Lauri Tirkkonen
(void)strlcat(buf, "from local ", sizeof buf); else { (void)strlcat(buf, "from src ", sizeof buf); (void)strlcat(buf, r->table_from, sizeof buf); -- Lauri Tirkkonen | lotheac @ IRCnet

grep: convert fgetln to getline

2019-01-06 Thread Lauri Tirkkonen
r(f)) err(2, "%s", fn); fclose(f); + free(line); } int -- Lauri Tirkkonen | lotheac @ IRCnet

Re: net80211: don't drop unencrypted data frames with no data

2019-01-14 Thread Lauri Tirkkonen
TYPE_NODATA | > + IEEE80211_FC0_SUBTYPE_CF_POLL_NODATA | > + IEEE80211_FC0_SUBTYPE_CF_ACK_NODATA)) { 1) shouldn't we first check that type is data here? 2) isn't this a false positive for subtype == IEEE80211_FC0_SUBTYPE_DATA_CF_ACK and subtype == IEEE80211_FC0_SUBTYPE_DATA_FC_POLL, since the _NODATA versions are just the _DATA_ bits ORed with FC0_SUBTYPE_NODATA? I think we should either check (subtype & IEEE80211_FC0_SUBTYPE_NODATA), or test subtype's equality to each of the possible NODATA macros. 3) where is IEEE80211_FC0_SUBTYPE_CF_ACK_CF_POLL? -- Lauri Tirkkonen | lotheac @ IRCnet

Re: net80211: don't drop unencrypted data frames with no data

2019-01-14 Thread Lauri Tirkkonen
> > 3) where is IEEE80211_FC0_SUBTYPE_CF_ACK_CF_POLL? > > Indeed, my diff was bad as well. Thanks for spotting these issues. > I hadn't run this diff yet cause I was still building a new snapshot > to test it. Could you also test this new version please? I'm not currently physically near my AP, but the diff looks good and I can test it later today. -- Lauri Tirkkonen | lotheac @ IRCnet

Re: grep: convert fgetln to getline

2019-01-14 Thread Lauri Tirkkonen
On Mon, Jan 07 2019 23:01:47 +0200, Lauri Tirkkonen wrote: > On Mon, Jan 07 2019 15:41:53 -0500, Ted Unangst wrote: > > Lauri Tirkkonen wrote: > > > On Sun, Jan 06 2019 14:02:16 -0500, Ted Unangst wrote: > > > > Lauri Tirkkonen wrote: > > > > > Hi

Re: net80211: don't drop unencrypted data frames with no data

2019-01-14 Thread Lauri Tirkkonen
On Mon, Jan 14 2019 16:41:13 +0200, Lauri Tirkkonen wrote: > > Indeed, my diff was bad as well. Thanks for spotting these issues. > > I hadn't run this diff yet cause I was still building a new snapshot > > to test it. Could you also test this new version please? > > I'm

Re: install(1) could fail due to race

2019-01-16 Thread Lauri Tirkkonen
On Wed, Jan 16 2019 11:00:04 +0100, Ingo Schwarze wrote: > Lauri Tirkkonen wrote on Mon, Jan 07, 2019 at 08:13:09PM +0200: > > > Hi, it seems install(1) has a race condition: in create_newfile, it > > first unlinks the target file and then tries to open it with

Re: net80211: don't drop unencrypted data frames with no data

2019-01-15 Thread Lauri Tirkkonen
n't increment a counter for the nodata frames anymore, but that seems reasonable since we are indeed using them for something, not ignoring them completely. -- Lauri Tirkkonen | lotheac @ IRCnet

Re: grep: convert fgetln to getline

2019-01-23 Thread Lauri Tirkkonen
On Mon, Jan 07 2019 23:01:47 +0200, Lauri Tirkkonen wrote: > On Mon, Jan 07 2019 15:41:53 -0500, Ted Unangst wrote: > > Lauri Tirkkonen wrote: > > > On Sun, Jan 06 2019 14:02:16 -0500, Ted Unangst wrote: > > > > Lauri Tirkkonen wrote: > > > > > Hi

Re: running Xorg without root

2018-12-12 Thread Lauri Tirkkonen
On Wed, Dec 12 2018 11:09:18 +0100, Mark Kettenis wrote: > > Date: Wed, 12 Dec 2018 01:27:24 +0200 > > From: Lauri Tirkkonen > > > > Hi, > > > > since the Xorg setuid bit was removed, I looked a little bit into what > > it would take to run it wit

running Xorg without root

2018-12-11 Thread Lauri Tirkkonen
es master */ file_priv->is_master = SPLAY_EMPTY(>files); + if (!file_priv->authenticated) + file_priv->authenticated = file_priv->is_master; SPLAY_INSERT(drm_file_tree, >files, file_priv); mutex_unlock(>struct_mutex); -- Lauri Tirkkonen | lotheac @ IRCnet

Re: running Xorg without root

2018-12-12 Thread Lauri Tirkkonen
argh: On Wed, Dec 12 2018 10:26:42 +0200, Lauri Tirkkonen wrote: > > What was the issue that prompted you to make this change ? > > The console was not opened otherwise if euid==0 euid != 0, I meant. -- Lauri Tirkkonen | lotheac @ IRCnet

Re: running Xorg without root

2018-12-12 Thread Lauri Tirkkonen
r. Unfortnatly, even the other KMS based driver (intel and > radeon) still need more work to run without some root privileges. true, I did not test other drivers. > And older drivers (non AMD/intel cards) will stop working completly. I don't see how that follows. This change *relaxes* the requirements for becoming master on /dev/drm0 (they no longer have to be root), how would that cause those older drivers to stop working? -- Lauri Tirkkonen | lotheac @ IRCnet

install(1) could fail due to race

2019-01-07 Thread Lauri Tirkkonen
amp; errno != ENOENT) - err(1, "rename: %s to %s (errno %d)", path, backup, errno); - } else { - if (unlink(path) < 0 && errno != ENOENT) - err(1, "%s", path); - } - - return(open(path, O_CREAT | O_RDWR | O_EXCL, S_IRUSR | S_IWUSR)); -} - /* * file_write() * Write/copy a file (during copy or archive extract). This routine knows -- Lauri Tirkkonen | lotheac @ IRCnet

Re: install(1) could fail due to race

2019-01-07 Thread Lauri Tirkkonen
On Mon, Jan 07 2019 20:13:09 +0200, Lauri Tirkkonen wrote: > @@ -128,9 +127,6 @@ main(int argc, char *argv[]) > case 'p': > docompare = dopreserve = 1; > break; > - case 'S': > -

Re: grep: convert fgetln to getline

2019-01-07 Thread Lauri Tirkkonen
On Sun, Jan 06 2019 14:02:16 -0500, Ted Unangst wrote: > Lauri Tirkkonen wrote: > > Hi, another simple diff converting fgetln usage to getline. > > > > I also considered converting grep_fgetln to grep_getline, but that would > > mean that for FILE_MMAP we'd have to co

Re: grep: convert fgetln to getline

2019-01-07 Thread Lauri Tirkkonen
On Mon, Jan 07 2019 15:41:53 -0500, Ted Unangst wrote: > Lauri Tirkkonen wrote: > > On Sun, Jan 06 2019 14:02:16 -0500, Ted Unangst wrote: > > > Lauri Tirkkonen wrote: > > > > Hi, another simple diff converting fgetln usage to getline. > > > > > &

Re: install(1) could fail due to race

2019-01-07 Thread Lauri Tirkkonen
t directories are created as required. This option cannot be used with the .Fl B , b , C , c , -.Fl f , p , S , +.Fl f , p , or .Fl s options. @@ -198,9 +198,8 @@ The .Fl C , .Fl D , .Fl F , -.Fl p , and -.Fl S +.Fl p flags are non-standard and should not be relied upon for portability. .Pp Temporary files may be left in the target directory if -- Lauri Tirkkonen | lotheac @ IRCnet

Re: install(1) could fail due to race

2019-01-07 Thread Lauri Tirkkonen
On Mon, Jan 07 2019 15:48:25 -0500, Ted Unangst wrote: > Lauri Tirkkonen wrote: > > Hi, it seems install(1) has a race condition: in create_newfile, it > > first unlinks the target file and then tries to open it with > > O_CREAT|O_EXCL. > > > The below diff ess

typo in getgrent.3

2018-12-28 Thread Lauri Tirkkonen
and .Fn getgrnam_r functions may fail if: -- Lauri Tirkkonen | lotheac @ IRCnet

Re: install(1) could fail due to race

2019-01-10 Thread Lauri Tirkkonen
t this patch then? I think the discussion about softupdates is a little orthogonal. -- Lauri Tirkkonen | lotheac @ IRCnet

net80211: don't drop unencrypted data frames with no data

2019-01-13 Thread Lauri Tirkkonen
/* drop unencrypted */ ic->ic_stats.is_rx_unencrypted++; goto err; -- Lauri Tirkkonen | lotheac @ IRCnet

Re: grep: convert fgetln to getline

2019-01-24 Thread Lauri Tirkkonen
t would have to compile both of the greps under test with -DSMALL to avoid the mmap path. But fine, since it seems so important to you I'll try to get *something*... -- Lauri Tirkkonen | lotheac @ IRCnet

Re: grep: convert fgetln to getline

2019-01-27 Thread Lauri Tirkkonen
On Thu, Jan 24 2019 17:03:57 -0700, Theo de Raadt wrote: > Scott Cheloha wrote: > > > > On Jan 24, 2019, at 06:19, Lauri Tirkkonen wrote: > > > > > > [...] > > > > > > I haven't done any actual measurements though, so it's possible my >

bsd.{prog,lib}.mk: drop -S for install

2019-02-21 Thread Lauri Tirkkonen
} ${INSTALL_COPY} -S ${INSTALL_STRIP} \ + ${INSTALL} ${INSTALL_COPY} ${INSTALL_STRIP} \ -o ${BINOWN} -g ${BINGRP} \ -m ${BINMODE} $p ${DESTDIR}${BINDIR}/$p .endfor -- Lauri Tirkkonen | lotheac @ IRCnet

Re: bsd.{prog,lib}.mk: drop -S for install

2019-02-21 Thread Lauri Tirkkonen
l: - ${INSTALL} ${INSTALL_COPY} -S ${INSTALL_STRIP} \ + ${INSTALL} ${INSTALL_COPY} ${INSTALL_STRIP} \ -o ${BINOWN} -g ${BINGRP} \ -m ${BINMODE} ${PROG} ${DESTDIR}${BINDIR}/install -- Lauri Tirkkonen | lotheac @ IRCnet

Re: update ctype data to unicode 10

2019-02-22 Thread Lauri Tirkkonen
and there are so many reasons to dislike that approach. I quite like the simplicity of your script - it doesn't really matter much if it takes a long time to run since you don't need to run it very often. -- Lauri Tirkkonen | lotheac @ IRCnet

mail(1): whitespace fixes

2019-03-01 Thread Lauri Tirkkonen
e8f233549 100644 --- a/usr.bin/mail/send.c +++ b/usr.bin/mail/send.c @@ -369,7 +369,7 @@ mail1(struct header *hp, int printheaders) } if ((cp = value("record")) != NULL) (void)savemail(expand(cp), mtf); - + /* Setup sendmail arguments. */ *ap++ = "send-mail"; *ap++ = "-i"; -- Lauri Tirkkonen | lotheac @ IRCnet

Re: net80211 hostap HT protection fixes

2019-03-01 Thread Lauri Tirkkonen
ms to work fine on my athn(4) 11n 5GHz AP. But I didn't observe any improvements in bandwidth, using an Android phone station as traffic sink (~9MBit/s maximum both before and after). -- Lauri Tirkkonen | lotheac @ IRCnet

mail(1): use "sendmail" as argv[0] for sendmail

2019-03-01 Thread Lauri Tirkkonen
*ap++ = "-t"; cp = hp->h_from ? hp->h_from : value("from"); -- Lauri Tirkkonen | lotheac @ IRCnet

update ctype data to unicode 10

2019-02-21 Thread Lauri Tirkkonen
0x1f980 - 0x1f997 0x1f9c0 0x1f9d0 - 0x1f9e6 /* @@ -5579,7 +5883,17 @@ SWIDTH2 0x2b820 - 0x2cea1 /* - * U+2CEB0 - U+2F7FF : No_Block + * U+2CEB0 - U+2EBEF : CJK Unified Ideographs Extension F + */ + +ALPHA 0x2ceb0 - 0x2ebe0 +GRAPH 0x2ceb0 - 0x2ebe0 +PRINT 0x2ceb0 - 0x2ebe0 +SWIDTH2 0x2ceb0 - 0x2ebe0 + + +/* + * U+2EBF0 - U+2F7FF : No_Block */ @@ -5603,9 +5917,10 @@ TODIGIT < 0x2f890 9 > * U+E - U+E007F : Tags */ -CONTROL 0xe0001 0xe0020 - 0xe007f +CONTROL 0xe0001 GRAPH 0xe0001 0xe0020 - 0xe007f PRINT 0xe0001 0xe0020 - 0xe007f +SPECIAL 0xe0020 - 0xe007f SWIDTH0 0xe0001 0xe0020 - 0xe007f -- Lauri Tirkkonen | lotheac @ IRCnet

smtpctl, mailer.conf: drop send-mail (was: mail(1): use "sendmail" as argv[0] for sendmail)

2019-03-19 Thread Lauri Tirkkonen
On Tue, Mar 19 2019 07:26:41 -0600, Todd C. Miller wrote: > On Tue, 19 Mar 2019 10:33:07 +0200, Lauri Tirkkonen wrote: > > > ping - doesn't look removed yet :) > > Committed. thanks. that means no need for smtpctl and mailer.conf to check for it any more. diff --git a/etc

Re: smtpctl, mailer.conf: drop send-mail (was: mail(1): use "sendmail" as argv[0] for sendmail)

2019-03-19 Thread Lauri Tirkkonen
ob/master/etc/mail/mailer.conf https://github.com/NetBSD/src/blob/trunk/etc/mailer.conf so I'm not really worried about that. -- Lauri Tirkkonen | lotheac @ IRCnet

Re: smtpctl, mailer.conf: drop send-mail (was: mail(1): use "sendmail" as argv[0] for sendmail)

2019-03-19 Thread Lauri Tirkkonen
On Tue, Mar 19 2019 15:16:10 -0600, Todd C. Miller wrote: > On Tue, 19 Mar 2019 22:15:17 +0200, Lauri Tirkkonen wrote: > > > thanks. that means no need for smtpctl and mailer.conf to check for it > > any more. > > Not so fast. There are still things in ports that us

Re: mail(1): use "sendmail" as argv[0] for sendmail

2019-03-19 Thread Lauri Tirkkonen
> when delivermail was still in use. Sendmail itself never checked > its argv[0] for "send-mail" as far as I know. > > At this point I consider it a historical oddity that is safe to > remove. ping - doesn't look removed yet :) -- Lauri Tirkkonen | lotheac @ IRCnet

xterm and wcwidth()

2019-03-08 Thread Lauri Tirkkonen
) { default: #if defined(HAVE_WCHAR_H) && defined(HAVE_WCWIDTH) - if (xtermEnvUTF8() && - systemWcwidthOk(xw->misc.mk_samplesize, xw->misc.mk_samplepass)) { + if (xtermEnvUTF8()) { my_wcwidth = wcwidth; TRACE(("using system wcwidth() function\n")); break; -- Lauri Tirkkonen | lotheac @ IRCnet

Re: smtpctl, mailer.conf: drop send-mail (was: mail(1): use "sendmail" as argv[0] for sendmail)

2019-03-22 Thread Lauri Tirkkonen
On Tue, Mar 19 2019 15:28:48 -0600, Todd C. Miller wrote: > On Tue, 19 Mar 2019 23:24:24 +0200, Lauri Tirkkonen wrote: > > > I might be blind, but 'grep -r send-mail /usr/ports/pobj/nmh-1.7.1' > > comes up empty for me after 'make extract' in /usr/ports/mail/nmh? > &g

Re: install(1) could fail due to race

2019-02-06 Thread Lauri Tirkkonen
sk for OKs. > > Just checking we didn't forget about this. Seems the right thing to do. weekly ping. -- Lauri Tirkkonen | lotheac @ IRCnet

Re: grep: convert fgetln to getline

2019-01-23 Thread Lauri Tirkkonen
On Wed, Jan 23 2019 18:01:24 -0500, Ted Unangst wrote: > Lauri Tirkkonen wrote: > > > > oh, interesting. that's sloppy. can you please fix that first, > > > > separately? > > > > > > Sure, here it is. > > > > Could you please take a look

Re: grep: convert fgetln to getline

2019-01-24 Thread Lauri Tirkkonen
s used for each line, and libc getline() reallocates it if it is not large enough. -- Lauri Tirkkonen | lotheac @ IRCnet

Re: grep: convert fgetln to getline

2019-01-24 Thread Lauri Tirkkonen
ap code path is not taken (ie. either stream is not seekable (determined with isatty), or if grep was built -DSMALL (bsd.rd grep I think), or if mmap fails). And even then I think the cost is negligible: getline grows the buffer in powers of 2, so only lines that happen to be twice as long as any previously encountered line pay the price. -- Lauri Tirkkonen | lotheac @ IRCnet

Re: grep: convert fgetln to getline

2019-01-24 Thread Lauri Tirkkonen
On Thu, Jan 24 2019 13:58:04 +0200, Lauri Tirkkonen wrote: > And even then I think the cost is negligible: getline grows > the buffer in powers of 2, so only lines that happen to be twice as long > as any previously encountered line pay the price. Actually, I went to skim t

Re: grep: convert fgetln to getline

2019-01-31 Thread Lauri Tirkkonen
ide compat for it in libbsd; there must be a reason for that). I'm speaking as someone who's been removing a bunch of crap from that other OS I mentioned, so that's my reason for this line of thinking slash pipe-dreaming ;) -- Lauri Tirkkonen | lotheac @ IRCnet

Re: net80211: fix ifconfig mode command

2019-04-15 Thread Lauri Tirkkonen
before applying 'mode 11b' or 'mode 11g' on my laptop would not actually disconnect from my 5GHz-only AP, and the ifconfig output was something like "mode 11b (HT-MCS0 mode 11n)" - after, it works as expected. -- Lauri Tirkkonen | lotheac @ IRCnet

Re: ssh_config.5: refer consistently to HostName, not Hostname

2019-06-12 Thread Lauri Tirkkonen
On Tue, Jun 11 2019 14:40:03 +0100, Jason McIntyre wrote: > On Tue, Jun 11, 2019 at 03:11:03PM +0300, Lauri Tirkkonen wrote: > > Hi, trivial manpage diff. > > > > fixed, thanks. > jmc I noticed the followup commit that changes the canonical option name to

ssh_config.5: refer consistently to HostName, not Hostname

2019-06-11 Thread Lauri Tirkkonen
any substitution by the -.Cm Hostname +.Cm HostName or .Cm CanonicalizeHostname options. -- Lauri Tirkkonen | lotheac @ IRCnet

ftplist.cgi & ftpinstall.cgi source code

2019-07-04 Thread Lauri Tirkkonen
anywhere. Is it available somewhere? -- Lauri Tirkkonen | lotheac @ IRCnet

Re: [PATCH] make: implement jobserver and use it to avoid exponential behavior

2019-11-14 Thread Lauri Tirkkonen
o be way > more clearly separated, to not included gratuitous changes to existing code, > to look like OpenBSD code, and to have decent error paths. Thanks; I take it this means there is at least a little interest in this proof of concept :) I'll resume work on this to polish it more, fix the remaining bugs and try to address your concerns. I did try to make it look like OpenBSD code, but obviously failed on some counts; please bear with me with any future mistakes I might make on that path. And I suppose I'll need some help on the "compiles on all architectures" part eventually; I just have amd64/arm64 stuff. -- Lauri Tirkkonen | lotheac @ IRCnet

Re: [PATCH] make: implement jobserver and use it to avoid exponential behavior

2019-11-15 Thread Lauri Tirkkonen
by one not to descend too far into yak shaving territory. Given infinite time, let's fix everything, but since that is not afforded to me, some educated guesses have to be made to be able to test the right thing in the meantime. ;) -- Lauri Tirkkonen | lotheac @ IRCnet

Re: [PATCH] make: implement jobserver and use it to avoid exponential behavior

2019-11-15 Thread Lauri Tirkkonen
Hi Martin, On Thu, Nov 14 2019 17:57:20 +0100, Martin Pieuchot wrote: > On 14/11/19(Thu) 17:30, Lauri Tirkkonen wrote: > > [...] > > The first test I made was on a beefy virtual machine under Hyper-V, > > with 32 vCPUs on a Threadripper 2950X. With and without this patch

Re: [PATCH] make: implement jobserver and use it to avoid exponential behavior

2019-11-15 Thread Lauri Tirkkonen
On Fri, Nov 15 2019 15:24:57 +0200, Lauri Tirkkonen wrote: > Your points are valid and I agree with them completely. There are > clearly problems with lock contention, and I should mention here that I would probably not have observed the magnitude of these problems had I not made make star

Re: make 'ifconfig scan' trigger a background scan

2019-11-07 Thread Lauri Tirkkonen
ight be a little confusing to make this operation implicit in another operation (ie. list APs), and for root only. How does a user find out about this feature? Wouldn't it be better to have a separate command to trigger the scan, eg. 'rescan'? That could be documented and restricted to root. -- Lauri Tirkkonen | lotheac @ IRCnet

Re: make 'ifconfig scan' trigger a background scan

2019-11-07 Thread Lauri Tirkkonen
don't see that as > a reason to hold off on making *this* change. Yeah, I totally agree. -- Lauri Tirkkonen | lotheac @ IRCnet

[PATCH] mk: build subdirs in parallel

2019-11-05 Thread Lauri Tirkkonen
${MAKE_FLAGS} \ + ${t:S/^real//}; \ + fi +. if !target($t) +$t: _SUBDIRUSE +. endif +. endfor +. endif +. endfor .endif .if !target(install) @@ -74,13 +71,6 @@ maninstall: afterinstall afterinstall: realinstall realinstall: beforeinstall _SUBDIRUSE .endif - - -.for t in all cleandir includes depend obj tags manlint -. if !target($t) -$t: _SUBDIRUSE -. endif -.endfor .if !target(regress) && empty(.TARGETS:Mall) regress: _SUBDIRUSE .endif -- 2.23.0 -- Lauri Tirkkonen | lotheac @ IRCnet

[PATCH] make: implement jobserver and use it to avoid exponential behavior

2019-11-05 Thread Lauri Tirkkonen
ne(MAKEFLAGS); @@ -796,7 +820,6 @@ main(int argc, char **argv) else Targ_FindList(, create); - Job_Init(maxJobs); /* If the user has defined a .BEGIN target, execute the commands * attached to it. */ if (!queryFlag) diff --git a/usr.bin/make/main.h b/usr.bin/make/main.h index 469487ee058..41a74af9d0d 100644 --- a/usr.bin/make/main.h +++ b/usr.bin/make/main.h @@ -29,6 +29,9 @@ /* main * User interface to make. */ + +#define MAKEFLAGS ".MAKEFLAGS" + /* Main_ParseArgLine(string); * Parse string as a line of arguments, and treats them as if they * were given at make's invocation. Used to implement .MFLAGS. */ -- 2.23.0 -- Lauri Tirkkonen | lotheac @ IRCnet

Re: [PATCH] make: implement jobserver and use it to avoid exponential behavior

2019-11-27 Thread Lauri Tirkkonen
On Wed, Nov 27 2019 11:49:00 +0100, Marc Espie wrote: > On Wed, Nov 27, 2019 at 12:42:48PM +0200, Lauri Tirkkonen wrote: > > In a lesson to always proof-read *before* sending your message: > > > > On Wed, Nov 27 2019 12:31:51 +0200, Lauri Tirkkonen wrote: > >

Re: [PATCH] make: implement jobserver and use it to avoid exponential behavior

2019-11-27 Thread Lauri Tirkkonen
ficial to me in identifying areas of improvement, even if those are nothing new to OpenBSD developers. -- Lauri Tirkkonen | lotheac @ IRCnet

Re: [PATCH] make: implement jobserver and use it to avoid exponential behavior

2019-11-27 Thread Lauri Tirkkonen
On Wed, Nov 27 2019 16:14:44 +0100, Marc Espie wrote: > On Fri, Nov 15, 2019 at 03:29:29PM +0200, Lauri Tirkkonen wrote: > > On Fri, Nov 15 2019 15:24:57 +0200, Lauri Tirkkonen wrote: > > > Your points are valid and I agree with them completely. There are > > >

Re: [PATCH] make: implement jobserver and use it to avoid exponential behavior

2019-11-27 Thread Lauri Tirkkonen
In a lesson to always proof-read *before* sending your message: On Wed, Nov 27 2019 12:31:51 +0200, Lauri Tirkkonen wrote: > - a full release build with the jobserver enabled passed after >disabling gnu/usr.bin/binutils this should, in fact, read "gnu/usr.bin/binutils-2.17".

Re: [PATCH] make: implement jobserver and use it to avoid exponential behavior

2019-11-27 Thread Lauri Tirkkonen
t create -J option string"); + record_option('J', optstr); + } + /* And set up everything for sub-makes */ Var_AddCmdline(MAKEFLAGS); @@ -796,7 +824,6 @@ main(int argc, char **argv) else Targ_FindList(, create); - Job_Init(maxJobs); /* If the user has defined a .BEGIN target, execute the commands * attached to it. */ if (!queryFlag) diff --git a/usr.bin/make/main.h b/usr.bin/make/main.h index 469487ee058..41a74af9d0d 100644 --- a/usr.bin/make/main.h +++ b/usr.bin/make/main.h @@ -29,6 +29,9 @@ /* main * User interface to make. */ + +#define MAKEFLAGS ".MAKEFLAGS" + /* Main_ParseArgLine(string); * Parse string as a line of arguments, and treats them as if they * were given at make's invocation. Used to implement .MFLAGS. */ -- Lauri Tirkkonen | lotheac @ IRCnet

Re: librthread sem_t opaqueness, storage & unnamed semaphore sharing

2020-02-23 Thread Lauri Tirkkonen
On Sun, Feb 23 2020 14:48:36 +0200, Lauri Tirkkonen wrote: > So, diff below makes struct __sem non-opaque and removes the indirect > allocations, so that the application is required to provide storage and > can therefore control where it's stored (which could be eg. shm). followup diff t

librthread sem_t opaqueness, storage & unnamed semaphore sharing

2020-02-23 Thread Lauri Tirkkonen
b_version b/lib/librthread/shlib_version index 72168dfd16a..54ef0c4cc0c 100644 --- a/lib/librthread/shlib_version +++ b/lib/librthread/shlib_version @@ -1,2 +1,2 @@ -major=26 -minor=1 +major=27 +minor=0 -- Lauri Tirkkonen | lotheac @ IRCnet

Re: librthread sem_t opaqueness, storage & unnamed semaphore sharing

2020-02-24 Thread Lauri Tirkkonen
On Mon, Feb 24 2020 10:24:53 +0100, Martin Pieuchot wrote: > On 23/02/20(Sun) 14:48, Lauri Tirkkonen wrote: > > I was working on a make jobserver implementation that uses POSIX > > semaphores as job tokens instead of a complicated socket-based approach. > > Initially I used na

Re: librthread sem_t opaqueness, storage & unnamed semaphore sharing

2020-02-24 Thread Lauri Tirkkonen
On Mon, Feb 24 2020 10:42:22 +0100, Martin Pieuchot wrote: > On 24/02/20(Mon) 11:29, Lauri Tirkkonen wrote: > > On Mon, Feb 24 2020 10:24:53 +0100, Martin Pieuchot wrote: > > > On 23/02/20(Sun) 14:48, Lauri Tirkkonen wrote: > > > > I was working on a make jobserver

Re: librthread sem_t opaqueness, storage & unnamed semaphore sharing

2020-02-24 Thread Lauri Tirkkonen
re in struct __sem if pshared=0, and check that on every access, but I'm honestly not sure what value it brings for a userspace library to essentially prevent access to userspace memory if the application went through the effort to share that memory between processes anyway. -- Lauri Tirkkonen | lotheac @ IRCnet

Re: librthread sem_t opaqueness, storage & unnamed semaphore sharing

2020-03-01 Thread Lauri Tirkkonen
On Mon, Feb 24 2020 15:33:35 -0500, Ted Unangst wrote: > Martin Pieuchot wrote: > > On 24/02/20(Mon) 11:29, Lauri Tirkkonen wrote: > > > On Mon, Feb 24 2020 10:24:53 +0100, Martin Pieuchot wrote: > > > > On 23/02/20(Sun) 14:48, Lauri Tirkkonen wrote: > > >

Re: Teach du(1) the -m flag, disk usage in megabytes

2020-01-29 Thread Lauri Tirkkonen
On Wed, Jan 29 2020 12:25:34 +0100, Sebastian Benoit wrote: > Lauri Tirkkonen(la...@hacktheplanet.fi) on 2020.01.29 01:31:56 +0200: > > On Tue, Jan 28 2020 18:03:19 +0100, Florian Obser wrote: > > > On Tue, Jan 28, 2020 at 09:58:40AM -0700, Todd C. Miller wrote: > > >

Re: Teach du(1) the -m flag, disk usage in megabytes

2020-01-28 Thread Lauri Tirkkonen
o you think that 'du -m' will be in all those then? POSIX doesn't have it [0]. The way I see it, the entire conversation in this thread is about doing things that might be useful to people. IMO, arguing about where extensions are or aren't implemented isn't productive. [0]: https://pubs.open

Re: pshared semaphores

2020-07-08 Thread Lauri Tirkkonen
that uses pshared semaphores that I intend to submit if this goes through (my initial attempts used sockets, but that was tricky to get right). But yes, there isn't a lot of software that uses them. -- Lauri Tirkkonen | lotheac @ IRCnet

Re: make btrace interval event to reciprocal of ticks

2020-06-25 Thread Lauri Tirkkonen
ggest similar to > bpftrace(8) or dtrace(1)? In DTrace, profile- probes fire at a frequency of hertz, but apparently also support suffixes. http://dtrace.org/guide/chp-profile.html -- Lauri Tirkkonen | lotheac @ IRCnet

[PATCH] make pthread_mutex_t non-opaque

2021-05-15 Thread Lauri Tirkkonen
ret = EINVAL; - } else if ((ret = pthread_mutex_lock(mutexp)) == 0) { + } else if ((ret = pthread_mutex_lock(mutex)) == 0) { *old_ceiling = mutex->prioceiling; mutex->prioceiling = prioceiling; - pthread_mutex_unlock(mutexp); +

Re: smtpd: use libtls

2021-01-27 Thread Lauri Tirkkonen
nSSL-based systems are largely unable to use libtls (which in itself is a shame) - how would this change make it to portable? -- Lauri Tirkkonen | lotheac @ IRCnet

Re: athn(4): switch Tx rate control to RA

2021-03-24 Thread Lauri Tirkkonen
ith eg. interactive ssh sessions. -- Lauri Tirkkonen | lotheac @ IRCnet

Re: wcwidth of soft hyphen

2021-04-05 Thread Lauri Tirkkonen
e SHY is not visible. The other issues I observed with discrepancies between OpenBSD and other systems I already outlined in my initial mail. -- Lauri Tirkkonen | lotheac @ IRCnet

Re: wcwidth of soft hyphen

2021-04-06 Thread Lauri Tirkkonen
On Tue, Apr 06 2021 13:09:11 +0200, Martijn van Duren wrote: > On Thu, 2021-04-01 at 10:39 +0300, Lauri Tirkkonen wrote: > > On Thu, Apr 01 2021 09:30:36 +0200, Martijn van Duren wrote: > > > However, based on the description by the Unicode Consortium I think > > > O

Re: wcwidth of soft hyphen

2021-04-06 Thread Lauri Tirkkonen
a/mutt/-/blob/master/mbyte.c#L528 Thanks, it's news to me that mutt does that. It speaks to something when an application is explicitly hardcoding codepoints not to print. I don't particularly like the 'solution' of every TUI application having to ship their own fixes for stuff like this though. -- Lauri Tirkkonen | lotheac @ IRCnet

wcwidth of soft hyphen

2021-04-01 Thread Lauri Tirkkonen
since + # it is width 1 in nearly every other environment, set it here. + return 1 if $code == 0x00ad; return 0 if $charinfo->{category} eq 'Mn'; return 0 if $charinfo->{category} eq 'Me'; -- Lauri Tirkkonen | lotheac @ IRCnet

Re: wcwidth of soft hyphen

2021-04-01 Thread Lauri Tirkkonen
break compatibility to their older versions, for example. I explicitly mentioned I don't wish to engage in a discussion about which way is _correct_ - I am interested in interoperability with real, existing systems. -- Lauri Tirkkonen | lotheac @ IRCnet

Re: wcwidth of soft hyphen

2021-04-14 Thread Lauri Tirkkonen
to at least patch xterm in-tree so that it does not render SHY? Or must it remain broken? -- Lauri Tirkkonen | lotheac @ IRCnet